Re: [PR] refactor(plugins): BigNumber Time Comparison with existing time_offset API [superset]

github-actions[bot] commented on PR #27718: URL: https://github.com/apache/superset/pull/27718#issuecomment-2115750712 Ephemeral environment shutdown and build artifacts deleted. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] refactor(plugins): BigNumber Time Comparison with existing time_offset API [superset]

Antonio-RiveroMartnez merged PR #27718: URL: https://github.com/apache/superset/pull/27718 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] refactor(plugins): BigNumber Time Comparison with existing time_offset API [superset]

michael-s-molina commented on PR #27718: URL: https://github.com/apache/superset/pull/27718#issuecomment-2115117430 Thanks for rebasing and addressing the comments @Antonio-RiveroMartnez. I'll execute the tests using Airbnb's production data. -- This is an automated message from the

Re: [PR] refactor(plugins): BigNumber Time Comparison with existing time_offset API [superset]

lilykuang commented on code in PR #27718: URL: https://github.com/apache/superset/pull/27718#discussion_r1601950378 ## superset-frontend/packages/superset-ui-core/src/time-comparison/getTimeOffset.ts: ## @@ -0,0 +1,121 @@ +/** + * Licensed to the Apache Software Foundation

Re: [PR] refactor(plugins): BigNumber Time Comparison with existing time_offset API [superset]

Antonio-RiveroMartnez commented on code in PR #27718: URL: https://github.com/apache/superset/pull/27718#discussion_r1601891165 ## superset-frontend/plugins/plugin-chart-echarts/src/BigNumber/BigNumberPeriodOverPeriod/controlPanel.ts: ## @@ -180,14 +108,12 @@ const config:

Re: [PR] refactor(plugins): BigNumber Time Comparison with existing time_offset API [superset]

Antonio-RiveroMartnez commented on code in PR #27718: URL: https://github.com/apache/superset/pull/27718#discussion_r1601890790 ## superset-frontend/packages/superset-ui-core/test/time-comparison/fetchTimeRange.test.ts: ## @@ -116,3 +117,54 @@ it('returns a formatted error

Re: [PR] refactor(plugins): BigNumber Time Comparison with existing time_offset API [superset]

michael-s-molina commented on code in PR #27718: URL: https://github.com/apache/superset/pull/27718#discussion_r1601467320 ## superset-frontend/packages/superset-ui-core/src/time-comparison/getTimeOffset.ts: ## @@ -0,0 +1,121 @@ +/** + * Licensed to the Apache Software

Re: [PR] refactor(plugins): BigNumber Time Comparison with existing time_offset API [superset]

michael-s-molina commented on PR #27718: URL: https://github.com/apache/superset/pull/27718#issuecomment-2112253838 @Antonio-RiveroMartnez I added the `hold:testing` label to this PR. I'll wait for your rebase and will test the changes using Airbnb's production data, the same way I did for

Re: [PR] refactor(plugins): BigNumber Time Comparison with existing time_offset API [superset]

Antonio-RiveroMartnez commented on code in PR #27718: URL: https://github.com/apache/superset/pull/27718#discussion_r1598372934 ## superset/common/query_context_processor.py: ## @@ -488,21 +511,17 @@ def processing_time_offsets( # pylint:

Re: [PR] refactor(plugins): BigNumber Time Comparison with existing time_offset API [superset]

michael-s-molina commented on code in PR #27718: URL: https://github.com/apache/superset/pull/27718#discussion_r1598335433 ## superset/common/query_context_processor.py: ## @@ -488,21 +511,17 @@ def processing_time_offsets( # pylint: disable=too-many-locals,too-many-stateme

Re: [PR] refactor(plugins): BigNumber Time Comparison with existing time_offset API [superset]

eschutho commented on code in PR #27718: URL: https://github.com/apache/superset/pull/27718#discussion_r1596970244 ## superset-frontend/plugins/plugin-chart-echarts/src/BigNumber/BigNumberPeriodOverPeriod/controlPanel.ts: ## @@ -180,14 +108,12 @@ const config:

Re: [PR] refactor(plugins): BigNumber Time Comparison with existing time_offset API [superset]

github-actions[bot] commented on PR #27718: URL: https://github.com/apache/superset/pull/27718#issuecomment-2088939075 @Antonio-RiveroMartnez Ephemeral environment spinning up at http://34.223.248.234:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and

Re: [PR] refactor(plugins): BigNumber Time Comparison with existing time_offset API [superset]

Antonio-RiveroMartnez commented on PR #27718: URL: https://github.com/apache/superset/pull/27718#issuecomment-2088922177 /testenv up FEATURE_CHART_PLUGINS_EXPERIMENTAL=true -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] refactor(plugins): BigNumber Time Comparison with existing time_offset API [superset]

github-actions[bot] commented on PR #27718: URL: https://github.com/apache/superset/pull/27718#issuecomment-2085829719 @Antonio-RiveroMartnez Ephemeral environment spinning up at http://34.218.244.115:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and

Re: [PR] refactor(plugins): BigNumber Time Comparison with existing time_offset API [superset]

Antonio-RiveroMartnez commented on PR #27718: URL: https://github.com/apache/superset/pull/27718#issuecomment-2085785075 /testenv up FEATURE_CHART_PLUGINS_EXPERIMENTAL=true -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] refactor(plugins): BigNumber Time Comparison with existing time_offset API [superset]

eschutho commented on code in PR #27718: URL: https://github.com/apache/superset/pull/27718#discussion_r1581476517 ## superset-frontend/packages/superset-ui-core/src/time-comparison/getTimeOffset.ts: ## @@ -0,0 +1,101 @@ +/** + * Licensed to the Apache Software Foundation (ASF)