[xwiki-notifications] [Issue] Commented: (XWIKI-1845) Create improved Statistics API

2007-11-29 Thread Sergiu Dumitriu (JIRA)
[ http://jira.xwiki.org/jira/browse/XWIKI-1845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_19918 ] Sergiu Dumitriu commented on XWIKI-1845: Thanks, applied. > Create improved Statistics API > --

[xwiki-notifications] [Issue] Commented: (XWIKI-1845) Create improved Statistics API

2007-11-26 Thread Vincent Massol (JIRA)
[ http://jira.xwiki.org/jira/browse/XWIKI-1845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_19855 ] Vincent Massol commented on XWIKI-1845: --- Thanks Marius. I haven't checked yet. However the functional xmlrpc validatio

[xwiki-notifications] [Issue] Commented: (XWIKI-1845) Create improved Statistics API

2007-11-22 Thread Marius Dumitru Florea (JIRA)
[ http://jira.xwiki.org/jira/browse/XWIKI-1845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_19777 ] Marius Dumitru Florea commented on XWIKI-1845: -- Hi Vincent, I can defend myself only regarding the getDAY(), g

[xwiki-notifications] [Issue] Commented: (XWIKI-1845) Create improved Statistics API

2007-11-22 Thread Vincent Massol (JIRA)
[ http://jira.xwiki.org/jira/browse/XWIKI-1845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_19776 ] Vincent Massol commented on XWIKI-1845: --- Hi Marius, Good patch in general. I'm applying it now. There are a few thing

[xwiki-notifications] [Issue] Commented: (XWIKI-1845) Create improved Statistics API

2007-11-20 Thread Vincent Massol (JIRA)
[ http://jira.xwiki.org/jira/browse/XWIKI-1845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_19767 ] Vincent Massol commented on XWIKI-1845: --- For rename I think we need to implement the jira issue about keeping the old

[xwiki-notifications] [Issue] Commented: (XWIKI-1845) Create improved Statistics API

2007-11-20 Thread Sergiu Dumitriu (JIRA)
[ http://jira.xwiki.org/jira/browse/XWIKI-1845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_19766 ] Sergiu Dumitriu commented on XWIKI-1845: I think the issue is a semantical one: what do we log, document access, or

[xwiki-notifications] [Issue] Commented: (XWIKI-1845) Create improved Statistics API

2007-11-20 Thread Sergiu Dumitriu (JIRA)
[ http://jira.xwiki.org/jira/browse/XWIKI-1845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_19765 ] Sergiu Dumitriu commented on XWIKI-1845: Then how about rename? > Create improved Statistics API >

[xwiki-notifications] [Issue] Commented: (XWIKI-1845) Create improved Statistics API

2007-11-20 Thread Vincent Massol (JIRA)
[ http://jira.xwiki.org/jira/browse/XWIKI-1845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_19764 ] Vincent Massol commented on XWIKI-1845: --- I don't think they should be deleted especially since we know don't delete a

[xwiki-notifications] [Issue] Commented: (XWIKI-1845) Create improved Statistics API

2007-11-20 Thread Sergiu Dumitriu (JIRA)
[ http://jira.xwiki.org/jira/browse/XWIKI-1845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_19762 ] Sergiu Dumitriu commented on XWIKI-1845: About 3, we need to decide what should we do. Should statistics be updated

[xwiki-notifications] [Issue] Commented: (XWIKI-1845) Create improved Statistics API

2007-11-13 Thread Vincent Massol (JIRA)
[ http://jira.xwiki.org/jira/browse/XWIKI-1845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_19683 ] Vincent Massol commented on XWIKI-1845: --- Looks good so far. It possibly needs some minor tweaks. What's really import

[xwiki-notifications] [Issue] Commented: (XWIKI-1845) Create improved Statistics API

2007-11-12 Thread Vincent Massol (JIRA)
[ http://jira.xwiki.org/jira/browse/XWIKI-1845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_19670 ] Vincent Massol commented on XWIKI-1845: --- Hi Marius, I've done a quick and light review: 1) I think the Java API shou