[GitHub] [zookeeper] arshadmohammad commented on pull request #1855: ZOOKEEPER-1875: NullPointerException in ClientCnxn$EventThread.processEvent

arshadmohammad commented on PR #1855: URL: https://github.com/apache/zookeeper/pull/1855#issuecomment-1094138322 I checked the zk client code carefully, NPE will occur only when watcher is set null either throw ZooKeeper constructor or through register method. Now I think we should do the e

[GitHub] [zookeeper] arshadmohammad commented on pull request #1829: ZOOKEEPER-4482 Fix commons-io and commons-cli LICENSE files

arshadmohammad commented on PR #1829: URL: https://github.com/apache/zookeeper/pull/1829#issuecomment-1094126772 It is ok -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [zookeeper] eolivelli commented on pull request #1829: ZOOKEEPER-4482 Fix commons-io and commons-cli LICENSE files

eolivelli commented on PR #1829: URL: https://github.com/apache/zookeeper/pull/1829#issuecomment-1094109450 @arshadmohammad I will do it on Monday. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [zookeeper] arshadmohammad commented on pull request #1688: ZOOKEEPER-4287: Upgrade prometheus client library version to 0.10.0

arshadmohammad commented on PR #1688: URL: https://github.com/apache/zookeeper/pull/1688#issuecomment-1094097263 Please conclude this PR, if this is supposed to be part of 3.7.1 release -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [zookeeper] arshadmohammad commented on pull request #1829: ZOOKEEPER-4482 Fix commons-io and commons-cli LICENSE files

arshadmohammad commented on PR #1829: URL: https://github.com/apache/zookeeper/pull/1829#issuecomment-1094096678 @eolivelli can you please raise one MR for branch-3.8, and one MR for branch-3.7 and branch-3.6 -- This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [zookeeper] asfgit closed pull request #1856: ZOOKEEPER-4515: ZK Cli quit command always logs error

asfgit closed pull request #1856: ZOOKEEPER-4515: ZK Cli quit command always logs error URL: https://github.com/apache/zookeeper/pull/1856 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [zookeeper] eolivelli commented on a diff in pull request #1859: ZOOKEEPER-4466: Support different watch modes on same path

eolivelli commented on code in PR #1859: URL: https://github.com/apache/zookeeper/pull/1859#discussion_r846618287 ## zookeeper-server/src/main/java/org/apache/zookeeper/server/watch/WatchStats.java: ## @@ -0,0 +1,105 @@ +/** + * Licensed to the Apache Software Foundation (ASF) u

[GitHub] [zookeeper] eolivelli commented on pull request #1859: ZOOKEEPER-4466: Support different watch modes on same path

eolivelli commented on PR #1859: URL: https://github.com/apache/zookeeper/pull/1859#issuecomment-1093910536 We need more eyes on this patch -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[GitHub] [zookeeper] kezhuw commented on a diff in pull request #1859: ZOOKEEPER-4466: Support different watch modes on same path

kezhuw commented on code in PR #1859: URL: https://github.com/apache/zookeeper/pull/1859#discussion_r846614408 ## zookeeper-server/src/main/java/org/apache/zookeeper/server/watch/WatchStats.java: ## @@ -0,0 +1,105 @@ +/** + * Licensed to the Apache Software Foundation (ASF) unde

[GitHub] [zookeeper] eolivelli commented on a diff in pull request #1859: ZOOKEEPER-4466: Support different watch modes on same path

eolivelli commented on code in PR #1859: URL: https://github.com/apache/zookeeper/pull/1859#discussion_r846609558 ## zookeeper-server/src/main/java/org/apache/zookeeper/server/watch/WatchStats.java: ## @@ -0,0 +1,105 @@ +/** + * Licensed to the Apache Software Foundation (ASF) u

[GitHub] [zookeeper] kezhuw commented on a diff in pull request #1859: ZOOKEEPER-4466: Support different watch modes on same path

kezhuw commented on code in PR #1859: URL: https://github.com/apache/zookeeper/pull/1859#discussion_r846609327 ## zookeeper-server/src/main/java/org/apache/zookeeper/server/watch/WatchStats.java: ## @@ -0,0 +1,105 @@ +/** + * Licensed to the Apache Software Foundation (ASF) unde

[GitHub] [zookeeper] kezhuw commented on a diff in pull request #1859: ZOOKEEPER-4466: Support different watch modes on same path

kezhuw commented on code in PR #1859: URL: https://github.com/apache/zookeeper/pull/1859#discussion_r846606935 ## zookeeper-server/src/main/java/org/apache/zookeeper/server/watch/WatchManager.java: ## @@ -305,13 +322,12 @@ public synchronized WatchesSummary getWatchesSummary() {

[GitHub] [zookeeper] eolivelli commented on pull request #1856: ZOOKEEPER-4515: ZK Cli quit command always logs error

eolivelli commented on PR #1856: URL: https://github.com/apache/zookeeper/pull/1856#issuecomment-1093818549 Please chery pick to all active branches -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [zookeeper] eolivelli commented on a diff in pull request #1859: ZOOKEEPER-4466: Support different watch modes on same path

eolivelli commented on code in PR #1859: URL: https://github.com/apache/zookeeper/pull/1859#discussion_r846598942 ## zookeeper-server/src/main/java/org/apache/zookeeper/server/watch/WatchStats.java: ## @@ -0,0 +1,105 @@ +/** + * Licensed to the Apache Software Foundation (ASF) u

[GitHub] [zookeeper] sonatype-lift[bot] commented on a diff in pull request #1859: ZOOKEEPER-4466: Support different watch modes on same path

sonatype-lift[bot] commented on code in PR #1859: URL: https://github.com/apache/zookeeper/pull/1859#discussion_r846598219 ## zookeeper-server/src/main/java/org/apache/zookeeper/server/watch/WatchManager.java: ## @@ -305,13 +322,12 @@ public synchronized WatchesSummary getWatche

[GitHub] [zookeeper] kezhuw opened a new pull request, #1859: ZOOKEEPER-4466: Support different watch modes on same path

kezhuw opened a new pull request, #1859: URL: https://github.com/apache/zookeeper/pull/1859 Currently, in server side, there is only one watcher mode per path. This will destroy and corrupt old watch when client watch a watching path. -- This is an automated message from the Apache Git