Re: [PR] ZOOKEEPER-4767: New implementation of prometheus quantile metrics based on DataSketches [zookeeper]

2023-11-21 Thread via GitHub
Shawyeok commented on code in PR #2086: URL: https://github.com/apache/zookeeper/pull/2086#discussion_r1400944637 ## zookeeper-metrics-providers/zookeeper-prometheus-metrics/src/main/java/io/prometheus/client/SketchesSummary.java: ## @@ -0,0 +1,254 @@ +/* + * Licensed to the Apa

Re: [PR] ZOOKEEPER-4767: New implementation of prometheus quantile metrics based on DataSketches [zookeeper]

2023-11-21 Thread via GitHub
tisonkun commented on code in PR #2086: URL: https://github.com/apache/zookeeper/pull/2086#discussion_r1400663413 ## zookeeper-metrics-providers/zookeeper-prometheus-metrics/src/main/java/io/prometheus/client/SketchesSummary.java: ## @@ -0,0 +1,254 @@ +/* + * Licensed to the Apa

Re: [PR] ZOOKEEPER-4767: New implementation of prometheus quantile metrics based on DataSketches [zookeeper]

2023-11-21 Thread via GitHub
tisonkun commented on code in PR #2086: URL: https://github.com/apache/zookeeper/pull/2086#discussion_r1400657176 ## zookeeper-metrics-providers/zookeeper-prometheus-metrics/src/main/java/org/apache/zookeeper/metrics/prometheus/PrometheusMetricsProvider.java: ## @@ -99,35 +102,3

Re: [PR] ZOOKEEPER-4767: New implementation of prometheus quantile metrics based on DataSketches [zookeeper]

2023-11-21 Thread via GitHub
tisonkun commented on code in PR #2086: URL: https://github.com/apache/zookeeper/pull/2086#discussion_r1400658972 ## zookeeper-metrics-providers/zookeeper-prometheus-metrics/src/main/java/org/apache/zookeeper/metrics/prometheus/PrometheusMetricsProvider.java: ## @@ -483,79 +487,

Re: [PR] ZOOKEEPER-4767: New implementation of prometheus quantile metrics based on DataSketches [zookeeper]

2023-11-21 Thread via GitHub
tisonkun commented on code in PR #2086: URL: https://github.com/apache/zookeeper/pull/2086#discussion_r1400658972 ## zookeeper-metrics-providers/zookeeper-prometheus-metrics/src/main/java/org/apache/zookeeper/metrics/prometheus/PrometheusMetricsProvider.java: ## @@ -483,79 +487,

Re: [PR] ZOOKEEPER-4767: New implementation of prometheus quantile metrics based on DataSketches [zookeeper]

2023-11-21 Thread via GitHub
tisonkun commented on code in PR #2086: URL: https://github.com/apache/zookeeper/pull/2086#discussion_r1400654747 ## zookeeper-metrics-providers/zookeeper-prometheus-metrics/src/main/java/org/apache/zookeeper/metrics/prometheus/PrometheusMetricsProvider.java: ## @@ -77,12 +73,14