Re: [PR] ZOOKEEPER-2590 exists() should check read ACL permission [zookeeper]

2023-12-01 Thread via GitHub
anmolnar commented on PR #2093: URL: https://github.com/apache/zookeeper/pull/2093#issuecomment-1836842117 @eolivelli I need to make a tiny change on the patch, because we shouldn't throw exception if the znode doesn't exist in exists(). We should skip ACL check in this case and return prop

[PR] Zookeeper 4756: [Addendum] Refactor commit message handling in merge_pr function [zookeeper]

2023-12-01 Thread via GitHub
szucsvillo opened a new pull request, #2095: URL: https://github.com/apache/zookeeper/pull/2095 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] ZOOKEEPER-4756: Merge script should use GitHub api to merge pull requ… [zookeeper]

2023-12-01 Thread via GitHub
anmolnar merged PR #2092: URL: https://github.com/apache/zookeeper/pull/2092 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@z

Re: [PR] ZOOKEEPER-4756: Merge script should use GitHub api to merge pull requ… [zookeeper]

2023-12-01 Thread via GitHub
anmolnar commented on PR #2092: URL: https://github.com/apache/zookeeper/pull/2092#issuecomment-1836063442 > > One issue I've found is that it couldn't parse the Jira ID and I had to enter it manually: > > I suppose this is a follow-up opportunity that we can merge this patch first s