karthick-ponnusamy commented on PR #2041:
URL: https://github.com/apache/zookeeper/pull/2041#issuecomment-2048381867
Will this be approved anytime soon? We would greatly appreciate if this was
merged as our infrastructure is greatly affected by this issue
--
This is an automated messa
ppkarwasz commented on PR #2155:
URL: https://github.com/apache/zookeeper/pull/2155#issuecomment-2048289428
> > The meaning is pretty much up to each developer to interpret. I
interpret `provided` as "we don't bundle Logback, but you **need** it for
Zookeeper to run". Regarding `optional` I
ctubbsii commented on code in PR #2155:
URL: https://github.com/apache/zookeeper/pull/2155#discussion_r1559893434
##
zookeeper-assembly/pom.xml:
##
@@ -103,6 +103,10 @@
jline
jline
+
+ ch.qos.logback
+ logback-classic
+
Review Comment:
B
ctubbsii commented on PR #2155:
URL: https://github.com/apache/zookeeper/pull/2155#issuecomment-2048181083
> Personally I am not a big fan of `optional` or `provided` dependencies:
their role is documentation only.
It affects behavior, so I would not say it's documentation only. But e
ppkarwasz commented on code in PR #2155:
URL: https://github.com/apache/zookeeper/pull/2155#discussion_r1559874907
##
zookeeper-server/pom.xml:
##
@@ -177,6 +169,11 @@
tools
test
+
+ ch.qos.logback
+ logback-classic
+ test
+
Review Com
ctubbsii commented on code in PR #2155:
URL: https://github.com/apache/zookeeper/pull/2155#discussion_r1559857699
##
zookeeper-server/pom.xml:
##
@@ -177,6 +169,11 @@
tools
test
+
+ ch.qos.logback
+ logback-classic
+ test
+
Review Comm
nikita15p opened a new pull request, #2156:
URL: https://github.com/apache/zookeeper/pull/2156
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
jonmv commented on code in PR #2154:
URL: https://github.com/apache/zookeeper/pull/2154#discussion_r1559542245
##
zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/SendAckRequestProcessor.java:
##
@@ -20,6 +20,8 @@
import java.io.Flushable;
import java.io.IOE
AlphaCanisMajoris commented on PR #2152:
URL: https://github.com/apache/zookeeper/pull/2152#issuecomment-2047602209
Hi, @kezhuw. thanks a lot for your careful review! I've updated the code fix
in this pr. Could u please take some time to check the new commit and see if
there is anything els
AlphaCanisMajoris commented on PR #2154:
URL: https://github.com/apache/zookeeper/pull/2154#issuecomment-2047539731
LGTM.
> Together with #2111 and #2152, this should cover all the fixes in #1925.
Yes I believe so.
BTW, could u please recommit this pr, since it wasn't bu
ppkarwasz commented on PR #2155:
URL: https://github.com/apache/zookeeper/pull/2155#issuecomment-2047451913
> maybe we can mark this dependency as runtime optional instead of test?
Personally I am not a big fan of `optional` or `provided` dependencies:
their role is documentation only
shoothzj commented on PR #2155:
URL: https://github.com/apache/zookeeper/pull/2155#issuecomment-2046946911
maybe we can mark this dependency as runtime optional instead of test?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
12 matches
Mail list logo
