Re: [PR] ZOOKEEPER-4693: Modify the comments of dataDir field and snapDir in FileTxnSnapLog class [zookeeper]

2024-08-25 Thread via GitHub
kezhuw commented on PR #1999: URL: https://github.com/apache/zookeeper/pull/1999#issuecomment-2309407452 Superceded by #2060. Thank you for your contribution! @LeeGuoPing -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] ZOOKEEPER-4693: Modify the comments of dataDir field and snapDir in FileTxnSnapLog class [zookeeper]

2024-08-25 Thread via GitHub
kezhuw closed pull request #1999: ZOOKEEPER-4693: Modify the comments of dataDir field and snapDir in FileTxnSnapLog class URL: https://github.com/apache/zookeeper/pull/1999 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] ZOOKEEPER-4747: Add synchronous sync to ease synchronous call chains [zookeeper]

2024-08-25 Thread via GitHub
kezhuw commented on PR #2068: URL: https://github.com/apache/zookeeper/pull/2068#issuecomment-2309390321 I plan to merge this now as all remaining review comments are either covered or cloud covered by separated jiras now: * ZOOKEEPER-3414 proposes way to handle `path` in `sync`. * ZOO

Re: [PR] ZOOKEEPER-4753: zookeeper-server: Improvement: Explicit handling of D… …IGEST-MD5 vs GSSAPI in quorum auth for branch 3.6 [zookeeper]

2024-08-25 Thread via GitHub
kezhuw closed pull request #2090: ZOOKEEPER-4753: zookeeper-server: Improvement: Explicit handling of D… …IGEST-MD5 vs GSSAPI in quorum auth for branch 3.6 URL: https://github.com/apache/zookeeper/pull/2090 -- This is an automated message from the Apache Git Service. To respond to the messag

Re: [PR] ZOOKEEPER-4753: zookeeper-server: Improvement: Explicit handling of D… …IGEST-MD5 vs GSSAPI in quorum auth for branch 3.6 [zookeeper]

2024-08-25 Thread via GitHub
kezhuw commented on PR #2090: URL: https://github.com/apache/zookeeper/pull/2090#issuecomment-2309372955 Close as 3.6 is end of life. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] ZOOKEEPER-4262: Backport ZOOKEEPER-3911 to branch-3.5 [zookeeper]

2024-08-25 Thread via GitHub
kezhuw closed pull request #1657: ZOOKEEPER-4262: Backport ZOOKEEPER-3911 to branch-3.5 URL: https://github.com/apache/zookeeper/pull/1657 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

Re: [PR] ZOOKEEPER-4262: Backport ZOOKEEPER-3911 to branch-3.5 [zookeeper]

2024-08-25 Thread via GitHub
kezhuw commented on PR #1657: URL: https://github.com/apache/zookeeper/pull/1657#issuecomment-2309370780 Close as already merged . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

Re: [PR] ZOOKEEPER-4432: Backport ZOOKEEPER-3109 to branch-3.5 [zookeeper]

2024-08-25 Thread via GitHub
kezhuw commented on PR #1789: URL: https://github.com/apache/zookeeper/pull/1789#issuecomment-2309369771 Close as 3.5 is end of life. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] ZOOKEEPER-4432: Backport ZOOKEEPER-3109 to branch-3.5 [zookeeper]

2024-08-25 Thread via GitHub
kezhuw closed pull request #1789: ZOOKEEPER-4432: Backport ZOOKEEPER-3109 to branch-3.5 URL: https://github.com/apache/zookeeper/pull/1789 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

Re: [PR] ZOOKEEPER-4643, ZOOKEEPER-4646 & ZOOKEEPER-4394: Committed txns lost / NullPointerException in Learner.syncWithLeader() [zookeeper]

2024-08-25 Thread via GitHub
AlphaCanisMajoris commented on PR #2152: URL: https://github.com/apache/zookeeper/pull/2152#issuecomment-2309356074 > @kezhuw Thanks for your review and approval! By the way, is it possible to invite or assign some developers familiar to ZooKeeper's design logic to review this fix so we can

Re: [PR] ZOOKEEPER-2332: Fix server failed to start for empty txn log [zookeeper]

2024-08-25 Thread via GitHub
kezhuw commented on code in PR #2141: URL: https://github.com/apache/zookeeper/pull/2141#discussion_r1730659290 ## zookeeper-server/src/test/java/org/apache/zookeeper/server/persistence/FileTxnLogTest.java: ## @@ -296,6 +302,73 @@ public void testLogSizeLimit(@TempDir File tmpDi

Re: [PR] ZOOKEEPER-4810: Fix buf data race at format_endpoint_info() [zookeeper]

2024-08-25 Thread via GitHub
kezhuw commented on code in PR #2140: URL: https://github.com/apache/zookeeper/pull/2140#discussion_r1730668299 ## zookeeper-client/zookeeper-client-c/src/zookeeper.c: ## @@ -5111,11 +5111,11 @@ int zoo_add_auth(zhandle_t *zh,const char* scheme,const char* cert, static const

Re: [PR] ZOOKEEPER-2332: Fix server failed to start for empty txn log [zookeeper]

2024-08-25 Thread via GitHub
kezhuw commented on code in PR #2141: URL: https://github.com/apache/zookeeper/pull/2141#discussion_r1730657993 ## zookeeper-server/src/main/java/org/apache/zookeeper/server/persistence/FileTxnLog.java: ## @@ -701,14 +708,26 @@ public long getStorageSize() { /**

Re: [PR] ZOOKEEPER-4853: Fix assert in ZooKeeperQuotaTest#testQuota [zookeeper]

2024-08-25 Thread via GitHub
kezhuw commented on PR #2169: URL: https://github.com/apache/zookeeper/pull/2169#issuecomment-2309272899 @1neverknow Thank you for your contribution! Merged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

Re: [PR] ZOOKEEPER-4853: Fix assert in ZooKeeperQuotaTest#testQuota [zookeeper]

2024-08-25 Thread via GitHub
kezhuw merged PR #2169: URL: https://github.com/apache/zookeeper/pull/2169 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@zoo

Re: [PR] ZOOKEEPER-4546: Backport auto reloading client key/trust store to 3.8 [zookeeper]

2024-08-25 Thread via GitHub
eolivelli commented on PR #1885: URL: https://github.com/apache/zookeeper/pull/1885#issuecomment-2308954731 Sorry for late reply -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

Re: [PR] ZOOKEEPER-4546: Backport auto reloading client key/trust store to 3.8 [zookeeper]

2024-08-25 Thread via GitHub
sangitaccount commented on PR #1885: URL: https://github.com/apache/zookeeper/pull/1885#issuecomment-2308934578 Hi @li4wang @symat Could you please help approving this PR so that we can have this feature in the stable release 3.8.4 ( at the time of writing ). Thank you. -- This