songxiaosheng commented on PR #2238:
URL: https://github.com/apache/zookeeper/pull/2238#issuecomment-2750008872
> Hello @songxiaosheng . Thank you for the patch, but I'm not sure we'll be
able to commit this.
>
> In #925 , we intentionally slimmed down pom.xml so that clients do not
empiredan commented on PR #2223:
URL: https://github.com/apache/zookeeper/pull/2223#issuecomment-2749996853
> @empiredan Thank you for your contribution! I checked the refined
`zoo_sasl_password_callback_t`, I think it is better than what I suggested.
>
> I left a comment about api do
tisonkun commented on PR #1596:
URL: https://github.com/apache/zookeeper/pull/1596#issuecomment-2749764359
> I'm following up on whether we will merge or improve this patch soon?
Thanks!
@functioner I can review this patch if you'd rebase on the master or open a
new PR.
--
This is
cnauroth closed pull request #2237: ZOOKEEPER-4909: Fix exceeded request
timeout in case of spurious wakeup
URL: https://github.com/apache/zookeeper/pull/2237
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
kezhuw commented on code in PR #2223:
URL: https://github.com/apache/zookeeper/pull/2223#discussion_r2010704219
##
zookeeper-client/zookeeper-client-c/include/zookeeper.h:
##
@@ -667,6 +667,74 @@ ZOOAPI zhandle_t *zookeeper_init_sasl(const char *host,
watcher_fn fn,
ZOOAPI sas
kezhuw commented on code in PR #2236:
URL: https://github.com/apache/zookeeper/pull/2236#discussion_r2010479529
##
zookeeper-server/src/main/java/org/apache/zookeeper/server/NettyServerCnxn.java:
##
@@ -366,7 +366,12 @@ private void appendToQueuedBuffer(ByteBuf buf) {
void
empiredan commented on PR #2223:
URL: https://github.com/apache/zookeeper/pull/2223#issuecomment-2748850389
> Looks good except possible `undefined` in `zoo_sasl_password_callback_t`.
I think we probably should avoid `undefined` path from caller side.
@kezhuw Thank you very much for h
kezhuw merged PR #2039:
URL: https://github.com/apache/zookeeper/pull/2039
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@zoo
kezhuw commented on code in PR #2236:
URL: https://github.com/apache/zookeeper/pull/2236#discussion_r2010479529
##
zookeeper-server/src/main/java/org/apache/zookeeper/server/NettyServerCnxn.java:
##
@@ -366,7 +366,12 @@ private void appendToQueuedBuffer(ByteBuf buf) {
void
songxiaosheng commented on PR #2238:
URL: https://github.com/apache/zookeeper/pull/2238#issuecomment-2748366532
@tisonkun PATL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment
songxiaosheng closed pull request #2233: fix error when no dep dropwizard
java.lang.NoClassDefFoundError: com/…
URL: https://github.com/apache/zookeeper/pull/2233
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
songxiaosheng opened a new pull request, #2238:
URL: https://github.com/apache/zookeeper/pull/2238
fix follow error
```
Exception in thread "ZooKeeper Server Starter"
java.lang.NoClassDefFoundError: com/codahale/metrics/Reservoir
at
org.apache.zookeeper.metrics.impl.DefaultMet
jiafu1115 commented on PR #2236:
URL: https://github.com/apache/zookeeper/pull/2236#issuecomment-2747493642
test fail? no relationshiop with this commit?
08:43:08 [ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time
elapsed: 4.045 s <<< FAILURE! - in
org.apache.zookeeper.serv
jiafu1115 commented on PR #2236:
URL: https://github.com/apache/zookeeper/pull/2236#issuecomment-2747282001
@kezhuw thanks for comment. I update the code according to your suggestion.
You can help to double check. thanks
--
This is an automated message from the Apache Git Service.
To resp
14 matches
Mail list logo
