[notmuch] [PATCH] notmuch-new: Eliminate tallocs whilst construct filenames.

2009-11-27 Thread Jeffrey Ollie
On Fri, Nov 27, 2009 at 11:41 PM, Carl Worth wrote: > > But yes, we need a test suite. I have zero experience, but Check[1] looks interesting. > Oh, and we'll also need to deal with remaining glib usage inside of > notmuch, (and inside of GMime as well), before we can do good testing > for

[notmuch] [PATCH] Use libgcrypt for hashing.

2009-11-27 Thread Jeffrey Ollie
On Fri, Nov 27, 2009 at 9:59 PM, Ingmar Vanhassel wrote: > > Most distributions have a rather strict policy to use system libraries > over internal copies. Fedora: https://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries Debian:

[notmuch] [PATCH] Use libgcrypt for hashing.

2009-11-27 Thread Jeffrey Ollie
On Fri, Nov 27, 2009 at 9:31 PM, Mikhail Gusarov wrote: > Twas brillig at 21:28:03 27.11.2009 UTC-06 when jeff at ocjtech.us did gyre > and gimble: > > ?JCO> Instead of including a private implementation of the SHA1 hash > > xserver went this road, and now it has >

[notmuch] Snippet to jump to message in Gnus from notmuch-show buffer

2009-11-27 Thread Tassilo Horn
Carl Worth writes: Hi Carl, > On Tue, 24 Nov 2009 09:02:46 +0100, Tassilo Horn > wrote: >> I'm a Gnus user and use notmuch mostly for searching. When I want to >> reply to a message, I need to get back to Gnus, so that my Gnus >> posting styles (gcc into that group, right email address,

[notmuch] [PATCH] Add tests to configure script to detect strndup and getline

2009-11-27 Thread Marten Veldthuis
On Mon, Nov 23, 2009 at 12:14:15PM -0600, Jeffrey C. Ollie wrote: > cat > Makefile.config < prefix = /usr/local > bash_completion_dir = /etc/bash_completion.d >-CFLAGS += ${have_valgrind} >+CFLAGS += ${have_valgrind} ${strndup} ${getline} > EOF This doesn't seem to do much for me, they don't seem

[notmuch] [PATCH -v6] notmuch.el: Add face support to search mode

2009-11-27 Thread Carl Worth
de basically the example above. Anyway, thanks for the patch. -Carl -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 189 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20091127/427b9084/attachment.pgp>

[notmuch] Problems importing my mail...

2009-11-27 Thread Carl Worth
Well, let us know if things go wrong again. -Carl -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 189 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20091127/d9cec710/attachment.pgp>

[notmuch] [PATCH] Use libgcrypt for hashing.

2009-11-27 Thread Carl Worth
189 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20091127/6e45f2a9/attachment.pgp>

[notmuch] [PATCH] Use libgcrypt for hashing.

2009-11-27 Thread Carl Worth
... Name: not available Type: application/pgp-signature Size: 189 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20091127/b002ab9f/attachment.pgp>

[notmuch] [PATCH RFC] debugger: detect presence of ptrace type debuggers

2009-11-27 Thread Carl Worth
able Type: application/pgp-signature Size: 189 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20091127/68b5e759/attachment.pgp>

[notmuch] semi-usable notmuch-gtk client

2009-11-27 Thread Bart Trojanowski
* Baruch Even [091127 12:58]: > I added a quick hack to show a message thread in notmuch-gtk and this > makes it semi-usable. I don't actually parse the reply of notmuch-show > but it's already passably usable to read mail. got screenshots? Cheers, -Bart --

[notmuch] [PATCH RFC] debugger: detect presence of ptrace type debuggers

2009-11-27 Thread Bart Trojanowski
According to the internet [1], this is a more reliable way of detecting if one is under the spell of a debugger. Should work for ptrace, strace, gdb, etc. Basically anything that uses the ptrace() syscall. [1] http://vx.netlux.org/lib/vsc04.html --- debugger.c |5 + 1 files changed, 5

[notmuch] Problems importing my mail...

2009-11-27 Thread Carl Worth
- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 189 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20091127/1e284ef9/attachment.pgp>

[notmuch] [PATCH] Return unpropertized strings for filename and message-id

2009-11-27 Thread Carl Worth
next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 189 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20091127/9fca7f74/attachment.pgp>

[notmuch] [PATCH] New function notmuch-show-kill-ring-save-message-id.

2009-11-27 Thread Carl Worth
mer of a message ID should be prepared to > > accept. > > Downside is that it requires shell escapes when pasting into a terminal. Yeah, there is that. -Carl -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 189 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20091127/e25bf6e8/attachment-0001.pgp>

[notmuch] [PATCH] Use libgcrypt for hashing.

2009-11-27 Thread Alexander Botero-Lowry
On Fri, 27 Nov 2009 23:43:34 -0600, Jeffrey Ollie wrote: > On Fri, Nov 27, 2009 at 9:59 PM, Ingmar Vanhassel > wrote: > > > > Most distributions have a rather strict policy to use system libraries > > over internal copies. > > Fedora [...], Debian [...] > > If there are other distributions

[notmuch] [PATCH 2/2] vim: use notmuch show --entire-thread

2009-11-27 Thread Bart Trojanowski
--- vim/plugin/notmuch.vim |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/vim/plugin/notmuch.vim b/vim/plugin/notmuch.vim index 34d70d9..a226f20 100644 --- a/vim/plugin/notmuch.vim +++ b/vim/plugin/notmuch.vim @@ -409,7 +409,7 @@ endfunction function!

[notmuch] [PATCH 1/2] notmuch-show: limit display to only matching messages

2009-11-27 Thread Bart Trojanowski
This patch changes the default behaviour of notmuch show to display only messages that match the search expression. However, --entire-thread option is provided to display all messages in threads that matched the search expression. It is deemed that will be more useful for human users on the

[notmuch] [PATCH 1/2] New function notmuch-search-operate-all: operate on all messages in the current query.

2009-11-27 Thread Carl Worth
I did accidentally add a tag once of just " " (oops!). We should nail this down so that interface authors can know how to validate things consistently. Any suggestions? -Carl -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 189 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20091127/04c40ff3/attachment.pgp>

[notmuch] [PATCH] notmuch-new: Eliminate tallocs whilst construct filenames.

2009-11-27 Thread Carl Worth
at we'll end up with is a patch to de-glib-ify GMime? I'm not sure. -Carl -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 189 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20091127/4e9dbb16/attachment.pgp>

[notmuch] [PATCH] notmuch-new: Check for non-fatal errors from stat()

2009-11-27 Thread Carl Worth
tion/pgp-signature Size: 189 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20091127/8e2b3386/attachment.pgp>

[notmuch] [PATCH] vim: preserve the 'show everything' flag when finding next/prev buffer

2009-11-27 Thread Bart Trojanowski
When show mode is invoked it could be displaying just the matched messages or everything. This flag is passed to NM_search_show_thread(). It is then stored in a buffer variable, b:nm_show_everything, and used for subsequent calls to NM_search_show_thread() triggered by , and . Signed-off-by:

[notmuch] [PATCH 9/9] Key binding rearrangement for save attachments in show mode

2009-11-27 Thread Carl Worth
9 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20091127/96577413/attachment.pgp>

[notmuch] [PATCH 8/9] Provide ability to save attachments

2009-11-27 Thread Carl Worth
l.org/pipermail/notmuch/attachments/20091127/5c370e71/attachment.pgp>

[notmuch] [PATCH] Use libgcrypt for hashing.

2009-11-27 Thread Jeffrey C. Ollie
Instead of including a private implementation of the SHA1 hash, use libgcrypt. This means less code of our own to maintain and it will be easier to switch to a different hash function like SHA256. libgcrypt was chosen because it has a fairly simple API, it's well tested (it's used in gnutls and

[notmuch] [PATCH 4/9] Factor out message buffer mgmt from notmuch-show-view-all-mime-parts

2009-11-27 Thread Alexander Botero-Lowry
On Fri, 27 Nov 2009 21:10:42 -0800, Carl Worth wrote: > On Fri, 27 Nov 2009 05:30:10 -0800, camalot at picnicpark.org wrote: > > From: Keith Amidon > > > > The ability to temporarily create a buffer containing only the > > contents of the currently selected message in notmuch show mode is > >

[notmuch] [PATCH 6/9] Reply to individual messages using message library

2009-11-27 Thread Carl Worth
ytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20091127/b31aea51/attachment.pgp>

[notmuch] [PATCH 2/3] have _notmuch_thread_create mark which messages matched the query

2009-11-27 Thread Bart Trojanowski
On Fri, 27 Nov 2009 17:15:35 -0800, Carl Worth wrote: > This is a very useful feature, Bart. Thanks for coding it up. And it's a > nicely-implemented patch series as well. Thanks. I've found it very handy. > By the way, do you think that this support obviates the > --only-matching-messages

[notmuch] [PATCH] correct message flag enum value so that it matches the type

2009-11-27 Thread Bart Trojanowski
As per Carl's request, this patch corrects the only value defined under the notmuch_message_flag_t enum typedef to match the name of the type. Signed-off-by: Bart Trojanowski --- lib/notmuch.h |2 +- lib/thread.cc |2 +- notmuch-show.c |2 +- 3 files changed, 3 insertions(+), 3

[notmuch] [PATCH 5/9] Forward individual messages using message-forward

2009-11-27 Thread Carl Worth
lable URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20091127/b5d66f88/attachment.pgp>

[notmuch] [PATCH 4/9] Factor out message buffer mgmt from notmuch-show-view-all-mime-parts

2009-11-27 Thread Carl Worth
o step aside and let experts take over. :-) This piece is pushed. -Carl -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 189 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20091127/b545a2a5/attachment.pgp>

[notmuch] [PATCH 2/9] Adjust autoload comments

2009-11-27 Thread Carl Worth
nt was scrubbed... Name: not available Type: application/pgp-signature Size: 189 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20091127/14880643/attachment.pgp>

[notmuch] [PATCH 1/9] Explicitly require the message library

2009-11-27 Thread Carl Worth
- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 189 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20091127/51a17c63/attachment.pgp>

[notmuch] [PATCH -v6] notmuch.el: Use message-mode font-face to highlight mail headers

2009-11-27 Thread Carl Worth
--- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 189 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20091127/c85030c3/attachment.pgp>

[notmuch] [PATCH 2/2] add some very rudimentary support for handling html parts

2009-11-27 Thread Carl Worth
text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 189 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20091127/e818f161/attachment.pgp>

[notmuch] [PATCH 1/2] add functions to toggle the nearest backwards button of a given type

2009-11-27 Thread Carl Worth
l.org/pipermail/notmuch/attachments/20091127/5cd79ee0/attachment.pgp>

[notmuch] Show mode enhancements

2009-11-27 Thread Carl Worth
ot available Type: application/pgp-signature Size: 189 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20091127/b30d363c/attachment-0001.pgp>

[notmuch] [PATCH 3/3] notmuch.el: Select tag names with completion.

2009-11-27 Thread Carl Worth
ation/pgp-signature Size: 189 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20091127/b852c092/attachment.pgp>

[notmuch] OpenPGP support

2009-11-27 Thread Carl Worth
k) Thanks. And look! A signed reply now. -Carl -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 189 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20091127/a34f0f4a/attachment.pgp>

[notmuch] [PATCH] Return unpropertized strings for filename and message-id

2009-11-27 Thread Carl Worth
On Fri, 27 Nov 2009 09:13:12 +0100, Tassilo Horn wrote: > I guess it won't be the last one. There are some byte-compiler warnings > with notmuch.el, that I'd like to remove. Great! I'll look forward to more from you? > So an email looking like this would be correct? Almost. The place where

[notmuch] semi-usable notmuch-gtk client

2009-11-27 Thread Baruch Even
Hi, I added a quick hack to show a message thread in notmuch-gtk and this makes it semi-usable. I don't actually parse the reply of notmuch-show but it's already passably usable to read mail. Baruch

[notmuch] notmuch_threads_back and notmuch_messages_back

2009-11-27 Thread Carl Worth
On Thu, 26 Nov 2009 21:23:47 +0100, Ruben Pollan wrote: > Is it possible to implement notmuch_threads_back and notmuch_messages_back? > And I guess will make sense to have also notmuch_tags_back. > > This functions will do the oposite than notmuch_threads_advance and > notmuch_messages_advance.

[notmuch] [PATCH] add missing comma in debugging code

2009-11-27 Thread Carl Worth
On Thu, 26 Nov 2009 11:32:35 -0400, David Bremner wrote: > - INTERNAL_ERROR ("Message %s has duplicate In-Reply-To IDs: %s and %s\n" > + INTERNAL_ERROR ("Message %s has duplicate In-Reply-To IDs: %s and > %s\n", Thanks. This is pushed. -Carl

[notmuch] Gmane

2009-11-27 Thread Carl Worth
On Wed, 25 Nov 2009 23:24:03 +0100, Ingmar Vanhassel wrote: > In case anyone's interested, I've submitted this list to gmane: > http://dir.gmane.org/gmane.mail.notmuch.general > > Maybe someone who was on this list from the very beginning can submit an > archive to them, for future reference.

[notmuch] [PATCH] notmuch.el: Require message mode to avoid undefined function in replies.

2009-11-27 Thread Carl Worth
On Wed, 25 Nov 2009 14:14:20 -0800, Eric Anholt wrote: > Otherwise, those without keithp's .emacs would end up with reply mode > not being entered. Suggested by keithp. Thanks, Eric. The fact that replies were only sometimes in message-mode was really annoying me. Should be nice to have this

[notmuch] [PATCH] notmuch-new: Test if directory looks like Maildir before skipping tmp.

2009-11-27 Thread Carl Worth
On Wed, 25 Nov 2009 22:11:45 +0100, Jan Janak wrote: > Files and subdirectories with the name "tmp" that do not look like > Maildir will still be processed by 'notmuch new'. This is a nice improvement. I realize we neglected to document the original "tmp" skipping. This should definitely be

[notmuch] [PATCH] notmuch: Add Maildir directory name as tag name for messages

2009-11-27 Thread Carl Worth
On Thu, 26 Nov 2009 22:12:02 +0100, Michiel Buddingh' wrote: > Carl Worth wrote: > I considered that approach; ideally, we could test for the presence of > all three of cur, tmp and new--but this is rather messy to do in the > current treewalk structure. Taking any one of them as proof

[notmuch] Problems importing my mail...

2009-11-27 Thread Jeffrey Ollie
I'm having some problems importing my mail. I've got quite a bit stored up, and some of them I'm sure are quite large. After several hours I get the following. Is notmuch running out of memory on me? $ ./notmuch new Found 328184 total files. Warning: Unexpected extra parts of multipart/signed.

[notmuch] Using notmuch from Ruby, Python, et al.

2009-11-27 Thread Carl Worth
On Wed, 25 Nov 2009 09:58:00 -0800, Scott Robinson wrote: > Excerpts from Jeffrey Ollie's message of Wed Nov 25 09:46:47 -0800 2009: > > I selected cJSON because it was simple for integration. Given how libsha1.c is > included in lib/, I figured adding a depedency wouldn't be very > popular.

[notmuch] Using notmuch from Ruby, Python, et al.

2009-11-27 Thread Carl Worth
On Wed, 25 Nov 2009 08:16:54 -0800, Scott Robinson wrote: > I'm hoping this thread will provide a guide for my efforts. > > I'm writing a web frontend for notmuch in Ruby. But, the output from the > notmuch command-line is ambiguous. Therefore, I've started two branches > experimenting with

[notmuch] [PATCH] Return unpropertized strings for filename and message-id

2009-11-27 Thread Bart Trojanowski
* Bart Trojanowski [091127 18:32]: > You can actually put arbitrary text between the diffstat output and the first > diff --git line. For example: Oops, and that's exactly what you said... > > So to satisfy "git am", introductory and explanatory portions of > > the email, ("Hi!" and

[notmuch] [PATCH] Silence compiler warning by initializing a variable.

2009-11-27 Thread Carl Worth
On Wed, 25 Nov 2009 07:01:36 -0600, "Jeffrey C. Ollie" wrote: > If Xapian threw an exception on notmuch_query_count_messages the count > variable could be used uninitialized. Initialize count to solve the > problem. Thanks for the fix. This is pushed. -Carl

[notmuch] [PATCH] Return unpropertized strings for filename and message-id

2009-11-27 Thread Bart Trojanowski
[[ First of all I am jazzed because this is the first email I am sending to anyone other than myself from the vim interface to notmuch ]] Getting on wit the show... > So to satisfy "git am", introductory and explanatory portions of > the email, ("Hi!" and "Here's my first patch"), have

[notmuch] vim interface pull request

2009-11-27 Thread Carl Worth
On Wed, 25 Nov 2009 00:54:22 -0500, Bart Trojanowski wrote: > as you already know, I've spent some time working on a vim-based > interface to notmuch. I currently only depend on the 'march:[01]' > patches that we talked about briefly on irc. Everything else is > isolated to the 'vim' directory

[notmuch] [PATCH] notmuch-new: Fix notmuch new to look at files within symbolic links

2009-11-27 Thread Carl Worth
On Wed, 25 Nov 2009 10:28:24 +0530, "Aneesh Kumar K.V" wrote: > We look at the modified time of the database and the directory > to decide whether we need to look at only the subdirectories. > ie, if directory modified time is < database modified time > then we have already looking at all the

[notmuch] [PATCH -v2] notmuch.el: Use variable notmuch-search-oldest-first to decide the search order

2009-11-27 Thread Carl Worth
On Wed, 25 Nov 2009 10:28:13 +0530, "Aneesh Kumar K.V" wrote: > Make sure we use notmuch-search-oldest-first to decide the how > the search result should be displayed. This helps to set the > value to nil and have latest mail shown first. This also fix the > notmuch-folder mode to use the right

[notmuch] [PATCH 2/3] have _notmuch_thread_create mark which messages matched the query

2009-11-27 Thread Carl Worth
On Tue, 24 Nov 2009 23:54:34 -0500, Bart Trojanowski wrote: > When _notmuch_thread_create() is given a query string, it can return more > messages than just those matching the query. To distinguish those that > matched the query expression, the MATCHING_SEARCH flag is set > appropriately. This

[notmuch] [PATCH 2/2] Recognize reply --format=headers-only-git

2009-11-27 Thread Carl Worth
On Wed, 25 Nov 2009 19:02:19 +0100, Jed Brown wrote: > This currently means the same thing as --format=headers-only, but this > name gives more freedom to change --format=headers-only without breaking > existing versions of git. While it may make sense in the future to put something git-specific

[notmuch] Notmuch-side support for git send-email --notmuch id:

2009-11-27 Thread Carl Worth
On Wed, 25 Nov 2009 02:35:12 +0100, Jed Brown wrote: > These two patches provide support for features like the one in the > subject line. Along with these two patches, I have one for git > format-patch (which I will submit upstream soon) that uses the output > from notmuch reply

[notmuch] [PATCH -v6] notmuch.el: Use message-mode font-face to highlight mail headers

2009-11-27 Thread Aneesh Kumar K.V
Signed-off-by: Aneesh Kumar K.V --- notmuch.el | 29 +++-- 1 files changed, 27 insertions(+), 2 deletions(-) diff --git a/notmuch.el b/notmuch.el index d2ebb40..b089732 100644 --- a/notmuch.el +++ b/notmuch.el @@ -604,6 +604,32 @@ which this thread was originally

[notmuch] [PATCH 1/2] New function notmuch-search-operate-all: operate on all messages in the current query.

2009-11-27 Thread Jed Brown
t -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 197 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20091127/f06fdd3e/attachment-0001.pgp>

[notmuch] [PATCH] notmuch-new: Remove the tiresome joke from the output.

2009-11-27 Thread Marten Veldthuis
On Fri, Nov 27, 2009 at 05:46:32AM -0800, Carl Worth wrote: >> -} else { >> -printf ("No new mail---and that's not much.\n"); >> } > >Shouldn't we still print *something* here, though ("No new mail")? >Imagine the new user trying to ensure "notmuch new" is working---and >let's say

[notmuch] [PATCH] New function notmuch-show-kill-ring-save-message-id.

2009-11-27 Thread Jed Brown
rminal. Jed -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 197 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20091127/04e3f594/attachment.pgp>

[notmuch] [PATCH] notmuch-new: Eliminate tallocs whilst construct filenames.

2009-11-27 Thread Chris Wilson
Excerpts from Carl Worth's message of Fri Nov 27 13:23:06 + 2009: > On Sun, 22 Nov 2009 00:57:10 +, Chris Wilson chris-wilson.co.uk> wrote: > > The majority of filenames will fit within PATH_MAX [4096] (because > > that's a hard limit imposed by the filesystems) so we can avoid an > >

[notmuch] [PATCH -v5] notmuch.el: Use message-mode font-face to highlight mail headers

2009-11-27 Thread Aneesh Kumar K.V
Signed-off-by: Aneesh Kumar K.V --- notmuch.el | 35 +-- 1 files changed, 33 insertions(+), 2 deletions(-) diff --git a/notmuch.el b/notmuch.el index 89ccef6..851c60c 100644 --- a/notmuch.el +++ b/notmuch.el @@ -595,6 +595,38 @@ which this thread was originally

[notmuch] [PATCH -v5] notmuch.el: Add face support to search mode

2009-11-27 Thread Aneesh Kumar K.V
This patch use notmuch-tag-face showing tags in the notmuch-search-mode. We can selectively highlight each tag by setting notmuch-tag-face-alist as below (defface notmuch-tag-unread-face 'class color)) (:foreground "goldenrod"))) "Notmuch search mode face used to highligh tags.")

[notmuch] [PATCH] notmuch-new: Check for non-fatal errors from stat()

2009-11-27 Thread Chris Wilson
Currently we assume that all errors on stat() a dname is fatal (but continue anyway and report the error at the end). However, some errors reported by stat() such as a missing file or insufficient privilege, we can simply ignore and skip the file. For the others, such as a fault (unlikely!) or

[notmuch] [PATCH] notmuch: Add Maildir directory name as tag name for messages

2009-11-27 Thread Jan Janak
On 26-11 22:53, Ingmar Vanhassel wrote: > Excerpts from Michiel Buddingh''s message of Thu Nov 26 22:12:02 +0100 2009: > > Haven't tested it, but it seems you can put > > > > [core] > > whitespace = trailing-space,space-before-tab > > > > into your ~/.gitconfig now. I've also set emacs to

[notmuch] [PATCH 3/3] notmuch.el: Select tag names with completion.

2009-11-27 Thread Jan Janak
Hi Carl, On 26-11 07:15, Carl Worth wrote: > On Mon, 23 Nov 2009 01:10:56 +0100, Jan Janak wrote: > > Several commands ask the user for a tag name. With this feature the > > user can just press tab and Emacs automatically retrieves the list of > > all existing tags from notmuch database with

[notmuch] _notmuch_message_create_for_message_id makes extra call to notmuch_database_find_message

2009-11-27 Thread Keith Packard
on/pgp-signature Size: 189 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20091127/01d51465/attachment.pgp>

[notmuch] [PATCH] Return unpropertized strings for filename and message-id

2009-11-27 Thread Tassilo Horn
Carl Worth writes: Hi Carl, >> Here's my first patch. It changes that notmuch-show-get-filename and >> notmuch-show-get-message-id return simple strings and not propertited >> strings. > > Thanks, Tassilo! > > It's great to have a contribution from you in notmuch. I've pushed > this out now.

[notmuch] [PATCH 6/9] Reply to individual messages using message library

2009-11-27 Thread Keith Amidon
{-- Fri, 27 Nov 2009 20:48:46 +0530: Aneesh wrote: --} Aneesh> Hi, Really good set of patches. I am right now testing with Aneesh> the set of changes and found that Thanks! Aneesh> a) notmuch-show-reply-current and other helpers doesn't put Aneesh> the mail content i am replying in the

[notmuch] [PATCH 1/2] New function notmuch-search-operate-all: operate on all messages in the current query.

2009-11-27 Thread Carl Worth
On Thu, 26 Nov 2009 22:36:49 +0100, Jed Brown wrote: > It is often convenient to change tags on several messages at once. This > function applies any number of tag whitespace-delimited tag > modifications to all messages matching the current query. Thanks Jed, I've applied both this and the

[notmuch] [PATCH] notmuch-new: Remove the tiresome joke from the output.

2009-11-27 Thread Carl Worth
On Tue, 24 Nov 2009 19:41:20 +, Chris Wilson wrote: > As I see this every time I poll for new mail, the joke becomes very old > very quickly. The other instances of "not much" are shown much less > often and have a much more natural style, this one however feels forced, > impairing the

[notmuch] [PATCH 1/5] make headers locally expandable/collapsable

2009-11-27 Thread Carl Worth
On Tue, 24 Nov 2009 11:49:40 -0800, Alexander Botero-Lowry wrote: > On Tue, 24 Nov 2009 11:40:24 -0800, Carl Worth wrote: > > Odd. I wouldn't be suprised were that behavior the case, but I can not > reproduce it locally. I totally agree it should be the case, but I seem > to be able to expand

[notmuch] [PATCH] New function notmuch-show-kill-ring-save-message-id.

2009-11-27 Thread Carl Worth
Thanks for the patch, Jed, I almost pushed it, but noticed that it's calling `called-interactively-p' with an argument even though that function does not accept an argument. Meanwhile, the documentation of called-interactively-p suggests that using (interactive "p") is an easier way to check

[notmuch] Snippet to jump to message in Gnus from notmuch-show buffer

2009-11-27 Thread Carl Worth
[Sorry for the previous abbreviated reply---I suppose an early send is bound to happen when you give me a new function with a "C-c C-c" binding. ;-)] On Tue, 24 Nov 2009 09:02:46 +0100, Tassilo Horn wrote: > I'm a Gnus user and use notmuch mostly for searching. When I want to > reply to a

[notmuch] [PATCH 9/9] Key binding rearrangement for save attachments in show mode

2009-11-27 Thread cama...@picnicpark.org
From: Keith Amidon The most obvious bindings for save attachments are already taken. The existing 'w' binding was bound to view the raw message. This commit moves it to 'V' which still seems somewhat mnemonic and uses 'w' for save (write) attachments. --- notmuch.el |3

[notmuch] [PATCH 8/9] Provide ability to save attachments

2009-11-27 Thread cama...@picnicpark.org
From: Keith Amidon Previously the only way to save an attachment was to attempt to view it and then save it from within the viewer program. --- notmuch.el | 41 + 1 files changed, 41 insertions(+), 0 deletions(-) diff --git

[notmuch] [PATCH 7/9] Key bindings for message library based replies

2009-11-27 Thread cama...@picnicpark.org
From: Keith Amidon --- notmuch.el |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/notmuch.el b/notmuch.el index fe20b54..eaa5798 100644 --- a/notmuch.el +++ b/notmuch.el @@ -64,6 +64,9 @@ (define-key map "A"

[notmuch] [PATCH 6/9] Reply to individual messages using message library

2009-11-27 Thread cama...@picnicpark.org
From: Keith Amidon As an alternative to creating a reply from the current thread, this commit provides functions to create replies directly in emacs using the message library. A future commit will provide keybindings so that they are easy to change if a different set is

[notmuch] [PATCH 4/9] Factor out message buffer mgmt from notmuch-show-view-all-mime-parts

2009-11-27 Thread cama...@picnicpark.org
From: Keith Amidon The ability to temporarily create a buffer containing only the contents of the currently selected message in notmuch show mode is generally useful. This commit factors the majority of the code required to do so out of notmuch-show-view-all-mime-parts into a

[notmuch] [PATCH 3/9] Add key binding for notmuch-search in show-mode

2009-11-27 Thread cama...@picnicpark.org
From: Keith Amidon It's not uncommon to want to start a search as a result of something read in a message so this is convenient. --- notmuch.el |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/notmuch.el b/notmuch.el index 6400199..cd6609d 100644 ---

[notmuch] [PATCH 2/9] Adjust autoload comments

2009-11-27 Thread cama...@picnicpark.org
From: Keith Amidon The previous location of autoload comments didn't seem to correspond with the functions most likely to be the entry points for using notmuch. This change adjusts them to match those likely entry points. --- notmuch.el |6 -- 1 files changed, 4

[notmuch] [PATCH 1/9] Explicitly require the message library

2009-11-27 Thread cama...@picnicpark.org
From: Keith Amidon Functions provided by the message library were being used without ensuring it was loaded. --- notmuch.el |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/notmuch.el b/notmuch.el index d7c973c..a1efa4f 100644 --- a/notmuch.el +++

[notmuch] Show mode enhancements

2009-11-27 Thread cama...@picnicpark.org
I started using notmuch a few days ago and was astounded at how much more efficiently I could process email with it. For my usage I needed a bit more flexibility in replying/forwarding messages and the ability to conveniently save attachments. The set of patches that follow contain these two

[notmuch] [PATCH] notmuch-count: make sure all created items are freed, even in error paths

2009-11-27 Thread Carl Worth
On Tue, 24 Nov 2009 16:22:02 +0200, Dirk-Jan C. Binnema wrote: > > Another minor patch, fixing a couple of resource leaks in error paths. Thanks, Dirk-Jan, but we don't actually need this kind of care in some cases, because these aren't leaks in a permanent sense since they are talloc-based.

[notmuch] Snippet to jump to message in Gnus from notmuch-show buffer

2009-11-27 Thread Carl Worth
On Tue, 24 Nov 2009 09:02:46 +0100, Tassilo Horn wrote: > I'm a Gnus user and use notmuch mostly for searching. When I want to > reply to a message, I need to get back to Gnus, so that my Gnus posting > styles (gcc into that group, right email address, correct signature,...) > are applied. Oh,

[notmuch] _notmuch_message_create_for_message_id makes extra call to notmuch_database_find_message

2009-11-27 Thread Carl Worth
On Mon, 23 Nov 2009 12:29:44 -0800, Keith Packard wrote: > > Looking at _notmuch_message_create_for_message_id, the first thing it > does is call notmuch_database_find_message, but the returned 'message' > is never used. I haven't tried, but I suspect this call could just be > removed. Did the

[notmuch] [PATCH] Handle message renames in mail spool

2009-11-27 Thread Mikhail Gusarov
In order to handle message renames the following changes were deemed necessary: * Mtime check on individual files was disabled. As files may be moved around without changing their mtime, it's necessary to parse them even if they appear old in case old message was moved. mtime check on directories

[notmuch] [PATCH -v5] notmuch.el: Use message-mode font-face to highlight mail headers

2009-11-27 Thread Aneesh Kumar K.V
Signed-off-by: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com --- notmuch.el | 35 +-- 1 files changed, 33 insertions(+), 2 deletions(-) diff --git a/notmuch.el b/notmuch.el index 89ccef6..851c60c 100644 --- a/notmuch.el +++ b/notmuch.el @@ -595,6 +595,38 @@

[notmuch] [PATCH -v6] notmuch.el: Use message-mode font-face to highlight mail headers

2009-11-27 Thread Aneesh Kumar K.V
Signed-off-by: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com --- notmuch.el | 29 +++-- 1 files changed, 27 insertions(+), 2 deletions(-) diff --git a/notmuch.el b/notmuch.el index d2ebb40..b089732 100644 --- a/notmuch.el +++ b/notmuch.el @@ -604,6 +604,32 @@ which

Re: [notmuch] [PATCH] notmuch: Add Maildir directory name as tag name for messages

2009-11-27 Thread Jan Janak
On 26-11 22:53, Ingmar Vanhassel wrote: Excerpts from Michiel Buddingh''s message of Thu Nov 26 22:12:02 +0100 2009: Haven't tested it, but it seems you can put [core] whitespace = trailing-space,space-before-tab into your ~/.gitconfig now. I've also set emacs to mark trailing

Re: [notmuch] _notmuch_message_create_for_message_id makes extra call to notmuch_database_find_message

2009-11-27 Thread Carl Worth
On Mon, 23 Nov 2009 12:29:44 -0800, Keith Packard kei...@keithp.com wrote: Looking at _notmuch_message_create_for_message_id, the first thing it does is call notmuch_database_find_message, but the returned 'message' is never used. I haven't tried, but I suspect this call could just be

Re: [notmuch] [PATCH] notmuch-new: Eliminate tallocs whilst construct filenames.

2009-11-27 Thread Carl Worth
On Sun, 22 Nov 2009 00:57:10 +, Chris Wilson ch...@chris-wilson.co.uk wrote: The majority of filenames will fit within PATH_MAX [4096] (because that's a hard limit imposed by the filesystems) so we can avoid an allocation per lookup and thereby eliminate a large proportion of the overhead

[notmuch] [PATCH 1/9] Explicitly require the message library

2009-11-27 Thread camalot
From: Keith Amidon ke...@nicira.com Functions provided by the message library were being used without ensuring it was loaded. --- notmuch.el |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/notmuch.el b/notmuch.el index d7c973c..a1efa4f 100644 --- a/notmuch.el +++

[notmuch] [PATCH 2/9] Adjust autoload comments

2009-11-27 Thread camalot
From: Keith Amidon ke...@nicira.com The previous location of autoload comments didn't seem to correspond with the functions most likely to be the entry points for using notmuch. This change adjusts them to match those likely entry points. --- notmuch.el |6 -- 1 files changed, 4

[notmuch] [PATCH 3/9] Add key binding for notmuch-search in show-mode

2009-11-27 Thread camalot
From: Keith Amidon ke...@nicira.com It's not uncommon to want to start a search as a result of something read in a message so this is convenient. --- notmuch.el |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/notmuch.el b/notmuch.el index 6400199..cd6609d 100644 ---

[notmuch] [PATCH 9/9] Key binding rearrangement for save attachments in show mode

2009-11-27 Thread camalot
From: Keith Amidon ke...@nicira.com The most obvious bindings for save attachments are already taken. The existing 'w' binding was bound to view the raw message. This commit moves it to 'V' which still seems somewhat mnemonic and uses 'w' for save (write) attachments. --- notmuch.el |3 ++-

Re: [notmuch] [PATCH 1/2] New function notmuch-search-operate-all: operate on all messages in the current query.

2009-11-27 Thread Carl Worth
On Thu, 26 Nov 2009 22:36:49 +0100, Jed Brown j...@59a2.org wrote: It is often convenient to change tags on several messages at once. This function applies any number of tag whitespace-delimited tag modifications to all messages matching the current query. Thanks Jed, I've applied both this

  1   2   >