Rebased to current master (cb8418) as atomic-new-v4 (aka
for-review/atomic-new-v4).
On Wed, May 4, 2011 at 4:30 PM, Austin Clements wrote:
> jrollins found a timing bug in the atomicity test. ?A fix, plus beefed
> up test comments are on a new atomic-new-v3 (and
> for-review/atomic-new-v3) branch
On Sat, May 28, 2011 at 5:58 PM, Jameson Graef Rollins
wrote:
> Austin: speaking of which, would you mind rebasing that patch series
> against notmuch/master at cb8418784c21155ffea79cce8409a7ea3c546937 and
> sending that to the list again? ?That might help push Carl to merge that
> stuff sooner. ?
Rebased to current master (cb8418) as atomic-new-v4 (aka
for-review/atomic-new-v4).
On Wed, May 4, 2011 at 4:30 PM, Austin Clements wrote:
> jrollins found a timing bug in the atomicity test. A fix, plus beefed
> up test comments are on a new atomic-new-v3 (and
> for-review/atomic-new-v3) branch
On Sat, May 28, 2011 at 5:58 PM, Jameson Graef Rollins
wrote:
> Austin: speaking of which, would you mind rebasing that patch series
> against notmuch/master at cb8418784c21155ffea79cce8409a7ea3c546937 and
> sending that to the list again? That might help push Carl to merge that
> stuff sooner.
Use prefix argument instead to set switch.
---
emacs/notmuch.el |7 +--
1 files changed, 1 insertions(+), 6 deletions(-)
diff --git a/emacs/notmuch.el b/emacs/notmuch.el
index 3311fe8..0978c66 100644
--- a/emacs/notmuch.el
+++ b/emacs/notmuch.el
@@ -218,7 +218,6 @@ For a mouse binding, re
This function, like the equivalent for notmuch-search, just refreshes
the current show view. Like in notmuch-search, this new function is
bound to "=". If a prefix is given then the rediplay happens with the
crypto-switch set, which displays the thread with the opposite logic
of whatever is set i
Use prefix argument instead to set switch.
---
emacs/notmuch.el |7 +--
1 files changed, 1 insertions(+), 6 deletions(-)
diff --git a/emacs/notmuch.el b/emacs/notmuch.el
index 3311fe8..0978c66 100644
--- a/emacs/notmuch.el
+++ b/emacs/notmuch.el
@@ -218,7 +218,6 @@ For a mouse binding, re
This function, like the equivalent for notmuch-search, just refreshes
the current show view. Like in notmuch-search, this new function is
bound to "=". If a prefix is given then the rediplay happens with the
crypto-switch set, which displays the thread with the opposite logic
of whatever is set i
non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 315 bytes
Desc: not available
URL:
<http://notmuchmail.org/pipermail/notmuch/attachments/20110528/5d7878a4/attachment.pgp>
---
test/crypto|3 +--
test/multipart | 12
2 files changed, 5 insertions(+), 10 deletions(-)
diff --git a/test/crypto b/test/crypto
index 8e92016..796c4ca 100755
--- a/test/crypto
+++ b/test/crypto
@@ -168,8 +168,7 @@ Non-text part: application/pgp-encrypted
part{ ID: 4,
Before the change, notmuch show output had filename only for
parts with "Content-Disposition: attachment". But parts with
inline disposition may have filename as well.
The patch makes notmuch show always output filename if available,
independent of Content-Disposition. Both JSON and text output
On Sat, 28 May 2011 14:51:35 -0700, Jameson Graef Rollins
wrote:
> So what follows is a patch series for a bunch of miscellaneous patches
> that should be included in 0.6. Most of them were originally part of
> the release-candiate/0.6 branch, and they are here rebased on top of
> notmuch/master
ture
Size: 835 bytes
Desc: not available
URL:
<http://notmuchmail.org/pipermail/notmuch/attachments/20110528/5b65612c/attachment-0001.pgp>
Again, this is a much cleaner and more thorough test, and in fact
exposes a bug in the format=text output, that will be fixed the next
commit. Because of this, some of the multipart tests currently fail.
---
test/multipart | 189
1 files c
This is a much cleaner way to do the emacs tests, since we're actually
comparing output against existing files with expected output. We also
won't miss any trailing newlines this way.
And speaking of which, one of the expected output files was actually
missing a trailing blank line that was actua
The declaration of the GMimeStream pointer to stdout in
format_part_content_text was somehow preventing subsequent printf
calls from outputting to stdout if the output was redirected to a
file. Scoping the declaration to the actual use of the stream pointer
works around this problem.
---
notmuch-
From: Dmitry Kurochkin
For message-fetch-field the buffer is expected to be narrowed to
just the header of the message. That is not the case when
notmuch-fcc-header-setup is run, hence a wrong header value may be
returned. E.g. when forwarding an
email, (message-fetch-field "From") returns the
From: Austin Clements
Previously, the test assumed the generated message would be assigned a
specific thread ID; now it doesn't. Also, spelling fix.
Signed-off-by: Jameson Graef Rollins
---
test/search-output |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/test/s
From: Anton Khirnov
Signed-off-by: Jameson Graef Rollins
---
lib/message-file.c |5 +
1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/lib/message-file.c b/lib/message-file.c
index 7722832..99505c1 100644
--- a/lib/message-file.c
+++ b/lib/message-file.c
@@ -341,12 +341,17
From: Daniel Kahn Gillmor
Signed-off-by: Jameson Graef Rollins
---
notmuch-search.c |3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/notmuch-search.c b/notmuch-search.c
index 530cecc..616fe68 100644
--- a/notmuch-search.c
+++ b/notmuch-search.c
@@ -116,6 +116,9 @@ sani
From: Thomas Jost
Most of the time, every entry in the list of identities has the same user name
part. It can then be filled in automatically, and the user can only be prompted
for the email address, which makes the interface much cleaner.
---
emacs/notmuch-mua.el | 33 +++-
This is a pretty important fix to this test, so that it can be used to
test against existing files, without deleting them in the case of test
failure.
---
test/test-lib.sh |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/test/test-lib.sh b/test/test-lib.sh
index 6a8cb98.
From: Thomas Jost
When replying, the From: address is already filled in by notmuch reply, so most
of the time there is no need to prompt the user for it.
---
emacs/notmuch-mua.el |7 +--
1 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/emacs/notmuch-mua.el b/emacs/notmuch-m
This makes the button cleaner, so that it doesn't include the entire
rest of the line that the button is on.
---
emacs/notmuch-show.el | 29 +
1 files changed, 17 insertions(+), 12 deletions(-)
diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
index 6c498ab.
From: Andreas Amann
When a Subject field contained encoded CRLF sequences, these sequences
would appear unfiltered in the output of notmuch search. This confused
the notmuch emacs interface leading to "Unexpected Output"
messages. This is now fixed by replacing all characters with ASCII
code less
From: Pieter Praet
(describe-face 'message-cited-text-face)
> message-cited-text-face is an alias for the face `message-cited-text'.
> This face is obsolete since 22.1; use `message-cited-text' instead.
Signed-off-by: Pieter Praet
Signed-off-by: Jameson Graef Rollins
---
emacs/notmuch-wash.el
These test now properly test for the presence of a newline at the end
of all output. Right now some of these test will fail because the
search output is currently broken to *not* produce proper newlines in
some cases.
---
test/search-output | 72 ++---
A previous commit to fix json formatting for null results
(0b1ddc5f6652bde99d63d9d553777b3d926694cf) accidentally introduced a
regression that removed trailing newlines for non-json output. (There
wasn't a good test for this previously, but there is now). The
problem is due to the fundamental dif
The test in json was inferior to the one in search-output, since it
wasn't properly testing for the presence of a trailing newline.
---
test/json |4
test/search-output |4 +---
2 files changed, 1 insertions(+), 7 deletions(-)
diff --git a/test/json b/test/json
index 0badb1d
From: Florian Friesdorf
Signed-off-by: Jameson Graef Rollins
---
test/search-output |9 +
1 files changed, 9 insertions(+), 0 deletions(-)
diff --git a/test/search-output b/test/search-output
index 13f9613..8edc26a 100755
--- a/test/search-output
+++ b/test/search-output
@@ -304,6
The configure script tries to check that the libdir is included in the
ldconfig paths, and then sets the RPATH compiler flag if it's not.
This check was broken, and was always setting RPATH. This fixes the
path check.
---
configure |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
From: Dmitry Kurochkin
In notmuch 0.5 notmuch-fcc-dirs style changed. The previous code
did not correctly identify an old configuration and, as a
consequence, broke new configurations.
The fix was extracted from a bigger patch series by David
Edmondson id:"1290682750-30283-2-git-send-email-...@
From: Thomas Jost
Signed-off-by: Jameson Graef Rollins
jrollins modified this patch to conform to recent changes in the
crypto processing since this patch was originally sent in.
---
emacs/notmuch-crypto.el | 42 --
1 files changed, 32 insertions(+), 1
From: Florian Friesdorf
My first patch send to the list, not sure whether done properly.
In the master branch in test/emacs two tests access the build users home
directory, so does emacs_deliver_message in the crypto branch.
I think the tests should not touch the build user's home directory. Th
Signed-off-by: Jameson Graef Rollins
---
test/search-output | 20 ++--
1 files changed, 10 insertions(+), 10 deletions(-)
diff --git a/test/search-output b/test/search-output
index 8edc26a..02cf602 100755
--- a/test/search-output
+++ b/test/search-output
@@ -4,7 +4,7 @@ test_de
This test doesn't have anything to do with json, and has everything to
do with testing search capability, so I'm not sure why it was in the
wrong place.
---
test/json |5 -
test/search |6 ++
2 files changed, 6 insertions(+), 5 deletions(-)
diff --git a/test/json b/test/json
ind
These tests also use the new test_expect_equal_file test.
---
test/search|5 -
test/search-output | 12
2 files changed, 12 insertions(+), 5 deletions(-)
diff --git a/test/search b/test/search
index 0981f66..4835872 100755
--- a/test/search
+++ b/test/search
@@ -118
So what follows is a patch series for a bunch of miscellaneous patches
that should be included in 0.6. Most of them were originally part of
the release-candiate/0.6 branch, and they are here rebased on top of
notmuch/master at cb8418784c21155ffea79cce8409a7ea3c546937, which
includes all the multip
---
RELEASING | 22 ++
1 files changed, 18 insertions(+), 4 deletions(-)
diff --git a/RELEASING b/RELEASING
index a392d81..475100a 100644
--- a/RELEASING
+++ b/RELEASING
@@ -35,7 +35,21 @@ repository. From here, there are just a few steps to release:
Commit this ch
The declaration of the GMimeStream pointer to stdout in
format_part_content_text was somehow preventing subsequent printf
calls from outputting to stdout if the output was redirected to a
file. Scoping the declaration to the actual use of the stream pointer
works around this problem.
---
notmuch-
Again, this is a much cleaner and more thorough test, and in fact
exposes a bug in the format=text output, that will be fixed the next
commit. Because of this, some of the multipart tests currently fail.
---
test/multipart | 189
1 files c
This is a much cleaner way to do the emacs tests, since we're actually
comparing output against existing files with expected output. We also
won't miss any trailing newlines this way.
And speaking of which, one of the expected output files was actually
missing a trailing blank line that was actua
This is a pretty important fix to this test, so that it can be used to
test against existing files, without deleting them in the case of test
failure.
---
test/test-lib.sh |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/test/test-lib.sh b/test/test-lib.sh
index 6a8cb98.
From: Thomas Jost
Most of the time, every entry in the list of identities has the same user name
part. It can then be filled in automatically, and the user can only be prompted
for the email address, which makes the interface much cleaner.
---
emacs/notmuch-mua.el | 33 +++-
From: Thomas Jost
When replying, the From: address is already filled in by notmuch reply, so most
of the time there is no need to prompt the user for it.
---
emacs/notmuch-mua.el |7 +--
1 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/emacs/notmuch-mua.el b/emacs/notmuch-m
This makes the button cleaner, so that it doesn't include the entire
rest of the line that the button is on.
---
emacs/notmuch-show.el | 29 +
1 files changed, 17 insertions(+), 12 deletions(-)
diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
index 6c498ab.
From: Austin Clements
Previously, the test assumed the generated message would be assigned a
specific thread ID; now it doesn't. Also, spelling fix.
Signed-off-by: Jameson Graef Rollins
---
test/search-output |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/test/s
From: Daniel Kahn Gillmor
Signed-off-by: Jameson Graef Rollins
---
notmuch-search.c |3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/notmuch-search.c b/notmuch-search.c
index 530cecc..616fe68 100644
--- a/notmuch-search.c
+++ b/notmuch-search.c
@@ -116,6 +116,9 @@ sani
From: Anton Khirnov
Signed-off-by: Jameson Graef Rollins
---
lib/message-file.c |5 +
1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/lib/message-file.c b/lib/message-file.c
index 7722832..99505c1 100644
--- a/lib/message-file.c
+++ b/lib/message-file.c
@@ -341,12 +341,17
From: Dmitry Kurochkin
For message-fetch-field the buffer is expected to be narrowed to
just the header of the message. That is not the case when
notmuch-fcc-header-setup is run, hence a wrong header value may be
returned. E.g. when forwarding an
email, (message-fetch-field "From") returns the
From: Dmitry Kurochkin
In notmuch 0.5 notmuch-fcc-dirs style changed. The previous code
did not correctly identify an old configuration and, as a
consequence, broke new configurations.
The fix was extracted from a bigger patch series by David
Edmondson id:"1290682750-30283-2-git-send-email-dme
From: Pieter Praet
(describe-face 'message-cited-text-face)
> message-cited-text-face is an alias for the face `message-cited-text'.
> This face is obsolete since 22.1; use `message-cited-text' instead.
Signed-off-by: Pieter Praet
Signed-off-by: Jameson Graef Rollins
---
emacs/notmuch-wash.el
Signed-off-by: Jameson Graef Rollins
---
test/search-output | 20 ++--
1 files changed, 10 insertions(+), 10 deletions(-)
diff --git a/test/search-output b/test/search-output
index 8edc26a..02cf602 100755
--- a/test/search-output
+++ b/test/search-output
@@ -4,7 +4,7 @@ test_de
From: Florian Friesdorf
Signed-off-by: Jameson Graef Rollins
---
test/search-output |9 +
1 files changed, 9 insertions(+), 0 deletions(-)
diff --git a/test/search-output b/test/search-output
index 13f9613..8edc26a 100755
--- a/test/search-output
+++ b/test/search-output
@@ -304,6
From: Andreas Amann
When a Subject field contained encoded CRLF sequences, these sequences
would appear unfiltered in the output of notmuch search. This confused
the notmuch emacs interface leading to "Unexpected Output"
messages. This is now fixed by replacing all characters with ASCII
code less
From: Thomas Jost
Signed-off-by: Jameson Graef Rollins
jrollins modified this patch to conform to recent changes in the
crypto processing since this patch was originally sent in.
---
emacs/notmuch-crypto.el | 42 --
1 files changed, 32 insertions(+), 1
From: Florian Friesdorf
My first patch send to the list, not sure whether done properly.
In the master branch in test/emacs two tests access the build users home
directory, so does emacs_deliver_message in the crypto branch.
I think the tests should not touch the build user's home directory. Th
The test in json was inferior to the one in search-output, since it
wasn't properly testing for the presence of a trailing newline.
---
test/json |4
test/search-output |4 +---
2 files changed, 1 insertions(+), 7 deletions(-)
diff --git a/test/json b/test/json
index 0badb1d
This test doesn't have anything to do with json, and has everything to
do with testing search capability, so I'm not sure why it was in the
wrong place.
---
test/json |5 -
test/search |6 ++
2 files changed, 6 insertions(+), 5 deletions(-)
diff --git a/test/json b/test/json
ind
A previous commit to fix json formatting for null results
(0b1ddc5f6652bde99d63d9d553777b3d926694cf) accidentally introduced a
regression that removed trailing newlines for non-json output. (There
wasn't a good test for this previously, but there is now). The
problem is due to the fundamental dif
These tests also use the new test_expect_equal_file test.
---
test/search|5 -
test/search-output | 12
2 files changed, 12 insertions(+), 5 deletions(-)
diff --git a/test/search b/test/search
index 0981f66..4835872 100755
--- a/test/search
+++ b/test/search
@@ -118
These test now properly test for the presence of a newline at the end
of all output. Right now some of these test will fail because the
search output is currently broken to *not* produce proper newlines in
some cases.
---
test/search-output | 72 ++---
---
RELEASING | 22 ++
1 files changed, 18 insertions(+), 4 deletions(-)
diff --git a/RELEASING b/RELEASING
index a392d81..475100a 100644
--- a/RELEASING
+++ b/RELEASING
@@ -35,7 +35,21 @@ repository. From here, there are just a few steps to release:
Commit this cha
The configure script tries to check that the libdir is included in the
ldconfig paths, and then sets the RPATH compiler flag if it's not.
This check was broken, and was always setting RPATH. This fixes the
path check.
---
configure |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
So what follows is a patch series for a bunch of miscellaneous patches
that should be included in 0.6. Most of them were originally part of
the release-candiate/0.6 branch, and they are here rebased on top of
notmuch/master at cb8418784c21155ffea79cce8409a7ea3c546937, which
includes all the multip
On Fri, 27 May 2011 17:53:44 -0700, Carl Worth wrote:
> So, well done, Jameson! You've been extremely patient as I sat on this
> patch series for *so* long, and then made you rebuild it so many
> times. I hope you think the rebuilds were at least worth it for the much
> cleaner final state, (I kno
lly, and I don't actually know the answer.
Ok, so more release-candidate/0.6 patches to follow.
Thanks again for pushing all this stuff through, Carl.
jamie.
-- next part --
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 835 bytes
Desc: not available
URL:
<http://notmuchmail.org/pipermail/notmuch/attachments/20110528/406b2cc9/attachment.pgp>
binary and parse its output..
Thanks!
/p
-- next part --
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL:
<http://notmuchmail.org/pipermail/notmuch/attachments/20110528/58b4c142/attachment.pgp>
On Sat, 28 May 2011 09:37:59 -0300, David Bremner wrote:
>
> I'd like to upload current master to debian experimental. I think this
> might help with a few integration issues (libgmime in particular, and
> maybe gpg-agent).
>
> My branch is at
>
>
> http://pivot.cs.unb.ca/git/?p=notmuch.g
Thanks for the clarification. I did that, and also commented out the
lower parts of _notmuch_thread_create and this did indeed improve
the performance, but not so much as I had hoped:
In [10]: q=Database().create_query('*')
In [11]: time T=[t for t in q.search_threads()]
CPU times: user 2.43 s, sys: 0.22 s, total: 2.65 s
Wall time: 2.66 s
And I have only about 8000 mails in my index.
Making thread lookups lazy would help, but here one would still
create a lot of unused (empty) thread objects.
The easiest solution to my problem would in my opinion be
a function that queries only for thread ids without instanciating them.
But I can't think of any other use case than mine for this
so I guess many of you would be against adding this to the API?
/p
-- next part --
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL:
<http://notmuchmail.org/pipermail/notmuch/attachments/20110528/e2e2791d/attachment.pgp>
e
URL:
<http://notmuchmail.org/pipermail/notmuch/attachments/20110528/5f565950/attachment.pgp>
Hi!
I wonder how I would get all messages of a thread with the python
bindings. The doc says one can only use Thread.get_toplevel_messages()
and then must recursively call Message.get_replies().
But look:
snip -
#/usr/bin/python
from notmuch import Database
I'd like to upload current master to debian experimental. I think this
might help with a few integration issues (libgmime in particular, and
maybe gpg-agent).
My branch is at
http://pivot.cs.unb.ca/git/?p=notmuch.git;a=shortlog;h=refs/heads/proposed-0.5.5
On top of current master, this in
Size: 3431 bytes
Desc: not available
URL:
<http://notmuchmail.org/pipermail/notmuch/attachments/20110528/43978cfb/attachment-0001.patch>
Excerpts from Austin Clements's message of Fri May 27 20:29:24 +0100 2011:
> On Fri, May 27, 2011 at 2:04 PM, Patrick Totzke
> wrote:
> > Excerpts from Austin Clements's message of Fri May 27 03:41:44 +0100 2011:
> >> >> > > Have you tried simply calling list() on your thread
> >> >> > > iterator
75 matches
Mail list logo