Re: [RFC][PATCH v4] emacs: Re-implement advance/rewind functions of notmuch-show-mode.

2011-12-26 Thread David Edmondson
On Mon, 26 Dec 2011 14:24:11 -0800, Jameson Graef Rollins wrote: > On Mon, 26 Dec 2011 22:00:21 +, David Edmondson wrote: > > Understood. For me this fell inside the 'trivial other change' boundary. > > Fwiw, I don't remember there ever being such a distinction. I think > we've always insi

[PATCH v2 1/2] emacs: create patch filename from subject for inline patch fake parts

2011-12-26 Thread Jani Nikula
On Mon, 26 Dec 2011 12:38:35 -0800, Jameson Graef Rollins wrote: > On Mon, 26 Dec 2011 14:24:42 +0200, Jani Nikula wrote: > > > Clicking on the button for the part saves the wrong thing, though, > > > because it's not a real MIME part. That looks a bit awkward to fix, so > > > perhaps you could s

list of notmuch frontend

2011-12-26 Thread Antoine Amarilli
oine Amarilli -- next part -- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 198 bytes Desc: Digital signature URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20111226/ebacd852/attachment.pgp>

[PATCH v2 1/2] emacs: create patch filename from subject for inline patch fake parts

2011-12-26 Thread David Edmondson
URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20111226/bb7d9634/attachment.pgp>

[PATCH 1/3] emacs: use a single history for all searches

2011-12-26 Thread David Edmondson
`notmuch-search' than to run `notmuch' and then click on the "search" button. -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 197 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20111226/41e4f998/attachment.pgp>

[RFC][PATCH v4] emacs: Re-implement advance/rewind functions of notmuch-show-mode.

2011-12-26 Thread David Edmondson
al, I suppose) with two smaller patches than > with a single bigger one. Your git-fu is obviously much stronger than mine. :-) Rebasing (groups of) patches takes more of my time and is more error prone than I'd like. -- next part ------ A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 197 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20111226/4be94e66/attachment.pgp>

have "notmuch help" call man?

2011-12-26 Thread David Bremner
re Size: 315 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20111226/4266bec4/attachment.pgp>

[PATCH] NEWS: emacs: notmuch-poll-script and saved search news items

2011-12-26 Thread Jani Nikula
--- NEWS | 16 1 files changed, 16 insertions(+), 0 deletions(-) diff --git a/NEWS b/NEWS index eaed960..0d88258 100644 --- a/NEWS +++ b/NEWS @@ -11,6 +11,22 @@ Hooks supports "pre-new" and "post-new" hooks that are run before and after importing new messages into the dat

Re: have "notmuch help" call man?

2011-12-26 Thread David Bremner
On Wed, 21 Dec 2011 20:53:08 -0800, Jameson Graef Rollins wrote: > I think what you've done looks great. A couple small issues: > > * There are a couple of formatting issues (notmuch.1, notmuch-config.1, > notmuch-reply.1). Hopefully I caught most of the formatting issues. > > * The notmu

[PATCH] NEWS: emacs: notmuch-poll-script and saved search news items

2011-12-26 Thread David Bremner
On Mon, 26 Dec 2011 16:38:59 +0200, Jani Nikula wrote: > --- > NEWS | 16 > 1 files changed, 16 insertions(+), 0 deletions(-) > Pushed to git://git.notmuchmail.org/git/notmuch release and pivot.cs.unb.ca:pub/git news

[RFC][PATCH v4] emacs: Re-implement advance/rewind functions of notmuch-show-mode.

2011-12-26 Thread Dmitry Kurochkin
Hi David. On Mon, 26 Dec 2011 10:46:13 +, David Edmondson wrote: > On Fri, 23 Dec 2011 23:01:33 +0400, Dmitry Kurochkin gmail.com> wrote: > > * Revert changes to notmuch-show-advance-and-archive. > > Why? (I mean, because the change is poor or just that it's unrelated or > because I didn't

[PATCH 1/3] emacs: use a single history for all searches

2011-12-26 Thread Dmitry Kurochkin
On Mon, 26 Dec 2011 10:58:02 +, David Edmondson wrote: > On Sat, 24 Dec 2011 22:32:27 +0400, Dmitry Kurochkin gmail.com> wrote: > > I got some positive feedback for replacing notmuch-hello search input > > with a button wich would call `notmuch-search' and read input from > > minibuffer as us

Re: [PATCH 1/3] emacs: use a single history for all searches

2011-12-26 Thread Jameson Graef Rollins
On Mon, 26 Dec 2011 22:02:55 +, David Edmondson wrote: > It's also simpler to have a global keybinding for `notmuch-search' than > to run `notmuch' and then click on the "search" button. We actually have that everywhere else *but* notmuch-hello; notmuch-hello is actually the odd man out in th

[PATCH 1/3] emacs: use a single history for all searches

2011-12-26 Thread Jameson Graef Rollins
scrubbed... Name: not available Type: application/pgp-signature Size: 835 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20111226/05115939/attachment.pgp>

[PATCH v2 1/2] emacs: create patch filename from subject for inline patch fake parts

2011-12-26 Thread Jani Nikula
On Mon, 26 Dec 2011 12:06:02 +, David Edmondson wrote: > On Mon, 26 Dec 2011 00:00:05 +0200, Jani Nikula wrote: > > +(defun notmuch-wash-subject-to-patch-filename (subject) > > + "Convert a patch mail SUBJECT into a filename. > > + > > +The resulting filename is similar to the names generate

Re: [RFC][PATCH v4] emacs: Re-implement advance/rewind functions of notmuch-show-mode.

2011-12-26 Thread Jameson Graef Rollins
On Mon, 26 Dec 2011 22:00:21 +, David Edmondson wrote: > Understood. For me this fell inside the 'trivial other change' boundary. Fwiw, I don't remember there ever being such a distinction. I think we've always insisted that unrelated changes should be excluded. As a general rule, I think a

[RFC][PATCH v4] emacs: Re-implement advance/rewind functions of notmuch-show-mode.

2011-12-26 Thread Jameson Graef Rollins
ruction is definitely cleaner. jamie. -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 835 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20111226/374961f1/attachment-0001.pgp>

Re: list of notmuch frontend

2011-12-26 Thread Antoine Amarilli
On Sun, Dec 18, 2011 at 06:10:13PM +0200, Tomi Ollila wrote: > On Sun, 18 Dec 2011 15:34:23 +0100, Olivier Schwander > wrote: > > Is there a somewhere a list of the various notmuch frontend ? It would > > be very valuable for people who are not completly happy with the main > > emacs frontend. >

Re: [PATCH v2 1/2] emacs: create patch filename from subject for inline patch fake parts

2011-12-26 Thread David Edmondson
On Mon, 26 Dec 2011 23:52:23 +0200, Jani Nikula wrote: > Below is an idea I came up with, utilizing the content-type > vs. declared-type distinction. I think it's really simple and neat, > but I hope not too magical. > > Picking up an example mail from the list, inline patches would show up > lik

Re: [PATCH 1/3] emacs: use a single history for all searches

2011-12-26 Thread David Edmondson
On Mon, 26 Dec 2011 15:02:14 +0400, Dmitry Kurochkin wrote: > On Mon, 26 Dec 2011 10:58:02 +, David Edmondson wrote: > > On Sat, 24 Dec 2011 22:32:27 +0400, Dmitry Kurochkin > > wrote: > > > I got some positive feedback for replacing notmuch-hello search input > > > with a button wich woul

Re: [RFC][PATCH v4] emacs: Re-implement advance/rewind functions of notmuch-show-mode.

2011-12-26 Thread David Edmondson
On Mon, 26 Dec 2011 15:09:55 +0400, Dmitry Kurochkin wrote: > Hi David. > > On Mon, 26 Dec 2011 10:46:13 +, David Edmondson wrote: > > On Fri, 23 Dec 2011 23:01:33 +0400, Dmitry Kurochkin > > wrote: > > > * Revert changes to notmuch-show-advance-and-archive. > > > > Why? (I mean, because

Re: [PATCH v2 1/2] emacs: create patch filename from subject for inline patch fake parts

2011-12-26 Thread Jani Nikula
On Mon, 26 Dec 2011 12:38:35 -0800, Jameson Graef Rollins wrote: > On Mon, 26 Dec 2011 14:24:42 +0200, Jani Nikula wrote: > > > Clicking on the button for the part saves the wrong thing, though, > > > because it's not a real MIME part. That looks a bit awkward to fix, so > > > perhaps you could

Re: [PATCH v2 1/2] emacs: create patch filename from subject for inline patch fake parts

2011-12-26 Thread Jameson Graef Rollins
On Mon, 26 Dec 2011 14:24:42 +0200, Jani Nikula wrote: > > Clicking on the button for the part saves the wrong thing, though, > > because it's not a real MIME part. That looks a bit awkward to fix, so > > perhaps you could still prefix the name with "inline: " to indicate that > > it's odd? > > I

[PATCH v2 1/2] emacs: create patch filename from subject for inline patch fake parts

2011-12-26 Thread Jameson Graef Rollins
to behave as expected. jamie. -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 835 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20111226/de0627d1/attachment.pgp>

[PATCH v2 1/2] emacs: create patch filename from subject for inline patch fake parts

2011-12-26 Thread David Edmondson
bed... Name: not available Type: application/pgp-signature Size: 197 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20111226/d30f7c14/attachment.pgp>

Re: [PATCH] NEWS: emacs: notmuch-poll-script and saved search news items

2011-12-26 Thread David Bremner
On Mon, 26 Dec 2011 16:38:59 +0200, Jani Nikula wrote: > --- > NEWS | 16 > 1 files changed, 16 insertions(+), 0 deletions(-) > Pushed to git://git.notmuchmail.org/git/notmuch release and pivot.cs.unb.ca:pub/git news

[PATCH] notmuch: Quiet buildbot warnings.

2011-12-26 Thread David Edmondson
errors? -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 197 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20111226/0a3369b3/attachment.pgp>

[PATCH 1/3] emacs: use a single history for all searches

2011-12-26 Thread David Edmondson
application/pgp-signature Size: 197 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20111226/fc3a6a4f/attachment.pgp>

[RFC][PATCH v4] emacs: Re-implement advance/rewind functions of notmuch-show-mode.

2011-12-26 Thread David Edmondson
c - just wonder which is more useful behaviour. -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 197 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20111226/f773610f/attachment.pgp>

[RFC][PATCH v4] emacs: Re-implement advance/rewind functions of notmuch-show-mode.

2011-12-26 Thread David Edmondson
l behaviour? -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 197 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20111226/38861c7c/attachment.pgp>

[RFC][PATCH v4] emacs: Re-implement advance/rewind functions of notmuch-show-mode.

2011-12-26 Thread David Edmondson
/notmuchmail.org/pipermail/notmuch/attachments/20111226/a74e36ef/attachment.pgp>

[PATCH v3 1/4] emacs: Let the user choose where to compose new mails

2011-12-26 Thread David Bremner
did you have this problem with? 23.3.1 -- next part -- A non-text attachment was scrubbed... Name: 50notmuch.el Type: application/emacs-lisp Size: 1274 bytes Desc: site startup for notmuch. URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20111226/0308f83a/attachment.bin>

[PATCH] NEWS: emacs: notmuch-poll-script and saved search news items

2011-12-26 Thread Jani Nikula
--- NEWS | 16 1 files changed, 16 insertions(+), 0 deletions(-) diff --git a/NEWS b/NEWS index eaed960..0d88258 100644 --- a/NEWS +++ b/NEWS @@ -11,6 +11,22 @@ Hooks supports "pre-new" and "post-new" hooks that are run before and after importing new messages into the dat

Re: [PATCH v2 1/2] emacs: create patch filename from subject for inline patch fake parts

2011-12-26 Thread Jani Nikula
On Mon, 26 Dec 2011 12:06:02 +, David Edmondson wrote: > On Mon, 26 Dec 2011 00:00:05 +0200, Jani Nikula wrote: > > +(defun notmuch-wash-subject-to-patch-filename (subject) > > + "Convert a patch mail SUBJECT into a filename. > > + > > +The resulting filename is similar to the names generate

Re: [PATCH v2 1/2] emacs: create patch filename from subject for inline patch fake parts

2011-12-26 Thread David Edmondson
On Mon, 26 Dec 2011 00:00:05 +0200, Jani Nikula wrote: > +(defun notmuch-wash-subject-to-patch-filename (subject) > + "Convert a patch mail SUBJECT into a filename. > + > +The resulting filename is similar to the names generated by \"git > +format-patch\". If the patch mail was generated and sent

[PATCH 3/4] Utility function to seek in MIME trees in depth-first order.

2011-12-26 Thread Dmitry Kurochkin
On Fri, 23 Dec 2011 22:46:19 -0500, Austin Clements wrote: > Quoth Dmitry Kurochkin on Dec 10 at 3:43 pm: > > On Fri, 9 Dec 2011 14:54:27 -0500, Austin Clements > > wrote: > > > This function matches how we number parts for the --part argument to > > > show. It will allow us to jump directly

Re: [PATCH v3 1/4] emacs: Let the user choose where to compose new mails

2011-12-26 Thread David Bremner
On Sun, 25 Dec 2011 23:54:41 -0500, Aaron Ecay wrote: > I just tried, and I cannot reproduce this behavior. IIUC, here is what > happened to you: you set nm-mua-compose-in to 'new-window. You began a > new message, this opened a new window as expected. Your emacs frame now > has two windows in

[PATCH v5 0/4] First step of 'show' rewrite

2011-12-26 Thread Dmitry Kurochkin
All looks good to me. Let's push it. I have some minor comments, but they are all more of a style preference (e.g. sig_validity vs signature_validity, using conditional operator (x ? y : z) where possible). Regards, Dmitry

Re: [RFC][PATCH v4] emacs: Re-implement advance/rewind functions of notmuch-show-mode.

2011-12-26 Thread Dmitry Kurochkin
Hi David. On Mon, 26 Dec 2011 10:46:13 +, David Edmondson wrote: > On Fri, 23 Dec 2011 23:01:33 +0400, Dmitry Kurochkin > wrote: > > * Revert changes to notmuch-show-advance-and-archive. > > Why? (I mean, because the change is poor or just that it's unrelated or > because I didn't mention

Re: [PATCH 1/3] emacs: use a single history for all searches

2011-12-26 Thread Dmitry Kurochkin
On Mon, 26 Dec 2011 10:58:02 +, David Edmondson wrote: > On Sat, 24 Dec 2011 22:32:27 +0400, Dmitry Kurochkin > wrote: > > I got some positive feedback for replacing notmuch-hello search input > > with a button wich would call `notmuch-search' and read input from > > minibuffer as usual. Th

Re: [PATCH] notmuch: Quiet buildbot warnings.

2011-12-26 Thread David Edmondson
On Sat, 24 Dec 2011 12:55:57 -0700, Tom Prince wrote: > On Wed, 21 Dec 2011 23:06:50 +0100, Thomas Jost wrote: > Non-text part: multipart/mixed > Non-text part: multipart/signed > > On Tue, 20 Dec 2011 15:20:04 +, David Edmondson wrote: > > > Cast away the result of various *write functions.

Re: [PATCH 1/3] emacs: use a single history for all searches

2011-12-26 Thread David Edmondson
On Sat, 24 Dec 2011 22:32:27 +0400, Dmitry Kurochkin wrote: > I got some positive feedback for replacing notmuch-hello search input > with a button wich would call `notmuch-search' and read input from > minibuffer as usual. This way we do not have to maintain 2 search > interfaces and get histor

Re: [RFC][PATCH v4] emacs: Re-implement advance/rewind functions of notmuch-show-mode.

2011-12-26 Thread David Edmondson
On Sun, 25 Dec 2011 23:11:27 -0500, Aaron Ecay wrote: > > > + ((> (let ((visible-bottom (notmuch-show-message-bottom))) > > > + (while (invisible-p visible-bottom) > > > +(setq visible-bottom (max (point-min) > > > + (1- (previous-single-char-property-change > >

Re: [RFC][PATCH v4] emacs: Re-implement advance/rewind functions of notmuch-show-mode.

2011-12-26 Thread David Edmondson
On Sat, 24 Dec 2011 20:06:35 -0500, Austin Clements wrote: > Awesome. This looks significantly cleaner. I think this is worth > pushing for the comment you added to notmuch-show-advance alone. Thanks. > This definitely changes the behavior of rewind, but other than one > case I point out below

Re: [RFC][PATCH v4] emacs: Re-implement advance/rewind functions of notmuch-show-mode.

2011-12-26 Thread David Edmondson
On Fri, 23 Dec 2011 23:01:33 +0400, Dmitry Kurochkin wrote: > * Revert changes to notmuch-show-advance-and-archive. Why? (I mean, because the change is poor or just that it's unrelated or because I didn't mention it) > * Can we split this in two patches? One for rewind and another for > adva

[PATCH v2 2/2] test: emacs: test notmuch-wash-subject-to-* functions

2011-12-26 Thread Jani Nikula
Signed-off-by: Jani Nikula --- test/emacs-subject-to-filename | 138 test/notmuch-test |1 + 2 files changed, 139 insertions(+), 0 deletions(-) create mode 100755 test/emacs-subject-to-filename diff --git a/test/emacs-subject-to-filenam

[PATCH v2 1/2] emacs: create patch filename from subject for inline patch fake parts

2011-12-26 Thread Jani Nikula
Use the mail subject line for creating a descriptive filename for the wash generated inline patch fake parts. The names are similar to the ones created by 'git format-patch'. If the user has notmuch-wash-convert-inline-patch-to-part hook enabled in notmuch-show-insert-text/plain-hook, this will ch

[PATCH v2 0/2] emacs: patch filename from subject

2011-12-26 Thread Jani Nikula
Hi all, v2 with the following changes: * split the conversion function into three * figure out patch sequence number from the [PATCH N/M] style prefixes * write a bunch of tests for the functions * update the regexps according to bugs found in tests :) BR, Jani. Jani Nikula (2): emacs: create