From: Kazuo Teramoto
As reported in
id:"CAEbOPGyuHnz4BPtDutnTPUHcP3eYcRCRkXhYoJR43RUMw671+g at mail.gmail.com"
sometimes gmime tries to access a NULL pointer, e.g. g_mime_iconv_open()
tries to access iconv_cache that is NULL if g_mime_init() is not called.
This causes notmuch to segfault when cal
From: David Bremner
One is quoted printable, the other users 8 bit encoding. The latter
triggers a bug in the python bindings due to missing call to
g_mime_init. The corresponding test is marked broken in this commit.
---
test/corpus/cur/52:2, | 39
From: David Bremner
This seems a bit easier to maintain, and is more accurate since lines
are not joined together.
---
test/search | 11 +++
1 files changed, 7 insertions(+), 4 deletions(-)
diff --git a/test/search b/test/search
index e7c8c54..4710d57 100755
--- a/test/search
+++ b/te
It turns out that our existing (trivial) python test is enough to
catch this bug, but the corpus needs to be augmented. This
augmentation is a bit intrusive so I'm thinking of cherry-picking only
the actual fix to the release branch.
Unfortunately the test message is 8 bit, so it may be encoded i
On Fri, 30 Dec 2011 13:50:49 -0500, Austin Clements wrote:
> The C side looks good to me (with the updated commit message). I
> can't speak for the nroff side.
I have pushed this series. We may have to tidy up a few things in the
man pages as people find them. Most of the text is identical to th
On Fri, 30 Dec 2011 10:28:17 +, David Edmondson wrote:
> Add various functions to print notmuch messages and tie them together
> with a simple frontend. No keybinding is currently made to encourage
> paper saving.
Hi David.
I started playing with this a bit.
print using muttprint doesn't se
On Fri, 30 Dec 2011 18:12:45 +0200, Tomi Ollila wrote:
> Tester may have set LD_LIBRARY_PATH to find libraries required
> by notmuch. Therefore add $TEST_DIRECTORY/../lib to the beginning
> of current list of library paths in $LD_LIBRARY_PATH before running
> symbol-test.
Hmm. People should just
On Fri, 30 Dec 2011 10:43:37 -0400, David Bremner wrote:
> On Fri, 30 Dec 2011 10:44:28 +, David Edmondson wrote:
> > On Sun, 25 Dec 2011 08:14:52 +0400, Dmitry Kurochkin > gmail.com>
> > Were there actual complaints about the usability of the current
> > approach?
> >
> > I much preferred
not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL:
<http://notmuchmail.org/pipermail/notmuch/attachments/20111231/e9a0bf0c/attachment.pgp>
On Sat, 31 Dec 2011 14:42:47 +0200, Jani Nikula wrote:
> Would it be a suitable compromise to bind 's' to notmuch-search (the
> mini-buffer search) also in notmuch-hello, while leaving the search box
> there with a common history?
That would be fine for me. But other people might find it weird I
On Sat, 31 Dec 2011 14:42:47 +0200, Jani Nikula wrote:
> Would it be a suitable compromise to bind 's' to notmuch-search (the
> mini-buffer search) also in notmuch-hello, while leaving the search
> box there with a common history?
>
> I'm not sure moving the point to search box needs a keybinding
On Sat, 31 Dec 2011 14:42:47 +0200, Jani Nikula wrote:
> Would it be a suitable compromise to bind 's' to notmuch-search (the
> mini-buffer search) also in notmuch-hello, while leaving the search box
> there with a common history?
That would be fine for me. But other people might find it weird I
On Fri, 30 Dec 2011 10:43:37 -0400, David Bremner wrote:
> On Fri, 30 Dec 2011 10:44:28 +, David Edmondson wrote:
> > On Sun, 25 Dec 2011 08:14:52 +0400, Dmitry Kurochkin
> >
> > Were there actual complaints about the usability of the current
> > approach?
> >
> > I much preferred your al
On 2011-12-31T00:55:59, David Bremner wrote:
>On Fri, 30 Dec 2011 19:58:09 -0200, Kazuo Teramoto
>wrote:
>> g_mime_init already check for multiple initializations.
>> ---
>> lib/index.cc |4
>> lib/message-file.c |4
>> 2 files changed, 0 insertions(+), 8 deletions(-)
>
As reported in
id:"CAEbOPGyuHnz4BPtDutnTPUHcP3eYcRCRkXhYoJR43RUMw671+g at mail.gmail.com"
sometimes gmime try to access a NULL pointer, e.g. g_mime_iconv_open()
try to access iconv_cache that is NULL if g_mime_init() is not called.
This cause notmuch to segfault when calling gmime functions.
Calli
I'm resending the PATCH 2/2 as a standalone, leaving the matter of
removing the checks for the future. I added a more detailed commit too.
This is the only patch needed to fix the segfault I reported.
Kazuo Teramoto (1):
lib: call g_mime_init() from notmuch_database_open()
lib/database.cc |
On 2011-12-30T23:16:47, Patrick Totzke wrote:
>It seeminly doesn't break things either and I'm all in favour of doing
>things right?.
And talking about doing things right, we probably need to call
g_mime_shutdown() too, one for every time we call g_mime_init(). I will
send a patch after I do some
hi!
while I cannot confirm that this patch solves the stated issue (cannot
reproduce),
It seeminly doesn't break things either and I'm all in favour of doing things
right?.
On a related note: It also doesn't fix the recent segfaults of the bindings
that occur when you try to write to a locked d
18 matches
Mail list logo
