On Tue, 31 Jan 2012 16:23:32 +, David Edmondson wrote:
> On Tue, 31 Jan 2012 16:15:11 +, Mark Walters gmail.com> wrote:
> > Hi I have reviewed the patch series within the limits of my lisp
> > knowledge. Patch 1: is rather beyond my lisp so I won't comment on that
> > (and I have never t
Before the change, test_expect_equal_file() function treated the first
argument as "actual output file" and the second argument as "expected
output file". When the test fails, the files are copied for later
inspection. The first files was copied to "$testname.output" and the
second file to "$test
Modify the show view key bindings as follows to make them more
consistent:
'a' = Archive current message, then move to next message, or show next
thread from search if at the last message in thread.
'A' = Archive each message in thread, then show next thread from
search.
'x' = Archive current me
From: Aaron Ecay
Emacs message-mode uses certain text strings to indicate how to attach
files to outgoing mail. If these are present in the text of an email,
and a user is tricked into replying to the message, the user’s files
could be exposed.
---
NEWS | 12
emac
From: Aaron Ecay
The test is broken at this time; the next commit will introduce a fix.
---
test/emacs| 12
test/emacs.expected-output/quote-mml-in-reply |7 +++
2 files changed, 19 insertions(+), 0 deletions(-)
create mode 100644 test/
Hi Aaron.
Thanks for your work! I took the liberty to do some cleanups for your
patch. Below is a detailed list of changes.
Hope this helps.
Changes since v2:
* change patch names to be consistent with others:
- s/emacs:/test:/ for the test patch
- lower case the first word after colon
A new configuration key 'new.ignore' is used to determine which
files and directories user wants not to be scanned as new mails.
This work merges my previous attempts and Andreas Amann's work
in id:"ylp7hi23mw8.fsf at tyndall.ie"
See notes in id:"20120131-new-
Proposal for show view a/A/x/X key bindings, according to
http://titanpad.com/SA39EbNezU and IRC discussion:
'a' = Archive current message, then move to next message, or show next
thread from search if at the last message in thread.
'A' = Archive each message in thread, then show next thread from
h.
Nothing precludes the implementation of what you describe. It's not hard
to see how the two approaches could live side by side.
-- next part --
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL:
<http://notmuchmail.org/pipermail/notmuch/attachments/20120131/534682e2/attachment.pgp>
local variable `indenting' needed because
> notmuch-show-indent-content is buffer local and this is in the
> with-temp-buffer?
Yes.
-- next part --
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL:
<http://notmuchmail.org/pipermail/notmuch/attachments/20120131/5c670fdf/attachment.pgp>
Hi I have reviewed the patch series within the limits of my lisp
knowledge. Patch 1: is rather beyond my lisp so I won't comment on that
(and I have never tried crypto): Patches 2-5 look fine with one
bikeshed and one query for my own understanding.
The bikeshed is that I agree with Jani in
id:"
On Tue, 31 Jan 2012 16:23:32 +, David Edmondson wrote:
> On Tue, 31 Jan 2012 16:15:11 +, Mark Walters
> wrote:
> > Hi I have reviewed the patch series within the limits of my lisp
> > knowledge. Patch 1: is rather beyond my lisp so I won't comment on that
> > (and I have never tried cry
On Mon, 30 Jan 2012 16:52:20 +, David Edmondson wrote:
> The blank line doesn't really change position, but is now considered
> to be part of the body rather than part of the headers. This means
> that it is visible when the body is visible rather than when the
> headers are visible.
> ---
>
vement.
-- next part --
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL:
<http://notmuchmail.org/pipermail/notmuch/attachments/20120131/9b1f6938/attachment.pgp>
On Tue, 31 Jan 2012 19:29:06 +0200, Jani Nikula wrote:
> Modify the show view key bindings as follows to make them more
> consistent:
>
> 'a' = Archive current message, then move to next message, or show next
> thread from search if at the last message in thread.
>
> 'A' = Archive each message i
On Thu, 26 Jan 2012 23:58:51 +0200, Jani Nikula wrote:
> On Thu, 26 Jan 2012 14:41:46 -0500, Austin Clements
> wrote:
> > Quoth Jani Nikula on Jan 26 at 9:21 pm:
> > > +("flagged" :foreground "red"))
> >
> > Red is pretty universally used to indicate danger or a
On Tue, 31 Jan 2012 10:32:12 +, David Edmondson wrote:
> On Mon, 30 Jan 2012 21:25:19 -0800, Jameson Graef Rollins finestructure.net> wrote:
> > On Mon, 30 Jan 2012 16:52:20 +, David Edmondson wrote:
> > > The blank line doesn't really change position, but is now considered
> > > to be p
On Tue, 31 Jan 2012 10:30:20 +, David Edmondson wrote:
> On Tue, 31 Jan 2012 11:25:36 +0200, Tomi Ollila wrote:
> > I like David's alternative suggestion (in IRC) where cursor is left at
> > the end of buffer in case last message is archived with 'a'.
>
> Unless the cursor is already at the
On Tue, 31 Jan 2012 10:43:10 +0200, Tomi Ollila wrote:
> On Tue, 31 Jan 2012 08:01:53 +, David Edmondson wrote:
> > When archiving the last message in a thread (a), rather than just
> > moving the pointer to the next thread in the parent search buffer,
> > actually display the next thread.
>
On Tue, 31 Jan 2012 08:36:27 +, David Edmondson wrote:
> On Tue, 31 Jan 2012 12:24:27 +0400, Dmitry Kurochkin gmail.com> wrote:
> > This is why I like big diff contexts...
>
> Can I set that in my .gitconfig?
Unfortunately, I did not find a way to do that, except for adding an
alias. But t
On Mon, 30 Jan 2012 23:56:24 -0500, Austin Clements wrote:
> Quoth Mark Walters on Jan 29 at 6:39 pm:
> > This adds the excludes to notmuch-show.c. We do not exclude when only
> > a single message (or part) is requested. notmuch-show will output the
> > exclude information when either text or jso
On Tue, 31 Jan 2012 08:22:20 +, David Edmondson wrote:
> On Tue, 31 Jan 2012 12:12:50 +0400, Dmitry Kurochkin gmail.com> wrote:
> > On Tue, 31 Jan 2012 08:01:54 +, David Edmondson wrote:
> > > When using the spacebar to scroll through a thread, hitting 'space'
> > > when the bottom of th
On Tue, 31 Jan 2012 08:01:54 +, David Edmondson wrote:
> When using the spacebar to scroll through a thread, hitting 'space'
> when the bottom of the last message is visible should take the cursor
> to the end of the buffer rather than immediately archiving the thread
> and moving to the next
On Tue, 31 Jan 2012 08:01:53 +, David Edmondson wrote:
> When archiving the last message in a thread (a), rather than just
> moving the pointer to the next thread in the parent search buffer,
> actually display the next thread.
> ---
+1
Regards,
Dmitry
> emacs/notmuch-show.el |2 +-
>
On Mon, 30 Jan 2012 23:50:20 -0500, Austin Clements wrote:
> Quoth Mark Walters on Jan 29 at 6:39 pm:
> > Add the NOTMUCH_MESSAGE_FLAG_EXCLUDED flag to
> > notmuch_query_search_threads. Implemented by inspecting the tags
> > directly in _notmuch_thread_create/_thread_add_message rather than as
>
On Mon, 30 Jan 2012 23:43:52 -0500, Austin Clements wrote:
> Quoth Mark Walters on Jan 29 at 6:39 pm:
> > Add a flag NOTMUCH_MESSAGE_FLAG_EXCLUDED which is set by
> > notmuch_query_search_messages for excluded messages. Also add an
> > option omit_excluded_messages to the search that we do not wa
Thanks for the review. Almost all of it (for all all the patches) I
agree with and will just fix but I do have a couple of queries.
On Mon, 30 Jan 2012 23:17:32 -0500, Austin Clements wrote:
> Quoth Mark Walters on Jan 29 at 6:39 pm:
> > This option turns off the exclusion so all matching messa
On Tue, 31 Jan 2012 12:51:44 +0400, Dmitry Kurochkin wrote:
> On Tue, 31 Jan 2012 10:43:10 +0200, Tomi Ollila wrote:
> > On Tue, 31 Jan 2012 08:01:53 +, David Edmondson wrote:
> > > When archiving the last message in a thread (a), rather than just
> > > moving the pointer to the next thread
Quoth Mark Walters on Jan 31 at 11:45 am:
> On Mon, 30 Jan 2012 23:43:52 -0500, Austin Clements
> wrote:
> > Quoth Mark Walters on Jan 29 at 6:39 pm:
> > > notmuch_message_node_t *iterator;
> > > };
> > >
> > > diff --git a/lib/notmuch.h b/lib/notmuch.h
> > > index 7929fe7..740d005 10064
Quoth Mark Walters on Jan 31 at 11:40 am:
>
> Thanks for the review. Almost all of it (for all all the patches) I
> agree with and will just fix but I do have a couple of queries.
>
> On Mon, 30 Jan 2012 23:17:32 -0500, Austin Clements
> wrote:
> > Quoth Mark Walters on Jan 29 at 6:39 pm:
> >
On Tue, 31 Jan 2012 08:01:53 +, David Edmondson wrote:
> When archiving the last message in a thread (a), rather than just
> moving the pointer to the next thread in the parent search buffer,
> actually display the next thread.
> ---
-1. Magic! Rather some customization option which lets user
On Tue, 31 Jan 2012 08:01:54 +, David Edmondson wrote:
> When using the spacebar to scroll through a thread, hitting 'space'
> when the bottom of the last message is visible should take the cursor
> to the end of the buffer rather than immediately archiving the thread
> and moving to the next
idden. +1.
Any objections to changing this?
-- next part --
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL:
<http://notmuchmail.org/pipermail/notmuch/attachments/20120131/544cca85/attachment.pgp>
On Mon, 30 Jan 2012 15:35:44 -0500, Allan Wind wrote:
> The function notmuch_database_find_message_by_filename now requires a
> notmuch_message_t and returns a notmuch_status_t. This
> change was introduced with 02a3076711, LIBNOTMUCH_VERSION_MAJOR = 2,
> version 0.9.
LGTM.
Tomi
e 'next thread' dance (i.e. it behaves like 'space' in that
respect).
-- next part --
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL:
<http://notmuchmail.org/pip
Quoth Jani Nikula on Jan 31 at 3:12 pm:
> On Thu, 26 Jan 2012 23:58:51 +0200, Jani Nikula wrote:
> > On Thu, 26 Jan 2012 14:41:46 -0500, Austin Clements
> > wrote:
> > > Quoth Jani Nikula on Jan 26 at 9:21 pm:
> > > > + ("flagged" :foreground "red"))
> > >
Quoth Jani Nikula on Jan 31 at 5:03 pm:
> Proposal for show view a/A/x/X key bindings, according to
> http://titanpad.com/SA39EbNezU and IRC discussion:
>
> 'a' = Archive current message, then move to next message, or show next
> thread from search if at the last message in thread.
>
> 'A' = Arc
Modify the show view key bindings as follows to make them more
consistent:
'a' = Archive current message, then move to next message, or show next
thread from search if at the last message in thread.
'A' = Archive each message in thread, then show next thread from
search.
'x' = Archive current me
On Tue, 31 Jan 2012 08:31:26 -0800, Jameson Graef Rollins
wrote:
> On Tue, 31 Jan 2012 08:09:08 +, David Edmondson wrote:
> > On Mon, 30 Jan 2012 09:47:34 -0800, Jameson Graef Rollins
> > wrote:
> > > One thing I've noticed, which isn't actually part of this patch, is that
> > > the long-l
n/pgp-signature
Size: 197 bytes
Desc: not available
URL:
<http://notmuchmail.org/pipermail/notmuch/attachments/20120131/7783f935/attachment.pgp>
---
NEWS | 18 ++
1 files changed, 18 insertions(+), 0 deletions(-)
diff --git a/NEWS b/NEWS
index 2acdce5..7506d68 100644
--- a/NEWS
+++ b/NEWS
@@ -39,6 +39,24 @@ Reply to sender
and search modes, 'r' has been bound to reply to sender, replacing
reply to all, which now ha
This makes the argument names more consistent and clear. The
following functions changed: `notmuch-tag',
`notmuch-search-tag-thread', `notmuch-search-tag-region' and
`notmuch-search-tag-all'.
---
emacs/notmuch.el | 33 +
1 files changed, 17 insertions(+), 16 dele
Since `notmuch-tag' is a non-interactive function and hence is meant
to be invoked programmatically, it should accept zero tags. Also, the
tagging operations (bound to "*", "+", "-") would accept empty input
without an error.
---
emacs/notmuch.el | 10 +-
1 files changed, 5 insertions(+
The tag syntax check in `notmuch-tag' function was too strict and did
not allow nmbug tags with "::". Since the check is done for all
tagging operations in Emacs UI, this basically means that no nmbug
tags can be changed. The patch relaxes the tag syntax check to allow
any tag names that do not i
Some tag-related operations accept a single tag without prefix
(`notmuch-select-tag-with-completion'), others accept multiple tags
prefixed with '+' or '-' (`notmuch-read-tag-changes'). Before the
change, both functions used a single default minibuffer history. This
is inconvenient because you ha
The patch adds `notmuch-show-tag-all' function bound to "*" in
notmuch-show view. The function is similar to the
`notmuch-search-tag-all' function for the notmuch-search view: it
changes tags for all messages in the current thread.
---
emacs/notmuch-show.el | 35
`Notmuch-search-tag-all' is more clear and consistent with other
tagging function names.
---
emacs/notmuch.el |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/emacs/notmuch.el b/emacs/notmuch.el
index ce8bef6..7d06109 100644
--- a/emacs/notmuch.el
+++ b/emacs/notmuch.e
After the recent tagging operations changes, functions bound to "+"
and "-" in notmuch-search and notmuch-show views always read input
from the minibuffer. Use kbd macros instead of calling them directly.
---
test/emacs | 20 ++--
1 files changed, 10 insertions(+), 10 deletions(
Before the change, "+" and "-" tagging operations in notmuch-show view
accepted only a single tag. The patch makes them use the recently
added `notmuch-read-tag-changes' function, which allows to enter
multiple tags with "+" and "-" prefixes. So after the change, "+" and
"-" bindings in notmuch-s
Before the change, "+" and "-" tagging operations in notmuch-search
view accepted only a single tag. The patch makes them use the
recently added `notmuch-read-tag-changes' function (renamed
`notmuch-select-tags-with-completion'), which allows to enter multiple
tags with "+" and "-" prefixes. So a
---
emacs/notmuch.el |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/emacs/notmuch.el b/emacs/notmuch.el
index 84d7d0a..ff46617 100644
--- a/emacs/notmuch.el
+++ b/emacs/notmuch.el
@@ -577,7 +577,7 @@ the messages that were tagged"
(let ((beg (+ (point) 1)))
(
Before the change, tag format validation was done in
`notmuch-search-operate-all' function only. The patch moves it down
to `notmuch-tag', so that all users of that function get input
validation.
---
emacs/notmuch.el | 12 ++--
1 files changed, 6 insertions(+), 6 deletions(-)
diff --gi
Changes:
v4:
* rebased on master after Jameson's archiving changes
v3:
* merged 3 `notmuch-show-tag-all'-related patches into one
* add patch to clean up tagging function argument names
* fix other comments from Austin's reviews [5,6]
v2:
* add patch to remove "No tags given" error from `no
With an argument, record and reply the state of the buffer during
`notmuch-show-refresh-view'.
In this context, "state" is defined as:
- the open/closed state of each message,
- the current message.
Traditional use of refresh with the = key does not retain the
state. The recently introduced tog
---
emacs/notmuch-show.el |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
index 789b6d9..28f2148 100644
--- a/emacs/notmuch-show.el
+++ b/emacs/notmuch-show.el
@@ -1116,6 +1116,7 @@ Refreshes the current view, observing changes
Very deeply indented content is sometimes difficult to
read (particular for something like patches). Allow the indentation of
the content to be toggled with '<'.
Indentation of the header lines is not affected, so it remains
possible to see the structure of the thread.
---
emacs/notmuch-show.el |
The current behaviour (all messages shown, non-matching collapsed)
is retained as the default. Type '!' to switch to showing only
the matching messages - non-matching messages are not available.
'!' will switch back to showing everything.
---
emacs/notmuch-show.el | 18 +-
1 file
Re-work the existing crypto switch toggle to be based on a persistant
buffer-local variable.
To allow this, modify `notmuch-show-refresh-view' to erase and re-draw
in the current buffer rather than killing the current buffer and
creating a new one. (This will also allow more per-buffer behaviour i
v4:
- Don't retain the state for '='.
- If refreshing the view removes the previously current message from
view, leave the cursor at (point-min).
- Adjust the display after refreshing if the previously current
message is found.
David Edmondson (5):
emacs: Rework crypto switch toggle.
emacs
not available
URL:
<http://notmuchmail.org/pipermail/notmuch/attachments/20120131/d134519d/attachment.pgp>
On Tue, 31 Jan 2012 08:09:08 +, David Edmondson wrote:
> On Mon, 30 Jan 2012 09:47:34 -0800, Jameson Graef Rollins
> wrote:
> > One thing I've noticed, which isn't actually part of this patch, is that
> > the long-line truncation doesn't respect the indentation, which makes
> > things look s
On Tue, 31 Jan 2012 11:40:00 +, Mark Walters
wrote:
> The reason I went for verbose do-not-exclude was to try and avoid the
> double negative ambiguity: does no-exclude mean do-not-exclude or
> do-note-return-excluded-messages. Possibly I am worrying needlessly, and
> obviously I am quite hap
On Tue, 31 Jan 2012 01:18:55 +, Mark Walters
wrote:
> One of the mails has an in-reply-to header which looks like
>
> In-reply-to: Message from Carsten Dominik of
> "Tue, 15 Mar 2011 12:18:51 BST."
> <17242340-a14f-495a-b144-20c96d52b...@gmail.com>
!!
__
available
Type: application/pgp-signature
Size: 835 bytes
Desc: not available
URL:
<http://notmuchmail.org/pipermail/notmuch/attachments/20120131/cc9102e6/attachment-0001.pgp>
-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 835 bytes
Desc: not available
URL:
<http://notmuchmail.org/pipermail/notmuch/attachments/20120131/45079e1a/attachment-0001.pgp>
On Tue, 31 Jan 2012 01:18:55 +, Mark Walters
wrote:
> One of the mails has an in-reply-to header which looks like
>
> In-reply-to: Message from Carsten Dominik of
> "Tue, 15 Mar 2011 12:18:51 BST."
> <17242340-A14F-495A-B144-20C96D52B620 at gmail.com>
!!
A new configuration key 'new.ignore' is used to determine which
files and directories user wants not to be scanned as new mails.
This work merges my previous attempts and Andreas Amann's work
in id:"ylp7hi23mw8@tyndall.ie"
See notes in id:"20120131-new-igno
Quoth Mark Walters on Jan 31 at 11:45 am:
> On Mon, 30 Jan 2012 23:43:52 -0500, Austin Clements wrote:
> > Quoth Mark Walters on Jan 29 at 6:39 pm:
> > > notmuch_message_node_t *iterator;
> > > };
> > >
> > > diff --git a/lib/notmuch.h b/lib/notmuch.h
> > > index 7929fe7..740d005 100644
>
On Tue, 31 Jan 2012 16:15:11 +, Mark Walters
wrote:
> Hi I have reviewed the patch series within the limits of my lisp
> knowledge. Patch 1: is rather beyond my lisp so I won't comment on that
> (and I have never tried crypto): Patches 2-5 look fine with one
> bikeshed and one query for my o
t;;; This is the last message - change the return value
> >(setq ret t)))
> > --
> > 1.7.8.3
> >
> > ___
> > notmuch mailing list
> > notmuch at notmuchmail.org
> > http://notmuchmail.org/mailm
Quoth Mark Walters on Jan 31 at 11:40 am:
>
> Thanks for the review. Almost all of it (for all all the patches) I
> agree with and will just fix but I do have a couple of queries.
>
> On Mon, 30 Jan 2012 23:17:32 -0500, Austin Clements wrote:
> > Quoth Mark Walters on Jan 29 at 6:39 pm:
> > > T
Hi I have reviewed the patch series within the limits of my lisp
knowledge. Patch 1: is rather beyond my lisp so I won't comment on that
(and I have never tried crypto): Patches 2-5 look fine with one
bikeshed and one query for my own understanding.
The bikeshed is that I agree with Jani in
id:"
rt of the "raison de notmuch"
:-)
-- next part --
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL:
<http://notmuchmail.org/pipermail/notmuch/attachments/20120131/100c771c/attachment.pgp>
When using the spacebar to scroll through a thread, hitting 'space'
when the bottom of the last message is visible should take the cursor
to the end of the buffer rather than immediately archiving the thread
and moving to the next thread.
---
emacs/notmuch-show.el |5 +
1 files changed, 5
When archiving the last message in a thread (a), rather than just
moving the pointer to the next thread in the parent search buffer,
actually display the next thread.
---
emacs/notmuch-show.el |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/emacs/notmuch-show.el b/emacs/n
After Jameson's recent work the precise behaviour of 'a' and ' ' in
`notmuch-show-mode' changed slightly. Revert to something nearer the
previous behaviour.
David Edmondson (2):
emacs: If archiving the last message in a thread, show the next
thread.
emacs: Don't move to the next thread unl
Hi Austin.
All 3 patches look good to me.
Regards,
Dmitry
On Tue, 31 Jan 2012 17:03:55 +0200, Jani Nikula wrote:
> 'a' = Archive current message, then move to next message, or show next
> thread from search if at the last message in thread.
>
> 'A' = Archive each message in thread, then show next thread from
> search.
>
> 'x' = Archive current message,
Quoth Jani Nikula on Jan 31 at 3:12 pm:
> On Thu, 26 Jan 2012 23:58:51 +0200, Jani Nikula wrote:
> > On Thu, 26 Jan 2012 14:41:46 -0500, Austin Clements
> > wrote:
> > > Quoth Jani Nikula on Jan 26 at 9:21 pm:
> > > > + ("flagged" :foreground "red"))
> > >
Quoth Jani Nikula on Jan 31 at 5:03 pm:
> Proposal for show view a/A/x/X key bindings, according to
> http://titanpad.com/SA39EbNezU and IRC discussion:
>
> 'a' = Archive current message, then move to next message, or show next
> thread from search if at the last message in thread.
>
> 'A' = Arc
Proposal for show view a/A/x/X key bindings, according to
http://titanpad.com/SA39EbNezU and IRC discussion:
'a' = Archive current message, then move to next message, or show next
thread from search if at the last message in thread.
'A' = Archive each message in thread, then show next thread from
-- next part --
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL:
<http://notmuchmail.org/pipermail/notmuch/attachments/20120131/3610f74c/attachment.pgp>
Size: 197 bytes
Desc: not available
URL:
<http://notmuchmail.org/pipermail/notmuch/attachments/20120131/f1fef699/attachment.pgp>
On Thu, 26 Jan 2012 23:58:51 +0200, Jani Nikula wrote:
> On Thu, 26 Jan 2012 14:41:46 -0500, Austin Clements wrote:
> > Quoth Jani Nikula on Jan 26 at 9:21 pm:
> > > +("flagged" :foreground "red"))
> >
> > Red is pretty universally used to indicate danger or a se
On Mon, 30 Jan 2012 23:56:24 -0500, Austin Clements wrote:
> Quoth Mark Walters on Jan 29 at 6:39 pm:
> > This adds the excludes to notmuch-show.c. We do not exclude when only
> > a single message (or part) is requested. notmuch-show will output the
> > exclude information when either text or jso
On Mon, 30 Jan 2012 23:50:20 -0500, Austin Clements wrote:
> Quoth Mark Walters on Jan 29 at 6:39 pm:
> > Add the NOTMUCH_MESSAGE_FLAG_EXCLUDED flag to
> > notmuch_query_search_threads. Implemented by inspecting the tags
> > directly in _notmuch_thread_create/_thread_add_message rather than as
>
On Mon, 30 Jan 2012 23:43:52 -0500, Austin Clements wrote:
> Quoth Mark Walters on Jan 29 at 6:39 pm:
> > Add a flag NOTMUCH_MESSAGE_FLAG_EXCLUDED which is set by
> > notmuch_query_search_messages for excluded messages. Also add an
> > option omit_excluded_messages to the search that we do not wa
On Mon, 30 Jan 2012 16:52:20 +, David Edmondson wrote:
> The blank line doesn't really change position, but is now considered
> to be part of the body rather than part of the headers. This means
> that it is visible when the body is visible rather than when the
> headers are visible.
> ---
>
Thanks for the review. Almost all of it (for all all the patches) I
agree with and will just fix but I do have a couple of queries.
On Mon, 30 Jan 2012 23:17:32 -0500, Austin Clements wrote:
> Quoth Mark Walters on Jan 29 at 6:39 pm:
> > This option turns off the exclusion so all matching messa
On Thu, 26 Jan 2012 01:55:26 -0500, Austin Clements wrote:
> This makes the text formatter take advantage of the new code
> structure. The previously duplicated header logic is now unified,
> several things that we used to compute repeatedly across different
> callbacks are now computed once, and
On Tue, 31 Jan 2012 10:32:12 +, David Edmondson wrote:
> On Mon, 30 Jan 2012 21:25:19 -0800, Jameson Graef Rollins
> wrote:
> > On Mon, 30 Jan 2012 16:52:20 +, David Edmondson wrote:
> > > The blank line doesn't really change position, but is now considered
> > > to be part of the body
On Thu, 26 Jan 2012 01:55:25 -0500, Austin Clements wrote:
> This is all code movement and a smidgen of glue. This moves the
> existing text formatter code into one self-recursive function, but
> doesn't change any of the logic. The next patch will actually take
> advantage of what the new struc
On Tue, 31 Jan 2012 10:30:20 +, David Edmondson wrote:
> On Tue, 31 Jan 2012 11:25:36 +0200, Tomi Ollila wrote:
> > I like David's alternative suggestion (in IRC) where cursor is left at
> > the end of buffer in case last message is archived with 'a'.
>
> Unless the cursor is already at the
On Mon, 30 Jan 2012 21:25:19 -0800, Jameson Graef Rollins
wrote:
> On Mon, 30 Jan 2012 16:52:20 +, David Edmondson wrote:
> > The blank line doesn't really change position, but is now considered
> > to be part of the body rather than part of the headers. This means
> > that it is visible whe
On Tue, 31 Jan 2012 11:25:36 +0200, Tomi Ollila wrote:
> I like David's alternative suggestion (in IRC) where cursor is left at
> the end of buffer in case last message is archived with 'a'.
Unless the cursor is already at the end of the buffer, in which case it
would do the 'next thread' dance (
Before the change, messages generated by generate_message() used "Test
message #N" for default subject where N is the generated messages
counter. Since message subject is commonly present in expected
results, there is a chance of breaking other tests when a new
generate_message() call is added. T
Before the change, the first subtest in raw format tests just
generated messages and checked that they are added successfully. This
is not really a raw format test, it is creating of environment
required for other subtests to run. The patch removes the first
subtest from raw and replaces it with
On Tue, 31 Jan 2012 12:51:44 +0400, Dmitry Kurochkin
wrote:
> On Tue, 31 Jan 2012 10:43:10 +0200, Tomi Ollila wrote:
> > On Tue, 31 Jan 2012 08:01:53 +, David Edmondson wrote:
> > > When archiving the last message in a thread (a), rather than just
> > > moving the pointer to the next thread
On Mon, 30 Jan 2012 23:34:16 +0100, Gregor Zattler wrote:
> Hi Mark,
> * Mark Walters [30. Jan. 2012]:
> > On Mon, 30 Jan 2012 20:04:25 +0100, Gregor Zattler
> > wrote:
> >> * Pieter Praet [30. Jan. 2012]:
> >>> On Mon, 30 Jan 2012 00:42:14 +0100, Gregor Zattler
> >>> wrote:
> * Pieter
I mangled the "in-reply-to" header, which should be
1327486729-18052-1-git-send-email-...@dme.org
(i.e. id:"1327486729-18052-1-git-send-email-...@dme.org").
pgpgoxHbRi9Py.pgp
Description: PGP signature
___
notmuch mailing list
notmuch@notmuchmail.org
ht
1 - 100 of 122 matches
Mail list logo
