[PATCH] build: Require gmime >= 2.6.7

2012-03-11 Thread David Bremner
From: Thomas Jost gmime-2.6 had a bug [1] which made it impossible to tell why a signature verification failed when the signer key was unavailable (empty "sigstatus" field in the JSON output). Since 00b5623d the corresponding test is marked as broken when using gmime-2.6

[PATCH v6 06/10] schemata: Add documentation for JSON reply format.

2012-03-11 Thread Adam Wolfe Gordon
On Sun, Mar 11, 2012 at 18:36, Austin Clements wrote: > Oops. ?Looks like I left references to various old JSON functions in > the schemata file. ?I'll submit a patch to fix those up, but you might > as well use the correct function names in the new documentation. Erk, I missed this review as I

[PATCH v7 10/10] emacs: Use the new JSON reply format and message-cite-original

2012-03-11 Thread Adam Wolfe Gordon
Use the new JSON reply format to create replies in emacs. Quote HTML parts nicely by using mm-display-part to turn them into displayable text, then quoting them with message-cite-original. This is very useful for users who regularly receive HTML-only email. Use message-mode's

[PATCH v7 09/10] test: Add broken tests for new emacs reply functionality

2012-03-11 Thread Adam Wolfe Gordon
Add tests for creating nice replies to multipart messages, including those with HTML parts. These tests are expected to fail for now. --- test/emacs | 97 1 files changed, 97 insertions(+), 0 deletions(-) diff --git a/test/emacs

[PATCH v7 08/10] emacs: Factor out useful functions into notmuch-lib

2012-03-11 Thread Adam Wolfe Gordon
Move a few functions related to handling multipart/alternative parts into notmuch-lib.el, so they can be used by future reply code. --- emacs/notmuch-lib.el | 33 + emacs/notmuch-show.el | 24 ++-- 2 files changed, 35 insertions(+), 22

[PATCH v7 07/10] man: Add --decrypt to reply flags

2012-03-11 Thread Adam Wolfe Gordon
--- man/man1/notmuch-reply.1 | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/man/man1/notmuch-reply.1 b/man/man1/notmuch-reply.1 index 36b60cb..e21559a 100644 --- a/man/man1/notmuch-reply.1 +++ b/man/man1/notmuch-reply.1 @@ -68,6 +68,16 @@ values from the first

[PATCH v7 06/10] man: Update notmuch-reply man page for JSON format.

2012-03-11 Thread Adam Wolfe Gordon
--- man/man1/notmuch-reply.1 | 10 -- 1 files changed, 8 insertions(+), 2 deletions(-) diff --git a/man/man1/notmuch-reply.1 b/man/man1/notmuch-reply.1 index 7ed7f0f..debc505 100644 --- a/man/man1/notmuch-reply.1 +++ b/man/man1/notmuch-reply.1 @@ -37,12 +37,17 @@ Supported options for

[PATCH v7 05/10] schemata: Add documentation for JSON reply format.

2012-03-11 Thread Adam Wolfe Gordon
--- devel/schemata | 27 +-- 1 files changed, 25 insertions(+), 2 deletions(-) diff --git a/devel/schemata b/devel/schemata index 24ad775..b1073a9 100644 --- a/devel/schemata +++ b/devel/schemata @@ -77,8 +77,9 @@ part = { content?: string } -# The headers

[PATCH v7 04/10] reply: Add a JSON reply format.

2012-03-11 Thread Adam Wolfe Gordon
This new JSON format for replies includes headers generated for a reply message as well as the headers of the original message. Using this data, a client can intelligently create a reply. For example, the emacs client will be able to create replies with quoted HTML parts by parsing the HTML

[PATCH v7 03/10] TODO: Add replying to multiple messages

2012-03-11 Thread Adam Wolfe Gordon
--- devel/TODO |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/devel/TODO b/devel/TODO index 4dda6f4..7b750af 100644 --- a/devel/TODO +++ b/devel/TODO @@ -141,6 +141,14 @@ Simplify notmuch-reply to simply print the headers (we have the original values) rather

[PATCH v7 02/10] reply: Factor out reply creation

2012-03-11 Thread Adam Wolfe Gordon
Factor out the creation of a reply message based on an original message so it can be shared by different reply formats. --- notmuch-reply.c | 104 -- 1 files changed, 62 insertions(+), 42 deletions(-) diff --git a/notmuch-reply.c

[PATCH v7 01/10] test: Add broken test for the new JSON reply format.

2012-03-11 Thread Adam Wolfe Gordon
--- test/multipart | 53 +++ test/test-lib | 1242 2 files changed, 1295 insertions(+), 0 deletions(-) create mode 100755 test/test-lib diff --git a/test/multipart b/test/multipart index 53782c6..80d6e88 100755 --- a/test/multipart +++

[PATCH v7 00/10] Reply enhancements

2012-03-11 Thread Adam Wolfe Gordon
Hi everyone, This is a new version of my reply series [1] that addresses Jani's and Austin's reviews and fixes a couple of bugs I found in using the patches. Summary of the changes: * The patch that disallows replying to multiple messages with the default format has been dropped, as Jani and

[PATCH 0/3] argument parsing additions

2012-03-11 Thread Jani Nikula
On Sat, 10 Mar 2012 11:23:15 +, Mark Walters wrote: > On Sat, 10 Mar 2012 00:33:27 +0200, Jani Nikula wrote: > > Hi Mark - > > > > I'm not sure which is worse, criticizing or rewriting other people's > > patches. I already did the former, and now I'm doing the > > latter. Apologies for

[PATCH v6] emacs: Use the new JSON reply format and message-cite-original

2012-03-11 Thread Austin Clements
Quoth Adam Wolfe Gordon on Feb 21 at 11:46 pm: > Use the new JSON reply format to create replies in emacs. Quote HTML > parts nicely by using mm-display-part to turn them into displayable > text, then quoting them with message-cite-original. This is very > useful for users who regularly receive

[PATCH v4] test: emacs: new test "notmuch-search: change tags of all matching messages"

2012-03-11 Thread Tomi Ollila
On Wed, 7 Mar 2012 20:49:52 +0100, Pieter Praet wrote: > * test/emacs-search: > > - New subtest "notmuch-search: change tags of all matching messages": > `notmuch-search-tag-all' (bound to "*") adds and removes tags > to/from all messages which match the query used to populate the >

[PATCH v6 06/10] schemata: Add documentation for JSON reply format.

2012-03-11 Thread Austin Clements
Oops. Looks like I left references to various old JSON functions in the schemata file. I'll submit a patch to fix those up, but you might as well use the correct function names in the new documentation. Quoth Adam Wolfe Gordon on Feb 21 at 11:46 pm: > --- > devel/schemata | 27

[PATCH v6 03/10] reply: Require that only one message is returned

2012-03-11 Thread Austin Clements
Quoth Jani Nikula on Mar 10 at 1:00 am: > On Tue, 21 Feb 2012 23:46:32 -0700, Adam Wolfe Gordon > wrote: > > As the semantics of replying to multiple messages have not yet been > > defined well, make notmuch reply require that the search given returns > > only a single

[PATCH v2 3/8] show: Allow formatters to return errors

2012-03-11 Thread Austin Clements
On Tue, 06 Mar 2012 21:22:55 +, Mark Walters wrote: > On Tue, 6 Mar 2012 18:48:39 +, Austin Clements > wrote: > > Formatter errors are propagated to the exit status of notmuch show. > > > > This isn't used by the JSON or text formatters, but it will be useful > > for the raw format,

nmfirehose - a crude nmbug companion tool

2012-03-11 Thread Jani Nikula
part -- A non-text attachment was scrubbed... Name: nmfirehose Type: application/octet-stream Size: 5862 bytes Desc: nmfirehose URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20120311/b0cf503f/attachment.obj>

Re: [PATCH v4] test: emacs: new test notmuch-search: change tags of all matching messages

2012-03-11 Thread Tomi Ollila
On Wed, 7 Mar 2012 20:49:52 +0100, Pieter Praet pie...@praet.org wrote: * test/emacs-search: - New subtest notmuch-search: change tags of all matching messages: `notmuch-search-tag-all' (bound to *) adds and removes tags to/from all messages which match the query used to populate

Re: [PATCH 0/3] argument parsing additions

2012-03-11 Thread Jani Nikula
On Sat, 10 Mar 2012 11:23:15 +, Mark Walters markwalters1...@gmail.com wrote: On Sat, 10 Mar 2012 00:33:27 +0200, Jani Nikula j...@nikula.org wrote: Hi Mark - I'm not sure which is worse, criticizing or rewriting other people's patches. I already did the former, and now I'm doing

[PATCH] man: update SEE ALSO references in man pages

2012-03-11 Thread Jani Nikula
Drop references to notmuch-part(1). Reference all man pages. Fix man page section of notmuch-dump(1). --- man/man1/notmuch-config.1 |5 ++--- man/man1/notmuch-count.1|8 man/man1/notmuch-dump.1 |8 man/man1/notmuch-new.1 |8

Re: [PATCH v2 3/8] show: Allow formatters to return errors

2012-03-11 Thread Austin Clements
On Tue, 06 Mar 2012 21:22:55 +, Mark Walters markwalters1...@gmail.com wrote: On Tue, 6 Mar 2012 18:48:39 +, Austin Clements amdra...@mit.edu wrote: Formatter errors are propagated to the exit status of notmuch show. This isn't used by the JSON or text formatters, but it will be

Re: [PATCH v6 03/10] reply: Require that only one message is returned

2012-03-11 Thread Austin Clements
Quoth Jani Nikula on Mar 10 at 1:00 am: On Tue, 21 Feb 2012 23:46:32 -0700, Adam Wolfe Gordon awg+notm...@xvx.ca wrote: As the semantics of replying to multiple messages have not yet been defined well, make notmuch reply require that the search given returns only a single message. Is

Re: [PATCH v6 06/10] schemata: Add documentation for JSON reply format.

2012-03-11 Thread Austin Clements
Oops. Looks like I left references to various old JSON functions in the schemata file. I'll submit a patch to fix those up, but you might as well use the correct function names in the new documentation. Quoth Adam Wolfe Gordon on Feb 21 at 11:46 pm: --- devel/schemata | 27

Re: [PATCH v6] emacs: Use the new JSON reply format and message-cite-original

2012-03-11 Thread Austin Clements
Quoth Adam Wolfe Gordon on Feb 21 at 11:46 pm: Use the new JSON reply format to create replies in emacs. Quote HTML parts nicely by using mm-display-part to turn them into displayable text, then quoting them with message-cite-original. This is very useful for users who regularly receive

[PATCH] build: Require gmime = 2.6.7

2012-03-11 Thread David Bremner
From: Thomas Jost schno...@schnouki.net gmime-2.6 had a bug [1] which made it impossible to tell why a signature verification failed when the signer key was unavailable (empty sigstatus field in the JSON output). Since 00b5623d the corresponding test is marked as broken when using gmime-2.6 (2.4

[PATCH v7 00/10] Reply enhancements

2012-03-11 Thread Adam Wolfe Gordon
Hi everyone, This is a new version of my reply series [1] that addresses Jani's and Austin's reviews and fixes a couple of bugs I found in using the patches. Summary of the changes: * The patch that disallows replying to multiple messages with the default format has been dropped, as Jani and

[PATCH v7 01/10] test: Add broken test for the new JSON reply format.

2012-03-11 Thread Adam Wolfe Gordon
--- test/multipart | 53 +++ test/test-lib | 1242 2 files changed, 1295 insertions(+), 0 deletions(-) create mode 100755 test/test-lib diff --git a/test/multipart b/test/multipart index 53782c6..80d6e88 100755 --- a/test/multipart +++

[PATCH v7 03/10] TODO: Add replying to multiple messages

2012-03-11 Thread Adam Wolfe Gordon
--- devel/TODO |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/devel/TODO b/devel/TODO index 4dda6f4..7b750af 100644 --- a/devel/TODO +++ b/devel/TODO @@ -141,6 +141,14 @@ Simplify notmuch-reply to simply print the headers (we have the original values) rather

[PATCH v7 05/10] schemata: Add documentation for JSON reply format.

2012-03-11 Thread Adam Wolfe Gordon
--- devel/schemata | 27 +-- 1 files changed, 25 insertions(+), 2 deletions(-) diff --git a/devel/schemata b/devel/schemata index 24ad775..b1073a9 100644 --- a/devel/schemata +++ b/devel/schemata @@ -77,8 +77,9 @@ part = { content?: string } -# The headers

[PATCH v7 06/10] man: Update notmuch-reply man page for JSON format.

2012-03-11 Thread Adam Wolfe Gordon
--- man/man1/notmuch-reply.1 | 10 -- 1 files changed, 8 insertions(+), 2 deletions(-) diff --git a/man/man1/notmuch-reply.1 b/man/man1/notmuch-reply.1 index 7ed7f0f..debc505 100644 --- a/man/man1/notmuch-reply.1 +++ b/man/man1/notmuch-reply.1 @@ -37,12 +37,17 @@ Supported options for

[PATCH v7 09/10] test: Add broken tests for new emacs reply functionality

2012-03-11 Thread Adam Wolfe Gordon
Add tests for creating nice replies to multipart messages, including those with HTML parts. These tests are expected to fail for now. --- test/emacs | 97 1 files changed, 97 insertions(+), 0 deletions(-) diff --git a/test/emacs

[PATCH v7 10/10] emacs: Use the new JSON reply format and message-cite-original

2012-03-11 Thread Adam Wolfe Gordon
Use the new JSON reply format to create replies in emacs. Quote HTML parts nicely by using mm-display-part to turn them into displayable text, then quoting them with message-cite-original. This is very useful for users who regularly receive HTML-only email. Use message-mode's

Re: [PATCH v6 06/10] schemata: Add documentation for JSON reply format.

2012-03-11 Thread Adam Wolfe Gordon
On Sun, Mar 11, 2012 at 18:36, Austin Clements amdra...@mit.edu wrote: Oops.  Looks like I left references to various old JSON functions in the schemata file.  I'll submit a patch to fix those up, but you might as well use the correct function names in the new documentation. Erk, I missed this