[PATCH v2 0/2] cli: Allow true/false parameter for boolean

Quoth Mark Walters on Mar 10 at 11:05 am: > Hi > > Here is a second version of a patch to allow parameters to boolean > options on the command line. This version allows parameters > (=true|false). My first version is at > id:"1331244944-7960-1-git-send-email-markwalters1009 at gmail.com". Jani >

[PATCH 2/2] lib: Add exclude query debug output

--- lib/query.cc | 10 -- 1 files changed, 8 insertions(+), 2 deletions(-) diff --git a/lib/query.cc b/lib/query.cc index 1e5e99a..53d505a 100644 --- a/lib/query.cc +++ b/lib/query.cc @@ -261,9 +261,12 @@ notmuch_query_search_messages (notmuch_query_t *query) break;

[PATCH 1/2] lib: Expose query debug output via an environment variable

Allow query debugging to be enabled at run-time by setting the NOTMUCH_DEBUG_QUERY environment variable to a non-empty string. Previously, enabling query debugging required recompiling, but parsed queries are often useful for tracking down bugs in situations where recompiling is inconvenient. ---

[PATCH 0/2] Query debug improvements

Two simple improvements for query debugging.

[PATCH v7.1 11/11] NEWS: news for reply enhancements

--- NEWS | 20 1 files changed, 20 insertions(+), 0 deletions(-) diff --git a/NEWS b/NEWS index a739914..46fb191 100644 --- a/NEWS +++ b/NEWS @@ -11,6 +11,18 @@ Reply to sender to all. The feature is available through the new command line option

[PATCH v7.1 10/11] emacs: Use the new JSON reply format and message-cite-original

Use the new JSON reply format to create replies in emacs. Quote HTML parts nicely by using mm-display-part to turn them into displayable text, then quoting them with message-cite-original. This is very useful for users who regularly receive HTML-only email. Use message-mode's

[PATCH v7.1 09/11] test: Add broken tests for new emacs reply functionality

Add tests for creating nice replies to multipart messages, including those with HTML parts. These tests are expected to fail for now. --- test/emacs | 97 1 files changed, 97 insertions(+), 0 deletions(-) diff --git a/test/emacs

[PATCH v7.1 08/11] emacs: Factor out useful functions into notmuch-lib

Move a few functions related to handling multipart/alternative parts into notmuch-lib.el, so they can be used by future reply code. --- emacs/notmuch-lib.el | 33 + emacs/notmuch-show.el | 24 ++-- 2 files changed, 35 insertions(+), 22

[PATCH v7.1 07/11] man: Add --decrypt to reply flags

--- man/man1/notmuch-reply.1 | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/man/man1/notmuch-reply.1 b/man/man1/notmuch-reply.1 index debc505..d9912c4 100644 --- a/man/man1/notmuch-reply.1 +++ b/man/man1/notmuch-reply.1 @@ -68,6 +68,16 @@ values from the first

[PATCH v7.1 06/11] man: Update notmuch-reply man page for JSON format.

--- man/man1/notmuch-reply.1 | 10 -- 1 files changed, 8 insertions(+), 2 deletions(-) diff --git a/man/man1/notmuch-reply.1 b/man/man1/notmuch-reply.1 index 7ed7f0f..debc505 100644 --- a/man/man1/notmuch-reply.1 +++ b/man/man1/notmuch-reply.1 @@ -37,12 +37,17 @@ Supported options for

[PATCH v7.1 05/11] schemata: Add documentation for JSON reply format.

--- devel/schemata | 27 +-- 1 files changed, 25 insertions(+), 2 deletions(-) diff --git a/devel/schemata b/devel/schemata index 24ad775..728a46f 100644 --- a/devel/schemata +++ b/devel/schemata @@ -77,8 +77,9 @@ part = { content?: string } -# The headers

[PATCH v7.1 04/11] reply: Add a JSON reply format.

This new JSON format for replies includes headers generated for a reply message as well as the headers of the original message. Using this data, a client can intelligently create a reply. For example, the emacs client will be able to create replies with quoted HTML parts by parsing the HTML

[PATCH v7.1 03/11] TODO: Add replying to multiple messages

--- devel/TODO |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/devel/TODO b/devel/TODO index 4dda6f4..7b750af 100644 --- a/devel/TODO +++ b/devel/TODO @@ -141,6 +141,14 @@ Simplify notmuch-reply to simply print the headers (we have the original values) rather

[PATCH v7.1 02/11] reply: Factor out reply creation

Factor out the creation of a reply message based on an original message so it can be shared by different reply formats. --- notmuch-reply.c | 104 -- 1 files changed, 62 insertions(+), 42 deletions(-) diff --git a/notmuch-reply.c

[PATCH v7.1 01/11] test: Add broken test for the new JSON reply format.

--- test/multipart | 53 + 1 files changed, 53 insertions(+), 0 deletions(-) diff --git a/test/multipart b/test/multipart index 53782c6..80d6e88 100755 --- a/test/multipart +++ b/test/multipart @@ -589,6 +589,59 @@ Non-text part: text/html

[PATCH v7.1 00/11] Reply enhancements, second attempt

Hi everyone, This is mostly a re-send of last night's series [1]. The only changes are: * Fixed the emacs patch, where I had a rebase issue. * Fixed the commit that re-added test/test-lib by accident. * Fixed devel/schemata per Austin's review of the previous version. Since this series seems to

[PATCH] build: Require gmime >= 2.6.7

On Sun, 11 Mar 2012 22:29:46 -0300, David Bremner wrote: > From: Thomas Jost > > gmime-2.6 had a bug [1] which made it impossible to tell why a signature > verification failed when the signer key was unavailable (empty "sigstatus" > field > in the JSON output). Since 00b5623d the corresponding

[PATCH] man: update SEE ALSO references in man pages

On Sun, 11 Mar 2012 23:36:16 +0200, Jani Nikula wrote: > Drop references to notmuch-part(1). Reference all man pages. Fix man > page section of notmuch-dump(1). pushed. As jani says, we can certainly improve the cross references later. d

[PATCH 0/2] A bug in the exclude code

On Mon, 12 Mar 2012 11:31:52 +, Mark Walters wrote: > There is a bug in the exclude code (found by jrollins in the > --with-excluded series) but also present in master. None of the > current tests were finding it so the first patch adds two tests. > > The bug (and test failure) do not

[PATCH] man: update SEE ALSO references in man pages

On Tue, 13 Mar 2012 13:35:44 -0400, Austin Clements wrote: > Quoth Jani Nikula on Mar 11 at 11:36 pm: > > Drop references to notmuch-part(1). Reference all man pages. Fix man > > page section of notmuch-dump(1). > > This LGTM, but is it actually what we want? Referencing everything > from

[PATCH] man: update SEE ALSO references in man pages

Quoth Jani Nikula on Mar 11 at 11:36 pm: > Drop references to notmuch-part(1). Reference all man pages. Fix man > page section of notmuch-dump(1). This LGTM, but is it actually what we want? Referencing everything from everything seems to defeat the purpose. I would expect notmuch(1) to

[PATCH v7 10/10] emacs: Use the new JSON reply format and message-cite-original

Quoth Adam Wolfe Gordon on Mar 11 at 10:05 pm: > Use the new JSON reply format to create replies in emacs. Quote HTML > parts nicely by using mm-display-part to turn them into displayable > text, then quoting them with message-cite-original. This is very > useful for users who regularly receive

[PATCH v7 01/10] test: Add broken test for the new JSON reply format.

Quoth Adam Wolfe Gordon on Mar 11 at 10:05 pm: > --- > test/multipart | 53 +++ > test/test-lib | 1242 > > 2 files changed, 1295 insertions(+), 0 deletions(-) > create mode 100755 test/test-lib > > diff --git a/test/multipart

[PATCH v7 10/10] emacs: Use the new JSON reply format and message-cite-original

On Tue, Mar 13, 2012 at 11:02, Austin Clements wrote: > Hmm. ?This patch looks the same as in v6, but your cover letter says > that you changed some things. Damn, indeed. Looks like I rebased the changes into the wrong commit, so they weren't included in this series. Might be best to ignore

[PATCH v7 01/10] test: Add broken test for the new JSON reply format.

On Tue, Mar 13, 2012 at 10:49, Austin Clements wrote: >> diff --git a/test/test-lib b/test/test-lib >> new file mode 100755 >> index 000..8158328 >> --- /dev/null >> +++ b/test/test-lib > > Spurious git add? ?(IIRC, this is what test-lib.sh used to be called, > so I'd guess you have an old

[PATCH 0/2] A bug in the exclude code

ipermail/notmuch/attachments/20120313/74db347f/attachment.pgp>

[PATCH] build: Require gmime >= 2.6.7

On Sun, 11 Mar 2012 22:29:46 -0300, David Bremner wrote: > From: Thomas Jost > > gmime-2.6 had a bug [1] which made it impossible to tell why a signature > verification failed when the signer key was unavailable (empty "sigstatus" > field > in the JSON output). Since 00b5623d the corresponding

Re: [PATCH] build: Require gmime = 2.6.7

On Sun, 11 Mar 2012 22:29:46 -0300, David Bremner da...@tethera.net wrote: From: Thomas Jost schno...@schnouki.net gmime-2.6 had a bug [1] which made it impossible to tell why a signature verification failed when the signer key was unavailable (empty sigstatus field in the JSON output).

Re: [PATCH v7 01/10] test: Add broken test for the new JSON reply format.

Quoth Adam Wolfe Gordon on Mar 11 at 10:05 pm: --- test/multipart | 53 +++ test/test-lib | 1242 2 files changed, 1295 insertions(+), 0 deletions(-) create mode 100755 test/test-lib diff --git a/test/multipart

Re: [PATCH v7 01/10] test: Add broken test for the new JSON reply format.

On Tue, Mar 13, 2012 at 10:49, Austin Clements amdra...@mit.edu wrote: diff --git a/test/test-lib b/test/test-lib new file mode 100755 index 000..8158328 --- /dev/null +++ b/test/test-lib Spurious git add?  (IIRC, this is what test-lib.sh used to be called, so I'd guess you have an old

Re: [PATCH v7 10/10] emacs: Use the new JSON reply format and message-cite-original

Quoth Adam Wolfe Gordon on Mar 11 at 10:05 pm: Use the new JSON reply format to create replies in emacs. Quote HTML parts nicely by using mm-display-part to turn them into displayable text, then quoting them with message-cite-original. This is very useful for users who regularly receive

Re: [PATCH] man: update SEE ALSO references in man pages

Quoth Jani Nikula on Mar 11 at 11:36 pm: Drop references to notmuch-part(1). Reference all man pages. Fix man page section of notmuch-dump(1). This LGTM, but is it actually what we want? Referencing everything from everything seems to defeat the purpose. I would expect notmuch(1) to reference

Re: [PATCH 0/2] A bug in the exclude code

On Mon, 12 Mar 2012 21:07:49 +, Mark Walters markwalters1...@gmail.com wrote: Just to emphasise the bug is already present in current master (just better hidden because of the defaults). Hence this pair of patches (unlike the first one I sent privately) are to current master rather than

Re: [PATCH v7 10/10] emacs: Use the new JSON reply format and message-cite-original

On Tue, Mar 13, 2012 at 11:02, Austin Clements amdra...@mit.edu wrote: Hmm.  This patch looks the same as in v6, but your cover letter says that you changed some things. Damn, indeed. Looks like I rebased the changes into the wrong commit, so they weren't included in this series. Might be best

Re: [PATCH] man: update SEE ALSO references in man pages

On Tue, 13 Mar 2012 13:35:44 -0400, Austin Clements amdra...@mit.edu wrote: Quoth Jani Nikula on Mar 11 at 11:36 pm: Drop references to notmuch-part(1). Reference all man pages. Fix man page section of notmuch-dump(1). This LGTM, but is it actually what we want? Referencing everything

Re: [PATCH] man: update SEE ALSO references in man pages

On Sun, 11 Mar 2012 23:36:16 +0200, Jani Nikula j...@nikula.org wrote: Drop references to notmuch-part(1). Reference all man pages. Fix man page section of notmuch-dump(1). pushed. As jani says, we can certainly improve the cross references later. d

Re: [PATCH] build: Require gmime = 2.6.7

On Sun, 11 Mar 2012 22:29:46 -0300, David Bremner da...@tethera.net wrote: From: Thomas Jost schno...@schnouki.net gmime-2.6 had a bug [1] which made it impossible to tell why a signature verification failed when the signer key was unavailable (empty sigstatus field in the JSON output).

Re: [PATCH 0/2] A bug in the exclude code

On Mon, 12 Mar 2012 11:31:52 +, Mark Walters markwalters1...@gmail.com wrote: There is a bug in the exclude code (found by jrollins in the --with-excluded series) but also present in master. None of the current tests were finding it so the first patch adds two tests. The bug (and test

[PATCH 0/2] Query debug improvements

Two simple improvements for query debugging. ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

[PATCH 1/2] lib: Expose query debug output via an environment variable

Allow query debugging to be enabled at run-time by setting the NOTMUCH_DEBUG_QUERY environment variable to a non-empty string. Previously, enabling query debugging required recompiling, but parsed queries are often useful for tracking down bugs in situations where recompiling is inconvenient. ---

[PATCH 2/2] lib: Add exclude query debug output

--- lib/query.cc | 10 -- 1 files changed, 8 insertions(+), 2 deletions(-) diff --git a/lib/query.cc b/lib/query.cc index 1e5e99a..53d505a 100644 --- a/lib/query.cc +++ b/lib/query.cc @@ -261,9 +261,12 @@ notmuch_query_search_messages (notmuch_query_t *query) break;

Re: [PATCH v2 0/2] cli: Allow true/false parameter for boolean

Quoth Mark Walters on Mar 10 at 11:05 am: Hi Here is a second version of a patch to allow parameters to boolean options on the command line. This version allows parameters (=true|false). My first version is at id:1331244944-7960-1-git-send-email-markwalters1...@gmail.com. Jani posted an

[PATCH v7.1 01/11] test: Add broken test for the new JSON reply format.

--- test/multipart | 53 + 1 files changed, 53 insertions(+), 0 deletions(-) diff --git a/test/multipart b/test/multipart index 53782c6..80d6e88 100755 --- a/test/multipart +++ b/test/multipart @@ -589,6 +589,59 @@ Non-text part: text/html

[PATCH v7.1 02/11] reply: Factor out reply creation

Factor out the creation of a reply message based on an original message so it can be shared by different reply formats. --- notmuch-reply.c | 104 -- 1 files changed, 62 insertions(+), 42 deletions(-) diff --git a/notmuch-reply.c

[PATCH v7.1 11/11] NEWS: news for reply enhancements

--- NEWS | 20 1 files changed, 20 insertions(+), 0 deletions(-) diff --git a/NEWS b/NEWS index a739914..46fb191 100644 --- a/NEWS +++ b/NEWS @@ -11,6 +11,18 @@ Reply to sender to all. The feature is available through the new command line option

[PATCH v7.1 09/11] test: Add broken tests for new emacs reply functionality

Add tests for creating nice replies to multipart messages, including those with HTML parts. These tests are expected to fail for now. --- test/emacs | 97 1 files changed, 97 insertions(+), 0 deletions(-) diff --git a/test/emacs

[PATCH v7.1 08/11] emacs: Factor out useful functions into notmuch-lib

Move a few functions related to handling multipart/alternative parts into notmuch-lib.el, so they can be used by future reply code. --- emacs/notmuch-lib.el | 33 + emacs/notmuch-show.el | 24 ++-- 2 files changed, 35 insertions(+), 22

[PATCH v7.1 04/11] reply: Add a JSON reply format.

This new JSON format for replies includes headers generated for a reply message as well as the headers of the original message. Using this data, a client can intelligently create a reply. For example, the emacs client will be able to create replies with quoted HTML parts by parsing the HTML

[PATCH v7.1 06/11] man: Update notmuch-reply man page for JSON format.

--- man/man1/notmuch-reply.1 | 10 -- 1 files changed, 8 insertions(+), 2 deletions(-) diff --git a/man/man1/notmuch-reply.1 b/man/man1/notmuch-reply.1 index 7ed7f0f..debc505 100644 --- a/man/man1/notmuch-reply.1 +++ b/man/man1/notmuch-reply.1 @@ -37,12 +37,17 @@ Supported options for

[PATCH v7.1 07/11] man: Add --decrypt to reply flags

--- man/man1/notmuch-reply.1 | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/man/man1/notmuch-reply.1 b/man/man1/notmuch-reply.1 index debc505..d9912c4 100644 --- a/man/man1/notmuch-reply.1 +++ b/man/man1/notmuch-reply.1 @@ -68,6 +68,16 @@ values from the first

[PATCH v7.1 10/11] emacs: Use the new JSON reply format and message-cite-original

Use the new JSON reply format to create replies in emacs. Quote HTML parts nicely by using mm-display-part to turn them into displayable text, then quoting them with message-cite-original. This is very useful for users who regularly receive HTML-only email. Use message-mode's

[PATCH v7.1 05/11] schemata: Add documentation for JSON reply format.

--- devel/schemata | 27 +-- 1 files changed, 25 insertions(+), 2 deletions(-) diff --git a/devel/schemata b/devel/schemata index 24ad775..728a46f 100644 --- a/devel/schemata +++ b/devel/schemata @@ -77,8 +77,9 @@ part = { content?: string } -# The headers