[PATCH] nmbug: check whether every forked process exit with (non)zero value

2012-04-01 Thread Tomi Ollila
If any of the forked process exits with nonzero value, terminate current operation -- nonzero exit value indicates failure and then there is no point continuing. --- I tested this by using most of the commands (pushed few tags in addtion to pull, log, status & checkout). I haven't encountered

[PATCH] emacs: do not modify the alist passed to notmuch-sort-saved-searches

2012-04-01 Thread Tomi Ollila
On Sun, Apr 01 2012, Jani Nikula wrote: > Sort modifies its input as a side effect. Pass it a copy in > notmuch-sort-saved-searches to not modify the notmuch-saved-searches > alist. > > --- +1 Tomi > > Earlier version by Daniel Schoepe and discussion in thread starting at > id:"1330633478-19

[PATCH] emacs: do not modify the alist passed to notmuch-sort-saved-searches

2012-04-01 Thread Jani Nikula
Sort modifies its input as a side effect. Pass it a copy in notmuch-sort-saved-searches to not modify the notmuch-saved-searches alist. --- Earlier version by Daniel Schoepe and discussion in thread starting at id:"1330633478-1974-1-git-send-email-daniel at schoepe.org". --- emacs/notmuch-hello.

Re: [PATCH v2 0/6] Move --no-exclude to --exclude=(true|false|flag)

2012-04-01 Thread Jameson Graef Rollins
On Sat, Mar 31 2012, Mark Walters wrote: > This is version 2 of the exclude= series (version 1 is [1]). > > The main changes are the addition of some systematic notmuch-search > tests for all the exclude options, and I no longer add the > exclude=flag option to notmuch-show.c (the output was too s

[PATCH v2 0/6] Move --no-exclude to --exclude=(true|false|flag)

2012-04-01 Thread Jameson Graef Rollins
tests pass. And in my cursory review everything LGTM. jamie. -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 835 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20120401/3ec418bb/attachment.pgp>

Re: [BUG/PATCH v4 0/4] Bug fixes for reply, rebased

2012-04-01 Thread Jameson Graef Rollins
On Sun, Apr 01 2012, Adam Wolfe Gordon wrote: > This series is the same as the one from yesterday [1], rebased onto the > current master to resolve some conflicts with Austin's chnages. > > [1] id:"1333240404-13076-1-git-send-email-awg+notm...@xvx.ca" This series applies cleanly against the curre

[BUG/PATCH v4 0/4] Bug fixes for reply, rebased

2012-04-01 Thread Jameson Graef Rollins
s scrubbed... Name: not available Type: application/pgp-signature Size: 835 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20120401/1f77766b/attachment.pgp>

[PATCH] nmbug: check whether every forked process exit with (non)zero value

2012-04-01 Thread Tomi Ollila
If any of the forked process exits with nonzero value, terminate current operation -- nonzero exit value indicates failure and then there is no point continuing. --- I tested this by using most of the commands (pushed few tags in addtion to pull, log, status & checkout). I haven't encountered

[BUG/PATCH v3 0/4] Bug fixes for reply: three bugs, one series

2012-04-01 Thread Mark Walters
On Sun, 01 Apr 2012, Adam Wolfe Gordon wrote: > Hi everyone, > > This series is a combination of the three bugfixes I sent this week [1] > [2]. As Mark pointed out, the fix for the emacs 23.2 bug actually fixes the > alternate address bug as well, so there's no real reason to have a > separate pa

Re: [PATCH] emacs: do not modify the alist passed to notmuch-sort-saved-searches

2012-04-01 Thread Tomi Ollila
On Sun, Apr 01 2012, Jani Nikula wrote: > Sort modifies its input as a side effect. Pass it a copy in > notmuch-sort-saved-searches to not modify the notmuch-saved-searches > alist. > > --- +1 Tomi > > Earlier version by Daniel Schoepe and discussion in thread starting at > id:"1330633478-19

[BUG/PATCH v4 4/4] emacs: Fix the References header in reply

2012-04-01 Thread Adam Wolfe Gordon
In the new reply code, the References header gets inserted by message.el using a function called message-shorten-references. Unlike all the other header-inserting functions, it doesn't put a newline after the header, causing the next header to end up on the same line. In our case, this header happe

[BUG/PATCH v4 3/4] test: Show all headers in emacs reply tests

2012-04-01 Thread Adam Wolfe Gordon
By default, emacs hides the User-Agent and References headers when composing mail. This is a good thing for users, but a bad thing for testing, since we can create ugly or invalid headers and not have it show up in the tests. By setting message-hidden-headers to an empty list, we force emacs to sh

[BUG/PATCH v4 2/4] emacs: Fix two bugs in reply

2012-04-01 Thread Adam Wolfe Gordon
Bug 1: Replying from alternate addresses The reply code was inconsistent in its use of symbols and strings for header names being passed to message.el functions. This caused the >From header to be lookup up incorrectly, causing an additional From header to

[BUG/PATCH v4 1/4] test: Tests for reply from alternate addresses in emacs

2012-04-01 Thread Adam Wolfe Gordon
Since the recent reply changes were pushed, there has been a bug that causes emacs to always reply from the primary address, even if the JSON or default CLI reply output uses an alternate address. This adds two tests to the emacs test library based on the two "Reply form..." tests in the reply tes

[BUG/PATCH v4 0/4] Bug fixes for reply, rebased

2012-04-01 Thread Adam Wolfe Gordon
This series is the same as the one from yesterday [1], rebased onto the current master to resolve some conflicts with Austin's chnages. [1] id:"1333240404-13076-1-git-send-email-awg+notmuch at xvx.ca" Adam Wolfe Gordon (4): test: Tests for reply from alternate addresses in emacs emacs: Fix tw

[BUG/PATCH v4 1/4] test: Tests for reply from alternate addresses in emacs

2012-04-01 Thread Adam Wolfe Gordon
Since the recent reply changes were pushed, there has been a bug that causes emacs to always reply from the primary address, even if the JSON or default CLI reply output uses an alternate address. This adds two tests to the emacs test library based on the two "Reply form..." tests in the reply tes

[BUG/PATCH v4 4/4] emacs: Fix the References header in reply

2012-04-01 Thread Adam Wolfe Gordon
In the new reply code, the References header gets inserted by message.el using a function called message-shorten-references. Unlike all the other header-inserting functions, it doesn't put a newline after the header, causing the next header to end up on the same line. In our case, this header happe

[BUG/PATCH v4 3/4] test: Show all headers in emacs reply tests

2012-04-01 Thread Adam Wolfe Gordon
By default, emacs hides the User-Agent and References headers when composing mail. This is a good thing for users, but a bad thing for testing, since we can create ugly or invalid headers and not have it show up in the tests. By setting message-hidden-headers to an empty list, we force emacs to sh

[BUG/PATCH v4 2/4] emacs: Fix two bugs in reply

2012-04-01 Thread Adam Wolfe Gordon
Bug 1: Replying from alternate addresses The reply code was inconsistent in its use of symbols and strings for header names being passed to message.el functions. This caused the >From header to be lookup up incorrectly, causing an additional From header to

[BUG/PATCH v4 0/4] Bug fixes for reply, rebased

2012-04-01 Thread Adam Wolfe Gordon
This series is the same as the one from yesterday [1], rebased onto the current master to resolve some conflicts with Austin's chnages. [1] id:"1333240404-13076-1-git-send-email-awg+notm...@xvx.ca" Adam Wolfe Gordon (4): test: Tests for reply from alternate addresses in emacs emacs: Fix two b

[PATCH] emacs: do not modify the alist passed to notmuch-sort-saved-searches

2012-04-01 Thread Jani Nikula
Sort modifies its input as a side effect. Pass it a copy in notmuch-sort-saved-searches to not modify the notmuch-saved-searches alist. --- Earlier version by Daniel Schoepe and discussion in thread starting at id:"1330633478-1974-1-git-send-email-dan...@schoepe.org". --- emacs/notmuch-hello.el

Re: [BUG/PATCH v3 0/4] Bug fixes for reply: three bugs, one series

2012-04-01 Thread Mark Walters
On Sun, 01 Apr 2012, Adam Wolfe Gordon wrote: > Hi everyone, > > This series is a combination of the three bugfixes I sent this week [1] > [2]. As Mark pointed out, the fix for the emacs 23.2 bug actually fixes the > alternate address bug as well, so there's no real reason to have a > separate pa

[PATCH 8/8] man: document notmuch tag --stdin option

2012-04-01 Thread Jani Nikula
--- man/man1/notmuch-tag.1 | 44 +++- 1 files changed, 43 insertions(+), 1 deletions(-) diff --git a/man/man1/notmuch-tag.1 b/man/man1/notmuch-tag.1 index aa4546e..30693cf 100644 --- a/man/man1/notmuch-tag.1 +++ b/man/man1/notmuch-tag.1 @@ -4,7 +4,11 @@ n

[PATCH 7/8] test: add test for notmuch tag --stdin option

2012-04-01 Thread Jani Nikula
--- test/tagging | 13 + 1 files changed, 13 insertions(+), 0 deletions(-) diff --git a/test/tagging b/test/tagging index e4782ed..15eb42d 100755 --- a/test/tagging +++ b/test/tagging @@ -46,4 +46,17 @@ test_expect_equal "$output" "\ thread:XXX 2001-01-05 [1/1] Notmuch Test Suite

[PATCH 6/8] cli: add support for batch tagging operations to "notmuch tag"

2012-04-01 Thread Jani Nikula
Add support for batch tagging operations through stdin to "notmuch tag". This can be enabled with the new --stdin command line option to "notmuch new". The input must consist of lines of the format: T +|- [...] [--] Each line is interpreted similarly to "notmuch tag" command line arguments. The

[PATCH 5/8] test/hex-escaping: new test for hex escaping routines

2012-04-01 Thread Jani Nikula
From: David Bremner These are more like unit tests, to (try to) make sure the library functionality is working before building more complicated things on top of it. --- test/hex-escaping | 26 ++ test/notmuch-test |1 + 2 files changed, 27 insertions(+), 0 deletions

[PATCH 4/8] test/hex-xcode: new test binary

2012-04-01 Thread Jani Nikula
From: David Bremner This program is used both as a test-bed/unit-tester for ../util/hex-escape.c, and also as a utility in future tests of dump and restore. --- test/.gitignore |1 + test/Makefile.local |6 ++- test/basic |2 +- test/hex-xcode.c| 103 +++

[PATCH 3/8] hex-escape: add function to decode escaped string in-place

2012-04-01 Thread Jani Nikula
Add function hex_decode_inplace() to decode the input string onto itself. Signed-off-by: Jani Nikula --- This could be folded to "hex-escape: (en|de)code strings to/from restricted character set". --- util/hex-escape.c | 62 ++-- util/hex-escap

[PATCH 2/8] hex-escape: be more strict about the format while decoding

2012-04-01 Thread Jani Nikula
Signed-off-by: Jani Nikula --- This could be folded to "hex-escape: (en|de)code strings to/from restricted character set". --- util/hex-escape.c |7 --- 1 files changed, 4 insertions(+), 3 deletions(-) diff --git a/util/hex-escape.c b/util/hex-escape.c index 6c1260b..9de79df 100644 ---

[PATCH 1/8] hex-escape: (en|de)code strings to/from restricted character set

2012-04-01 Thread Jani Nikula
From: David Bremner The character set is chosen to be suitable for pathnames, and the same as that used by contrib/nmbug --- util/Makefile.local |2 +- util/hex-escape.c | 156 +++ util/hex-escape.h | 32 +++ 3 files changed, 189

[PATCH 0/8] batch tagging support: "notmuch tag --stdin"

2012-04-01 Thread Jani Nikula
Hi all, this series adds support for batch tagging through stdin to "notmuch tag". This should be useful and efficient for e.g. initial tagging scripts. See the test patch for an example using a "here document". The hex escaping routines are by David; my additions to them are in separate patches,