[ANN] New awesome vim plug-in using Ruby bindings

Hi Felipe, This work sounds nice - it's good to have lots of interface choices. One question below: On Sun, Apr 22, 2012 at 19:12, Felipe Contreras wrote: > doesn't have support for that), and even learning emacs, to use what > most people here use (but it turns out the HTML messages don't work

Re: [ANN] New awesome vim plug-in using Ruby bindings

Hi Felipe, This work sounds nice - it's good to have lots of interface choices. One question below: On Sun, Apr 22, 2012 at 19:12, Felipe Contreras wrote: > doesn't have support for that), and even learning emacs, to use what > most people here use (but it turns out the HTML messages don't work

[ANN] New awesome vim plug-in using Ruby bindings

Hi, I've never been particularly happy with the code of the vim plug-in, but it sort of did the job, after some fixes, and has been working great so far for most of my needs even though it's clearly very rough on the edges. However, I'm recently in need of been able to read HTML mails, and just t

[PATCH 2/7] NEWS: Document the notmuch_database_close split

On Sun, Apr 22, 2012 at 3:07 PM, Justus Winter <4winter at informatik.uni-hamburg.de> wrote: > Signed-off-by: Justus Winter <4winter at informatik.uni-hamburg.de> > --- > ?NEWS | ? 12 > ?1 file changed, 12 insertions(+) > > diff --git a/NEWS b/NEWS > index c1704e0..a2cd080 100644 > ---

folder searches don't work (sometimes) with current git

Hi, just a short notice, before I start further investigation into this bug. For some reason folder: searches won't work for new messages. After I tag a message taht won't be found there, by running `notmuch tag` it is found again. More details as soon as I find time for more investigation. Reg

Re: [PATCH v3 1/4] emacs: Let the user choose where to compose new mails

Le 15 avril 2012 à 16:52 CEST, David Bremner a écrit : > Jameson Graef Rollins writes: > >> I think the issues that David was experiencing have to do with flakiness >> in emacs's dedicated windows, not in this patch itself. > > Thomas, > > Did you have a change to investigate this as proposed in >

[PATCH 7/7] python: wrap and use notmuch_database_destroy as destructor

Adapt the python bindings to the notmuch_database_close split. Signed-off-by: Justus Winter <4winter at informatik.uni-hamburg.de> --- bindings/python/notmuch/database.py | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/bindings/python/notmuch/database.py b/b

[PATCH 6/7] ruby: Use notmuch_database_destroy instead of notmuch_database_close

Adapt the ruby bindings to the notmuch_database_close split. Signed-off-by: Justus Winter <4winter at informatik.uni-hamburg.de> --- bindings/ruby/database.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bindings/ruby/database.c b/bindings/ruby/database.c index 982fd59..b

[PATCH 5/7] go: Use notmuch_database_destroy instead of notmuch_database_close

Adapt the go bindings to the notmuch_database_close split. Signed-off-by: Justus Winter <4winter at informatik.uni-hamburg.de> --- bindings/go/pkg/notmuch.go |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/bindings/go/pkg/notmuch.go b/bindings/go/pkg/notmuch.go index c6

[PATCH 4/7] Use notmuch_database_destroy instead of notmuch_database_close

Adapt notmuch-deliver to the notmuch_database_close split. Signed-off-by: Justus Winter <4winter at informatik.uni-hamburg.de> --- contrib/notmuch-deliver/src/main.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contrib/notmuch-deliver/src/main.c b/contrib/notmuch-delive

[PATCH 3/7] Use notmuch_database_destroy instead of notmuch_database_close

Adapt the notmuch binaries source to the notmuch_database_close split. Signed-off-by: Justus Winter <4winter at informatik.uni-hamburg.de> --- notmuch-count.c |2 +- notmuch-dump.c|2 +- notmuch-new.c |2 +- notmuch-reply.c |2 +- notmuch-restore.c |2 +- notmuch-s

[PATCH 2/7] NEWS: Document the notmuch_database_close split

Signed-off-by: Justus Winter <4winter at informatik.uni-hamburg.de> --- NEWS | 12 1 file changed, 12 insertions(+) diff --git a/NEWS b/NEWS index c1704e0..a2cd080 100644 --- a/NEWS +++ b/NEWS @@ -73,6 +73,18 @@ leaving Mutt. notmuch-mutt, formerly distributed under the name "mu

[PATCH 1/7] Split notmuch_database_close into two functions

Formerly notmuch_database_close closed the xapian database and destroyed the talloc structure associated with the notmuch database object. Split notmuch_database_close into notmuch_database_close and notmuch_database_destroy. This makes it possible for long running programs to close the xapian dat

[PATCH 1/7] Split notmuch_database_close into two functions

On Sun, 22 Apr 2012, Justus Winter <4winter at informatik.uni-hamburg.de> wrote: > Formerly notmuch_database_close closed the xapian database and > destroyed the talloc structure associated with the notmuch database > object. Split notmuch_database_close into notmuch_database_close and > notmuch_da

[PATCH 7/7] python: wrap and use notmuch_database_destroy as destructor

Quoting Austin Clements (2012-04-12 19:02:49) > Quoth Justus Winter on Mar 21 at 1:55 am: > > Adapt the go bindings to the notmuch_database_close split. > > Typo. Duh >,< > > Signed-off-by: Justus Winter <4winter at informatik.uni-hamburg.de> > > --- > > bindings/python/notmuch/database.py |

[PATCH 1/7] Split notmuch_database_close into two functions

Quoth Justus Winter on Apr 22 at 2:07 pm: > Formerly notmuch_database_close closed the xapian database and > destroyed the talloc structure associated with the notmuch database > object. Split notmuch_database_close into notmuch_database_close and > notmuch_database_destroy. > > This makes it pos

[PATCH v3 4/4] new: Fix missing end_atomic in remove_filename on error

Previously, if we failed to find the message by filename in remove_filename, we would return immediately from the function without ending its atomic block. Now this code follows the usual goto DONE idiom to perform cleanup. --- notmuch-new.c |5 - 1 files changed, 4 insertions(+), 1 delet

[PATCH v3 3/4] new: Print final fatal error message to stderr

This was going to stdout. I removed the newline at the beginning of printing the fatal error message because it wouldn't make sense if you were only looking at the stderr stream (e.g., you had redirected stdout to /dev/null). --- notmuch-new.c |4 ++-- 1 files changed, 2 insertions(+), 2 dele

[PATCH v3 2/4] new: Handle fatal errors in remove_filename and _remove_directory

Previously such errors were simply ignored. Now they cause an immediate cleanup and abort. --- notmuch-new.c | 25 +++-- 1 files changed, 19 insertions(+), 6 deletions(-) diff --git a/notmuch-new.c b/notmuch-new.c index 15c0b36..2faf2f8 100644 --- a/notmuch-new.c +++ b/notm

[PATCH v3 1/4] new: Consistently treat fatal errors as fatal

Previously, fatal errors in add_files_recursive were not treated as fatal by its callers (including itself!). This makes add_files_recursive errors consistently fatal and updates all callers to treat them as fatal. --- notmuch-new.c | 16 1 files changed, 12 insertions(+), 4 de

[PATCH v3 0/4] Fix some error handling in notmuch new

This version fixes a silly mistake Mark pointed out. No further review is necessary, per id:"877gx8kyad.fsf at qmul.ac.uk".

[PATCH v2 2/4] new: Handle fatal errors in remove_filename and _remove_directory

Quoth Mark Walters on Apr 22 at 8:34 am: > On Sun, 22 Apr 2012, Austin Clements wrote: > > Previously such errors were simply ignored. Now they cause an > > immediate cleanup and abort. > > --- > > notmuch-new.c | 25 +++-- > > 1 files changed, 19 insertions(+), 6 deletion

Re: [PATCH 1/7] Split notmuch_database_close into two functions

On Sun, 22 Apr 2012, Justus Winter <4win...@informatik.uni-hamburg.de> wrote: > Formerly notmuch_database_close closed the xapian database and > destroyed the talloc structure associated with the notmuch database > object. Split notmuch_database_close into notmuch_database_close and > notmuch_datab

Re: [PATCH 1/7] Split notmuch_database_close into two functions

Quoth Justus Winter on Apr 22 at 2:07 pm: > Formerly notmuch_database_close closed the xapian database and > destroyed the talloc structure associated with the notmuch database > object. Split notmuch_database_close into notmuch_database_close and > notmuch_database_destroy. > > This makes it pos

[PATCH 2/2] emacs: Correctly quote non-text/plain parts in reply

On Sun, 22 Apr 2012, Adam Wolfe Gordon wrote: > Quote non-text parts nicely by displaying them with mm-display-part > before calling message-cite-original to quote them. HTML-only emails > can now be quoted correctly. My instinct would have been to do this with a temporary buffer rather than the

[PATCH v3 4/4] new: Fix missing end_atomic in remove_filename on error

Previously, if we failed to find the message by filename in remove_filename, we would return immediately from the function without ending its atomic block. Now this code follows the usual goto DONE idiom to perform cleanup. --- notmuch-new.c |5 - 1 files changed, 4 insertions(+), 1 delet

[PATCH v3 3/4] new: Print final fatal error message to stderr

This was going to stdout. I removed the newline at the beginning of printing the fatal error message because it wouldn't make sense if you were only looking at the stderr stream (e.g., you had redirected stdout to /dev/null). --- notmuch-new.c |4 ++-- 1 files changed, 2 insertions(+), 2 dele

[PATCH v3 2/4] new: Handle fatal errors in remove_filename and _remove_directory

Previously such errors were simply ignored. Now they cause an immediate cleanup and abort. --- notmuch-new.c | 25 +++-- 1 files changed, 19 insertions(+), 6 deletions(-) diff --git a/notmuch-new.c b/notmuch-new.c index 15c0b36..2faf2f8 100644 --- a/notmuch-new.c +++ b/notm

[PATCH v3 1/4] new: Consistently treat fatal errors as fatal

Previously, fatal errors in add_files_recursive were not treated as fatal by its callers (including itself!). This makes add_files_recursive errors consistently fatal and updates all callers to treat them as fatal. --- notmuch-new.c | 16 1 files changed, 12 insertions(+), 4 de

[PATCH v3 0/4] Fix some error handling in notmuch new

This version fixes a silly mistake Mark pointed out. No further review is necessary, per id:"877gx8kyad@qmul.ac.uk". ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

[PATCH v2 4/4] new: Fix missing end_atomic in remove_filename on error

On Sun, 22 Apr 2012, Austin Clements wrote: > Previously, if we failed to find the message by filename in > remove_filename, we would return immediately from the function without > ending its atomic block. Now this code follows the usual goto DONE > idiom to perform cleanup. The whole series loo

Re: [PATCH v2 2/4] new: Handle fatal errors in remove_filename and _remove_directory

Quoth Mark Walters on Apr 22 at 8:34 am: > On Sun, 22 Apr 2012, Austin Clements wrote: > > Previously such errors were simply ignored. Now they cause an > > immediate cleanup and abort. > > --- > > notmuch-new.c | 25 +++-- > > 1 files changed, 19 insertions(+), 6 deletion

[PATCH v2 2/4] new: Handle fatal errors in remove_filename and _remove_directory

On Sun, 22 Apr 2012, Austin Clements wrote: > Previously such errors were simply ignored. Now they cause an > immediate cleanup and abort. > --- > notmuch-new.c | 25 +++-- > 1 files changed, 19 insertions(+), 6 deletions(-) > > diff --git a/notmuch-new.c b/notmuch-new.c >

Re: [PATCH 2/7] NEWS: Document the notmuch_database_close split

On Sun, Apr 22, 2012 at 3:07 PM, Justus Winter <4win...@informatik.uni-hamburg.de> wrote: > Signed-off-by: Justus Winter <4win...@informatik.uni-hamburg.de> > --- >  NEWS |   12 >  1 file changed, 12 insertions(+) > > diff --git a/NEWS b/NEWS > index c1704e0..a2cd080 100644 > --- a/NEW

folder searches don't work (sometimes) with current git

Hi, just a short notice, before I start further investigation into this bug. For some reason folder: searches won't work for new messages. After I tag a message taht won't be found there, by running `notmuch tag` it is found again. More details as soon as I find time for more investigation. Reg

[PATCH 7/7] python: wrap and use notmuch_database_destroy as destructor

Adapt the python bindings to the notmuch_database_close split. Signed-off-by: Justus Winter <4win...@informatik.uni-hamburg.de> --- bindings/python/notmuch/database.py | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/bindings/python/notmuch/database.py b/bind

[PATCH 5/7] go: Use notmuch_database_destroy instead of notmuch_database_close

Adapt the go bindings to the notmuch_database_close split. Signed-off-by: Justus Winter <4win...@informatik.uni-hamburg.de> --- bindings/go/pkg/notmuch.go |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/bindings/go/pkg/notmuch.go b/bindings/go/pkg/notmuch.go index c6844

[PATCH 6/7] ruby: Use notmuch_database_destroy instead of notmuch_database_close

Adapt the ruby bindings to the notmuch_database_close split. Signed-off-by: Justus Winter <4win...@informatik.uni-hamburg.de> --- bindings/ruby/database.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bindings/ruby/database.c b/bindings/ruby/database.c index 982fd59..ba9a

[PATCH 3/7] Use notmuch_database_destroy instead of notmuch_database_close

Adapt the notmuch binaries source to the notmuch_database_close split. Signed-off-by: Justus Winter <4win...@informatik.uni-hamburg.de> --- notmuch-count.c |2 +- notmuch-dump.c|2 +- notmuch-new.c |2 +- notmuch-reply.c |2 +- notmuch-restore.c |2 +- notmuch-sear

[PATCH 4/7] Use notmuch_database_destroy instead of notmuch_database_close

Adapt notmuch-deliver to the notmuch_database_close split. Signed-off-by: Justus Winter <4win...@informatik.uni-hamburg.de> --- contrib/notmuch-deliver/src/main.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contrib/notmuch-deliver/src/main.c b/contrib/notmuch-deliver/s

[PATCH 2/7] NEWS: Document the notmuch_database_close split

Signed-off-by: Justus Winter <4win...@informatik.uni-hamburg.de> --- NEWS | 12 1 file changed, 12 insertions(+) diff --git a/NEWS b/NEWS index c1704e0..a2cd080 100644 --- a/NEWS +++ b/NEWS @@ -73,6 +73,18 @@ leaving Mutt. notmuch-mutt, formerly distributed under the name "mutt-

[PATCH 1/7] Split notmuch_database_close into two functions

Formerly notmuch_database_close closed the xapian database and destroyed the talloc structure associated with the notmuch database object. Split notmuch_database_close into notmuch_database_close and notmuch_database_destroy. This makes it possible for long running programs to close the xapian dat

Re: [PATCH 7/7] python: wrap and use notmuch_database_destroy as destructor

Quoting Austin Clements (2012-04-12 19:02:49) > Quoth Justus Winter on Mar 21 at 1:55 am: > > Adapt the go bindings to the notmuch_database_close split. > > Typo. Duh >,< > > Signed-off-by: Justus Winter <4win...@informatik.uni-hamburg.de> > > --- > > bindings/python/notmuch/database.py | 17

Re: [PATCH 2/2] emacs: Correctly quote non-text/plain parts in reply

On Sun, 22 Apr 2012, Adam Wolfe Gordon wrote: > Quote non-text parts nicely by displaying them with mm-display-part > before calling message-cite-original to quote them. HTML-only emails > can now be quoted correctly. My instinct would have been to do this with a temporary buffer rather than the

Re: [PATCH v2 4/4] new: Fix missing end_atomic in remove_filename on error

On Sun, 22 Apr 2012, Austin Clements wrote: > Previously, if we failed to find the message by filename in > remove_filename, we would return immediately from the function without > ending its atomic block. Now this code follows the usual goto DONE > idiom to perform cleanup. The whole series loo

Re: [PATCH v2 2/4] new: Handle fatal errors in remove_filename and _remove_directory

On Sun, 22 Apr 2012, Austin Clements wrote: > Previously such errors were simply ignored. Now they cause an > immediate cleanup and abort. > --- > notmuch-new.c | 25 +++-- > 1 files changed, 19 insertions(+), 6 deletions(-) > > diff --git a/notmuch-new.c b/notmuch-new.c >

[PATCH v2 4/4] new: Fix missing end_atomic in remove_filename on error

Previously, if we failed to find the message by filename in remove_filename, we would return immediately from the function without ending its atomic block. Now this code follows the usual goto DONE idiom to perform cleanup. --- notmuch-new.c |5 - 1 files changed, 4 insertions(+), 1 delet

[PATCH v2 3/4] new: Print final fatal error message to stderr

This was going to stdout. I removed the newline at the beginning of printing the fatal error message because it wouldn't make sense if you were only looking at the stderr stream (e.g., you had redirected stdout to /dev/null). --- notmuch-new.c |4 ++-- 1 files changed, 2 insertions(+), 2 dele

[PATCH v2 2/4] new: Handle fatal errors in remove_filename and _remove_directory

Previously such errors were simply ignored. Now they cause an immediate cleanup and abort. --- notmuch-new.c | 25 +++-- 1 files changed, 19 insertions(+), 6 deletions(-) diff --git a/notmuch-new.c b/notmuch-new.c index 15c0b36..92e0489 100644 --- a/notmuch-new.c +++ b/notm

[PATCH v2 1/4] new: Consistently treat fatal errors as fatal

Previously, fatal errors in add_files_recursive were not treated as fatal by its callers (including itself!). This makes add_files_recursive errors consistently fatal and updates all callers to treat them as fatal. --- notmuch-new.c | 16 1 files changed, 12 insertions(+), 4 de

[PATCH v2 0/4] Fix some error handling in notmuch new

Version 2 should address Mark's comments. It also adds a patch to fix an additional error handling error he pointed out in remove_filename.

[PATCH 2/3] new: Handle fatal errors in remove_filename and _remove_directory

Quoth Mark Walters on Apr 16 at 5:02 pm: > On Mon, 27 Feb 2012, Austin Clements wrote: > > Previously such errors were simply ignored. Now they cause an > > immediate cleanup and abort. > > This one looks fine except for a minor query. > > > --- > > notmuch-new.c | 24 ++

[PATCH 1/3] new: Consistently treat fatal errors as fatal

Quoth Mark Walters on Apr 16 at 4:53 pm: > > On Mon, 27 Feb 2012, Austin Clements wrote: > > Previously, fatal errors in add_files_recursive were not treated as > > fatal by its callers (including itself!) and add_files_recursive > > sometimes returned errors on non-fatal conditions. This makes