Re: [PATCH 6/6] man: document notmuch count --output=files

2013-05-26 Thread Mark Walters
David Bremner writes: > Other than the bikeshed about starting from zero instead of one, and not > being completely happy with the option name --duplicate (but not being > inspired to suggest a better one), this series looks OK to me. > > It seems like it would be quite useful to query based on

handle CPPFLAGS in configure and make

2013-05-26 Thread Tomi Ollila
On Sun, May 26 2013, david at tethera.net wrote: > I wanted to enable hardening flags in the debian build (I guess other > distros will want to do the same); I realized this is made more > difficult by the fact that we don't handle CPPFLAGS in our build > system. Well, if it makes us feel any bett

[PATCH] NEWS: a bunch of cli news since 0.15

2013-05-26 Thread Jani Nikula
--- NEWS | 31 +++ 1 file changed, 31 insertions(+) diff --git a/NEWS b/NEWS index 8545913..a7f2ec6 100644 --- a/NEWS +++ b/NEWS @@ -4,6 +4,37 @@ Notmuch 0.16 (2013-MM-DD) Command-Line Interface -- +Decrypting commands explicitly expect a gpg-a

[PATCH 6/6] man: document notmuch count --output=files

2013-05-26 Thread David Bremner
Other than the bikeshed about starting from zero instead of one, and not being completely happy with the option name --duplicate (but not being inspired to suggest a better one), this series looks OK to me. It seems like it would be quite useful to query based on the number of duplicates, but tha

[PATCH 1/6] cli: add --duplicate=N option to notmuch search

2013-05-26 Thread David Bremner
Jani Nikula writes: > Effective with --output=files, output the Nth filename associated with > each message matching the query (N is 0-based). If N is equal to or > greater than the number of files associated with the message, don't > print anything. I guess this is a proverbial bikeshed, but 1

[PATCH v2] build: fix out-of-tree builds

2013-05-26 Thread David Bremner
Jani Nikula writes: > > Out-of-tree 'make test' has been broken since earlier than the above, > and remains broken, as does out-of-tree perf test, but at least the > build now works. pushed, d

[PATCH] emacs: add show view bindings to move to previous/next thread

2013-05-26 Thread David Bremner
Mark Walters writes: > From: Jani Nikula > > We have most of the plumbing in place, add the bindings M-n and M-p. pushed, d

[PATCH v2] emacs: Don't override mm-show-part in notmuch-show-view-part

2013-05-26 Thread David Bremner
Austin Clements writes: > > This patch removes the mm-show-part override in favor of passing the > file name in to mm-show-part the way it expects, so we get its default Pushed, d

[PATCH] NEWS: a bunch of cli news since 0.15

2013-05-26 Thread David Bremner
Jani Nikula writes: > --- > NEWS | 31 +++ > 1 file changed, 31 insertions(+) pushed, d

[PATCH] cli: remove unused argument descriptions

2013-05-26 Thread Tomi Ollila
On Sat, May 25 2013, Jani Nikula wrote: > Clean up leftovers from help system rework. These are no longer > needed. They are easy to resurrect and update if a need later arises. > --- +1 Tomi > notmuch.c | 13 - > 1 file changed, 13 deletions(-) > > diff --git a/notmuch.c b/not

Re: [PATCH 6/6] man: document notmuch count --output=files

2013-05-26 Thread David Bremner
Other than the bikeshed about starting from zero instead of one, and not being completely happy with the option name --duplicate (but not being inspired to suggest a better one), this series looks OK to me. It seems like it would be quite useful to query based on the number of duplicates, but tha

Re: [PATCH 1/6] cli: add --duplicate=N option to notmuch search

2013-05-26 Thread David Bremner
Jani Nikula writes: > Effective with --output=files, output the Nth filename associated with > each message matching the query (N is 0-based). If N is equal to or > greater than the number of files associated with the message, don't > print anything. I guess this is a proverbial bikeshed, but 1

Re: [PATCH v2] build: fix out-of-tree builds

2013-05-26 Thread David Bremner
Jani Nikula writes: > > Out-of-tree 'make test' has been broken since earlier than the above, > and remains broken, as does out-of-tree perf test, but at least the > build now works. pushed, d ___ notmuch mailing list notmuch@notmuchmail.org http://not

Re: [PATCH] emacs: add show view bindings to move to previous/next thread

2013-05-26 Thread David Bremner
Mark Walters writes: > From: Jani Nikula > > We have most of the plumbing in place, add the bindings M-n and M-p. pushed, d ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH v2] emacs: Don't override mm-show-part in notmuch-show-view-part

2013-05-26 Thread David Bremner
Austin Clements writes: > > This patch removes the mm-show-part override in favor of passing the > file name in to mm-show-part the way it expects, so we get its default Pushed, d ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org

Re: [PATCH] NEWS: a bunch of cli news since 0.15

2013-05-26 Thread David Bremner
Jani Nikula writes: > --- > NEWS | 31 +++ > 1 file changed, 31 insertions(+) pushed, d ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

[PATCH v2] build: fix out-of-tree builds

2013-05-26 Thread Tomi Ollila
On Sat, May 25 2013, Jani Nikula wrote: > Support for out-of-tree builds was added in > commit 3e4a9d60a9419621b08c647a306843d76c47c2cb > Author: Carl Worth > Date: Wed Mar 9 15:02:42 2011 -0800 > > build: Add support for non-source-directory builds. > > and broken in > commit 7beeb8c88a01

Re: handle CPPFLAGS in configure and make

2013-05-26 Thread Tomi Ollila
On Sun, May 26 2013, da...@tethera.net wrote: > I wanted to enable hardening flags in the debian build (I guess other > distros will want to do the same); I realized this is made more > difficult by the fact that we don't handle CPPFLAGS in our build > system. Well, if it makes us feel any better,

[PATCH] NEWS: a bunch of cli news since 0.15

2013-05-26 Thread Jani Nikula
--- NEWS | 31 +++ 1 file changed, 31 insertions(+) diff --git a/NEWS b/NEWS index 8545913..a7f2ec6 100644 --- a/NEWS +++ b/NEWS @@ -4,6 +4,37 @@ Notmuch 0.16 (2013-MM-DD) Command-Line Interface -- +Decrypting commands explicitly expect a gpg-

[PATCH v2 4/4] NEWS: added information about new --stderr=FILE global option

2013-05-26 Thread Tomi Ollila
--- NEWS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/NEWS b/NEWS index 8545913..c04f6bb 100644 --- a/NEWS +++ b/NEWS @@ -18,6 +18,12 @@ Bash command-line completion `notmuch config`. The new completion support depends on the bash-completion package. +New global option `--stder

[PATCH v2 3/4] man: documented --stderr=FILE in notmuch.1 manual page

2013-05-26 Thread Tomi Ollila
--- man/man1/notmuch.1 | 7 +++ 1 file changed, 7 insertions(+) diff --git a/man/man1/notmuch.1 b/man/man1/notmuch.1 index 033cc10..fbd575a 100644 --- a/man/man1/notmuch.1 +++ b/man/man1/notmuch.1 @@ -76,7 +76,14 @@ Print the installed version of notmuch, and exit. Specify the configuration

[PATCH v2 2/4] test: added --stderr=FILE tests

2013-05-26 Thread Tomi Ollila
--stderr=FILE tests were added to test/help-test as it is the one doing most global option testing. Also, it was simplest to test this new option using `notmuch help` command. --- test/help-test | 9 + 1 file changed, 9 insertions(+) diff --git a/test/help-test b/test/help-test index f7df

[PATCH v2 1/4] cli: add global option --stderr=FILE

2013-05-26 Thread Tomi Ollila
With this option all writes to stderr are redirected to the spesified FILE (or to stdout on case FILE is '-'). This is immediately useful in emacs interface as some of its exec intefaces do not provide separation of stdout and stderr. --- notmuch-client.h | 1 + notmuch.c| 32

v2 of --stderr=FILE patches

2013-05-26 Thread Tomi Ollila
This is version 2 of id:1369332362-4719-1-git-send-email-tomi.ollila at iki.fi NEWS | 6 ++ man/man1/notmuch.1 | 7 +++ notmuch-client.h | 1 + notmuch.c | 32 test/help-test | 9 + 5 files changed, 55 insertions(+)

[PATCH v2] emacs: Don't override mm-show-part in notmuch-show-view-part

2013-05-26 Thread Tomi Ollila
On Sun, May 26 2013, Austin Clements wrote: > Previously, notmuch-show-view-part overrode the function binding of > mm-show-part to redirect it to notmuch-show-save-part to get notmuch's > default file name handling in case mm-display-part decided to fall > back to saving the part. In addition t

The Python bindings are now back on PyPI

2013-05-26 Thread Julian Berman
-- next part -- An HTML attachment was scrubbed... URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20130526/57ca14e4/attachment.html>

Re: [PATCH] cli: remove unused argument descriptions

2013-05-26 Thread Tomi Ollila
On Sat, May 25 2013, Jani Nikula wrote: > Clean up leftovers from help system rework. These are no longer > needed. They are easy to resurrect and update if a need later arises. > --- +1 Tomi > notmuch.c | 13 - > 1 file changed, 13 deletions(-) > > diff --git a/notmuch.c b/not

[PATCH v2 3/3] emacs: show: implement lazy hidden part handling

2013-05-26 Thread Mark Walters
This adds the actual code to do the lazy insertion of hidden parts. We use a memory inefficient but simple method: when we come to insert the part if it is hidden we just store all of the arguments to the part insertion function as a button property. This means when we want to show the part we can

[PATCH v2 2/3] emacs: show: move the insertion of the header button to the top level

2013-05-26 Thread Mark Walters
Previously each of the part insertion handlers inserted the part button themselves. Move this up into notmuch-show-insert-bodypart. Since a small number of the handlers modify the button (the encryption/signature ones) we need to pass the header button as an argument into the individual part insert

[PATCH v2 1/3] emacs: show: fake wash parts are handled at insert-bodypart level

2013-05-26 Thread Mark Walters
Earlier patches have moved the handling of wash fake inline patch parts to insert-bodypart so we can drop the function notmuch-show-insert-part-inline-patch-fake-part --- emacs/notmuch-show.el |4 1 files changed, 0 insertions(+), 4 deletions(-) diff --git a/emacs/notmuch-show.el b/emacs

[PATCH v2 0/3] emacs: show: lazy handling of hidden parts

2013-05-26 Thread Mark Walters
This is a slightly tweaked version of id:1367672478-12247-1-git-send-email-markwalters1009 at gmail.com minus the first two patches which have already been pushed. The second patch of the previous series obsoleted the handler notmuch-show-insert-part-inline-patch-fake-part so we remove that and we

[PATCH v2] emacs: Don't override mm-show-part in notmuch-show-view-part

2013-05-26 Thread Mark Walters
LGTM +1 This does not rely on the followup Austin mentioned in id:20130526063627.GQ5999 at mit.edu is so I think this should go in as is as it fixes the flet thing without changing the behaviour. Best wishes Mark On Sun, 26 May 2013, Austin Clements wrote: > Previously, notmuch-show-view-par

[PATCH 2/2] contrib: pick: fix refresh result

2013-05-26 Thread Mark Walters
The function notmuch-pick-refresh-result (used to update tag changes) was not quite correct: sometimes it got the choice between the subject and " ..." wrong. This was always true but the new code often calls this (when opening a message in the message pane to remove the unread tag) while the async

[PATCH 1/2] contrib: pick: remove hack notmuch-pick-show-match-message-with-wait

2013-05-26 Thread Mark Walters
This function was a horrible hack (sleeping while waiting for the correct message). The new target code can just open the message in the message window when it arrives. --- contrib/notmuch-pick/notmuch-pick.el | 37 +++--- 1 files changed, 12 insertions(+), 25 deletio

[PATCH 0/2] Contrib: Pick: Remove horrible hack

2013-05-26 Thread Mark Walters
Pick used to have one horrible hack: if the user asked it to open the first matching message it had to check whether that had arrived (as the search is asynchronous) and if not wait and try again. Now the opening of the first matching message is called via the pick process filter this hack can be r

[PATCH] contrib: pick: if no target specified go to first matching message

2013-05-26 Thread Mark Walters
--- Now that all the plumbing (id:1357814477-1348-1-git-send-email-markwalters1009 at gmail.com) is in place this is easy. Best wishes Mark contrib/notmuch-pick/notmuch-pick.el |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/contrib/notmuch-pick/notmuch-pick.el b

Re: [PATCH v2] build: fix out-of-tree builds

2013-05-26 Thread Tomi Ollila
On Sat, May 25 2013, Jani Nikula wrote: > Support for out-of-tree builds was added in > commit 3e4a9d60a9419621b08c647a306843d76c47c2cb > Author: Carl Worth > Date: Wed Mar 9 15:02:42 2011 -0800 > > build: Add support for non-source-directory builds. > > and broken in > commit 7beeb8c88a01

[PATCH] emacs: Don't override mm-show-part in notmuch-show-view-part

2013-05-26 Thread Austin Clements
Quoth Mark Walters on May 21 at 8:13 pm: > > On Tue, 21 May 2013, Mark Walters wrote: > > Hi > > > >> Previously, notmuch-show-view-part overrode the function binding of > >> mm-show-part to redirect it to notmuch-show-save-part to get notmuch's > >> default file name handling in case mm-display

[PATCH v2] emacs: Don't override mm-show-part in notmuch-show-view-part

2013-05-26 Thread Austin Clements
Previously, notmuch-show-view-part overrode the function binding of mm-show-part to redirect it to notmuch-show-save-part to get notmuch's default file name handling in case mm-display-part decided to fall back to saving the part. In addition to being messy, this depended on the now-deprecated dyn

[PATCH v2 2/4] test: added --stderr=FILE tests

2013-05-26 Thread Tomi Ollila
--stderr=FILE tests were added to test/help-test as it is the one doing most global option testing. Also, it was simplest to test this new option using `notmuch help` command. --- test/help-test | 9 + 1 file changed, 9 insertions(+) diff --git a/test/help-test b/test/help-test index f7df

[PATCH v2 4/4] NEWS: added information about new --stderr=FILE global option

2013-05-26 Thread Tomi Ollila
--- NEWS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/NEWS b/NEWS index 8545913..c04f6bb 100644 --- a/NEWS +++ b/NEWS @@ -18,6 +18,12 @@ Bash command-line completion `notmuch config`. The new completion support depends on the bash-completion package. +New global option `--stde

[PATCH v2 3/4] man: documented --stderr=FILE in notmuch.1 manual page

2013-05-26 Thread Tomi Ollila
--- man/man1/notmuch.1 | 7 +++ 1 file changed, 7 insertions(+) diff --git a/man/man1/notmuch.1 b/man/man1/notmuch.1 index 033cc10..fbd575a 100644 --- a/man/man1/notmuch.1 +++ b/man/man1/notmuch.1 @@ -76,7 +76,14 @@ Print the installed version of notmuch, and exit. Specify the configuratio

v2 of --stderr=FILE patches

2013-05-26 Thread Tomi Ollila
This is version 2 of id:1369332362-4719-1-git-send-email-tomi.oll...@iki.fi NEWS | 6 ++ man/man1/notmuch.1 | 7 +++ notmuch-client.h | 1 + notmuch.c | 32 test/help-test | 9 + 5 files changed, 55 insertions(+) d

[PATCH v2 1/4] cli: add global option --stderr=FILE

2013-05-26 Thread Tomi Ollila
With this option all writes to stderr are redirected to the spesified FILE (or to stdout on case FILE is '-'). This is immediately useful in emacs interface as some of its exec intefaces do not provide separation of stdout and stderr. --- notmuch-client.h | 1 + notmuch.c| 32

[PATCH v2 2/3] emacs: show: move the insertion of the header button to the top level

2013-05-26 Thread Mark Walters
Previously each of the part insertion handlers inserted the part button themselves. Move this up into notmuch-show-insert-bodypart. Since a small number of the handlers modify the button (the encryption/signature ones) we need to pass the header button as an argument into the individual part insert

[PATCH v2 3/3] emacs: show: implement lazy hidden part handling

2013-05-26 Thread Mark Walters
This adds the actual code to do the lazy insertion of hidden parts. We use a memory inefficient but simple method: when we come to insert the part if it is hidden we just store all of the arguments to the part insertion function as a button property. This means when we want to show the part we can

[PATCH v2 0/3] emacs: show: lazy handling of hidden parts

2013-05-26 Thread Mark Walters
This is a slightly tweaked version of id:1367672478-12247-1-git-send-email-markwalters1...@gmail.com minus the first two patches which have already been pushed. The second patch of the previous series obsoleted the handler notmuch-show-insert-part-inline-patch-fake-part so we remove that and we up

[PATCH v2 1/3] emacs: show: fake wash parts are handled at insert-bodypart level

2013-05-26 Thread Mark Walters
Earlier patches have moved the handling of wash fake inline patch parts to insert-bodypart so we can drop the function notmuch-show-insert-part-inline-patch-fake-part --- emacs/notmuch-show.el |4 1 files changed, 0 insertions(+), 4 deletions(-) diff --git a/emacs/notmuch-show.el b/emacs

Re: [PATCH v2] emacs: Don't override mm-show-part in notmuch-show-view-part

2013-05-26 Thread Tomi Ollila
On Sun, May 26 2013, Austin Clements wrote: > Previously, notmuch-show-view-part overrode the function binding of > mm-show-part to redirect it to notmuch-show-save-part to get notmuch's > default file name handling in case mm-display-part decided to fall > back to saving the part. In addition t

Re: [PATCH v2] emacs: Don't override mm-show-part in notmuch-show-view-part

2013-05-26 Thread Mark Walters
LGTM +1 This does not rely on the followup Austin mentioned in id:20130526063627.gq5...@mit.edu is so I think this should go in as is as it fixes the flet thing without changing the behaviour. Best wishes Mark On Sun, 26 May 2013, Austin Clements wrote: > Previously, notmuch-show-view-part o