[PATCH 1/1] devel/release-checks.sh: check NOTMUCH_(MAJOR|MINOR|MICRO)_VERSION

Tomi Ollila writes: > New defines NOTMUCH_MAJOR_VERSION, NOTMUCH_MINOR_VERSION and > NOTMUCH_MICRO_VERSION were added to lib/notmuch.h. > Check that these match the current value defined in ./version. This seems OK to me. And in worse case it can't break anything too important. d

[PATCH v2 00/11] Fix search tagging races

Austin Clements writes: > This is v2 of id:1381185201-25197-1-git-send-email-amdragon at mit.edu. > It fixes several comments from Mark and Jani. This has been rebased > on top of the tag completion changes, so doing * from a large search > buffer will no longer crash. Hence, this series

[PATCH 1/1] devel/release-checks.sh: check NOTMUCH_(MAJOR|MINOR|MICRO)_VERSION

New defines NOTMUCH_MAJOR_VERSION, NOTMUCH_MINOR_VERSION and NOTMUCH_MICRO_VERSION were added to lib/notmuch.h. Check that these match the current value defined in ./version. --- devel/release-checks.sh | 36 1 file changed, 36 insertions(+) diff --git

[PATCH v3 7/7] emacs: help: base-keymap-test-help

Add an argument to notmuch-help for the mode to display help for. This aids testing of the base-keymap case in remapping in emacs help. It is only intended for testing, ie not for master (but it does no harm) --- emacs/notmuch-lib.el |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)

[PATCH v3 6/7] emacs: tree: use remap for the over-ridden global bindings

Following a suggestion by Austin in id:20130915153642.GY1426 at mit.edu we use remap for the over-riding bindings in pick. This means that if the user modifies the global keymap these modifications will happen in the tree-view versions of them too. [tree-view overrides these to do things like

[PATCH v3 5/7] emacs: help: add a special function to deal with remaps

remaps are a rather unusual keymap consisting of "first key" 'remap and then "second-key" the remapped-function. Thus we do the documentation for it separately. --- emacs/notmuch-lib.el | 22 -- 1 files changed, 20 insertions(+), 2 deletions(-) diff --git

[PATCH v3 4/7] emacs: help: add base-keymap

To support key remapping in emacs help we need to know the base keymap when looking at the remapping. keep track of this while we recurse down the sub-keymaps in help. --- emacs/notmuch-lib.el |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/emacs/notmuch-lib.el

[PATCH v3 3/7] emacs: help: split out notmuch-describe-key as a function

The actual documentation function notmuch-describe-keymap was getting rather complicated so split out the code for a single key into its own function notmuch-describe-key. --- emacs/notmuch-lib.el | 42 +- 1 files changed, 25 insertions(+), 17

[PATCH v3 2/7] emacs: help: remove duplicate bindings

If the user (or a mode) overrides a keybinding from the common keymap in one of the modes then both help lines appear in the help screen even though only one of them is applicable. Fix this by checking if we already have that key binding. We do this by constructing an list of (key . docstring)

[PATCH v3 1/7] emacs: help: check for nil key binding

A standard way to unset a key binding is local-unset-key which is equivalent to (define-key (current-local-map) key nil) Currently notmuch-help gives an error and fails if a user has done this. To fix this we only add a help line if the binding is non-nil. --- emacs/notmuch-lib.el |2 +-

[PATCH v3 0/7] emacs: help: remap keybindings

This is version 3 of the series. v2 is at id:1383870096-14627-1-git-send-email-markwalters1009 at gmail.com The changes are in response to Austin's review of v2. I have not changed notmuch-describe-key. The other change is to add a base-keymap to look up the remapped commands in (since

[PATCH v3 0/7] emacs: help: remap keybindings

LGTM. Quoth Mark Walters on Nov 08 at 5:40 pm: > This is version 3 of the series. v2 is at > id:1383870096-14627-1-git-send-email-markwalters1009 at gmail.com > > The changes are in response to Austin's review of v2. I have not > changed notmuch-describe-key. > > The other change is to add a

[PATCH 21/21] vim: add help file

Felipe Contreras writes: > > You can probably check that it's working with this: > % vim -c ":h notmuch" It turns I needed to re-run "vim-addon-manager install notmuch" This might be a bit debian specific, but it's already documented as needed for the initial install. It would probably be

[PATCH 21/21] vim: add help file

On Fri, Nov 8, 2013 at 12:03 PM, David Bremner wrote: > Felipe Contreras writes: >> >> You can probably check that it's working with this: >> % vim -c ":h notmuch" > > It turns I needed to re-run > >"vim-addon-manager install notmuch" > > This might be a bit debian specific, but it's already

[PATCH 21/21] vim: add help file

Felipe Contreras writes: > Signed-off-by: Felipe Contreras > --- > debian/notmuch-vim.dirs| 1 + > debian/notmuch-vim.install | 1 + > vim/Makefile | 1 + > vim/notmuch.txt| 153 > + > vim/notmuch.yaml |

[PATCH 21/21] vim: add help file

On Fri, Nov 8, 2013 at 6:43 AM, David Bremner wrote: > Felipe Contreras writes: > >> Signed-off-by: Felipe Contreras >> --- >> debian/notmuch-vim.dirs| 1 + >> debian/notmuch-vim.install | 1 + >> vim/Makefile | 1 + >> vim/notmuch.txt| 153 >>

[PATCH v2 5/5] emacs: tree: use remap for the over-ridden global bindings

Following a suggestion by Austin in id:20130915153642.GY1426 at mit.edu we use remap for the over-riding bindings in pick. This means that if the user modifies the global keymap these modifications will happen in the tree-view versions of them too. [tree-view overrides these to do things like

[PATCH v2 4/5] emacs: help: add a special function to deal with remaps

remaps are a rather unusual keymap consisting of "first key" 'remap and then "second-key" the remapped-function. Thus we do the documentation for it separately. --- emacs/notmuch-lib.el | 25 ++--- 1 files changed, 22 insertions(+), 3 deletions(-) diff --git

[PATCH v2 3/5] emacs: help: split out notmuch-describe-key as a function

The actual documentation function notmuch-describe-keymap was getting rather complicated so split out the code for a single key into its own function notmuch-describe-key. --- emacs/notmuch-lib.el | 42 +- 1 files changed, 25 insertions(+), 17

[PATCH v2 2/5] emacs: help: remove duplicate bindings

If the user (or a mode) overrides a keybinding from the common keymap in one of the modes then both help lines appear in the help screen even though only one of the is applicable. Fix this by checking if we already have that key binding. We do this by constructing an list of (key . docstring)

[PATCH v2 1/5] emacs: help: check for nil key binding

A standard way to unset a key binding is local-unset-key which is equivalent to (define-key (current-local-map) key nil) Currently notmuch-help gives an error and fails if a user has done this. To fix this we only add a help line if the binding is non-nil. --- emacs/notmuch-lib.el |2 +-

[PATCH v2 0/5] emacs: help: and remap keybindings

This is version 2 of the series id:1382821479-23384-1-git-send-email-markwalters1009 at gmail.com It fixes most of the comments Austin raised in his review. The first patch is now trivial and fixes a bug with unset keys in help. (This is Austin's solution which is obviously better than mine

Re: [PATCH 21/21] vim: add help file

Felipe Contreras felipe.contre...@gmail.com writes: Signed-off-by: Felipe Contreras felipe.contre...@gmail.com --- debian/notmuch-vim.dirs| 1 + debian/notmuch-vim.install | 1 + vim/Makefile | 1 + vim/notmuch.txt| 153

Re: [PATCH 21/21] vim: add help file

On Fri, Nov 8, 2013 at 6:43 AM, David Bremner da...@tethera.net wrote: Felipe Contreras felipe.contre...@gmail.com writes: Signed-off-by: Felipe Contreras felipe.contre...@gmail.com --- debian/notmuch-vim.dirs| 1 + debian/notmuch-vim.install | 1 + vim/Makefile | 1

[PATCH 1/1] devel/release-checks.sh: check NOTMUCH_(MAJOR|MINOR|MICRO)_VERSION

New defines NOTMUCH_MAJOR_VERSION, NOTMUCH_MINOR_VERSION and NOTMUCH_MICRO_VERSION were added to lib/notmuch.h. Check that these match the current value defined in ./version. --- devel/release-checks.sh | 36 1 file changed, 36 insertions(+) diff --git

[PATCH v3 3/7] emacs: help: split out notmuch-describe-key as a function

The actual documentation function notmuch-describe-keymap was getting rather complicated so split out the code for a single key into its own function notmuch-describe-key. --- emacs/notmuch-lib.el | 42 +- 1 files changed, 25 insertions(+), 17

[PATCH v3 1/7] emacs: help: check for nil key binding

A standard way to unset a key binding is local-unset-key which is equivalent to (define-key (current-local-map) key nil) Currently notmuch-help gives an error and fails if a user has done this. To fix this we only add a help line if the binding is non-nil. --- emacs/notmuch-lib.el |2 +-

[PATCH v3 2/7] emacs: help: remove duplicate bindings

If the user (or a mode) overrides a keybinding from the common keymap in one of the modes then both help lines appear in the help screen even though only one of them is applicable. Fix this by checking if we already have that key binding. We do this by constructing an list of (key . docstring)

[PATCH v3 4/7] emacs: help: add base-keymap

To support key remapping in emacs help we need to know the base keymap when looking at the remapping. keep track of this while we recurse down the sub-keymaps in help. --- emacs/notmuch-lib.el |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/emacs/notmuch-lib.el

[PATCH v3 7/7] emacs: help: base-keymap-test-help

Add an argument to notmuch-help for the mode to display help for. This aids testing of the base-keymap case in remapping in emacs help. It is only intended for testing, ie not for master (but it does no harm) --- emacs/notmuch-lib.el |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)

[PATCH v3 5/7] emacs: help: add a special function to deal with remaps

remaps are a rather unusual keymap consisting of first key 'remap and then second-key the remapped-function. Thus we do the documentation for it separately. --- emacs/notmuch-lib.el | 22 -- 1 files changed, 20 insertions(+), 2 deletions(-) diff --git a/emacs/notmuch-lib.el

Re: [PATCH 21/21] vim: add help file

Felipe Contreras felipe.contre...@gmail.com writes: You can probably check that it's working with this: % vim -c :h notmuch It turns I needed to re-run vim-addon-manager install notmuch This might be a bit debian specific, but it's already documented as needed for the initial install. It

Re: [PATCH 21/21] vim: add help file

On Fri, Nov 8, 2013 at 12:03 PM, David Bremner da...@tethera.net wrote: Felipe Contreras felipe.contre...@gmail.com writes: You can probably check that it's working with this: % vim -c :h notmuch It turns I needed to re-run vim-addon-manager install notmuch This might be a bit debian

Re: [PATCH v3 0/7] emacs: help: remap keybindings

LGTM. Quoth Mark Walters on Nov 08 at 5:40 pm: This is version 3 of the series. v2 is at id:1383870096-14627-1-git-send-email-markwalters1...@gmail.com The changes are in response to Austin's review of v2. I have not changed notmuch-describe-key. The other change is to add a base-keymap

Re: [PATCH 21/21] vim: add help file

Felipe Contreras felipe.contre...@gmail.com writes: On Fri, Nov 8, 2013 at 12:03 PM, David Bremner da...@tethera.net wrote: This might be a bit debian specific, but it's already documented as needed for the initial install. It would probably be worth updating debian/notmuch-vim.README.Debian

RPM repository for Fedora on copr

Hi, The notmuch packages available for Fedora are rather old. So I have been building my own packages for a while. Today I discovered copr[1], so I thought others might be interested in the packages. I have based the spec on the version used for Fedora with some changes. I update the package

Re: [PATCH v2 00/11] Fix search tagging races

Austin Clements amdra...@mit.edu writes: This is v2 of id:1381185201-25197-1-git-send-email-amdra...@mit.edu. It fixes several comments from Mark and Jani. This has been rebased on top of the tag completion changes, so doing * from a large search buffer will no longer crash. Hence, this

Re: [PATCH 1/1] devel/release-checks.sh: check NOTMUCH_(MAJOR|MINOR|MICRO)_VERSION

Tomi Ollila tomi.oll...@iki.fi writes: New defines NOTMUCH_MAJOR_VERSION, NOTMUCH_MINOR_VERSION and NOTMUCH_MICRO_VERSION were added to lib/notmuch.h. Check that these match the current value defined in ./version. This seems OK to me. And in worse case it can't break anything too important.