On Sat, Jan 04, 2014 at 09:18:15AM -0400, David Bremner wrote:
> Thomas Klausner writes:
>
> > ^
> > ./lib/notmuch-private.h:52:13: note: previous attribute is here
> > #pragma GCC visibility push(hidden)
> > ^
>
> The clang related issues might be
On Sat, Jan 04 2014, Thomas Klausner wrote:
> On Sat, Jan 04, 2014 at 02:46:37PM +0200, Jani Nikula wrote:
>> I guess we should look at realpath() compatibility, but in fairness passing
>> NULL for the second parameter is according to POSIX.1-2008, not glibc
>> extension.
>
> Ah, interesting.
>
> > ^
> >
> > and so on. I guess it is because the visibility differs between c and
> > c++. I've disabled visibility locally, see second attached patch, but
> > of course that's not a solution, just a workaround. Suggestions
> > welcome.
> >
> > Thanks,
> > Thomas
> >
> > ___
> > notmuch mailing list
> > notmuch at notmuchmail.org
> > http://notmuchmail.org/mailman/listinfo/notmuch
> >
-- next part --
An HTML attachment was scrubbed...
URL:
<http://notmuchmail.org/pipermail/notmuch/attachments/20140104/b40645a8/attachment-0001.html>
ion, just a workaround. Suggestions
> welcome.
>
> Thanks,
> Thomas
>
> ___
> notmuch mailing list
> notmuch at notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch
>
-- next part --
An HTML attachment was scrubbed...
URL:
<http://notmuchmail.org/pipermail/notmuch/attachments/20140104/c815d23e/attachment.html>
On Sat, Jan 04, 2014 at 03:06:38PM +0200, Tomi Ollila wrote:
> The linux namual page (*) has good explanation of this in the BUGS section
>
> (*) http://man7.org/linux/man-pages/man3/realpath.3.html
>
> After reading that I think fixing that is not as simple as your previous
> patch does it --
On Sat, Jan 04, 2014 at 02:46:37PM +0200, Jani Nikula wrote:
> I guess we should look at realpath() compatibility, but in fairness passing
> NULL for the second parameter is according to POSIX.1-2008, not glibc
> extension.
Ah, interesting.
I can file a bug report with NetBSD about that, but in
On Sat, Jan 04, 2014 at 02:35:54PM +0200, Jani Nikula wrote:
> For the visibility issue please upgrade Notmuch.
Thanks. It seems 0.17 came out a short time after I downloaded notmuch :)
I don't need the visibility patch with that version any longer.
Thomas
On Wed, Jan 01 2014, Jani Nikula wrote:
> v2 of id:cover.1385826040.git.jani at nikula.org
>
> Rebase, minor tweaks since v1; the TODO in the referenced message above
> is still valid. I suggest we get this merged as a starting point, so we
> can collaborate on including a nice API man page (and
Thomas Klausner writes:
> ^
> ./lib/notmuch-private.h:52:13: note: previous attribute is here
> #pragma GCC visibility push(hidden)
> ^
The clang related issues might be fixed in 0.17; can you try that (or
git master)?
> size_t length;
> -
On Wed, Jan 01 2014, Jani Nikula j...@nikula.org wrote:
v2 of id:cover.1385826040.git.j...@nikula.org
Rebase, minor tweaks since v1; the TODO in the referenced message above
is still valid. I suggest we get this merged as a starting point, so we
can collaborate on including a nice API man
Hi!
I'm currently starting to try out notmuch-0.16 on NetBSD. It went off
to a rocky start, since it segfaulted in the initial config setup.
Debugging it I found that notmuch uses a glibc extension to realpath,
allowing NULL as second argument.
I've converted it to use a prepared buffer
For the visibility issue please upgrade Notmuch.
BR,
Jani.
On Jan 4, 2014 2:26 PM, Thomas Klausner t...@giga.or.at wrote:
Hi!
I'm currently starting to try out notmuch-0.16 on NetBSD. It went off
to a rocky start, since it segfaulted in the initial config setup.
Debugging it I found that
I guess we should look at realpath() compatibility, but in fairness passing
NULL for the second parameter is according to POSIX.1-2008, not glibc
extension.
On Jan 4, 2014 2:35 PM, Jani Nikula j...@nikula.org wrote:
For the visibility issue please upgrade Notmuch.
BR,
Jani.
On Jan 4, 2014
On Sat, Jan 04, 2014 at 02:46:37PM +0200, Jani Nikula wrote:
I guess we should look at realpath() compatibility, but in fairness passing
NULL for the second parameter is according to POSIX.1-2008, not glibc
extension.
Ah, interesting.
I can file a bug report with NetBSD about that, but in the
On Sat, Jan 04, 2014 at 02:35:54PM +0200, Jani Nikula wrote:
For the visibility issue please upgrade Notmuch.
Thanks. It seems 0.17 came out a short time after I downloaded notmuch :)
I don't need the visibility patch with that version any longer.
Thomas
On Sat, Jan 04 2014, Thomas Klausner t...@giga.or.at wrote:
On Sat, Jan 04, 2014 at 02:46:37PM +0200, Jani Nikula wrote:
I guess we should look at realpath() compatibility, but in fairness passing
NULL for the second parameter is according to POSIX.1-2008, not glibc
extension.
Ah,
Thomas Klausner t...@giga.or.at writes:
^
./lib/notmuch-private.h:52:13: note: previous attribute is here
#pragma GCC visibility push(hidden)
^
The clang related issues might be fixed in 0.17; can you try that (or
git master)?
size_t length;
On Sat, Jan 04, 2014 at 03:06:38PM +0200, Tomi Ollila wrote:
The linux namual page (*) has good explanation of this in the BUGS section
(*) http://man7.org/linux/man-pages/man3/realpath.3.html
After reading that I think fixing that is not as simple as your previous
patch does it -- so
The c files in root directory not starting with 'notmuch'.
gmime-filter-reply.c used 8-character indenting and seems to
be external in this project; therefore it was left intact.
No functional change.
---
Based on the response to this patch I may submit much larger
patch which tunes the style
On Sat, Jan 04, 2014 at 09:18:15AM -0400, David Bremner wrote:
Thomas Klausner t...@giga.or.at writes:
^
./lib/notmuch-private.h:52:13: note: previous attribute is here
#pragma GCC visibility push(hidden)
^
The clang related issues might be
On Jan 5, 2014 12:38 AM, Thomas Klausner t...@giga.or.at wrote:
On Sat, Jan 04, 2014 at 09:18:15AM -0400, David Bremner wrote:
I'm not sure what the right answer is here. MATHPATHLEN (and PATH_MAX)
are not necessarily defined; in particular this would break
compilation on GNU Hurd. Perhaps
21 matches
Mail list logo
