[RFC PATCH] configure: check for POSIX.1-2008 realpath(3) implementation.

2014-01-25 Thread Tomi Ollila
Check whether realpath(3) supports the resolved_path == NULL feature, standardized in POSIX.1-2008. This is tested by executing the realpath(3) with NULL as second argument and the program is expected to SIGSEGV in case the feature is not supported. If the feature is not supported the compatibili

[PATCH] emacs: initialize ido mode in notmuch-mua.el

2014-01-25 Thread Tomi Ollila
On Sat, Jan 25 2014, David Bremner wrote: > Mark Walters writes: > >> ido-completing-read is used in notmuch-mua.el without any >> initialization. This should work but a bug (emacs bug #3247) in some >> emacs 23 versions (including 23.2.1 from Debian stable) causes emacs >> to get stuck in the

[PATCH 0/7] emacs: show tag changes in buffer

2014-01-25 Thread Jani Nikula
On Sun, 19 Jan 2014, Mark Walters wrote: > I have been running this series (with the unread and auto-updating > described above) for about a month and it seems to work well for my use. I've been running this for a while now, and I really like it. Haven't noticed any issues. I'm anticipating the f

automatic database upgrades (was: Re: [PATCH 0/7] cli: notmuch new improvements)

2014-01-25 Thread Jani Nikula
On Sat, 25 Jan 2014, Mark Walters wrote: > What about a config option? Something like > database_auto_upgrade=true/false? I wouldn't have a strong preference > which was the default (though I would choose "false" in my own > config). I guess we would need a command line --upgrade to allow people >

[PATCH] emacs: initialize ido mode in notmuch-mua.el

2014-01-25 Thread David Bremner
Tomi Ollila writes: > > How about doing it with defadvice with something like: > > (from http://comments.gmane.org/gmane.emacs.bugs/27856 one can notice > this happening with emacs 23.3 -- David can check whether 23.4 if > affected) It's fixed in 23.4 > > (if (and (= emacs-major-version 23) (<

[RFC PATCH] configure: check for POSIX.1-2008 realpath(3) implementation.

2014-01-25 Thread David Bremner
Tomi Ollila writes: > +#if POSIX_2008_REALPATH > filename = realpath (config->filename, NULL); > +#else > +/* compatibility with minor effort, not elegance, is the ruling factor > + in these (two) else branches... */ > +char resolved_path[PATH_MAX]; > +filename = realpath (c

[PATCH 0/5] lib: make folder: prefix literal

2014-01-25 Thread Jani Nikula
On Sat, 25 Jan 2014, David Bremner wrote: > Jani Nikula writes: > >> On Sat, 25 Jan 2014, Jani Nikula wrote: >>> Perhaps we need to have two prefixes, one of which is the literal >>> filesystem folder and another which hides the implementation details, >>> like I mentioned in my mail to Peter [1

[PATCH 0/7] cli: notmuch new improvements

2014-01-25 Thread Tomi Ollila
On Sun, Jan 19 2014, Jani Nikula wrote: > Here's an assortment of notmuch new fixes, non-functional cleanups, and > the oft-requested --quiet option. > > These should be pretty straightforward to review. > series LGTM. Tomi > BR, > Jani. > > > Jani Nikula (7): > cli: extract single message a

[PATCH 0/5] lib: make folder: prefix literal

2014-01-25 Thread Jani Nikula
On Sat, 25 Jan 2014, Jani Nikula wrote: > Perhaps we need to have two prefixes, one of which is the literal > filesystem folder and another which hides the implementation details, > like I mentioned in my mail to Peter [1]. But consider this: my proposed > implementation does cover *all* use cases

automatic database upgrades (was: Re: [PATCH 0/7] cli: notmuch new improvements)

2014-01-25 Thread Mark Walters
Thanks for posting this. You are quite right about it being orthogonal to this series so a clear +1 from me for the series. What about a config option? Something like database_auto_upgrade=true/false? I wouldn't have a strong preference which was the default (though I would choose "false" in my o

Re: [PATCH] emacs: initialize ido mode in notmuch-mua.el

2014-01-25 Thread David Bremner
Tomi Ollila writes: > > How about doing it with defadvice with something like: > > (from http://comments.gmane.org/gmane.emacs.bugs/27856 one can notice > this happening with emacs 23.3 -- David can check whether 23.4 if > affected) It's fixed in 23.4 > > (if (and (= emacs-major-version 23) (<

automatic database upgrades (was: Re: [PATCH 0/7] cli: notmuch new improvements)

2014-01-25 Thread Jani Nikula
On Sat, 25 Jan 2014, Mark Walters wrote: > This series LGTM. Hi Mark, thanks for the review! > I do now recall there was some discussion on irc about the automatic > database upgrade: it would be good to have that documented but the > consensus was to do it, so +1 from me. Here's some summary,

Re: [RFC PATCH] configure: check for POSIX.1-2008 realpath(3) implementation.

2014-01-25 Thread David Bremner
Tomi Ollila writes: > +#if POSIX_2008_REALPATH > filename = realpath (config->filename, NULL); > +#else > +/* compatibility with minor effort, not elegance, is the ruling factor > + in these (two) else branches... */ > +char resolved_path[PATH_MAX]; > +filename = realpath (c

Re: [PATCH 0/5] lib: make folder: prefix literal

2014-01-25 Thread Carl Worth
Jani Nikula writes: > Here's a thought. With boolean prefix folder:, we can devise a scheme > where the folder: query defines what is to be matched. I like the idea, but I tried to infer the rules from the examples, and I failed. It looks like there are two new symbols, "/" and "/." but I couldn'

mm-image-fit-p: Invalid image specification

2014-01-25 Thread David Bremner
Michal Sojka writes: > Hello, > > in emacs, I have a problem displaying an email that contain the > following part (--format=json): > > { >"content-type" : "image/svg+xml", >"filename" : "_logo.svg", >"id" : 4 > } > > I see this message "mm-image-fit-p: Invalid

[PATCH 1/1] build: write VERSION file containing $(VERSION) string

2014-01-25 Thread Tomi Ollila
This version file will be as prerequisite to the target files that use the version info for some purpose, like printing it to the user to examine. The contents of the VERSION file is seldom read by the build system itself as the $(VERSION) variable has the same information. --- Makefile.local | 11

[PATCH] emacs: initialize ido mode in notmuch-mua.el

2014-01-25 Thread David Bremner
Mark Walters writes: > ido-completing-read is used in notmuch-mua.el without any > initialization. This should work but a bug (emacs bug #3247) in some > emacs 23 versions (including 23.2.1 from Debian stable) causes emacs > to get stuck in the mini-buffer. This tests to see if ido-mode has > be

[PATCH 1/1] build: delete the default .SUFFIXES

2014-01-25 Thread Tomi Ollila
All implicit rules in notmuch Makefiles are "pattern rules"; Deleting the default suffixes (to support obsolete, old-fashioned "suffix rules") from make reduces the output of 'make -d' by 40 to 90 percent, helping e.g. debugging make problems. --- output size comparisons: full-build: script -c 'm

Re: [RFC PATCH] configure: check for POSIX.1-2008 realpath(3) implementation.

2014-01-25 Thread Tomi Ollila
On Sat, Jan 25 2014, Tomi Ollila wrote: > Check whether realpath(3) supports the resolved_path == NULL feature, > standardized in POSIX.1-2008. > > This is tested by executing the realpath(3) with NULL as second > argument and the program is expected to SIGSEGV in case the > feature is not suppor

[RFC PATCH] configure: check for POSIX.1-2008 realpath(3) implementation.

2014-01-25 Thread Tomi Ollila
Check whether realpath(3) supports the resolved_path == NULL feature, standardized in POSIX.1-2008. This is tested by executing the realpath(3) with NULL as second argument and the program is expected to SIGSEGV in case the feature is not supported. If the feature is not supported the compatibili

[PATCH 0/5] lib: make folder: prefix literal

2014-01-25 Thread Tomi Ollila
On Sat, Jan 25 2014, Jani Nikula wrote: > On Sat, 25 Jan 2014, Tomi Ollila wrote: >> On Sat, Jan 25 2014, Jani Nikula wrote: >>> Perhaps we need to have two prefixes, one of which is the literal >>> filesystem folder and another which hides the implementation details, >>> like I mentioned in my

[PATCH] lib: update documentation for notmuch_database_get_directory

2014-01-25 Thread Tomi Ollila
On Sat, Jan 25 2014, David Bremner wrote: > Clarify that using the directory after destroying the corresponding > database is not permitted. > > This is implicit in the description of notmuch_database_destroy, but > it doesn't hurt to be explicit, and we do express similar "ownership" > relations

[PATCH 2/5] test: fix insert folder: searches

2014-01-25 Thread Rob Browning
Austin Clements writes: > This is the other reason I disagree with including cur/new. If we strip > it, people's existing folder: searches will mostly continue to work. If > we include it, such saved searches, scripted searches, and post-new > hooks are guaranteed to break. What about Maildir+

Re: [PATCH] emacs: initialize ido mode in notmuch-mua.el

2014-01-25 Thread Tomi Ollila
On Sat, Jan 25 2014, David Bremner wrote: > Mark Walters writes: > >> ido-completing-read is used in notmuch-mua.el without any >> initialization. This should work but a bug (emacs bug #3247) in some >> emacs 23 versions (including 23.2.1 from Debian stable) causes emacs >> to get stuck in the

[PATCH 1/1] build: delete the default .SUFFIXES

2014-01-25 Thread David Bremner
Tomi Ollila writes: > All implicit rules in notmuch Makefiles are "pattern rules"; Deleting the > default suffixes (to support obsolete, old-fashioned "suffix rules") from > make reduces the output of 'make -d' by 40 to 90 percent, helping e.g. > debugging make problems. LGTM. d

[PATCH 0/5] lib: make folder: prefix literal

2014-01-25 Thread Jani Nikula
On Sat, 25 Jan 2014, Tomi Ollila wrote: > On Sat, Jan 25 2014, Jani Nikula wrote: >> Perhaps we need to have two prefixes, one of which is the literal >> filesystem folder and another which hides the implementation details, >> like I mentioned in my mail to Peter [1]. But consider this: my propos

[PATCH 0/5] lib: make folder: prefix literal

2014-01-25 Thread David Bremner
Jani Nikula writes: > On Sat, 25 Jan 2014, Jani Nikula wrote: >> Perhaps we need to have two prefixes, one of which is the literal >> filesystem folder and another which hides the implementation details, >> like I mentioned in my mail to Peter [1]. But consider this: my proposed >> implementatio

[PATCH 0/5] lib: make folder: prefix literal

2014-01-25 Thread Tomi Ollila
On Sat, Jan 25 2014, Jani Nikula wrote: > On Fri, 24 Jan 2014, Austin Clements wrote: >> On Thu, 09 Jan 2014, Jani Nikula wrote: >>> Hi all, this series makes the folder: search prefix literal, or switches >>> it from a probabilistic prefix to a boolean prefix. With this, you have >>> to give t

[PATCH 1/1] emacs: always write emacs/.eldeps when the target is remade

2014-01-25 Thread Tomi Ollila
So that the target is newer than its prerequisites. --- emacs/Makefile.local | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/emacs/Makefile.local b/emacs/Makefile.local index 42bfbd9..d5d402e 100644 --- a/emacs/Makefile.local +++ b/emacs/Makefile.local @@ -32,8 +32,7 @@ emacs

Re: [PATCH 2/5] test: fix insert folder: searches

2014-01-25 Thread Rob Browning
Austin Clements writes: > This is the other reason I disagree with including cur/new. If we strip > it, people's existing folder: searches will mostly continue to work. If > we include it, such saved searches, scripted searches, and post-new > hooks are guaranteed to break. What about Maildir+

Re: [PATCH 0/7] emacs: show tag changes in buffer

2014-01-25 Thread Jani Nikula
On Sun, 19 Jan 2014, Mark Walters wrote: > I have been running this series (with the unread and auto-updating > described above) for about a month and it seems to work well for my use. I've been running this for a while now, and I really like it. Haven't noticed any issues. I'm anticipating the f

[PATCH 0/5] lib: make folder: prefix literal

2014-01-25 Thread Jani Nikula
On Fri, 24 Jan 2014, Austin Clements wrote: > On Thu, 09 Jan 2014, Jani Nikula wrote: >> Hi all, this series makes the folder: search prefix literal, or switches >> it from a probabilistic prefix to a boolean prefix. With this, you have >> to give the path from the maildir root to the folder you

Re: automatic database upgrades (was: Re: [PATCH 0/7] cli: notmuch new improvements)

2014-01-25 Thread Jani Nikula
On Sat, 25 Jan 2014, Mark Walters wrote: > What about a config option? Something like > database_auto_upgrade=true/false? I wouldn't have a strong preference > which was the default (though I would choose "false" in my own > config). I guess we would need a command line --upgrade to allow people >

Re: mm-image-fit-p: Invalid image specification

2014-01-25 Thread David Bremner
Michal Sojka writes: > Hello, > > in emacs, I have a problem displaying an email that contain the > following part (--format=json): > > { >"content-type" : "image/svg+xml", >"filename" : "_logo.svg", >"id" : 4 > } > > I see this message "mm-image-fit-p: Invalid

Re: [PATCH] emacs: initialize ido mode in notmuch-mua.el

2014-01-25 Thread David Bremner
Mark Walters writes: > ido-completing-read is used in notmuch-mua.el without any > initialization. This should work but a bug (emacs bug #3247) in some > emacs 23 versions (including 23.2.1 from Debian stable) causes emacs > to get stuck in the mini-buffer. This tests to see if ido-mode has > be

Re: [PATCH 0/5] lib: make folder: prefix literal

2014-01-25 Thread Jani Nikula
On Sat, 25 Jan 2014, David Bremner wrote: > Jani Nikula writes: > >> On Sat, 25 Jan 2014, Jani Nikula wrote: >>> Perhaps we need to have two prefixes, one of which is the literal >>> filesystem folder and another which hides the implementation details, >>> like I mentioned in my mail to Peter [1

Re: automatic database upgrades (was: Re: [PATCH 0/7] cli: notmuch new improvements)

2014-01-25 Thread Mark Walters
Thanks for posting this. You are quite right about it being orthogonal to this series so a clear +1 from me for the series. What about a config option? Something like database_auto_upgrade=true/false? I wouldn't have a strong preference which was the default (though I would choose "false" in my o

Re: [PATCH 0/7] cli: notmuch new improvements

2014-01-25 Thread Tomi Ollila
On Sun, Jan 19 2014, Jani Nikula wrote: > Here's an assortment of notmuch new fixes, non-functional cleanups, and > the oft-requested --quiet option. > > These should be pretty straightforward to review. > series LGTM. Tomi > BR, > Jani. > > > Jani Nikula (7): > cli: extract single message a

Re: [PATCH 1/1] build: delete the default .SUFFIXES

2014-01-25 Thread David Bremner
Tomi Ollila writes: > All implicit rules in notmuch Makefiles are "pattern rules"; Deleting the > default suffixes (to support obsolete, old-fashioned "suffix rules") from > make reduces the output of 'make -d' by 40 to 90 percent, helping e.g. > debugging make problems. LGTM. d ___

Re: [PATCH 0/5] lib: make folder: prefix literal

2014-01-25 Thread David Bremner
Jani Nikula writes: > On Sat, 25 Jan 2014, Jani Nikula wrote: >> Perhaps we need to have two prefixes, one of which is the literal >> filesystem folder and another which hides the implementation details, >> like I mentioned in my mail to Peter [1]. But consider this: my proposed >> implementatio

[PATCH 0/7] cli: notmuch new improvements

2014-01-25 Thread Mark Walters
This series LGTM. I do now recall there was some discussion on irc about the automatic database upgrade: it would be good to have that documented but the consensus was to do it, so +1 from me. Best wishes Mark On Sun, 19 Jan 2014, Jani Nikula wrote: > Here's an assortment of notmuch new fi

Re: [PATCH 0/5] lib: make folder: prefix literal

2014-01-25 Thread Jani Nikula
On Sat, 25 Jan 2014, Jani Nikula wrote: > Perhaps we need to have two prefixes, one of which is the literal > filesystem folder and another which hides the implementation details, > like I mentioned in my mail to Peter [1]. But consider this: my proposed > implementation does cover *all* use cases

automatic database upgrades (was: Re: [PATCH 0/7] cli: notmuch new improvements)

2014-01-25 Thread Jani Nikula
On Sat, 25 Jan 2014, Mark Walters wrote: > This series LGTM. Hi Mark, thanks for the review! > I do now recall there was some discussion on irc about the automatic > database upgrade: it would be good to have that documented but the > consensus was to do it, so +1 from me. Here's some summary,

[PATCH 1/1] build: delete the default .SUFFIXES

2014-01-25 Thread Tomi Ollila
All implicit rules in notmuch Makefiles are "pattern rules"; Deleting the default suffixes (to support obsolete, old-fashioned "suffix rules") from make reduces the output of 'make -d' by 40 to 90 percent, helping e.g. debugging make problems. --- output size comparisons: full-build: script -c 'm

Re: [PATCH 0/5] lib: make folder: prefix literal

2014-01-25 Thread Tomi Ollila
On Sat, Jan 25 2014, Jani Nikula wrote: > On Sat, 25 Jan 2014, Tomi Ollila wrote: >> On Sat, Jan 25 2014, Jani Nikula wrote: >>> Perhaps we need to have two prefixes, one of which is the literal >>> filesystem folder and another which hides the implementation details, >>> like I mentioned in my

Re: [PATCH] lib: update documentation for notmuch_database_get_directory

2014-01-25 Thread Tomi Ollila
On Sat, Jan 25 2014, David Bremner wrote: > Clarify that using the directory after destroying the corresponding > database is not permitted. > > This is implicit in the description of notmuch_database_destroy, but > it doesn't hurt to be explicit, and we do express similar "ownership" > relations

Re: [PATCH 0/5] lib: make folder: prefix literal

2014-01-25 Thread Jani Nikula
On Sat, 25 Jan 2014, Tomi Ollila wrote: > On Sat, Jan 25 2014, Jani Nikula wrote: >> Perhaps we need to have two prefixes, one of which is the literal >> filesystem folder and another which hides the implementation details, >> like I mentioned in my mail to Peter [1]. But consider this: my propos

Re: [PATCH 0/5] lib: make folder: prefix literal

2014-01-25 Thread Tomi Ollila
On Sat, Jan 25 2014, Jani Nikula wrote: > On Fri, 24 Jan 2014, Austin Clements wrote: >> On Thu, 09 Jan 2014, Jani Nikula wrote: >>> Hi all, this series makes the folder: search prefix literal, or switches >>> it from a probabilistic prefix to a boolean prefix. With this, you have >>> to give t

[PATCH 1/1] emacs: always write emacs/.eldeps when the target is remade

2014-01-25 Thread Tomi Ollila
So that the target is newer than its prerequisites. --- emacs/Makefile.local | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/emacs/Makefile.local b/emacs/Makefile.local index 42bfbd9..d5d402e 100644 --- a/emacs/Makefile.local +++ b/emacs/Makefile.local @@ -32,8 +32,7 @@ emacs

Re: [PATCH 0/5] lib: make folder: prefix literal

2014-01-25 Thread Jani Nikula
On Fri, 24 Jan 2014, Austin Clements wrote: > On Thu, 09 Jan 2014, Jani Nikula wrote: >> Hi all, this series makes the folder: search prefix literal, or switches >> it from a probabilistic prefix to a boolean prefix. With this, you have >> to give the path from the maildir root to the folder you

Re: [PATCH 0/7] cli: notmuch new improvements

2014-01-25 Thread Mark Walters
This series LGTM. I do now recall there was some discussion on irc about the automatic database upgrade: it would be good to have that documented but the consensus was to do it, so +1 from me. Best wishes Mark On Sun, 19 Jan 2014, Jani Nikula wrote: > Here's an assortment of notmuch new fi