[PATCH] lib: Simplify close and codify aborting atomic section

"W. Trevor King" writes: > On Wed, Sep 24, 2014 at 09:25:20PM +0200, David Bremner wrote: >> I think the fact that you have to close the notmuch database (when >> not using begin/end atomic) to get a commit is surprising for many >> people, so it would be nice to make that clearer somehow. > >

[PATCH] lib: Simplify close and codify aborting atomic section

"W. Trevor King" writes: > > Sorry, I didn't phrase that very well. The notmuch docs (as of this > patch) explain that we don't commit if we're in an atomic block. The > Xapian docs also say that, *and* they say that if we're not in atomic > block the close *does* try to commit. I think

[PATCH] lib: Simplify close and codify aborting atomic section

"W. Trevor King" writes: > Ah, I thought the implicit flush/commit was just in our code. Since > it's also in the underlying Xapian close, then this patch looks pretty > good to me. I'd mention Xapian's explicit close in the notmuch. h > message. Xapain's docs say [1]: > > For a

[PATCH] emacs: jump: fix compile warning on emacs 23

Mark Walters writes: > notmuch-jump uses window-body-width which is not defined in emacs > 23. To get around this it does > > (unless (fboundp 'window-body-width) > ;; Compatibility for Emacs pre-24 > (defalias 'window-body-width 'window-width)) pushed, d

[PATCH v3] lib: Simplify close and codify aborting atomic section

From: Austin Clements In Xapian, closing a database implicitly aborts any outstanding transaction and commits changes. For historical reasons, notmuch_database_close had grown to almost, but not quite duplicate this behavior. Before closing the database, it would explicitly

[PATCH v2] lib: Simplify close and codify aborting atomic section

From: Austin Clements In Xapian, closing a database implicitly aborts any outstanding transaction and commits changes. For historical reasons, notmuch_database_close had grown to almost, but not quite duplicate this behavior. Before closing the database, it would explicitly

[PATCH v3] lib: Simplify close and codify aborting atomic section

crubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: OpenPGP digital signature URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20140924/b15fa880/attachment.pgp>

[PATCH v2] lib: Simplify close and codify aborting atomic section

http://www.gnupg.org). For more information, see http://en.wikipedia.org/wiki/Pretty_Good_Privacy -- next part -- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: OpenPGP digital signature URL: <http://not

[PATCH] lib: Simplify close and codify aborting atomic section

dia.org/wiki/Pretty_Good_Privacy -- next part -- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: OpenPGP digital signature URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20140924/2a98db8b/attachment.pgp>

[PATCH] lib: Simplify close and codify aborting atomic section

non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: OpenPGP digital signature URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20140924/deb58ac9/attachment.pgp>

Emacs cheat sheet ?

Olivier Berger writes: > Hi. > > I kind of remember having seen a cheat sheet for Notmuch under emacs, > but cannot find anything conclusive... > > Did I dream of it ? ;-) > Could it be you remember the screen from "?" in notmuch-search or notmuch-show mode? d

Changing sort order in notmuch-show thread view (emacs) ?

Hi. Maybe this is obvious, but I can't figure out how to change the sort order from inside a threaded view when reviewing discussions in a thread, in Emacs. Using < removes thread indentation, but then I'm not sure what the sort order is : dates or order of navigating the tree of responses ? If

[PATCH] lib: Simplify close and codify aborting atomic section

--- next part -- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: OpenPGP digital signature URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20140924/90c2af76/attachment.pgp>

Emacs cheat sheet ?

Hi. I kind of remember having seen a cheat sheet for Notmuch under emacs, but cannot find anything conclusive... Did I dream of it ? ;-) Many thanks in advance. Best regards, -- Olivier BERGER http://www-public.telecom-sudparis.eu/~berger_o/ - OpenPGP-Id: 2048R/5819D7E8 Ingenieur Recherche -

[PATCH v5] nmbug: Translate to Python

This allows us to capture stdout and stderr separately, and do other explicit subprocess manipulation without resorting to external packages. It should be compatible with Python 2.6 and later (including the 3.x series), although with 2.6 you'll need the external argparse package. Most of the

Emacs cheat sheet ?

Hi. I kind of remember having seen a cheat sheet for Notmuch under emacs, but cannot find anything conclusive... Did I dream of it ? ;-) Many thanks in advance. Best regards, -- Olivier BERGER http://www-public.telecom-sudparis.eu/~berger_o/ - OpenPGP-Id: 2048R/5819D7E8 Ingenieur Recherche -

Changing sort order in notmuch-show thread view (emacs) ?

Hi. Maybe this is obvious, but I can't figure out how to change the sort order from inside a threaded view when reviewing discussions in a thread, in Emacs. Using removes thread indentation, but then I'm not sure what the sort order is : dates or order of navigating the tree of responses ? If

[PATCH v5] nmbug: Translate to Python

This allows us to capture stdout and stderr separately, and do other explicit subprocess manipulation without resorting to external packages. It should be compatible with Python 2.6 and later (including the 3.x series), although with 2.6 you'll need the external argparse package. Most of the

Re: [PATCH] emacs: jump: fix compile warning on emacs 23

Mark Walters markwalters1...@gmail.com writes: notmuch-jump uses window-body-width which is not defined in emacs 23. To get around this it does (unless (fboundp 'window-body-width) ;; Compatibility for Emacs pre-24 (defalias 'window-body-width 'window-width)) pushed, d

Re: [PATCH] lib: Simplify close and codify aborting atomic section

W. Trevor King wk...@tremily.us writes: Ah, I thought the implicit flush/commit was just in our code. Since it's also in the underlying Xapian close, then this patch looks pretty good to me. I'd mention Xapian's explicit close in the notmuch. h message. Xapain's docs say [1]: For a

Re: [PATCH] lib: Simplify close and codify aborting atomic section

W. Trevor King wk...@tremily.us writes: Sorry, I didn't phrase that very well. The notmuch docs (as of this patch) explain that we don't commit if we're in an atomic block. The Xapian docs also say that, *and* they say that if we're not in atomic block the close *does* try to commit. I

Re: [PATCH] lib: Simplify close and codify aborting atomic section

On Wed, Sep 24, 2014 at 09:25:20PM +0200, David Bremner wrote: I think the fact that you have to close the notmuch database (when not using begin/end atomic) to get a commit is surprising for many people, so it would be nice to make that clearer somehow. It looks like Xapian is GPLv2+, so we

Re: [PATCH] lib: Simplify close and codify aborting atomic section

W. Trevor King wk...@tremily.us writes: On Wed, Sep 24, 2014 at 09:25:20PM +0200, David Bremner wrote: I think the fact that you have to close the notmuch database (when not using begin/end atomic) to get a commit is surprising for many people, so it would be nice to make that clearer

Re: [PATCH] lib: Simplify close and codify aborting atomic section

On Wed, Sep 24, 2014 at 10:13:31PM +0200, David Bremner wrote: W. Trevor King writes: I think it would be better to write our own, not because of licensing issues, but because the user of the notmuch API won't know what a xapian commit is. Between version control and databases, I feel like

Re: [PATCH v2] lib: Simplify close and codify aborting atomic section

On Wed, Sep 24, 2014 at 05:20:23PM -0400, Austin Clements wrote: diff --git a/lib/notmuch.h b/lib/notmuch.h index fe2340b..5c40c67 100644 --- a/lib/notmuch.h +++ b/lib/notmuch.h @@ -292,6 +292,11 @@ notmuch_database_open (const char *path, * notmuch_database_close can be called multiple

[PATCH v3] lib: Simplify close and codify aborting atomic section

From: Austin Clements amdra...@mit.edu In Xapian, closing a database implicitly aborts any outstanding transaction and commits changes. For historical reasons, notmuch_database_close had grown to almost, but not quite duplicate this behavior. Before closing the database, it would explicitly