[PATCH] Make patch saving in vim a little better.

PATCH LGTM. Did not find any patch that couldn't be saved. One issue: It saves the patches into $WORKDIR. It would be great if the target path could be prompted (default again to ~/.notmuch/tmp?) so no random dirs get polluted. But that isn't a regression to the previous behaviour -> no

[PATCH] VIM: Make starting in 'insert' mode for compose optional

Ian Main wrote: > I found it unusual to be started in insert mode Me too. Patch LGTM. Works as expected - thx! Franz > > Ian > --- > vim/notmuch.vim | 13 +++-- > 1 file changed, 11 insertions(+), 2 deletions(-) > > diff --git a/vim/notmuch.vim b/vim/notmuch.vim > index

[PATCH] VIM: Improve search list

LGTM Franz Ian Main wrote: > Make the width of the search name column expand/contract with the > length of the longest search name string. > > Fix syntax highlighting to make the above work right. > > Add the ability to use a blank search pattern to create a spacer > to break up searches into

[PATCH] VIM: Improve moving between messages in a thread

Ian Main wrote: > Franz Fellner wrote: > > Patch works fine for me. It also would be nice to have a "move to next > > unread message" function. > > Most beautiful would be a treeview of the thread structure. Currently > > threads are rendered as plain list, so you can't immediately see and > >

[PATCH] VIM: Make an option to save sent mail locally

Ian Main wrote: > Franz Fellner wrote: > > Why not simply use Notmuch::Database.add_message? Would save a > > system-call. > > One could easily copy the sent mail into nm_db_path/sent/cur, add it to the > > db, tag it. > > Though I don't know enough about maildir handling, but probably rubys > >

Tabulation in multiline headers

On Sat, 18 Oct 2014, Sergei Shilovsky wrote: >> Hi, Sergei. I'm not clear on where exactly you are seeing a problem >> with this tab in the subject line. Is it showing up somewhere you think >> it shouldn't? > > It is shown in e.g. `notmuch show` as well as > 'notmuch_message_get_header(m,

[PATCH] test: add simple tests for post-insert hook

Most of the existing tests for pre/post-new hook don't seem to apply. --- test/T400-hooks.sh | 18 ++ 1 file changed, 18 insertions(+) diff --git a/test/T400-hooks.sh b/test/T400-hooks.sh index 77e8569..e741211 100755 --- a/test/T400-hooks.sh +++ b/test/T400-hooks.sh @@ -30,6

[Patch v2.5 1/4] test/insert: add known broken tests for indexing failures

David Bremner writes: > Jani Nikula writes: > >> On Sat, 04 Oct 2014, David Bremner wrote: >>> These tests are written with the assumption that we want all indexing >>> failures to be considered as failures by notmuch insert. >> >> Just realized this needs a missing prereq test for gdb. >> >>

[Patch v2.5 1/4] test/insert: add known broken tests for indexing failures

Jani Nikula writes: > On Sat, 04 Oct 2014, David Bremner wrote: >> These tests are written with the assumption that we want all indexing >> failures to be considered as failures by notmuch insert. > > Just realized this needs a missing prereq test for gdb. > > BR, > Jani. oops. missed this

Tabulation in multiline headers

> Hi, Sergei. I'm not clear on where exactly you are seeing a problem > with this tab in the subject line. Is it showing up somewhere you think > it shouldn't? It is shown in e.g. `notmuch show` as well as 'notmuch_message_get_header(m, "subject")` > I'm not sure libnotmuch should be doing any

Tabulation in multiline headers

Lets consider this message: id:87r5aucoeg.fsf at servo.finestructure.net Its subject spreads over 2 lines and the 2nd line is indented with in the file: Subject: running the crypto branch [was: Re: Hiding HTML mime-parts and/or scrubbing (gmail's) HTML-based citation] The issue is

Re: [Patch v2.5 1/4] test/insert: add known broken tests for indexing failures

Jani Nikula j...@nikula.org writes: On Sat, 04 Oct 2014, David Bremner da...@tethera.net wrote: These tests are written with the assumption that we want all indexing failures to be considered as failures by notmuch insert. Just realized this needs a missing prereq test for gdb. BR, Jani.

Re: [Patch v2.5 1/4] test/insert: add known broken tests for indexing failures

David Bremner da...@tethera.net writes: Jani Nikula j...@nikula.org writes: On Sat, 04 Oct 2014, David Bremner da...@tethera.net wrote: These tests are written with the assumption that we want all indexing failures to be considered as failures by notmuch insert. Just realized this needs a

[PATCH] test: add simple tests for post-insert hook

Most of the existing tests for pre/post-new hook don't seem to apply. --- test/T400-hooks.sh | 18 ++ 1 file changed, 18 insertions(+) diff --git a/test/T400-hooks.sh b/test/T400-hooks.sh index 77e8569..e741211 100755 --- a/test/T400-hooks.sh +++ b/test/T400-hooks.sh @@ -30,6

Re: Tabulation in multiline headers

On Sat, 18 Oct 2014, Sergei Shilovsky sshilov...@gmail.com wrote: Hi, Sergei. I'm not clear on where exactly you are seeing a problem with this tab in the subject line. Is it showing up somewhere you think it shouldn't? It is shown in e.g. `notmuch show` as well as

Re: [PATCH] VIM: Make an option to save sent mail locally

Ian Main wrote: Franz Fellner wrote: Why not simply use Notmuch::Database.add_message? Would save a system-call. One could easily copy the sent mail into nm_db_path/sent/cur, add it to the db, tag it. Though I don't know enough about maildir handling, but probably rubys Mail module

Re: [PATCH] VIM: Improve moving between messages in a thread

Ian Main wrote: Franz Fellner wrote: Patch works fine for me. It also would be nice to have a move to next unread message function. Most beautiful would be a treeview of the thread structure. Currently threads are rendered as plain list, so you can't immediately see and jump to the

RE: [PATCH] VIM: Improve search list

LGTM Franz Ian Main wrote: Make the width of the search name column expand/contract with the length of the longest search name string. Fix syntax highlighting to make the above work right. Add the ability to use a blank search pattern to create a spacer to break up searches into groups.

RE: [PATCH] VIM: Make starting in 'insert' mode for compose optional

Ian Main wrote: I found it unusual to be started in insert mode Me too. Patch LGTM. Works as expected - thx! Franz Ian --- vim/notmuch.vim | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/vim/notmuch.vim b/vim/notmuch.vim index 331e930..252f16b

RE: [PATCH] Make patch saving in vim a little better.

PATCH LGTM. Did not find any patch that couldn't be saved. One issue: It saves the patches into $WORKDIR. It would be great if the target path could be prompted (default again to ~/.notmuch/tmp?) so no random dirs get polluted. But that isn't a regression to the previous behaviour - no