[PATCH] Avoid empty thread names if possible.

2014-10-28 Thread Tomi Ollila
On Tue, Oct 07 2014, Jesse Rosenthal wrote: > Currently the thread is named based on either the oldest or newest > matching message (depending on the search order). If this message has > an empty subject, though, the thread will show up with an empty > subject in the search results. (See the threa

[PATCH] test: use LDFLAGS in test/Makefile.local

2014-10-28 Thread Tomi Ollila
On Mon, Oct 20 2014, Jani Nikula wrote: > Apparently the test binaries are built with minimal LDFLAGS, only > adding dependency specific LDFLAGS as needed. However because some of > the test binaries incorporate notmuch object files, it is necessary to > use the same link flags as notmuch. For exa

[PATCH v4 0/6] notmuch search --output=sender/recipients

2014-10-28 Thread Tomi Ollila
On Mon, Oct 27 2014, Michal Sojka wrote: > Hi all, > > this is v4 of the search --output=address series. It obsoletes v3 that > starts at id:1413150093-8383-1-git-send-email-sojkam1 at fel.cvut.cz. > > It addresses most comments made by Mark Walters and others. In > addition to v3, it also implem

feature freeze for notmuch 0.19

2014-10-28 Thread David Bremner
647 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20141028/0340943d/attachment.pgp>

[PATCH] test: fix test_require_external_prereq gdb in insert test

2014-10-28 Thread David Bremner
Jani Nikula writes: >> Of course you're right that moving it forward to only skip the gdb >> requiring tests is the right thing to do, and in that setting having a >> skipped message for all 10 skipped tests is a bit ugly. OTOHO your >> version doesn't give any output at all, which seems not per

[PATCH] test: fix test_require_external_prereq gdb in insert test

2014-10-28 Thread Jani Nikula
On Tue, 28 Oct 2014, David Bremner wrote: > Jani Nikula writes: > >> You need to actually check the return value. Limit the missing deps >> part to subtests requiring gdb. > > For me, on a system without gdb, the current version looks like > > T070-insert: Testing "notmuch insert" > missing prer

[PATCH] emacs: add stash support for git send-email command line

2014-10-28 Thread Jani Nikula
Stash From/To/Cc as --to/--to/--cc, respectively, and Message-Id as --in-reply-to, suitable for pasting to git send-email command line. --- emacs/notmuch-show.el | 25 + 1 file changed, 25 insertions(+) diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el index a9974

[PATCH] test: fix test_require_external_prereq gdb in insert test

2014-10-28 Thread Jani Nikula
You need to actually check the return value. Limit the missing deps part to subtests requiring gdb. --- test/T070-insert.sh | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/test/T070-insert.sh b/test/T070-insert.sh index 168345c9897b..b21609833228 100755 --- a/test/T070-in

[PATCH] Avoid empty thread names if possible.

2014-10-28 Thread Jani Nikula
On Wed, 08 Oct 2014, Sergei Shilovsky wrote: > I would also suggest to drop subjects consisting of only "Re:" and > "Fwd" sequences I think it's okay to avoid empty thread names at the lib level; however I think any further processing should be done near the user interface. BR, Jani.

[PATCH] test: add simple tests for post-insert hook

2014-10-28 Thread David Bremner
Jani Nikula writes: > > I presume the two lines above... > >> +notmuch insert < "$gen_msg_filename" >> +echo $? > > ...and this line are leftover debug messages? Uh, yeah. I should have fixed those a while ago when Tomi pointed them out. > > Otherwise LGTM. I guess this could be expanded with a

[PATCH] lib: make notmuch_query_count_messages exact

2014-10-28 Thread Jani Nikula
On Tue, 14 Oct 2014, Jani Nikula wrote: > Our tests have expected this to be exact all along, but maybe > inaccuracies only show up with big databases. >From my IRC logs on Thu Oct 16 2014 j4ni olly: does this do what it claims? http://mid.gmane.org/1413304374-17997-1-git-send-email-jan

[PATCH] test: add simple tests for post-insert hook

2014-10-28 Thread Jani Nikula
On Sat, 18 Oct 2014, David Bremner wrote: > Most of the existing tests for pre/post-new hook don't seem to apply. > --- > test/T400-hooks.sh | 18 ++ > 1 file changed, 18 insertions(+) > > diff --git a/test/T400-hooks.sh b/test/T400-hooks.sh > index 77e8569..e741211 100755 > --- a

[PATCH] test: fix test_require_external_prereq gdb in insert test

2014-10-28 Thread David Bremner
Jani Nikula writes: > You need to actually check the return value. Limit the missing deps > part to subtests requiring gdb. For me, on a system without gdb, the current version looks like T070-insert: Testing "notmuch insert" missing prerequisites: gdb(1) SKIP all tests in T070-insert This

[RFC][PATCH v1] emacs: Improve the behaviour of the 'q' binding.

2014-10-28 Thread Jani Nikula
On Thu, 16 Oct 2014, David Edmondson wrote: > When a user hits 'q' in a notmuch buffer, kill the buffer only if > there are no other windows currently showing it. > --- > > This arose from a discussion in #notmuch. Please try it and see if you > like the new behaviour. Yes, very much, thank you.

[PATCH v3] nmbug: Add an 'init' command

2014-10-28 Thread W. Trevor King
For folks that want to start versioning a new tag-space, instead of cloning one that someone else has already started. The empty-blob hash-object call avoids errors like: $ nmbug commit error: invalid object 100644 e69de29bb2d1d6434b8b29ae775ad8c2e48c5391 for 'tags/...' fatal: git-write-tre

[PATCH v3] nmbug: Add an 'init' command

2014-10-28 Thread W. Trevor King
For folks that want to start versioning a new tag-space, instead of cloning one that someone else has already started. The empty-blob hash-object call avoids errors like: $ nmbug commit error: invalid object 100644 e69de29bb2d1d6434b8b29ae775ad8c2e48c5391 for 'tags/...' fatal: git-write-tre

Re: [PATCH] Avoid empty thread names if possible.

2014-10-28 Thread Tomi Ollila
On Tue, Oct 07 2014, Jesse Rosenthal wrote: > Currently the thread is named based on either the oldest or newest > matching message (depending on the search order). If this message has > an empty subject, though, the thread will show up with an empty > subject in the search results. (See the threa

Re: [PATCH] test: use LDFLAGS in test/Makefile.local

2014-10-28 Thread Tomi Ollila
On Mon, Oct 20 2014, Jani Nikula wrote: > Apparently the test binaries are built with minimal LDFLAGS, only > adding dependency specific LDFLAGS as needed. However because some of > the test binaries incorporate notmuch object files, it is necessary to > use the same link flags as notmuch. For exa

feature freeze for notmuch 0.19

2014-10-28 Thread David Bremner
Hi Gang; As always we have plenty of things on the go, but I think theres enough merged in since 0.18.2 (yesterday!) to make a release worthwhile. To pick a date completely at random *cough* I'd like to freeze on November 5. For those of you just joining us that means I'll merge master to release

Re: [PATCH v4 0/6] notmuch search --output=sender/recipients

2014-10-28 Thread Tomi Ollila
On Mon, Oct 27 2014, Michal Sojka wrote: > Hi all, > > this is v4 of the search --output=address series. It obsoletes v3 that > starts at id:1413150093-8383-1-git-send-email-sojk...@fel.cvut.cz. > > It addresses most comments made by Mark Walters and others. In > addition to v3, it also implement

Re: [PATCH] test: fix test_require_external_prereq gdb in insert test

2014-10-28 Thread David Bremner
Jani Nikula writes: >> Of course you're right that moving it forward to only skip the gdb >> requiring tests is the right thing to do, and in that setting having a >> skipped message for all 10 skipped tests is a bit ugly. OTOHO your >> version doesn't give any output at all, which seems not per

Re: [PATCH] test: fix test_require_external_prereq gdb in insert test

2014-10-28 Thread Jani Nikula
On Tue, 28 Oct 2014, David Bremner wrote: > Jani Nikula writes: > >> You need to actually check the return value. Limit the missing deps >> part to subtests requiring gdb. > > For me, on a system without gdb, the current version looks like > > T070-insert: Testing "notmuch insert" > missing prer

[PATCH] gitignore: ignore sh.config and doc/config.dox

2014-10-28 Thread David Bremner
pushed. d

[PATCH] cli: cast timeval fields to long for format

2014-10-28 Thread David Bremner
Jani Nikula writes: > This hides platform differences between struct timeval field types. pushed d

Re: [PATCH] test: add simple tests for post-insert hook

2014-10-28 Thread David Bremner
Jani Nikula writes: > > I presume the two lines above... > >> +notmuch insert < "$gen_msg_filename" >> +echo $? > > ...and this line are leftover debug messages? Uh, yeah. I should have fixed those a while ago when Tomi pointed them out. > > Otherwise LGTM. I guess this could be expanded with a

[PATCH] cli: cast timeval fields to long for format

2014-10-28 Thread Tomi Ollila
On Tue, Oct 28 2014, Jani Nikula wrote: > This hides platform differences between struct timeval field types. LGTM. Tomi > --- > notmuch-insert.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/notmuch-insert.c b/notmuch-insert.c > index 7074077..0d2d810 100644

Re: [PATCH] test: fix test_require_external_prereq gdb in insert test

2014-10-28 Thread David Bremner
Jani Nikula writes: > You need to actually check the return value. Limit the missing deps > part to subtests requiring gdb. For me, on a system without gdb, the current version looks like T070-insert: Testing "notmuch insert" missing prerequisites: gdb(1) SKIP all tests in T070-insert This

[PATCH] test: fix test_require_external_prereq gdb in insert test

2014-10-28 Thread Jani Nikula
You need to actually check the return value. Limit the missing deps part to subtests requiring gdb. --- test/T070-insert.sh | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/test/T070-insert.sh b/test/T070-insert.sh index 168345c9897b..b21609833228 100755 --- a/test/T070-in

Re: [PATCH] Avoid empty thread names if possible.

2014-10-28 Thread Jani Nikula
On Wed, 08 Oct 2014, Sergei Shilovsky wrote: > I would also suggest to drop subjects consisting of only "Re:" and > "Fwd" sequences I think it's okay to avoid empty thread names at the lib level; however I think any further processing should be done near the user interface. BR, Jani. __

Re: [PATCH] lib: make notmuch_query_count_messages exact

2014-10-28 Thread Jani Nikula
On Tue, 14 Oct 2014, Jani Nikula wrote: > Our tests have expected this to be exact all along, but maybe > inaccuracies only show up with big databases. >From my IRC logs on Thu Oct 16 2014 j4ni olly: does this do what it claims? http://mid.gmane.org/1413304374-17997-1-git-send-email-j..

Re: [PATCH] test: add simple tests for post-insert hook

2014-10-28 Thread Jani Nikula
On Sat, 18 Oct 2014, David Bremner wrote: > Most of the existing tests for pre/post-new hook don't seem to apply. > --- > test/T400-hooks.sh | 18 ++ > 1 file changed, 18 insertions(+) > > diff --git a/test/T400-hooks.sh b/test/T400-hooks.sh > index 77e8569..e741211 100755 > --- a

Re: [RFC][PATCH v1] emacs: Improve the behaviour of the 'q' binding.

2014-10-28 Thread Jani Nikula
On Thu, 16 Oct 2014, David Edmondson wrote: > When a user hits 'q' in a notmuch buffer, kill the buffer only if > there are no other windows currently showing it. > --- > > This arose from a discussion in #notmuch. Please try it and see if you > like the new behaviour. Yes, very much, thank you.

[PATCH] cli: cast timeval fields to long for format

2014-10-28 Thread Jani Nikula
This hides platform differences between struct timeval field types. --- notmuch-insert.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/notmuch-insert.c b/notmuch-insert.c index 7074077..0d2d810 100644 --- a/notmuch-insert.c +++ b/notmuch-insert.c @@ -197,7 +197,7 @@ tem

[PATCH] cli: cast timeval fields to long for format

2014-10-28 Thread David Edmondson
On Tue, Oct 28 2014, Jani Nikula wrote: > This hides platform differences between struct timeval field types. Good for me. Tested on Debian Testing and OS X 10.10 (which previously emitted a compiler warning). > --- > notmuch-insert.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-)

Re: [PATCH] gitignore: ignore sh.config and doc/config.dox

2014-10-28 Thread David Bremner
pushed. d ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH] cli: cast timeval fields to long for format

2014-10-28 Thread David Bremner
Jani Nikula writes: > This hides platform differences between struct timeval field types. pushed d ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH] cli: cast timeval fields to long for format

2014-10-28 Thread Tomi Ollila
On Tue, Oct 28 2014, Jani Nikula wrote: > This hides platform differences between struct timeval field types. LGTM. Tomi > --- > notmuch-insert.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/notmuch-insert.c b/notmuch-insert.c > index 7074077..0d2d810 100644

Re: [PATCH] cli: cast timeval fields to long for format

2014-10-28 Thread David Edmondson
On Tue, Oct 28 2014, Jani Nikula wrote: > This hides platform differences between struct timeval field types. Good for me. Tested on Debian Testing and OS X 10.10 (which previously emitted a compiler warning). > --- > notmuch-insert.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-)

[PATCH] cli: cast timeval fields to long for format

2014-10-28 Thread Jani Nikula
This hides platform differences between struct timeval field types. --- notmuch-insert.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/notmuch-insert.c b/notmuch-insert.c index 7074077..0d2d810 100644 --- a/notmuch-insert.c +++ b/notmuch-insert.c @@ -197,7 +197,7 @@ tem