Re: Add support for imenu

2017-05-23 Thread Damien Cassou
Jani Nikula writes: I would appreciate a commit message explaining what the patch is about, written to someone who doesn't know what imenu is, or how it could be applicable in search and show modes. done Please also look into using git send-email if possible, instead of attaching the patch

[PATCH] Add Emacs' imenu support in notmuch-show and notmuch-search

2017-05-23 Thread Damien Cassou
Emacs' major modes can facilitate navigation in their buffers by supporting Imenu. In such major modes, launching Imenu (M-x imenu) makes Emacs display a list of items (e.g., function definitions in a code buffer). Selecting an item from this list moves point to this item. This patch adds Imenu su

[PATCH] test/thread-naming: remove excess escaping from sender address.

2017-05-23 Thread David Bremner
This is another case where the behaviour of gmime-2.6 and gmime-3.0 seems to differ. It may be that we prefer the more lax parsing of the previous version, but that should be tested seperately. --- As far as I can tell, the "LOOSE" parsing in gmime-3.0 is not as loose as previous. It could well be

Re: [PATCH 2/2] exit lingering gpg agents at the end of relevant tests

2017-05-23 Thread Daniel Kahn Gillmor
On Tue 2017-05-23 21:54:25 +0300, Tomi Ollila wrote: > Since gnupg 2.1.20, gpg-agent no longer shut itself down when > $GNUPGHOME directory is removed. > > Add exit hooks to the test modules which execute `gpgconf --kill all` > > Add exit hooks to execute `gpgconf --kill all` in the modules that >

Re: [PATCH v2 00/11] Add filesize index, search, sort & emacs UI

2017-05-23 Thread Ioan-Adrian Ratiu
On Tue, 23 May 2017, Jani Nikula wrote: > On Fri, 19 May 2017, Ioan-Adrian Ratiu wrote: >> I'd like to add a feature to quickly work with mail file sizes >> because using custom scripts / external programs which parse >> maildir contents is slow, and non-intuitive, especially since >> notmuch doe

[no subject]

2017-05-23 Thread Tomi Ollila
This implementation adds add_exit_function (and rm_exit_function) which can also be used for other things in the future. Now that I did this simpler way would be to just check for existence of $GNUPGHOME for indication to exit gpg processes. If that path is taken this series can be used for futur

[PATCH 2/2] exit lingering gpg agents at the end of relevant tests

2017-05-23 Thread Tomi Ollila
Since gnupg 2.1.20, gpg-agent no longer shut itself down when $GNUPGHOME directory is removed. Add exit hooks to the test modules which execute `gpgconf --kill all` Add exit hooks to execute `gpgconf --kill all` in the modules that create $GNUPGHOME for gpg to work with. --- test/T350-crypto.sh

[PATCH 1/2] test-lib.sh: add "atexit" functionality

2017-05-23 Thread Tomi Ollila
New function at_exit_function registers given function to be called at script termination. Functions so registered are called in the reverse order of their registration; no arguments are passed. Function is called only once; re-adding with function name already registered will remove previous reg

Re: [PATCH v2 00/11] Add filesize index, search, sort & emacs UI

2017-05-23 Thread Jani Nikula
On Fri, 19 May 2017, Ioan-Adrian Ratiu wrote: > I'd like to add a feature to quickly work with mail file sizes > because using custom scripts / external programs which parse > maildir contents is slow, and non-intuitive, especially since > notmuch does incremental parsing and has such a nice emacs

Re: [PATCH v2 06/11] sprinter: add unsigned_long printer function

2017-05-23 Thread Jani Nikula
On Fri, 19 May 2017, Ioan-Adrian Ratiu wrote: > We need to output unsigned long values for message and thread > (sum of all message's) file sizes. The sprinter types should be about the types that can be represented using the format being output, i.e. JSON and S-Expressions, *not* about the C typ

Re: Add support for imenu

2017-05-23 Thread Jani Nikula
On Tue, 23 May 2017, Damien Cassou wrote: > Please find attached a patch adding imenu support in both search > and show modes. I would appreciate a commit message explaining what the patch is about, written to someone who doesn't know what imenu is, or how it could be applicable in search and sh

Add support for imenu

2017-05-23 Thread Damien Cassou
Please find attached a patch adding imenu support in both search and show modes. -- Damien Cassou http://damiencassou.seasidehosting.st "Success is the ability to go from one failure to another without losing enthusiasm." --Winston Churchill >From aa29c3e4227ad95e940a047494ef5367eaa57596 Mon Se

Re: changing behaviour of notmuch show --part=1

2017-05-23 Thread David Bremner
Daniel Kahn Gillmor writes: >> >> 2) Allow-varying-output: Consider the previous behaviour a bug, fixed by >>using gmime-3.0. This makes it hard for people to rely on, although >>how one relies on it currently since it varies by message is a >>mystery. >> >> 3) Fix the alleged bug: s

Re: [PATCH 2/2] cli/dump: don't include tags when not asked for

2017-05-23 Thread David Bremner
David Bremner writes: > Add in the analogous test for tags that is given for properties a few > lines below. > --- > notmuch-dump.c| 3 ++- > test/T610-message-property.sh | 1 - > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/notmuch-dump.c b/notmuch-dump.c >