Re: Washing GitHub emails to include inline patch?

2017-10-10 Thread William Casarin
Kyle Meyer writes: > Call M-x km/notmuch-visit-pr-in-magit in a notmuch-show buffer for a > GitHub PR, modifying km/notmuch-repo-from-message so that it returns > the full path to the local repository. Are you a wizard? That worked like magit. I changed

Re: Washing GitHub emails to include inline patch?

2017-10-10 Thread Kyle Meyer
William Casarin writes: > I now mainly review GitHub PRs via the patch fetching snippet you sent, > but there's a tedious disconnect between notmuch and magit. In the above > scenario, I would have to: > > 1. cd to the project > 2. open magit > 2. fetch > 3. checkout the

Re: Washing GitHub emails to include inline patch?

2017-10-10 Thread William Casarin
Kyle Meyer writes: > However, I personally haven't felt the need for such a command. I > pretty frequently use the command I posted earlier in this thread to > take a quick look at PRs, but, for anything aside from the simplest > changes, I want to apply the commits locally to

Public notmuch.mbox missing some messages which are tagged in nmbug

2017-10-10 Thread W. Trevor King
I was dusting off my local nmbug repository today, and noticed that some messages are tagged in the nmbug repository [1] but missing from our mbox archive [2]. Here's a list: $ nmbug status U 20170509021719.13086-2-da...@tethera.netobsolete U

[PATCH v4 08/15] index: implement notmuch_indexopts_t with try_decrypt

2017-10-10 Thread Daniel Kahn Gillmor
This is currently mostly a wrapper around _notmuch_crypto_t that keeps its internals private and doesn't expose any of the GMime API. However, non-crypto indexing options might also be added later (e.g. filters or other transformations). --- lib/add-message.cc| 9 - lib/indexopts.c

avoid double typedef

2017-10-10 Thread Daniel Kahn Gillmor
On IRC, Domo pointed out that older gcc complains when a typedef gets repeated. So i'm updating patch 8 in this series to avoid double typedefs. The rest of the series should be unchanged, so i'm avoiding re-flooding the lst with them, but i'm happy to send along a full round of v4 if folks

Re: [PATCH 0/3] nmbug:

2017-10-10 Thread Daniel Kahn Gillmor
On Tue 2017-10-10 15:49:48 -0700, W. Trevor King wrote: > Two changes and a bugfix spun off from today's IRC disussion. This series looks reasonable to me, from what little i understand of nmbug. Thanks for proposing the changes, Trevor. --dkg signature.asc Description: PGP signature

[PATCH 1/4] nmbug: Respect 'expect' in _spawn(..., wait=True)

2017-10-10 Thread W. Trevor King
Fixing a bug from 7f2cb3be (nmbug: Translate to Python, 2014-10-03). The bug had no direct impact though, because none of the wait=True callers were setting expect. Also add expected codes to the debug messages, to help log readers understand why nonzero exits are occasionally accepted. ---

[PATCH 3/4] nmbug: Auto-checkout in clone if it wouldn't clobber

2017-10-10 Thread W. Trevor King
We currently auto-checkout after pull and merge to make those more convenient. They're guarded against data-loss with a leading _insist_committed(). This commit adds the same convenience to clone, since in most cases users will have no NMBPREFIX-prefixed tags in their database when they clone.

[PATCH 2/4] nmbug: Accept failures to unset core.worktree in clone

2017-10-10 Thread W. Trevor King
Since 6311cfaf (init: do not set unnecessary core.worktree, 2016-09-25, 2.11.0 [1]), Git has no longer set core.worktree when --separate-git-dir is used. This broke clone with: $ nmbug clone http://nmbug.notmuchmail.org/git/nmbug-tags.git Cloning into '/tmp/nmbug-clone.33gg442e'...

[PATCH 0/3] nmbug:

2017-10-10 Thread W. Trevor King
Two changes and a bugfix spun off from today's IRC disussion. We probably also want to bump nmbug's __version__ to 0.3. Changes since 0.2, including the patches in this series, ordered by decreasing impact on 0.2 users: * Accept failures to unset core.worktree in clone (this series). * Use

Re: Washing GitHub emails to include inline patch?

2017-10-10 Thread Kyle Meyer
William Casarin writes: > I was wondering if you had any insight into what I'm thinking next. I > would love to view these patches via the way magit handles hunks. I > wonder if there was a way to get magit-style hunk browsing when viewing > a patch file with a series of commits.

Re: Washing GitHub emails to include inline patch?

2017-10-10 Thread William Casarin
Hey Kyle, Kyle Meyer writes: >> I wonder if it would be be possible to wash this email by downloading >> the patch and present it inline like git-send-email. This would allow me >> to review patches without having to click around the GitHub interface. >> Has anyone done this? >

Re: cleartext indexing, round 3

2017-10-10 Thread Daniel Kahn Gillmor
On Tue 2017-10-10 08:50:17 -0700, Jameson Graef Rollins wrote: > On Tue, Oct 10 2017, Daniel Kahn Gillmor wrote: >> I've also pushed this series to the "cleartext-indexing" branch at >> https://gitlab.com/dkg/notmuch for those who prefer a direct git pull. >> it is

[bug] [emacs] notmuch-show: names not shown on some mailing lists

2017-10-10 Thread William Casarin
Hey there, Here's something I've noticed in some mailing list threads in notmuch-show: https://jb55.com/s/81d7c740ef60984d.png It doesn't look like it is showing the correct name. Looking at the raw message, the From line looks like this: From: Some Person via Some-mailinglist

Re: cleartext indexing, round 3

2017-10-10 Thread Jameson Graef Rollins
On Tue, Oct 10 2017, Daniel Kahn Gillmor wrote: > I've also pushed this series to the "cleartext-indexing" branch at > https://gitlab.com/dkg/notmuch for those who prefer a direct git pull. > it is currently git commit 6f7f6847141db2f031b29c68d966fa13c3be2da5. Hey,