[PATCH 03/16] gmime-cleanup: remove obsolete gpg_path configuration option and crypto contexts

Note that we do keep ignoring the gpg_path configuration option, though, to avoid breakage of existing installations. signed-off-by: Daniel Kahn Gillmor --- mime-node.c | 16 -- notmuch-client.h| 9 notmuch-config.c| 29 --- notmuch-reply.c | 4 --

[PATCH 06/16] gmime-cleanup: simplify T355-smime.sh

GMime 3.0 and later can handle User ID as expected. signed-off-by: Daniel Kahn Gillmor --- test/T355-smime.sh | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/test/T355-smime.sh b/test/T355-smime.sh index be45e3b1..e410286b 100755 --- a/test/T355-smime.sh +++

[PATCH 14/16] gmime-cleanup: no longer need to use GMime major version during build

Signed-off-by: Daniel Kahn Gillmor --- configure | 4 1 file changed, 4 deletions(-) diff --git a/configure b/configure index 8775f6a7..0b65630e 100755 --- a/configure +++ b/configure @@ -497,7 +497,6 @@ if pkg-config --exists "gmime-3.0 > $GMIME3_MINVER"; then have_gmime=1

[PATCH 04/16] gmime-cleanup: always support session keys

Our minimum version of GMime 3.0 always supports good session key handling. signed-off-by: Daniel Kahn Gillmor --- configure | 9 - lib/built-with.c | 2 +- lib/index.cc | 4 +--- mime-node.c | 2 -- notmuch-show.c

[PATCH 11/16] gmime-cleanup: use GMime 3.0 function names

Signed-off-by: Daniel Kahn Gillmor --- lib/index.cc | 4 ++-- notmuch-reply.c| 8 notmuch-show.c | 16 util/gmime-extra.h | 4 4 files changed, 14 insertions(+), 18 deletions(-) diff --git a/lib/index.cc b/lib/index.cc index f21761d0..41822488

[PATCH 15/16] gmime-cleanup: use GMIME_MINVER instead of GMIME3_MINVER

This looks cleaner and simpler, but has no functional change. Signed-off-by: Daniel Kahn Gillmor --- configure | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/configure b/configure index 0b65630e..9140026a 100755 --- a/configure +++ b/configure @@ -489,11 +489,11 @@

[PATCH 05/16] gmime-cleanup: tests should only care about gmime 3

note that "notmuch-show for message with invalid From" is still broken in T310-emacs.sh. It would be good to debug what's going on there and try to get it fixed! signed-off-by: Daniel Kahn Gillmor --- test/T190-multipart.sh | 2 -- test/T310-emacs.sh | 2 +- test/T350-crypto.sh| 2

[PATCH 02/16] gmime-cleanup: remove GMime 2.6 variant codeblocks

signed-off-by: Daniel Kahn Gillmor --- lib/message-file.c | 42 - notmuch-show.c | 21 --- util/gmime-extra.c | 93 -- util/gmime-extra.h | 12 -- 4 files changed, 168 deletions(-) diff --git a/lib/message-file.c

[PATCH 08/16] gmime-cleanup: drop all unused GMimeCryptoContext arguments

signed-off-by: Daniel Kahn Gillmor --- lib/index.cc | 3 +-- mime-node.c| 13 + notmuch-client.h | 2 +- notmuch-insert.c | 2 +- notmuch-new.c | 2 +- notmuch-reindex.c | 2 +- notmuch.c | 2 +- util/crypto.c | 1 - util/crypto.h |

[PATCH 07/16] gmime-cleanup: drop g_mime_2_6_unref

signed-off-by: Daniel Kahn Gillmor --- lib/index.cc | 1 - notmuch-reply.c| 2 -- util/gmime-extra.h | 1 - 3 files changed, 4 deletions(-) diff --git a/lib/index.cc b/lib/index.cc index 6b6fbb8f..76830921 100644 --- a/lib/index.cc +++ b/lib/index.cc @@ -591,7 +591,6 @@

[PATCH 16/16] gmime-cleanup: strip remaining references to GMime 2.6

Comments and documentation no longer need to refer to GMime 2.6, so clean them all up. Signed-off-by: Daniel Kahn Gillmor --- INSTALL | 2 +- debian/control | 2 +- mime-node.c | 8 notmuch-reply.c | 6 -- notmuch-show.c | 2 +- 5 files changed, 7 insertions(+), 13

[PATCH 01/16] gmime-cleanup: drop unused gmime 2.6 content_type from _index_encrypted_mime_part

Signed-off-by: Daniel Kahn Gillmor --- lib/index.cc | 22 +- 1 file changed, 1 insertion(+), 21 deletions(-) diff --git a/lib/index.cc b/lib/index.cc index efd9da4c..0e98984c 100644 --- a/lib/index.cc +++ b/lib/index.cc @@ -367,7 +367,6 @@ _index_content_type

[PATCH 10/16] gmime-cleanup: use GMime 3.0 data types

Signed-off-by: Daniel Kahn Gillmor --- notmuch-reply.c| 4 ++-- notmuch-show.c | 8 util/gmime-extra.h | 11 +++ 3 files changed, 9 insertions(+), 14 deletions(-) diff --git a/notmuch-reply.c b/notmuch-reply.c index f6ec3c07..35b6645b 100644 --- a/notmuch-reply.c +++

[PATCH 12/16] gmime-cleanup: pass NULL arguments explicitly where GMime 3.0 expects it

Signed-off-by: Daniel Kahn Gillmor --- lib/message-file.c | 4 ++-- lib/thread.cc | 2 +- mime-node.c| 2 +- notmuch-reply.c| 10 +- notmuch-search.c | 4 ++-- notmuch-show.c | 4 ++-- util/gmime-extra.h | 7 --- 7 files changed, 13 insertions(+), 20

[PATCH 09/16] gmime-cleanup: drop unused gmime #defines and simplify g_mime_init ()

signed-off-by: Daniel Kahn Gillmor --- lib/database.cc| 2 +- lib/message-file.c | 2 +- notmuch.c | 2 +- util/gmime-extra.h | 7 --- 4 files changed, 3 insertions(+), 10 deletions(-) diff --git a/lib/database.cc b/lib/database.cc index d2732f5e..1753117f 100644 ---

[PATCH 13/16] gmime-cleanup: pass NULL as default GMimeParserOptions

This is a functional change, not a straight translation, because we are no longer directly invoking g_mime_parser_options_get_default(), but the GMime source has indicated that the options parameter for g_mime_parser_construct_message() is "nullable" since upstream commit

Dropping GMime 2.6 compatibility layer

This series follows David Bremner's id:20190501104643.5836-1-da...@tethera.net removal of gmime 2.6. It adopts GMime 3.0's API and idiom throughout, removing any attempt to paper over the differences between GMime 2.6 and 3.0. All tests pass. This is a nice simplification, dropping about 500

Re: [PATCH] build: drop support for gmime-2.6

"Rollins, Jameson" writes: > On Wed, May 01 2019, David Bremner wrote: >> I was thinking of a minimal change now, so it isn't blocking other >> things, and then a gradual cleanup. > > just go for it. You mean this patch, or the other more extensive patch that someone (TM) has to write? d

Re: [PATCH] build: drop support for gmime-2.6

Tomi Ollila writes: >> -# we need to have a version >= 2.6.5 to avoid a crypto bug. We need >> -# 2.6.7 for permissive "From " header handling. >> -GMIME_MINVER=2.6.7 >> GMIME3_MINVER=3.0.3 > > This series looks good, but why change GMIME_MINVER to GMIME3_MINVER ? > Both existed before, and I

Re: [PATCH] build: drop support for gmime-2.6

Daniel Kahn Gillmor writes: > On Wed 2019-05-01 07:46:43 -0300, David Bremner wrote: >> GMime 3.0 is over 2 years old now, and 2.6 has been deprecated in >> notmuch for about 1.5 years. > > I was just looking at this change myself. > > As a gmime maintainer in debian, I'd love to see it happen,

Re: [PATCH] build: drop support for gmime-2.6

On Wed 2019-05-01 07:46:43 -0300, David Bremner wrote: > GMime 3.0 is over 2 years old now, and 2.6 has been deprecated in > notmuch for about 1.5 years. I was just looking at this change myself. As a gmime maintainer in debian, I'd love to see it happen, but i think the right way to do that is

Re: [PATCH 1/2] test: notmuch show --format=raw for 4096 byte messages.

Tomi Ollila writes: > On Sun, Apr 28 2019, David Bremner wrote: > >> Rob Browning isolated a bug where files of exactly 4096 bytes generate >> errors because of a zero byte read. > > This happens to be effective test in case where FILE buffering uses 4096 > byte buffers. If it used any other

Re: [PATCH] build: drop support for gmime-2.6

On Wed, May 01 2019, David Bremner wrote: > GMime 3.0 is over 2 years old now, and 2.6 has been deprecated in > notmuch for about 1.5 years. > --- > > Thanks to Rob Browning, I realized that the gzipped-mail-file series I > have recently posted does not compile with GMime 2.6. This made me >

Re: [PATCH 1/2] test: notmuch show --format=raw for 4096 byte messages.

On Sun, Apr 28 2019, David Bremner wrote: > Rob Browning isolated a bug where files of exactly 4096 bytes generate > errors because of a zero byte read. This happens to be effective test in case where FILE buffering uses 4096 byte buffers. If it used any other size then this is null test. So

[PATCH] build: drop support for gmime-2.6

GMime 3.0 is over 2 years old now, and 2.6 has been deprecated in notmuch for about 1.5 years. --- Thanks to Rob Browning, I realized that the gzipped-mail-file series I have recently posted does not compile with GMime 2.6. This made me think that maybe it's the right time to drop support for

gmailieer -> lieer

Hi, because of Googles new stricter rules [0] for public OAuth api keys gmailieer needs to be renamed to something non-google / non-gmail´y. So say hello to `lieer`. https://github.com/gauteh/lieer There will probably be a bunch of references that need to be updated. Hopefully this will