On Sun 2019-05-26 13:54:29 -0300, David Bremner wrote:
> % uncrustify -c devel/uncrustify.cfg --replace $files
thanks for this pointer, i will experiment with it.
> If we do decide to rip off the bandage, that will cause a certain amount
> of rebasing pain for any patch series in flight; now (i.e
Protected subject lines were being emitted in reply when the cleartext
of documents was indexed. create_reply_message() was pulling the
subject line from the index, rather than pulling it from the
GMimeMessage object that it already has on hand.
This one-line fix to notmuch-reply.c solves that pr
When walking the MIME tree, if we discover that we are at the
cryptographic payload, then we would like to record at least the
Subject header of the current MIME part.
In the future, we might want to record many other headers as well, but
for now we will stick with just the Subject.
See
https://d
We want to make sure that internally-forwarded messages don't end up
"bubbling up" when they aren't actually the cryptographic payload.
Signed-off-by: Daniel Kahn Gillmor
---
test/T356-protected-headers.sh| 6
...pted-message-with-forwarded-attachment.eml | 33 +
Here we add several variant e-mail messages, some of which have
correctly-structured protected headers, and some of which do not. The
goal of the tests is to ensure that the right protected subjects get
reported.
Signed-off-by: Daniel Kahn Gillmor
---
test/T356-protected-headers.sh
Make sure that we emit the correct cryptographic envelope status for
cleartext signed messages.
Signed-off-by: Daniel Kahn Gillmor
---
test/T356-protected-headers.sh| 11 ++-
.../signed-protected-header.eml | 29 +++
.../protected-headers/simple-
Adding another test to ensure that we handle protected headers
gracefully when no external subject is present.
Signed-off-by: Daniel Kahn Gillmor
---
test/T356-protected-headers.sh| 6
.../subjectless-protected-header.eml | 29 +++
2 files changed,
These tests are currently broken! When a protected subject is indexed
in the clear, it leaks in the reply headers :(
For emacs, we set up separate tests for when the protected header is
indexed in the clear and when it is unindexed. neither case should
leak, but the former wasn't tested yet.
We
Now that we can decrypt headers, we want to make sure that clients
using "notmuch reply" to prepare a reply don't leak cleartext in their
subject lines. In particular, the ["reply-headers"]["Subject"] should
by default show the external Subject.
A replying MUA that intends to protect the Subject
Up to this point, we've tested protected headers on messages that have
either been encrypted or signed, but not both.
This adds a couple tests of signed+encrypted messages, one where the
subject line is masked (outside subject line is "Subject Unavailable")
and another where it is not (outside Sub
We initially test only notmuch-search; tests for other functionality
come in different patchsets later.
Signed-off-by: Daniel Kahn Gillmor
---
test/T358-emacs-protected-headers.sh | 36
1 file changed, 36 insertions(+)
create mode 100755 test/T358-emacs-protected-he
When indexing the cleartext of an encrypted message, record any
protected subject in the database, which should make it findable and
visible in search.
Signed-off-by: Daniel Kahn Gillmor
---
lib/index.cc | 42 ++
lib/message.cc |
The header-mask member of the per-message crypto object allows a
clever UI frontend to mark whether a header was protected (or not).
And if it was protected, it contains enough information to show useful
detail to an interested user. For example, an MUA could offer a "show
what this message's Subj
From: Jameson Graef Rollins
This makes it easier to write fairly compact, readable tests of json
output, without needing to sanitize away parts that we don't care
about.
Signed-off-by: Daniel Kahn Gillmor
---
test/json_check_nodes.py | 113 +++
test/test-lib
Hi all--
Way back in id:20180511055544.13676-1-...@fifthhorseman.net, i
proposed support for protected headers (in particular, for being able
to read and search for subject lines of encrypted messages which
protect the Subject). Although that series was reviewed by Bremner, i
never managed to get
This paves the way for emitting protected headers after verification
and decryption, because it means that the headers will only be emitted
after the body has been parsed.
Signed-off-by: Daniel Kahn Gillmor
---
notmuch-show.c| 6 +++---
test/T170-sexp.sh | 10 +-
2 files changed, 8
This test scans for all the possible protected headers (including
bogus/broken ones) that are present in the protected-headers corpus,
trying to make sure that only the ones that are not broken or
malformed show up in a search after re-indexing.
Signed-off-by: Daniel Kahn Gillmor
---
test/T356-p
Correctly fix the two outstanding tests so that the protected (hidden)
subject is properly reported.
Signed-off-by: Daniel Kahn Gillmor
---
notmuch-client.h | 2 +-
notmuch-reply.c| 4 +++-
notmuch-show.c | 14 +-
test/T356-protected-he
This tests notmuch-show; headers appear appropriately based on the
setting of notmuch-crypto-process-mime.
Signed-off-by: Daniel Kahn Gillmor
---
test/T358-emacs-protected-headers.sh | 36 +++-
1 file changed, 35 insertions(+), 1 deletion(-)
diff --git a/test/T358-emacs-
Daniel Kahn Gillmor writes:
> In certain cases of test suite failure, the summary report was not
> being printed. In particular, any failure on the parallel test suite,
> and any aborted test in the serialized test suite would end up hiding
> the summary.
>
pushed to master,
d
On Sun, May 26 2019, Daniel Kahn Gillmor wrote:
> In certain cases of test suite failure, the summary report was not
> being printed. In particular, any failure on the parallel test suite,
> and any aborted test in the serialized test suite would end up hiding
> the summary.
>
> It's better to al
Daniel Kahn Gillmor writes:
> On Sun 2019-05-26 09:01:46 -0300, David Bremner wrote:
>> Daniel Kahn Gillmor writes:
>>
>>> This is the third revision of the series originally posted at
>>> id:20190424183113.29242-1-...@fifthhorseman.net (revision 2 was at
>>> id:20190520032228.27420-1-...@fifthh
David Bremner writes:
> These are pretty terse overall, and could be expanded in future
> commits.
> ---
> NEWS | 33 +
> 1 file changed, 33 insertions(+)
[snip]
> +
> +Add support for gzip compressed mail messages (/not/ mboxes);
> +e.g. `gzip -9 Maildir/cur/* &&
On Sun 2019-05-26 09:01:46 -0300, David Bremner wrote:
> Daniel Kahn Gillmor writes:
>
>> This is the third revision of the series originally posted at
>> id:20190424183113.29242-1-...@fifthhorseman.net (revision 2 was at
>> id:20190520032228.27420-1-...@fifthhorseman.net)
>>
>> This series addres
In certain cases of test suite failure, the summary report was not
being printed. In particular, any failure on the parallel test suite,
and any aborted test in the serialized test suite would end up hiding
the summary.
It's better to always show the summary where we can (while preserving
the ret
Thanks for the feedback, Tomi!
On Sat 2019-05-25 22:41:58 +0300, Tomi Ollila wrote:
> On Sat, May 25 2019, Daniel Kahn Gillmor wrote:
>
>> In certain cases of test suite failure, the summary report was not
>> being printed. In particular, any failure on the parallel test suite,
>> and any aborted
Tomi Ollila writes:
> ---
> NEWS | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/NEWS b/NEWS
> index 26b8160c8ee2..d8aa272f0093 100644
> --- a/NEWS
> +++ b/NEWS
> @@ -10,6 +10,8 @@ Command Line Interface
> Emacs
> -
>
> +The minimum supported major version of Emacs is now 24.
---
NEWS | 2 ++
1 file changed, 2 insertions(+)
diff --git a/NEWS b/NEWS
index 26b8160c8ee2..d8aa272f0093 100644
--- a/NEWS
+++ b/NEWS
@@ -10,6 +10,8 @@ Command Line Interface
Emacs
-
+The minimum supported major version of Emacs is now 24.
+
Support for GNU Emacs older than 25.1 is dep
These patches are somewhere in between WIP and proposed for
merging. I'm sure there are some shell scripting tweaks needed, and
it's a potentially disruptive enough change that I want to wait until
after 0.29. On the other hand, it works for me, and the API seems
like an improvement on what it rep
These can be used e.g. to override return values for functions, in
place of the existing scripting of gdb.
---
test/test-lib.sh | 16
1 file changed, 16 insertions(+)
diff --git a/test/test-lib.sh b/test/test-lib.sh
index ff18fae6..a423b7f4 100644
--- a/test/test-lib.sh
+++ b/tes
This removes the dependency of this test script on gdb, and
considerably speeds up the running of the tests.
---
test/T070-insert.sh | 50 -
1 file changed, 18 insertions(+), 32 deletions(-)
diff --git a/test/T070-insert.sh b/test/T070-insert.sh
index 4
Daniel Kahn Gillmor writes:
> This is the third revision of the series originally posted at
> id:20190424183113.29242-1-...@fifthhorseman.net (revision 2 was at
> id:20190520032228.27420-1-...@fifthhorseman.net)
>
> This series addresses comments raised by David Bremner in his review.
> Thanks, B
These are pretty terse overall, and could be expanded in future
commits.
---
NEWS | 33 +
1 file changed, 33 insertions(+)
diff --git a/NEWS b/NEWS
index 26b8160c..7a79e560 100644
--- a/NEWS
+++ b/NEWS
@@ -1,18 +1,51 @@
Notmuch 0.29 (UNRELEASED)
=
David Bremner writes:
> I know there are several things "in progress", but we've also
> accumulated a fair amount of change since 0.28. I am planning a feature
> freeze for 0.29 on May 31 and (hopefully) a release on June 7.
>
> d
It's that time again, time to add NEWS items for user facing chan
34 matches
Mail list logo