Re: [PATCH] configure: fix mktemp call for macOS

2019-06-16 Thread David Bremner
Ralph Seichter writes: > Add missing template to mktemp, as required by macOS / OS X. > > Signed-off-by: Ralph Seichter > --- I've merged this to master and release. In the case that we do another point release before 0.30, it will be in that. d ___

Re: [PATCH 3/8] CLI: replace some constructs with more uncrustify friendly ones

2019-06-16 Thread David Bremner
Daniel Kahn Gillmor writes: > On Thu 2019-06-13 08:08:32 -0300, David Bremner wrote: >>- add parens in some ternery operators > > itym "ternary" yep. > >> @@ -120,13 +120,13 @@ _process_string_arg (const notmuch_opt_desc_t >> *arg_desc, char next, const char * >> static int

Re: [PATCH] python: bind add_property/remove_property and related methods

2019-06-16 Thread Daniel Kahn Gillmor
On Sun 2019-06-16 02:52:52 +0300, Daniel Kahn Gillmor wrote: > On Fri 2019-06-14 22:34:16 +0200, VA wrote: >> As a general rule, an application MUST prefix their own property names >> with "x--". It is recommended to report an application's >> properties on the notmuch wiki, to open

Re: [PATCH v2 2/2] test: replace use of gdb with LD_PRELOAD shims in T070-insert.sh

2019-06-16 Thread Daniel Kahn Gillmor
On Sun 2019-06-16 14:35:53 +0300, Tomi Ollila wrote: > On Mon, Jun 10 2019, Daniel Kahn Gillmor wrote: >> +test_expect_code 1 "$(printf "notmuch_with_shim shim-%q insert < %q" >> "$code" "$gen_msg_filename")" > > does test_expect_code 1 'notmuch_with_shim shim-$code insert < >

Re: [PATCH 3/8] CLI: replace some constructs with more uncrustify friendly ones

2019-06-16 Thread Daniel Kahn Gillmor
On Thu 2019-06-13 08:08:32 -0300, David Bremner wrote: >- add parens in some ternery operators itym "ternary" > @@ -120,13 +120,13 @@ _process_string_arg (const notmuch_opt_desc_t > *arg_desc, char next, const char * > static int _opt_set_count (const notmuch_opt_desc_t *opt_desc) > { >

Re: [PATCH] configure: fix mktemp call for macOS

2019-06-16 Thread Daniel Kahn Gillmor
On Fri 2019-06-14 20:57:07 +0300, Tomi Ollila wrote: > Yes. $TMPDIR could be problematic if it makes the full (unix domain > socket?) path be too long. Modern, maintained version of GnuPG will only place sockets directly in the $GNUPGHOME if /run/user/$(id -u) (i.e., $XDG_RUNTIME_DIR) is not

Re: [PATCH] python: bind add_property/remove_property and related methods

2019-06-16 Thread Daniel Kahn Gillmor
On Fri 2019-06-14 22:34:16 +0200, VA wrote: > The wiki would serve to advertise each projects interests, and if some > other project has a common interest, they could get together to > standardize it in the interest of both projects? Makes sense to me. Each one then gets to deal with the

[PATCH] configure: fix mktemp call for macOS

2019-06-16 Thread Ralph Seichter
Add missing template to mktemp, as required by macOS / OS X. Signed-off-by: Ralph Seichter --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index 8b80f0e0..6e73b22e 100755 --- a/configure +++ b/configure @@ -529,7 +529,7 @@ int main () {

Re: [PATCH v2 2/2] test: replace use of gdb with LD_PRELOAD shims in T070-insert.sh

2019-06-16 Thread Tomi Ollila
On Mon, Jun 10 2019, Daniel Kahn Gillmor wrote: > diff --git a/test/T070-insert.sh b/test/T070-insert.sh > index 48165caa..017124fc 100755 > --- a/test/T070-insert.sh > +++ b/test/T070-insert.sh > @@ -266,30 +264,18 @@ gen_insert_msg > > for code in FILE_NOT_EMAIL READ_ONLY_DATABASE

Re: [PATCH] configure: fix mktemp call for macOS

2019-06-16 Thread Tomi Ollila
On Sat, Jun 15 2019, Ralph Seichter wrote: > * Tomi Ollila: > >> First, it would be better if >> >> TEMP_GPG=$(mktemp -d "${TMPDIR:-/tmp}/notmuch.XX") >> >> worked, then the behaviour on Linux would not change. > > I'm trying to figure out if I can override $TMPDIR during the MacPorts >