Re: [PATCH 1/3] gitignore: Ignore generated sphinx.config

David Bremner writes: > I don't think the patch dos what you think it does? Indeed. I'll post the correct commit in v2 but will wait for the rest of the review before posting that. ___ notmuch mailing list -- notmuch@notmuchmail.org To unsubscribe

Re: [PATCH 1/3] gitignore: Ignore generated sphinx.config

Jonas Bernoulli writes: > --- > sphinx.config | 4 > 1 file changed, 4 insertions(+) > create mode 100644 sphinx.config > > diff --git a/sphinx.config b/sphinx.config > new file mode 100644 > index ..207614b4 > --- /dev/null > +++ b/sphinx.config > @@ -0,0 +1,4 @@ > +# Generated

[PATCH 3/3] test: Explicitly state that we want to sign with sender

Since Emacs 27 'mml-secure-epg-sign' errors out if we don't opt-in to signing as the sender using 'mml-secure-openpgp-sign-with-sender'. --- test/test-lib.sh | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/test/test-lib.sh b/test/test-lib.sh index 8c331b88..90e26639 100644

[PATCH 2/3] test: Deal with Emacs 27 switching to lexical scope by default

Starting with Emacs 27 undeclared variables in evaluated interactive code uses lexical scope. This includes code passed with '--eval' as we do in the Emacs tests, which also happen to assume dynamic scope. This can affect variables defined by libraries that we use. We let- bind such variables

[PATCH 0/3] Adjust test for changes in Emacs 27

Without these changes many tests fail on upcoming Emacs 27.1. The details are in the commit messages. Cheers, Jonas Bernoulli (3): gitignore: Ignore generated sphinx.config test: Deal with Emacs 27 switching to lexical scope by default test: Explicitly state that we want to sign with

[PATCH 1/3] gitignore: Ignore generated sphinx.config

--- sphinx.config | 4 1 file changed, 4 insertions(+) create mode 100644 sphinx.config diff --git a/sphinx.config b/sphinx.config new file mode 100644 index ..207614b4 --- /dev/null +++ b/sphinx.config @@ -0,0 +1,4 @@ +# Generated by configure, run from doc/conf.py

batch 9: API cleanup for exception handling

This is another batch where everything seems to just work (TM), which is great because no API changes are needed. ___ notmuch mailing list -- notmuch@notmuchmail.org To unsubscribe send an email to notmuch-le...@notmuchmail.org

[PATCH 5/8] test: add regression tests for n_t_get_{authors, subject}

This is returning explicitely cached data, so no database access is needed. --- test/T568-lib-thread.sh | 33 + 1 file changed, 33 insertions(+) diff --git a/test/T568-lib-thread.sh b/test/T568-lib-thread.sh index c7d4f26b..0f9fa443 100755 ---

[PATCH 4/8] test: add regression test for n_t_get_messages

This is similar to the case of toplevel messages. Currently everything is cached, so no database access is necessary. This might change in the future, but it should not crash in either case. --- test/T568-lib-thread.sh | 26 ++ 1 file changed, 26 insertions(+) diff --git

[PATCH 6/8] test: add regression tests for oldest and newest dates

These are strictly to watch for crashes, so don't be too fussy about the actual timestamps. --- test/T568-lib-thread.sh | 32 1 file changed, 32 insertions(+) diff --git a/test/T568-lib-thread.sh b/test/T568-lib-thread.sh index 0f9fa443..3eb28f3b 100755 ---

[PATCH 2/8] test: add regression test for n_thread_get_total_{messages,files}

This is returning cached info, so does not need to access the (closed) database. --- test/T568-lib-thread.sh | 32 1 file changed, 32 insertions(+) diff --git a/test/T568-lib-thread.sh b/test/T568-lib-thread.sh index 00755834..5816cfbc 100755 ---

[PATCH 8/8] test: destroy thread from closed database

Check for (non)-crash. --- test/T568-lib-thread.sh | 14 ++ 1 file changed, 14 insertions(+) diff --git a/test/T568-lib-thread.sh b/test/T568-lib-thread.sh index 82e4ecb8..66066854 100755 --- a/test/T568-lib-thread.sh +++ b/test/T568-lib-thread.sh @@ -285,5 +285,19 @@ unread EOF

[PATCH 7/8] test: regression test for n_thread_get_tags

Code is taken from the API docs, with the twist that the underlying database is closed. Not crashing is the main point. --- test/T568-lib-thread.sh | 23 +++ 1 file changed, 23 insertions(+) diff --git a/test/T568-lib-thread.sh b/test/T568-lib-thread.sh index

[PATCH 1/8] test: regression test for n_t_get_thread_id

This is just cached data, so as long as we don't prematurely free anything, it should be fine. --- test/T568-lib-thread.sh | 63 + 1 file changed, 63 insertions(+) create mode 100755 test/T568-lib-thread.sh diff --git a/test/T568-lib-thread.sh

[PATCH 3/8] test: add regression tests for n_thread_get_toplevel_messages

Include a test for the previously omitted non-trivial code path for notmuch_thread_get_replies. --- test/T566-lib-message.sh | 1 - test/T568-lib-thread.sh | 80 2 files changed, 80 insertions(+), 1 deletion(-) diff --git a/test/T566-lib-message.sh