Re: [PATCH] notmuch-show: use correct format specifier for ssize_t

2021-02-02 Thread Tomi Ollila
On Mon, Feb 01 2021, David Bremner wrote: > Đoàn Trần Công Danh writes: > >> Signed-off-by: Đoàn Trần Công Danh >> --- >> >> I found this after inspecting one of my build today. >> I'm not sure what is acceptable action. >> I think using %zd is the right move. >> But I'm not sure if you pref

Re: [PATCH] emacs: When completing tags, offer each tag once

2021-02-02 Thread Tomi Ollila
On Mon, Feb 01 2021, David Edmondson wrote: > On Monday, 2021-02-01 at 11:49:36 -04, David Bremner wrote: > >> David Edmondson writes: >>> >>> +(defun notmuch-search-uniq-tags (tags) >>> + (let (result) >>> +(mapc (lambda (tag) >>> + (unless (member tag result) >>> + (push ta

Re: [PATCH] emacs: When completing tags, offer each tag once

2021-02-02 Thread David Bremner
Tomi Ollila writes: > On Mon, Feb 01 2021, David Edmondson wrote: > >> On Monday, 2021-02-01 at 11:49:36 -04, David Bremner wrote: >> >>> David Edmondson writes: +(defun notmuch-search-uniq-tags (tags) + (let (result) +(mapc (lambda (tag) + (unless (member ta

Re: [PATCH] emacs: When completing tags, offer each tag once

2021-02-02 Thread Tomi Ollila
On Tue, Feb 02 2021, David Bremner wrote: > > Maybe delete-dups (subr.el) would be useful here? It is destructive, but > even with a copy (if needed), it should still be faster. I looked the implementation of delete-dups. In case of >100 elements, it uses hash table for checking duplicates. less