[PATCH v4] emacs: notmuch-tree: customizable strings for drawing trees

2021-08-30 Thread jao
New customizable variable, notmuch-tree-thread-symbols, that allows tweaking of how trees in a forest are represented. For instance, one can now choose to use an hyphen rather than a white space as a prefix, or replace the character(s) used to draw arrows. --- emacs/notmuch-tree.el | 44 +

Re: [PATCH v2] emacs: tree: support fold/unfold thread or sub-thread

2021-08-30 Thread David Bremner
"inwit" writes: > After applying the patch manually, I get some warnings and > the following error: > > `emacs/notmuch.el:76:1:Error: Symbol’s value as variable is void: > notmuch-tree-previous-message-button` > > Seems like that function is missing in the current code, am I right? That function

Re: [PATCH 2/3] emacs: don't inline message/rfc822 parts without content

2021-08-30 Thread David Bremner
David Bremner writes: > This avoids some ugly error messages and exceptions, and hopes that > some gnus method will display message/rfc822 parts that have only a > file, no :content part. applied to master ___ notmuch mailing list -- notmuch@notmuchmai

Re: [PATCH 2/2] test: known broken test for emacs display of message/rfc822 parts

2021-08-30 Thread David Bremner
David Bremner writes: > Tomi Ollila writes: > >> In this case one could just do >> >> test_expect_code 1 "fgrep -q '!!!' OUTPUT" >> >> (these file comparisons w/ /dev/null (currently 5) annoys me ;/ >> so if I am biased the current suggestion is fine) > > Sure, I've adopted your suggestion in

Re: [PATCH v2] emacs: tree: support fold/unfold thread or sub-thread

2021-08-30 Thread inwit
Hi all, While being a total noob, I'm also interested in this patch, so after getting it via David Bremner (thanks!), I have tried to apply it. However, the code seems to have diverged and `git am 3` complains about conflicts. After applying the patch manually, I get some warnings and the followin

[PATCH v2] test/emacs: test for functions in notmuch-search-result-format.

2021-08-30 Thread David Bremner
Based on the commit message in id:20210221151902.2301690-3-...@dme.org Add the function notmuch-test-result-flags to test-lib.el to avoid repeating it in 3 T*.sh files. --- test/T310-emacs.sh| 14 + test/T460-emacs-tree.sh | 15 ++ test/T4

Re: [PATCH] emacs: notmuch-tree: customizable strings for drawing trees

2021-08-30 Thread Jose Antonio Ortega Ruiz
On Mon, Aug 30 2021, David Bremner wrote: > jao writes: > >> +(defcustom notmuch-tree-thread-symbols '(" " "─" "┬" "│" "├" "╰" "►") > > How hard would it be to use a plist or an alist, and allow the user to > overide only the symbols they are interested in? not hard at all... we just need to fig

Re: [PATCH] emacs: notmuch-tree: customizable strings for drawing trees

2021-08-30 Thread David Bremner
jao writes: > +(defcustom notmuch-tree-thread-symbols '(" " "─" "┬" "│" "├" "╰" "►") How hard would it be to use a plist or an alist, and allow the user to overide only the symbols they are interested in? > + (push (elt notmuch-tree-thread-symbols 4) tree-status)) As hinted above, I don't