Re: [PATCH] notmuch.c: add missing trailing newlines in two error messages

Tomi Ollila writes: > Removed duplicate error check (and the message) in 3rd case where > the same error message (w/o trailing newline) was present. > > In case of test/T040-setup.sh, command substitution deletes > trailing newlines, so related test there cannot be changed > (and therefore could

Re: [PATCH] notmuch.c: add missing trailing newlines in two error messages

Tomi Ollila writes: > Removed duplicate error check (and the message) in 3rd case where > the same error message (w/o trailing newline) was present. > > In case of test/T040-setup.sh, command substitution deletes > trailing newlines, so related test there cannot be changed > (and therefore could

[PATCH] notmuch.c: add missing trailing newlines in two error messages

Removed duplicate error check (and the message) in 3rd case where the same error message (w/o trailing newline) was present. In case of test/T040-setup.sh, command substitution deletes trailing newlines, so related test there cannot be changed (and therefore could not notice this user experience f

[PATCH v2] emacs: add docstring for notmuch-show-choose-duplicate

It should have one in any case, but in particular it is needed for the manual. --- I realized my first attempt at a docstring didn't work well in the manual. emacs/notmuch-show.el | 10 ++ 1 file changed, 10 insertions(+) diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el index

[PATCH 4/7] doc/emacs: split index category from label

A more verbose category is needed for the index, but not the description in the manual. --- doc/elisp.py | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/doc/elisp.py b/doc/elisp.py index b8b4931b..1b0392e6 100644 --- a/doc/elisp.py +++ b/doc/elisp.py @@ -110,6 +1

[PATCH 7/7] doc/emacs: use define-key instead of hard-coding markup

Add keys to index. Allow indexing of both keys and commands. Use standard typesetting for multiple keybindings. --- doc/notmuch-emacs.rst | 180 ++ 1 file changed, 129 insertions(+), 51 deletions(-) diff --git a/doc/notmuch-emacs.rst b/doc/notmuch-emacs.rst

[PATCH 3/7] doc/emacs: drop domain label

This makes the generate info files somewhat less verbose, so that they say e.g. "Key Binding" instead of "Emacs Key Binding" --- doc/elisp.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/elisp.py b/doc/elisp.py index 642ea9ae..b8b4931b 100644 --- a/doc/elisp.py +++ b/doc

[PATCH 6/7] doc/emacs: replace use of emacsvar with el:defcustom

Mainly this allows dropping the ad-hoc directive emacsvar --- doc/conf.py | 4 --- doc/notmuch-emacs.rst | 74 +-- 2 files changed, 37 insertions(+), 41 deletions(-) diff --git a/doc/conf.py b/doc/conf.py index 0b7b8af5..e23cb7d7 100644 --- a/doc

[PATCH 1/7] doc: copy elisp.py from flycheck, make available

This corresponds to flycheck commit 1702d2db3d8ba9bcb9b2bf810e791e907fcc3adc, which is apparently the last time this file was modified (2018). Embedding seems defensible since the file is evidently not changing that much, and we need to change some labels to make it fit with the not-just-emacs nat

[PATCH 5/7] doc/emacs: replace emacscmd with el:define-key

This allows us to eliminate the ad-hoc emacscmd directive / role, and improve indexing. doc/emacs: convert remaining uses of emacscmd to define-key This allows us to remove the no-longer used object type. --- doc/conf.py | 5 - doc/notmuch-emacs.rst | 14 -- 2 files ch

[PATCH 2/7] doc/elisp: replace label for Emacs commands and key bindings.

In the notmuch doc index it is important to be clear which parts are Emacs related. --- doc/elisp.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/elisp.py b/doc/elisp.py index 1a96b12a..642ea9ae 100644 --- a/doc/elisp.py +++ b/doc/elisp.py @@ -215,7 +215,7 @@ class E

Embed elisp.py from flycheck, use it in notmuch-emacs doc

After finding myself spending a while trying to re-create one of the features [0] of the el sphinx domain used in flycheck, I decided to try just converting the docs to use that sphinx extension. As I remarked in 2018 [1], there doesn't seem to be a distributed version of this sphinx extension. It

Re: Multiple files per message in emacs

David Bremner writes: > Rafael Ávila de Espíndola writes: > >> Hi, >> >> I got a few emails which all have the same Message-ID: >> >> $ notmuch search subject:'"MB WAY"' >> thread:00089926 34 mins. ago [1/1(3)] MB WAY >> >> $ notmuch search --output=files subject:'"MB WAY"' | xargs g