Re: [DRAFT 1/1] lib: replace some uses of Query::MatchAll with a thread-safe alternative

2023-02-26 Thread David Bremner
Kevin Boulain writes: > This is what can be expected from the tests when they fail: >== stderr == > +== > +WARNING: ThreadSanitizer: data race (pid=207931) > + Read of size 1 at 0x7b1001a0 by thread T2: > +#0 memcpy (libtsan.so.2+0x62506) > +#1 void std

Re: [DRAFT 0/1] lib: replace some uses of Query::MatchAll with a thread-safe alternative

2023-02-26 Thread David Bremner
Kevin Boulain writes: > > Thoughts? Should clients using the library gate every function call to > Notmuch behind a lock instead? Ideally that should not be necessary. On the other hand, it may take some time to fix issues with concurrent access. > I can also start a discussion in sfsexp's iss

Re: [PATCH 1/1] lib/notmuch: update example

2023-02-26 Thread David Bremner
Kevin Boulain writes: > Likely missed in 86cbd215e, when notmuch_query_search_messages_st was > renamed to notmuch_query_search_messages. > --- > lib/notmuch.h | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/lib/notmuch.h b/lib/notmuch.h > index ce375c04..73e246e0 1006