Re: [PATCH 2/2] lib/message-property: sync removed properties to the database

2023-03-02 Thread Kevin Boulain
On 2023-03-03 at 00:39 +02, Tomi Ollila wrote: > Somehow testkey1 = testvalue1 disappeared from the test code (which is > probably expected -- perhaps the commit message of the *change* 1/2 > tried to point to that ;D) Yes, that proves notmuch_message_remove_all_properties is broken without the

Re: [PATCH 2/2] lib/message-property: sync removed properties to the database

2023-03-02 Thread Tomi Ollila
On Wed, Mar 01 2023, Kevin Boulain wrote: > _notmuch_message_remove_all_properties wasn't syncing the message back > to the database but was still invalidating the metadata, giving the > impression the properties had actually been removed. > > Also move the metadata invalidation to

[PATCH 1/1] lib: replace some uses of Query::MatchAll with a thread-safe alternative

2023-03-02 Thread Kevin Boulain
This replaces two instances of Xapian::Query::MatchAll with the equivalent but thread-safe alternative Xapian::Query(std::string()). Xapian::Query::MatchAll maintains an internal pointer to a refcounted Xapian::Internal::QueryTerm. None of this is thread-safe but that wouldn't be an issue if