Re: [PATCH] notmuch-mutt: replace extra command with notmuch-native thread search feature

2023-04-09 Thread Paul Wise
On Sun, 2023-04-09 at 13:00 -0300, David Bremner wrote: > You might be interested in the s-expression query parser. Part of the > goal is to be less dwim/quirky than the native Xapian query parser, and > to make it easier / safer to construct notmuch queries via programs. That does seem saner to

Re: [PATCH] notmuch-mutt: replace extra command with notmuch-native thread search feature

2023-04-09 Thread David Bremner
Paul Wise writes: > So I think that it would be good if there were a library for notmuch > query construction that would take care of all the different quoting > levels, Message-Id munging etc. This could then get language bindings > so that notmuch based tools and MUAs could use them for

[PATCH v3 5/5] debian: add autopkgtests

2023-04-09 Thread David Bremner
We generate output to stderr for BROKEN tests, which are not failures, so tell the test runner not to fail because of output on stderr. --- debian/tests/control | 17 + 1 file changed, 17 insertions(+) create mode 100644 debian/tests/control diff --git a/debian/tests/control

[PATCH v3 1/5] test: use bash specific test for feature tests

2023-04-09 Thread David Bremner
It is desirable to have the tests consider these variables being undefined as equivalent to the feature not being present, and in particular for the tests not to generate errors. We know the test suite is tied to bash anyway, so this is a simple fix. --- test/T060-count.sh | 2 +-

[PATCH v3 4/5] test: support testing notmuch as installed

2023-04-09 Thread David Bremner
We put some effort into testing the built copy rather than some installed copy. On the other hand for people like packagers, testing the installed copy is also of interest. When NOTMUCH_TEST_INSTALLED is set to a nonempty value, tests do not require a built notmuch tree or running configure.

[PATCH v3 2/5] test: check for empty/missing files in test_expect_equal_message_body

2023-04-09 Thread David Bremner
Messages can have empty bodies, but empty files are not messages. --- test/test-lib.sh | 8 1 file changed, 8 insertions(+) diff --git a/test/test-lib.sh b/test/test-lib.sh index 1a6525df..b5aa94dd 100644 --- a/test/test-lib.sh +++ b/test/test-lib.sh @@ -388,6 +388,14 @@

[PATCH v3 3/5] test: Guess a value for NOTMUCH_PYTHON

2023-04-09 Thread David Bremner
python3 will work for many people, and reduce the friction to running the tests without running configure first. --- test/test-lib-common.sh | 4 1 file changed, 4 insertions(+) diff --git a/test/test-lib-common.sh b/test/test-lib-common.sh index 18fa29c0..4d14e0b3 100644 ---

v3 test notmuch as installed

2023-04-09 Thread David Bremner
Compared to the previous version [1], the first patch is now applied, and the setup for running without configure now relies on the various NOTMUCH_HAVE_* environment variables working OK when unset. This allows eliminating the "defaults.sh". There is also some added documentation on how to use