Re: [PATCH v3 1/5] test: use bash specific test for feature tests

2023-04-13 Thread Felipe Contreras
On Thu, Apr 13, 2023 at 2:25 PM Tomi Ollila wrote: > On Sun, Apr 09 2023, David Bremner wrote: > I would just use [ "${VAR-}" = 1 ] in shell script code (or barely > [[ ${VAR-0} == 1 ]] if desired not to have ""s around variables...but...) > > ... using [ "${VAR-}" = 1 ] is also good in a sense t

Re: [PATCH v3 1/5] test: use bash specific test for feature tests

2023-04-13 Thread Tomi Ollila
On Sun, Apr 09 2023, David Bremner wrote: > It is desirable to have the tests consider these variables being > undefined as equivalent to the feature not being present, and in > particular for the tests not to generate errors. > > We know the test suite is tied to bash anyway, so this is a simple

Re: [PATCH v3 1/5] test: use bash specific test for feature tests

2023-04-13 Thread Tomi Ollila
On Thu, Apr 13 2023, Felipe Contreras wrote: > On Sun, Apr 9, 2023 at 9:26 AM David Bremner wrote: >> >> It is desirable to have the tests consider these variables being >> undefined as equivalent to the feature not being present, and in >> particular for the tests not to generate errors. > > Thi

Re: [PATCH] doc: fix typos

2023-04-13 Thread David Bremner
Jakub Wilk writes: > --- > doc/man1/notmuch-config.rst | 2 +- > doc/man1/notmuch-git.rst | 4 ++-- > doc/man7/notmuch-sexp-queries.rst | 8 > doc/notmuch-emacs.rst | 6 +++--- > 4 files changed, 10 insertions(+), 10 deletions(-) applied to master, thanks d

[PATCH] doc: fix typos

2023-04-13 Thread Jakub Wilk
--- doc/man1/notmuch-config.rst | 2 +- doc/man1/notmuch-git.rst | 4 ++-- doc/man7/notmuch-sexp-queries.rst | 8 doc/notmuch-emacs.rst | 6 +++--- 4 files changed, 10 insertions(+), 10 deletions(-) diff --git a/doc/man1/notmuch-config.rst b/doc/man1/notmuch-co

Re: [PATCH v3 1/5] test: use bash specific test for feature tests

2023-04-13 Thread Felipe Contreras
On Sun, Apr 9, 2023 at 9:26 AM David Bremner wrote: > > It is desirable to have the tests consider these variables being > undefined as equivalent to the feature not being present, and in > particular for the tests not to generate errors. This can be done easily with `[ ${FOO-0} -eq 1 ]`, or as I