[PATCH 5/9] cli/reply: Ignore PKCS#7 wrapper parts when replying

2020-04-30 Thread Daniel Kahn Gillmor
When composing a reply, no one wants to see this line in the proposed message: Non-text part: application/pkcs7-mime So we hide it, the same way we hide PGP/MIME cruft. Signed-off-by: Daniel Kahn Gillmor --- notmuch-reply.c| 5 +++-- test/T355-smime.sh | 1 - 2 files changed, 3

[PATCH 8/9] smime: Pass PKCS#7 envelopedData to node_decrypt_and_verify

2020-04-30 Thread Daniel Kahn Gillmor
Signed-off-by: Daniel Kahn Gillmor --- mime-node.c| 6 ++ test/T355-smime.sh | 2 -- test/T356-protected-headers.sh | 2 -- 3 files changed, 6 insertions(+), 4 deletions(-) diff --git a/mime-node.c b/mime-node.c index c2ee858d..f552e03a 100644 --- a/mime-node.c

[PATCH 07/15 v2] test: Allow tests to have both gpg and gpgsm active at once

2020-04-30 Thread Daniel Kahn Gillmor
Without this fix, we couldn't run both add_gnupg_home and add_gpgsm_home in the same test script. Signed-off-by: Daniel Kahn Gillmor --- test/test-lib.sh | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/test/test-lib.sh b/test/test-lib.sh index ac1b9315..1baa2d20

[PATCH 08/15 v2] tests/smime: include secret key material for Bob

2020-04-30 Thread Daniel Kahn Gillmor
passphrase into no passphrase at all on import). Signed-off-by: Daniel Kahn Gillmor --- test/smime/bob.p12 | 58 ++ test/test-lib.sh | 2 ++ 2 files changed, 60 insertions(+) create mode 100644 test/smime/bob.p12 diff --git a/test/smime/bob.p12 b/test/smi

[PATCH 03/15 v2] tests/smime: Include the Sample LAMPS Certificate Authority

2020-04-30 Thread Daniel Kahn Gillmor
.html#name-certificate-authority-certi Signed-off-by: Daniel Kahn Gillmor --- test/smime/README | 2 ++ test/smime/ca.crt | 20 test/test-lib.sh | 2 ++ 3 files changed, 24 insertions(+) create mode 100644 test/smime/ca.crt diff --git a/test/smime/README b/test/smime

Re: [PATCH 15/15] tests: disable CRL checks from gpgsm

2020-04-30 Thread Daniel Kahn Gillmor
On Wed 2020-04-29 23:12:33 +0300, Tomi Ollila wrote: > Rest of the series look tolerable to me. That one missing > "inconsistent quotes" is inconsistent with added quotes > in one of the changes in previous email (which just did that) > > Otherwise OK (provided that tests pass) > (except that

Re: [PATCH 07/15] test: Allow tests to have both gpg and gpgsm active at once

2020-04-30 Thread Daniel Kahn Gillmor
On Wed 2020-04-29 23:02:19 +0300, Tomi Ollila wrote: > On Tue, Apr 28 2020, Daniel Kahn Gillmor wrote: > >> Without this fix, we couldn't run both add_gnupg_home and >> add_gpgsm_home in the same test script. >> >> Signed-off-by: Daniel Kahn Gillmor >> --- >

Re: Inconsistencies in handling command flags: `--flag=value` different than `--flag value`

2020-04-30 Thread Daniel Kahn Gillmor
On Wed 2020-04-29 08:33:24 -0700, Jameson Graef Rollins wrote: > On Tue, Apr 28 2020, Daniel Kahn Gillmor wrote: >> One final way we could normalize everything and make it less >> idiosyncratic, with shorter, simpler man pages: deprecate and then drop >> the --boolo

Re: [PATCH 08/15] tests/smime: include secret key material for Bob

2020-04-30 Thread Daniel Kahn Gillmor
On Wed 2020-04-29 23:05:03 +0300, Tomi Ollila wrote: > Now that I started w/ consistenly quotes -- "$NOTMUCH_SRCDIR/..." > > Or maybe not, is this variable consistently unquoted -- or something ;) there are lots of places where NOTMUCH_SRCDIR is unquoted, and some where it is. I guess i should

Re: [PATCH 03/15] tests/smime: Include the Sample LAMPS Certificate Authority

2020-04-30 Thread Daniel Kahn Gillmor
On Tue 2020-04-28 22:43:10 -0300, David Bremner wrote: > Daniel Kahn Gillmor writes: > >> This CA is useful for test suites and the like, but is not an >> actually-secure CA, because its secret key material is also published. >> >> I plan to use it for its intend

Re: Inconsistencies in handling command flags: `--flag=value` different than `--flag value`

2020-04-28 Thread Daniel Kahn Gillmor
On Mon 2020-04-27 22:21:36 +0300, Ciprian Dorin Craciun wrote: > On Mon, Apr 27, 2020 at 9:21 PM Tomi Ollila wrote: >>> [dkg wrote:] >>> release, remove the suggestion to use a whitespace separator from the >>> documentation, and eventually phase it out entirely in some future >>> release. >> >>

[PATCH 05/15] tests/smime: Use gpgsm instead of openssl for mml creation of S/MIME msgs

2020-04-28 Thread Daniel Kahn Gillmor
openssl's smime subcommand. See https://dev.gnupg.org/T4878 for more details. Signed-off-by: Daniel Kahn Gillmor --- test/T355-smime.sh | 4 ++-- test/test-lib.el | 10 -- test/test-lib.sh | 6 +- 3 files changed, 7 insertions(+), 13 deletions(-) diff --git a/test/T355-smime.sh b

[PATCH 03/15] tests/smime: Include the Sample LAMPS Certificate Authority

2020-04-28 Thread Daniel Kahn Gillmor
.html#name-certificate-authority-certi Signed-off-by: Daniel Kahn Gillmor --- test/smime/README | 2 ++ test/smime/ca.crt | 20 test/test-lib.sh | 2 ++ 3 files changed, 24 insertions(+) create mode 100644 test/smime/ca.crt diff --git a/test/smime/README b/test/smime/README

[PATCH 04/15] tests/smime: consistently quote $GNUPGHOME

2020-04-28 Thread Daniel Kahn Gillmor
Signed-off-by: Daniel Kahn Gillmor --- test/test-lib.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/test/test-lib.sh b/test/test-lib.sh index 1ffedb25..31f37ed7 100644 --- a/test/test-lib.sh +++ b/test/test-lib.sh @@ -132,13 +132,13 @@ add_gnupg_home

[PATCH 14/15] test/protected-headers: Add tests for S/MIME protected headers

2020-04-28 Thread Daniel Kahn Gillmor
Recognize the protected subject for S/MIME example protected header messages. Signed-off-by: Daniel Kahn Gillmor --- test/T356-protected-headers.sh | 38 +++--- 1 file changed, 35 insertions(+), 3 deletions(-) diff --git a/test/T356-protected-headers.sh b/test/T356

[PATCH 15/15] tests: disable CRL checks from gpgsm

2020-04-28 Thread Daniel Kahn Gillmor
d messages are already handled correctly (one-part PKCS#7 messages will get fixed later). Signed-off-by: Daniel Kahn Gillmor --- test/T356-protected-headers.sh | 2 +- test/test-lib.sh | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/test/T356-protected-headers

[PATCH 11/15] tests/smime: Test indexing cleartext of envelopedData

2020-04-28 Thread Daniel Kahn Gillmor
These tests describe some simple behavior we would expect to work if we were to correctly index the cleartext of encrypted S/MIME messages (PKCS#7 envelopedData). Of course, they don't currently pass, so we mark them known-broken. Signed-off-by: Daniel Kahn Gillmor --- test/T355-smime.sh | 22

[PATCH 07/15] test: Allow tests to have both gpg and gpgsm active at once

2020-04-28 Thread Daniel Kahn Gillmor
Without this fix, we couldn't run both add_gnupg_home and add_gpgsm_home in the same test script. Signed-off-by: Daniel Kahn Gillmor --- test/test-lib.sh | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/test/test-lib.sh b/test/test-lib.sh index ac1b9315..d9997b27

[PATCH 13/15] tests/smime: add tests for S/MIME SignedData

2020-04-28 Thread Daniel Kahn Gillmor
properly quote and attribute content? Signed-off-by: Daniel Kahn Gillmor --- test/T355-smime.sh | 77 + test/corpora/pkcs7/smime-onepart-signed.eml | 51 ++ 2 files changed, 128 insertions(+) create mode 100644 test/corpora/pkcs7/smime

[PATCH 12/15] test-lib.sh: add test_valid_json

2020-04-28 Thread Daniel Kahn Gillmor
This test does exactly what it says on the tin. It expects JSON data to be parseable by Python, at least. Signed-off-by: Daniel Kahn Gillmor --- test/test-lib.sh | 6 ++ 1 file changed, 6 insertions(+) diff --git a/test/test-lib.sh b/test/test-lib.sh index dd7fdfaa..6f47994e 100644

[PATCH 06/15] tests/smime: avoid copying the key+cert.pem around

2020-04-28 Thread Daniel Kahn Gillmor
No functional change. We no longer need to identify the key and cert to mml-mode when sending an S/MIME message, so making a copy of key+cert.pem to test_suite.pem is superfluous. Get rid of the extra file. Signed-off-by: Daniel Kahn Gillmor --- test/T355-smime.sh | 6 ++ 1 file changed

[PATCH 09/15] tests: Add S/MIME messages to protected-headers corpus

2020-04-28 Thread Daniel Kahn Gillmor
of the corpus, though. We should have that trailing whitespace, so I've made this commit with --no-verify. Signed-off-by: Daniel Kahn Gillmor --- .../smime-enc+legacy-disp.eml | 50 + .../smime-multipart-signed.eml| 68 .../smime-onepart

[PATCH 02/15] tests/smime: Always use --batch with gpgsm

2020-04-28 Thread Daniel Kahn Gillmor
GnuPG's gpgsm, like gpg, should always be used with --batch when it is invoked in a non-interactive environment. Signed-off-by: Daniel Kahn Gillmor --- test/test-lib.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/test/test-lib.sh b/test/test-lib.sh index 6a62b5c1

[PATCH 08/15] tests/smime: include secret key material for Bob

2020-04-28 Thread Daniel Kahn Gillmor
passphrase into no passphrase at all on import). Signed-off-by: Daniel Kahn Gillmor --- test/smime/bob.p12 | 58 ++ test/test-lib.sh | 2 ++ 2 files changed, 60 insertions(+) create mode 100644 test/smime/bob.p12 diff --git a/test/smime/bob.p12 b/test/smi

Add tests for S/MIME PKCS#7 messages

2020-04-28 Thread Daniel Kahn Gillmor
S/MIME messages that use PKCS#7 are not currently well-handled by notmuch. This series introduces a set of tests that cover such messages, most of which are initially broken. A future (shorter) series will resolve these tests. Some S/MIME messages *are* handled correctly by notmuch already: in

[PATCH 01/15] tests: move add_gpgsm_home to test-lib.sh

2020-04-28 Thread Daniel Kahn Gillmor
This allows us to test S/MIME messages in other tests. Signed-off-by: Daniel Kahn Gillmor --- test/T355-smime.sh | 13 - test/test-lib.sh | 13 + 2 files changed, 13 insertions(+), 13 deletions(-) diff --git a/test/T355-smime.sh b/test/T355-smime.sh index 11a4d6cd

[PATCH 10/15] tests/smime: Verify cryptographic message status

2020-04-28 Thread Daniel Kahn Gillmor
When consuming a signed+encrypted S/MIME message generated by emacs, we expect to see the same cryptographic properties for the message as a whole. This is not done correctly yet, so the test is marked as known broken. Signed-off-by: Daniel Kahn Gillmor --- test/T355-smime.sh | 9 + 1

Re: Inconsistencies in handling command flags: `--flag=value` different than `--flag value`

2020-04-27 Thread Daniel Kahn Gillmor
On Mon 2020-04-27 14:53:07 -0300, David Bremner wrote: > Quoting notmuch(1) > >OPTION SYNTAX >All options accepting an argument can be used with '=' >or ':' as a separator. For the cases where it's not ambiguous >(in particular excluding boolean options), a space can

Re: [PATCH] util/zlib-extra: de-inline gzerror_str

2020-04-27 Thread Daniel Kahn Gillmor
On Mon 2020-04-27 09:28:08 -0300, David Bremner wrote: > It turns out the behaviour of inline functions in C header files is > not a good idea, and can cause linking problems if the compiler > decides not to inline them. In principle this is solvable by using a > "static inline" declaration, but

Re: Weird tagging issue

2020-03-29 Thread Daniel Kahn Gillmor
On Sun 2020-03-29 17:53:01 -0700, Carl Worth wrote: > On Mon, Mar 30 2020, Brian May wrote: >> This applies to all 4 of those messages. Yes, they all look like they >> have the same Message-ID > > 4 different messages all with the same message ID definitely violates a > core assumption of notmuch

Re: Weird tagging issue

2020-03-29 Thread Daniel Kahn Gillmor
Hi Brian-- whew, what a mess! I'm having a hard time identifying a specific problem, but I did notice this surprising sequence: On Mon 2020-03-30 08:03:20 +1100, Brian May wrote: > subgraph "cluster_id:pr-wspdigital/bupaoshc/8...@bitbucket.org" { > "pr-wspdigital/bupaoshc/8...@bitbucket.org"

Re: [PATCH] debian: Add packaging for python3-notmuch2

2020-03-24 Thread Daniel Kahn Gillmor
On Fri 2020-01-10 18:16:37 -0500, Daniel Kahn Gillmor wrote: > I took one more step at debugging the newly-built modules to try to > understand why the non-stripped versions might differ, and noticed that > the debugging info in each module itself is different. in particular, > in th

Re: [PATCH] nmbug: explicitly prefer python3

2020-03-24 Thread Daniel Kahn Gillmor
On Thu 2020-03-12 18:57:51 +0200, Tomi Ollila wrote: > I've been running nmbug with a wrapper that runs python 2.7 (since default > python in that particular machine is python 2.6 -- which doesn't work with > nmbug (or it may but that is complicated, i'm not sure...). > > So, to me just doing

Re: Weird tagging issue

2020-03-22 Thread Daniel Kahn Gillmor
On Sun 2020-03-22 22:12:14 -0300, David Bremner wrote: > I think dkg and I agreed a few years ago we should ship [draw-thread] > as one of our devel tools, but then I didn't follow through. So I'd be > interested in knowing if it works for you. fwiw, i still think it's worth shipping it in devel/

Re: Weird tagging issue

2020-03-20 Thread Daniel Kahn Gillmor
Hi Brian-- On Fri 2020-03-20 11:06:55 +1100, Brian May wrote: > Brian May writes: > >> I am having a problem with certain messages, in that I remove the tag >> and it still shows up in search results. > > I just recreated the entire database, and I still get the same problem. This sounds really

[PATCH 1/2] mime-node: rename decrypted_child to unwrapped_child

2020-03-18 Thread Daniel Kahn Gillmor
unwrappings as well as multipart/encrypted decryptions. This change is just a naming change, it has no effect on function. Signed-off-by: Daniel Kahn Gillmor --- mime-node.c | 10 +- notmuch-client.h | 6 -- 2 files changed, 9 insertions(+), 7 deletions(-) diff --git a/mime

[PATCH 2/2] mime-node: Clean up unwrapped MIME parts correctly.

2020-03-18 Thread Daniel Kahn Gillmor
We clean it up by analogy with cleaning up the signature list associated with a MIME node. Signed-off-by: Daniel Kahn Gillmor --- mime-node.c | 22 ++ 1 file changed, 22 insertions(+) diff --git a/mime-node.c b/mime-node.c index 2a823dfd..ff6805bf 100644 --- a/mime-node.c

Minor cleanup to mime-node.c

2020-03-18 Thread Daniel Kahn Gillmor
This simple 2-patch series is a bit of cleanup that i noticed while completing the work on handling S/MIME messages. It's not strictly part of the S/MIME series, so breaking out this minor cleanup separately should make it easier to review. Regards, --dkg

[PATCH] emacs: avoid warning about notmuch-show-get-message-id

2020-03-18 Thread Daniel Kahn Gillmor
for their followup about this. Signed-off-by: Daniel Kahn Gillmor --- emacs/notmuch-crypto.el | 1 + 1 file changed, 1 insertion(+) diff --git a/emacs/notmuch-crypto.el b/emacs/notmuch-crypto.el index 4035ee37..928de0bb 100644 --- a/emacs/notmuch-crypto.el +++ b/emacs/notmuch-crypto.el @@ -163,6

[PATCH] configure: Check GMime version properly

2020-03-18 Thread Daniel Kahn Gillmor
Signed-off-by: Daniel Kahn Gillmor --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index c16d18dc..70031d14 100755 --- a/configure +++ b/configure @@ -513,7 +513,7 @@ fi GMIME_MINVER=3.0.3 printf "Checking for GMime development

[PATCH] tests/smime: fix typo in README

2020-03-18 Thread Daniel Kahn Gillmor
Signed-off-by: Daniel Kahn Gillmor --- test/smime/README | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/smime/README b/test/smime/README index 92803c77..46211922 100644 --- a/test/smime/README +++ b/test/smime/README @@ -2,6 +2,6 @@ test.crt: self signed certificated

[PATCH] mime-node: Pass the correct flags to g_mime_multipart_signed_verify

2020-03-18 Thread Daniel Kahn Gillmor
GMIME_ENCRYPT_NONE and GMIME_VERIFY_NONE have the same value, but they are different enumerated types. So in C, this is a cosmetic change, but it is technically correct if we only had stricter typing. Signed-off-by: Daniel Kahn Gillmor --- mime-node.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH] Correct doxygen framing for libnotmuch.h

2020-03-17 Thread Daniel Kahn Gillmor
Apparently doxygen needs its comments formatted in a specific way to notice that the group is closed. Without this fix, with doxygen 1.8.16-2 we see: ``` doxygen ./doc/doxygen.cfg …/notmuch/lib/notmuch.h:2322: warning: end of file while inside a group ``` Signed-off-by: Daniel Kahn Gillmor

notmuch-crypto.el: "‘notmuch-show-get-message-id’ is not known to be defined"

2020-03-17 Thread Daniel Kahn Gillmor
When building the current version of notmuch on debian testing/unstable, i see the following warning: ``` EMACS emacs/notmuch-crypto.elc In end of data: emacs/notmuch-crypto.el:266:1:Warning: the function ‘notmuch-show-get-message-id’ is not known to be defined. ``` No part of the test

[PATCH] doc: Drop obsolete MSCGEN_PATH, PERL_PATH from doxygen configuration

2020-03-17 Thread Daniel Kahn Gillmor
o avoid the warnings. Signed-off-by: Daniel Kahn Gillmor --- doc/doxygen.cfg | 2 -- 1 file changed, 2 deletions(-) diff --git a/doc/doxygen.cfg b/doc/doxygen.cfg index 2ca15d41..a2c4fd07 100644 --- a/doc/doxygen.cfg +++ b/doc/doxygen.cfg @@ -264,12 +264,10 @@ GENERATE_TAGFILE

Re: [PATCH] nmbug: explicitly prefer python3

2020-03-12 Thread Daniel Kahn Gillmor
their path ? --dkg On Thu 2018-02-08 23:32:11 -0500, Daniel Kahn Gillmor wrote: > nmbug and notmuch-report are developer tools. It's 2018, and all > developers should have python3 available. > > Signed-off-by: Daniel Kahn Gillmor > --- > devel/nmbug/nmbug | 2 +- >

Re: [PATCH v3 0/7] Port notmuch-show's x/X bindings to notmuch-tree

2020-02-20 Thread Daniel Kahn Gillmor
On Sat 2019-12-28 10:01:17 -0500, William Casarin wrote: > These patches bring notmuch-tree more in line with the user experience > of notmuch-show by adding the x/X bindings. It looks like this series has been reviewed by dme, and is presumably approved by him, with the exception of patch 3/7,

Re: export notmuch_database_reopen

2020-02-20 Thread Daniel Kahn Gillmor
On Thu 2020-02-20 19:16:23 +0100, Reto wrote: > On 20 February 2020 18:18:52 CET, Daniel Kahn Gillmor > wrote: >>if you have a read/write DB, then the changes you make to the DB are >>also visible, right? it's not a static snapshot in that sense. > > Ehm, not the be

Re: [PATCH 2/2] doc: add a hint about field processor support availability

2020-02-20 Thread Daniel Kahn Gillmor
On Sun 2020-01-12 17:13:59 +0200, Tomi Ollila wrote: > But, if we already made Xapian 1.4 minimun requirement in the next notmuch > release, there XAPIAN_FIELD_PROCESSOR is always supported and all these > conditionals could be removed (before even adding new)... I'd support making Xapian 1.4 a

Re: [PATCH 2/2] sprinter: change integer method to use int64_t

2020-02-20 Thread Daniel Kahn Gillmor
On Thu 2020-02-13 19:13:51 -0400, David Bremner wrote: > Peter Wang writes: > >> In particular, timestamps beyond 2038 could overflow the sprinter >> interface on systems where time_t is 64-bit but 'int' is a signed 32-bit >> integer type. > > Series pushed to master. I'm a bit slow following up

Re: export notmuch_database_reopen

2020-02-20 Thread Daniel Kahn Gillmor
On Thu 2020-02-13 22:11:27 +0100, Reto wrote: > I'm trying to use the notmuch C library in a mail client. > Now, I learned that an open DB is essentially a snapshot at the time of > opening. > If I want the current state of the notmuch DB, I need to reopen the DB. if you have a read/write DB,

[PATCH] Drop deprecated/unused crypto.gpg_path

2020-02-18 Thread Daniel Kahn Gillmor
to unilaterally remove it. Signed-off-by: Daniel Kahn Gillmor --- bindings/python-cffi/tests/conftest.py | 2 -- doc/man1/notmuch-config.rst| 8 notmuch-config.c | 1 - 3 files changed, 11 deletions(-) diff --git a/bindings/python-cffi/tests/conftest.py b

upgrades to nmbug

2020-01-20 Thread Daniel Kahn Gillmor
Hi folks-- The server that runs https://nmbug.notmuchmail.org has just been upgraded from debian 9 (stretch) to debian 10 (buster). As far as i can tell, the upgrade went as smoothly as can be hoped for. Please give a shout if you think something is not working right there. --dkg, one

Re: filtering headers from forwarded messages

2020-01-16 Thread Daniel Kahn Gillmor
On Wed 2020-01-08 10:25:50 -0500, Daniel Kahn Gillmor wrote: > Thanks for the pointer! it looks like > message-forward-{ignored,included}-headers should do (roughly) what i > want. I'll try them out. Just reporting back that they do indeed suit my purposes. Things are much nicer now

Re: proposing "notmuch purge"

2020-01-14 Thread Daniel Kahn Gillmor
On Tue 2020-01-14 15:03:29 -0500, Antoine Beaupré wrote: > Agreed. If you want to delete messages matching an another tag, you just > run: > > notmuch tag +deleted tag:another > notmuch purge > > Composability wins over configurability in this case. :) I like this outcome, though i'm not

Re: proposing "notmuch purge"

2020-01-14 Thread Daniel Kahn Gillmor
On Wed 2020-01-15 09:59:14 +1100, Brian May wrote: > Daniel Kahn Gillmor writes: > >> So i'm proposing "notmuch purge", which could be something as simple as >> the equivalent of: > > I can't help think it will only be a matter of time before somebody > mist

Re: proposing "notmuch purge"

2020-01-14 Thread Daniel Kahn Gillmor
On Tue 2020-01-14 07:01:08 +0200, Teemu Likonen wrote: > We would need "notmuch search --exclude=false tag:deleted" to really > find all messages with tag:deleted. I agree that we ought to deliberately avoid the exclude_tags when purging. > I think that the "SEARCH-TERMS" part should be

proposing "notmuch purge"

2020-01-13 Thread Daniel Kahn Gillmor
This e-mail proposes a new notmuch subcommand "purge", which actually removes explicitly deleted messages from the mailstore. Notmuch currently never deletes mail, but notmuch-emacs makes it easy to tag mail with "deleted" (via the "d") key, and "notmuch setup" automatically adds "deleted" to the

Re: [PATCH] debian: Add packaging for python3-notmuch2

2020-01-10 Thread Daniel Kahn Gillmor
On Fri 2020-01-10 16:01:35 -0500, Daniel Kahn Gillmor wrote: > during the more recent build, i also see this warning from dh_python3: > > W: dh_python3 fs:112: Paths differ: > debian/python3-notmuch2/usr/lib/python3.8/dist-packages/notmuch2/_capi.abi3.so > and > debian/python

Re: [PATCH] debian: Add packaging for python3-notmuch2

2020-01-10 Thread Daniel Kahn Gillmor
On Thu 2020-01-09 22:38:02 -0400, David Bremner wrote: > Daniel Kahn Gillmor writes: > >> On Mon 2019-12-23 17:17:22 -0500, Daniel Kahn Gillmor wrote: >>> Ship a new debian package for the notmuch2 CFFI-based Python interface >>> to notmuch. >>> >&g

[PATCH] doc: clean up manpage description of "notmuch-config list" output

2020-01-10 Thread Daniel Kahn Gillmor
to stdout, each on a separate line of the form: *section*.\ *item*\ =\ *value* This simplification cleans up the overescaping. Signed-off-by: Daniel Kahn Gillmor --- doc/man1/notmuch-config.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH] debian: Add packaging for python3-notmuch2

2020-01-08 Thread Daniel Kahn Gillmor
On Mon 2019-12-23 17:17:22 -0500, Daniel Kahn Gillmor wrote: > Ship a new debian package for the notmuch2 CFFI-based Python interface > to notmuch. > > Unlike the notmuch python module, the new notmuch2 module is no longer > arch-independent, because it builds and ships

Re: [PATCH] debian: add Build-Depends-Package for libnotmuch5.symbols

2020-01-08 Thread Daniel Kahn Gillmor
On Mon 2019-12-23 15:14:38 -0500, Daniel Kahn Gillmor wrote: > See lintian informational tag > symbols-file-missing-build-depends-package-field for hints about this > minor metadata update. > > Signed-off-by: Daniel Kahn Gillmor > --- > debian/libnotmuch5.symbols | 1 +

Re: filtering headers from forwarded messages

2020-01-08 Thread Daniel Kahn Gillmor
On Mon 2019-12-30 15:16:59 +0200, Teemu Likonen wrote: > Daniel Kahn Gillmor [2019-12-20T13:50:03-05] wrote: > >> In notmuch-emacs, i can manually filter the headers by editing the >> reply compose buffer, of course, but it's kind of a pain, and it'd be >> nice to have it d

Re: [PATCH 1/2] legacy-display: accept text/plain legacy display parts

2019-12-24 Thread Daniel Kahn Gillmor
On Wed 2019-12-25 06:23:57 +0900, David Bremner wrote: > Daniel Kahn Gillmor writes: > >> Bremner, if you are considering a merge, and want to inject this comment >> yourself, that's fine with me. let me know if you want me to send >> another revision instead. > >

[PATCH v2] legacy-display: accept text/plain legacy display parts

2019-12-24 Thread Daniel Kahn Gillmor
ntent-type text/rfc822-headers. Notmuch should recognize the part whichever of the two content-types it uses. See also discussion in https://github.com/autocrypt/protected-headers/issues/23 for why the community of implementers is moving in the direction of text/plain. Signed-off-by: Daniel Ka

Re: [PATCH 1/2] legacy-display: accept text/plain legacy display parts

2019-12-24 Thread Daniel Kahn Gillmor
On Tue 2019-12-24 10:59:09 +, David Edmondson wrote: > Patch looks good, though I would quite like there to be a comment in the > code. Something simple like: > > /* text/rfc822-headers was replaced by text/plain as the MIME type for > “Legacy Display” parts - we allow either. */ I have no

[PATCH] debian: Add packaging for python3-notmuch2

2019-12-23 Thread Daniel Kahn Gillmor
Ship a new debian package for the notmuch2 CFFI-based Python interface to notmuch. Unlike the notmuch python module, the new notmuch2 module is no longer arch-independent, because it builds and ships a shared object in addition to the python code. This patch encourages new downstream development

[PATCH] debian: Override lintian suggestion to move elpa-notmuch to Section: lisp

2019-12-23 Thread Daniel Kahn Gillmor
Signed-off-by: Daniel Kahn Gillmor --- debian/elpa-notmuch.lintian-overrides | 4 1 file changed, 4 insertions(+) create mode 100644 debian/elpa-notmuch.lintian-overrides diff --git a/debian/elpa-notmuch.lintian-overrides b/debian/elpa-notmuch.lintian-overrides new file mode 100644 index

[PATCH] python/notmuch2: fix typo for "destroyed"

2019-12-23 Thread Daniel Kahn Gillmor
Another fix to the docstrings, this time for the English part of the docstrings, not the Python class name. No functional changes here. Signed-off-by: Daniel Kahn Gillmor --- bindings/python-cffi/notmuch2/_database.py | 28 +++--- bindings/python-cffi/notmuch2/_errors.py | 2

[PATCH] python/notmuch2: fix typo for ObjectDestroyedError

2019-12-23 Thread Daniel Kahn Gillmor
There is no functional change here, just a fix to a typo in the docstrings. Signed-off-by: Daniel Kahn Gillmor --- bindings/python-cffi/notmuch2/__init__.py | 2 +- bindings/python-cffi/notmuch2/_database.py | 4 ++-- bindings/python-cffi/notmuch2/_tags.py | 2 +- 3 files changed, 4

[PATCH] debian: add Build-Depends-Package for libnotmuch5.symbols

2019-12-23 Thread Daniel Kahn Gillmor
See lintian informational tag symbols-file-missing-build-depends-package-field for hints about this minor metadata update. Signed-off-by: Daniel Kahn Gillmor --- debian/libnotmuch5.symbols | 1 + 1 file changed, 1 insertion(+) diff --git a/debian/libnotmuch5.symbols b/debian/libnotmuch5

[PATCH 1/2] legacy-display: accept text/plain legacy display parts

2019-12-23 Thread Daniel Kahn Gillmor
ntent-type text/rfc822-headers. Notmuch should recognize the part whichever of the two content-types it uses. See also discussion in https://github.com/autocrypt/protected-headers/issues/23 for why the community of implementers is moving in the direction of text/plain. Signed-off-by: Daniel Ka

[PATCH 2/2] legacy-display: drop tests that try to match headers in a Legacy Display part

2019-12-23 Thread Daniel Kahn Gillmor
tures, etc, all make it possible to ship some content in a message that will be visible in some MUAs but not in others. This doesn't make the situation demonstrably worse. Signed-off-by: Daniel Kahn Gillmor --- util/repair.c | 60 ++- 1 file c

filtering headers from forwarded messages

2019-12-20 Thread Daniel Kahn Gillmor
hey folks-- i recently had cause to forward a set of messages to a colleague via notmuch (thank you for "notmuch-show-forward-open-messages"!), and noticed that forwarding messages that i've personally received leaks quite a bit of metadata about message delivery paths that is (a) generally not

Re: moving the config into the database [was: Re: [PATCH] Display extra headers for emacs-mua - db config option]

2019-12-12 Thread Daniel Kahn Gillmor
On Wed 2019-12-11 10:00:07 -0400, David Bremner wrote: > David Edmondson writes: > >> It seems that only “notmuch new” is currently prepared to create a new >> database, but it will also import all of my email before I have a chance >> to set the above parameters. >> >> It seems that the obvious

Re: moving the config into the database [was: Re: [PATCH] Display extra headers for emacs-mua - db config option]

2019-12-11 Thread Daniel Kahn Gillmor
On Tue 2019-12-10 09:46:14 -0300, Jorge P. de Morais Neto wrote: > I hope you don't mind my insistence Insistence is fine -- it sounds like you have a real need for your backup/sync strategy, and if we can figure out a way to support it, that would be good. perhaps we should talk about different

Re: [PATCH] lib: fix memory error in notmuch_config_list_value

2019-12-09 Thread Daniel Kahn Gillmor
On Mon 2019-11-25 19:21:24 +0200, Tomi Ollila wrote: > On Sun, Nov 24 2019, David Bremner wrote: > >> The documentation for notmuch_config_list_key warns that that the >> returned value will be destroyed by the next call to >> notmuch_config_list_key, but it neglected to mention that calling >>

Re: [PATCH] test: add a known broken test for S/MIME decryption

2019-12-09 Thread Daniel Kahn Gillmor
On Sun 2019-11-17 21:58:12 -0400, David Bremner wrote: > This should serve to clarify this feature is not implimented in > notmuch yet. > --- > test/T355-smime.sh | 9 + > 1 file changed, 9 insertions(+) > > diff --git a/test/T355-smime.sh b/test/T355-smime.sh > index 336da917..11a4d6cd

Re: [PATCH] configure: fix reference to possibly undefined $PKG_CONFIG_PATH

2019-12-09 Thread Daniel Kahn Gillmor
On Sun 2019-11-17 23:24:41 +0200, Tomi Ollila wrote: > In case zlib not found by pkg-config(1) the pkg-config information > is resolved by attempting to print ZLIB_VERSION from from zlib > installation if it exists anyway. > > If above done successfully compat/zlib.pc is written for forthcoming >

[PATCH 2/4] debian: ship info files in the standard location

2019-12-09 Thread Daniel Kahn Gillmor
Signed-off-by: Daniel Kahn Gillmor --- debian/elpa-notmuch.elpa | 1 - debian/elpa-notmuch.info | 1 + 2 files changed, 1 insertion(+), 1 deletion(-) create mode 100644 debian/elpa-notmuch.info diff --git a/debian/elpa-notmuch.elpa b/debian/elpa-notmuch.elpa index 19e3ba51..a924468a 100644

[PATCH 1/4] debian: record upstream files which should not be installed by the package

2019-12-09 Thread Daniel Kahn Gillmor
Signed-off-by: Daniel Kahn Gillmor --- debian/not-installed | 3 +++ 1 file changed, 3 insertions(+) create mode 100644 debian/not-installed diff --git a/debian/not-installed b/debian/not-installed new file mode 100644 index ..fd929459 --- /dev/null +++ b/debian/not-installed @@ -0,0

[PATCH 4/4] debian: move packaging to dh 12

2019-12-09 Thread Daniel Kahn Gillmor
--- debian/compat | 1 - debian/control | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) delete mode 100644 debian/compat diff --git a/debian/compat b/debian/compat deleted file mode 100644 index b4de3947.. --- a/debian/compat +++ /dev/null @@ -1 +0,0 @@ -11 diff --git

[PATCH 3/4] debian elpa-notmuch: ship elisp and .png from "make install"

2019-12-09 Thread Daniel Kahn Gillmor
the deployed package. Signed-off-by: Daniel Kahn Gillmor --- debian/elpa-notmuch.elpa | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/debian/elpa-notmuch.elpa b/debian/elpa-notmuch.elpa index a924468a..4712b73f 100644 --- a/debian/elpa-notmuch.elpa +++ b/debian/elpa-notmu

Complete Debian packaging transition to dh 12

2019-12-09 Thread Daniel Kahn Gillmor
This series follows the series introduced by id:20191204084742.398298-1-...@fifthhorseman.net Its goal is to move the notmuch debian packaging to dh 12. To do this, the series accepts the conclusions about info files reached in the thread anchored at id:87a7887akl@fifthhorseman.net, and it

Re: moving the config into the database [was: Re: [PATCH] Display extra headers for emacs-mua - db config option]

2019-12-09 Thread Daniel Kahn Gillmor
On Sun 2019-12-08 15:19:38 -0300, Jorge P. de Morais Neto wrote: > Em [2019-12-08 dom 09:12:55-0800], Jameson Graef Rollins escreveu: > >> You can already use 'notmuch config list' to dump every configuration >> item to stdout. Would that be sufficient for personal synchronization >> purposes. >

Re: shipping elisp for notmuch in elpa-notmuch debian package

2019-12-09 Thread Daniel Kahn Gillmor
On Sat 2019-12-07 10:32:26 -0400, David Bremner wrote: > sure, I don't really object to this. I guess I was just lazy / > impressed-with-myself for finding an upstream way to install info > files. As long as you don't break "make elpa", I don't mind making the > debian packaging more standard. I

Re: shipping elisp for notmuch in elpa-notmuch debian package

2019-12-06 Thread Daniel Kahn Gillmor
On Wed 2019-12-04 15:29:24 -0400, David Bremner wrote: > no. the standalone info reader is a weakness of this approach, since it > only looks in /usr/share/info. So i did a dumb search for other .info pages on a reasonably well-used modern system: dpkg -S .info | grep -v ': /usr/share/info'

Re: compacting the notmuch database through systemd

2019-12-06 Thread Daniel Kahn Gillmor
On Thu 2019-12-05 11:38:09 +, Georg Faerber wrote: > On 19-12-05 08:29:44, Jorge P. de Morais Neto wrote: >> But the user might have changed ~NOTMUCH_CONFIG~. On my Debian >> install it is "~/.config/notmuch/config" (XDG compliant). > > It's possible to specify multiple conditions, and join

Re: compacting the notmuch database through systemd

2019-12-04 Thread Daniel Kahn Gillmor
Thanks for raising this, Anarcat! One more advantage that i think you haven't noted yet about regular database compaction: "notmuch compact" tends to get rid of a lot of lingering written data that is no longer referenced. While this isn't robust "secure deletion", it's a lot better than not

Re: shipping elisp for notmuch in elpa-notmuch debian package

2019-12-04 Thread Daniel Kahn Gillmor
On Wed 2019-12-04 08:53:14 -0400, David Bremner wrote: > Daniel Kahn Gillmor writes: >> rstdoc.el >> make-deps.el >> dir > > the first two are build tools. if they're build tools then we don't need to ship them with elpa-notmuch, right? > The latt

[PATCH 1/5] debian: return an error if debian snapshot build fails

2019-12-04 Thread Daniel Kahn Gillmor
Signed-off-by: Daniel Kahn Gillmor --- Makefile.local | 18 ++ 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/Makefile.local b/Makefile.local index 7c12612d..586cdf75 100644 --- a/Makefile.local +++ b/Makefile.local @@ -97,14 +97,16 @@ pre-release: .PHONY: debian

[PATCH 5/5] debian: Remove python2 detritus

2019-12-04 Thread Daniel Kahn Gillmor
Since we removed python-notmuch, we do not need to retain this file any longer. Signed-off-by: Daniel Kahn Gillmor --- debian/python-notmuch.install | 1 - 1 file changed, 1 deletion(-) delete mode 100644 debian/python-notmuch.install diff --git a/debian/python-notmuch.install b/debian/python

[PATCH 4/5] debian: ship notmuch-setup(1) as a copy of notmuch(1)

2019-12-04 Thread Daniel Kahn Gillmor
This was being shipped by "make install", but we weren't shipping it in the debian package. Thanks to dh_missing for noticing! Signed-off-by: Daniel Kahn Gillmor --- debian/notmuch.manpages | 1 + 1 file changed, 1 insertion(+) diff --git a/debian/notmuch.manpages b/debian/notmuc

[PATCH 3/5] debian: install notmuch(3) manpage in libnotmuch-dev

2019-12-04 Thread Daniel Kahn Gillmor
dh_missing noticed that we are building this manpage but not shipping it in debian. Signed-off-by: Daniel Kahn Gillmor --- debian/libnotmuch-dev.manpages | 1 + 1 file changed, 1 insertion(+) create mode 100644 debian/libnotmuch-dev.manpages diff --git a/debian/libnotmuch-dev.manpages b

[PATCH 2/5] debian: ship notmuch-emacs-mua.desktop from "make install" copy

2019-12-04 Thread Daniel Kahn Gillmor
This helps dh_missing know what's going on. Signed-off-by: Daniel Kahn Gillmor --- debian/notmuch.install | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/debian/notmuch.install b/debian/notmuch.install index b4847fe5..60f09712 100644 --- a/debian/notmuch.install +++ b/debian

More debian packaging cleanup

2019-12-04 Thread Daniel Kahn Gillmor
This series should apply after "wrap-and-sort -ast" v2 is applied (id:20191110173748.25792-5-...@fifthhorseman.net). In this series, i clean up a few things that i noticed from applying dh_missing to the debian packaging. In particular, we were failing to ship notmuch(3) (programmer's manual for

shipping elisp for notmuch in elpa-notmuch debian package

2019-12-04 Thread Daniel Kahn Gillmor
Hi Notmuch folks-- In the course of trying to figure out the dh_missing warnings, I've been looking into what we ship in debian in the elpa-notmuch package. Dubious files - elpa-notmuch currently ships a few files in /usr/share/emacs/site-lisp/elpa-src/notmuch-*/ that i'm not

Re: [PATCH 3/6] Move to dh 12

2019-12-03 Thread Daniel Kahn Gillmor
On Tue 2019-12-03 19:17:19 -0400, David Bremner wrote: > I've merged all except this patch, Thanks! > and the wrap-and-sort. No real objection to the latter, but it is too > painful to rebase, and will need regeneration. I've regenerated it and sent it to the list. the earlier you apply

[PATCH 4/6 v2] wrap-and-sort -ast

2019-12-03 Thread Daniel Kahn Gillmor
Signed-off-by: Daniel Kahn Gillmor --- debian/control | 105 debian/notmuch-mutt.install | 2 +- debian/notmuch-vim.dirs | 4 +- debian/notmuch-vim.install | 4 +- debian/notmuch.install | 2 +- debian/notmuch.manpages | 18

<    1   2   3   4   5   6   7   8   9   10   >