Update test_emacs documentation in test/README according to the latest
changes in emacs tests. Move the note regarding setting variables
from test/emacs to test/README.
---
test/README | 10 +++---
test/emacs |5 -
2 files changed, 7 insertions(+), 8 deletions(-)
diff --git a/test
This version implements suggestions by Austin.
Regards,
Dmitry
___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch
>
Oh. I hope atomicity will be there soon.
> Three minor comments below.
>
> On Sun, Jul 3, 2011 at 9:59 PM, Dmitry Kurochkin
> wrote:
> > There is existing support for broken tests. But it is not convenient
> > to use. The primary issue is that we have to m
Human-friendly scenario:
* open a thread where a message which ends with an HTML part is
followed by another message
* make the first message visible
* goto the beginning of the second message (first line, first colon)
* hit "RET"
Result: nothing happens except for "No URL at point" message
There is existing support for broken tests. But it is not convenient
to use. The primary issue is that we have to maintain a set of
test_expect_*_failure functions which are equivalent to the normal
test_expect_* counterparts except for what functions are called for
result reporting. The patch a
Update test_emacs documentation in test/README according to the latest
changes in emacs tests. Move the note regarding setting variables
from test/emacs to test/README.
---
test/README | 10 +++---
test/emacs |5 -
2 files changed, 7 insertions(+), 8 deletions(-)
diff --git a/test
The patch rewrites `notmuch-show-message-extent' to be more
robust. The main goal is to make it work as expected if point is
invisible. Besides, there are no more point movements and
property search functions are used instead manual loops. The
comment regarding properties strangeness is removed
Human-friendly scenario:
* open a thread which has at least 2 messages in notmuch-show view
* hide the first message
* move to the first line of the second message
* press C-a (bound to `beginning-of-visual-line')
* press RET (bound to `notmuch-show-toggle-message')
Result: the first message is s
The patch rewrites `notmuch-show-message-extent' to be more
robust. The main goal is to make it work as expected if point is
invisible. Besides, there are no more point movements and
property search functions are used instead manual loops. The
comment regarding properties strangeness is removed
Human-friendly scenario:
* open a thread which has at least 2 messages in notmuch-show view
* hide the first message
* move to the first line of the second message
* press C-a (bound to `beginning-of-visual-line')
* press RET (bound to `notmuch-show-toggle-message')
Result: the first message is s
Just fix some typos in the recently added NEWS for notmuch 0.6
release.
---
Amended version, fixes one more typo.
Regards,
Dmitry
NEWS | 28 ++--
1 files changed, 14 insertions(+), 14 deletions(-)
diff --git a/NEWS b/NEWS
index d55453b..8149899 100644
--- a/NEWS
+++
Just fix some typos in the recently added NEWS for notmuch 0.6
release.
---
NEWS | 26 +-
1 files changed, 13 insertions(+), 13 deletions(-)
diff --git a/NEWS b/NEWS
index d55453b..d9ffb02 100644
--- a/NEWS
+++ b/NEWS
@@ -79,13 +79,13 @@ Deprecate "notmuch search-tags",
Just fix some typos in the recently added NEWS for notmuch 0.6
release.
---
Amended version, fixes one more typo.
Regards,
Dmitry
NEWS | 28 ++--
1 files changed, 14 insertions(+), 14 deletions(-)
diff --git a/NEWS b/NEWS
index d55453b..8149899 100644
--- a/NEWS
+++
Just fix some typos in the recently added NEWS for notmuch 0.6
release.
---
NEWS | 26 +-
1 files changed, 13 insertions(+), 13 deletions(-)
diff --git a/NEWS b/NEWS
index d55453b..d9ffb02 100644
--- a/NEWS
+++ b/NEWS
@@ -79,13 +79,13 @@ Deprecate "notmuch search-tags",
`point-invisible-p' does not work correctly when `invisible'
property is a list. There are standard `invisible-p' and related
functions that should be used instead.
---
emacs/notmuch-lib.el | 15 ---
1 files changed, 0 insertions(+), 15 deletions(-)
diff --git a/emacs/notmuch-lib.e
Remove `notmuch-show-move-past-invisible-backward' and
`notmuch-show-move-past-invisible-forward' functions which are
unused.
---
emacs/notmuch-show.el |8
1 files changed, 0 insertions(+), 8 deletions(-)
diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
index ad3cc7b..dcaea
Use `previous-single-char-property-change' instead of going
through each character by hand and testing it's visibility. This
fixes `notmuch-show-advance-and-archive' to work for the last
message in thread with hidden signature.
---
emacs/notmuch-show.el | 17 +
1 files changed,
Add Emacs test to check that `notmuch-show-advance-and-archive'
works for the last message in thread with invisible signature.
---
test/emacs | 14 ++
1 files changed, 14 insertions(+), 0 deletions(-)
diff --git a/test/emacs b/test/emacs
index 53f455a..708c504 100755
--- a/test/emac
+20,6 @@
;;
;; Authors: Dmitry Kurochkin
-;; avoid crazy 10-column default of --batch
-(set-frame-width (window-frame (get-buffer-window)) 80)
-
;; `read-file-name' by default uses `completing-read' function to read
;; user input. It does not respect `standard-input' variable
Set SCREENRC and SYSSCREENRC environment variables to "/dev/null"
as suggested by Jim Paris to avoid potential problems with
screen(1) configuration files.
---
test/test-lib.sh |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/test/test-lib.sh b/test/test-lib.sh
index 68859
Before the change, emacs run in daemon mode without any visible
buffers. Turns out that this affects emacs behavior in some
cases. In particular, `window-end' function returns `point-max'
instead of the last visible position. That makes it hard or
impossible to implement some tests. The patch r
Amended patch series. Only minor changes:
* redirect errors from test_emacs in the emacs server wait loop to /dev/null
* reordered patches
Regards,
Dmitry
Add Emacs test to check that `notmuch-show-advance-and-archive'
works for the last message in thread with invisible signature.
---
test/emacs | 14 ++
1 files changed, 14 insertions(+), 0 deletions(-)
diff --git a/test/emacs b/test/emacs
index 53f455a..708c504 100755
--- a/test/emac
+20,6 @@
;;
;; Authors: Dmitry Kurochkin
-;; avoid crazy 10-column default of --batch
-(set-frame-width (window-frame (get-buffer-window)) 80)
-
;; `read-file-name' by default uses `completing-read' function to read
;; user input. It does not respect `standard-input' variable
Set SCREENRC and SYSSCREENRC environment variables to "/dev/null"
as suggested by Jim Paris to avoid potential problems with
screen(1) configuration files.
---
test/test-lib.sh |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/test/test-lib.sh b/test/test-lib.sh
index 68859
Before the change, emacs run in daemon mode without any visible
buffers. Turns out that this affects emacs behavior in some
cases. In particular, `window-end' function returns `point-max'
instead of the last visible position. That makes it hard or
impossible to implement some tests. The patch r
`point-invisible-p' does not work correctly when `invisible'
property is a list. There are standard `invisible-p' and related
functions that should be used instead.
---
emacs/notmuch-lib.el | 15 ---
1 files changed, 0 insertions(+), 15 deletions(-)
diff --git a/emacs/notmuch-lib.e
Remove `notmuch-show-move-past-invisible-backward' and
`notmuch-show-move-past-invisible-forward' functions which are
unused.
---
emacs/notmuch-show.el |8
1 files changed, 0 insertions(+), 8 deletions(-)
diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
index ad3cc7b..dcaea
Use `previous-single-char-property-change' instead of going
through each character by hand and testing it's visibility. This
fixes `notmuch-show-advance-and-archive' to work for the last
message in thread with hidden signature.
---
emacs/notmuch-show.el | 17 +
1 files changed,
Amended patch series. Only minor changes:
* redirect errors from test_emacs in the emacs server wait loop to /dev/null
* reordered patches
Regards,
Dmitry
___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuc
Do not redirect test_emacs stderr to /dev/null. Test_emacs uses
emacsclient(1) now and it does not print unwanted messages (like
those from `message') to stderr. But it does print useful
errors, e.g. when emacs server connection fails, given expression
is not valid or undefined function is called
The patch adds a test to check that json show format includes
filenames for attachments with inline disposition.
---
Carl, I owe you this test case for my patch that added filenames
for inline attachments :)
Regards,
Dmitry
test/json | 13 +
1 files changed, 13 insertions(+), 0
Do not redirect test_emacs stderr to /dev/null. Test_emacs uses
emacsclient(1) now and it does not print unwanted messages (like
those from `message') to stderr. But it does print useful
errors, e.g. when emacs server connection fails, given expression
is not valid or undefined function is called
The patch adds a test to check that json show format includes
filenames for attachments with inline disposition.
---
Carl, I owe you this test case for my patch that added filenames
for inline attachments :)
Regards,
Dmitry
test/json | 13 +
1 files changed, 13 insertions(+), 0
On Wed, 29 Jun 2011 16:16:40 -0400, Jim Paris wrote:
> Dmitry Kurochkin wrote:
> > Before the change, emacs run in daemon mode without any visible
> > buffers. Turns out that this affects emacs behavior in some
> > cases. In particular, `window-end' function returns
Set SCREENRC and SYSSCREENRC environment variables to "/dev/null"
as suggested by Jim Paris to avoid potential problems with
screen(1) configuration files.
---
test/test-lib.sh |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/test/test-lib.sh b/test/test-lib.sh
index 8d7c9
On Wed, 29 Jun 2011 09:10:19 +0400, Dmitry Kurochkin wrote:
> On Wed, 29 Jun 2011 05:48:50 +0400, Dmitry Kurochkin gmail.com> wrote:
> > Add Emacs test to check that `notmuch-show-advance-and-archive'
> > works for the last message in thread with invisible signature.
>
`point-invisible-p' does not work correctly when `invisible'
property is a list. There are standard `invisible-p' and related
functions that should be used instead.
---
emacs/notmuch-lib.el | 15 ---
1 files changed, 0 insertions(+), 15 deletions(-)
diff --git a/emacs/notmuch-lib.e
Remove `notmuch-show-move-past-invisible-backward' and
`notmuch-show-move-past-invisible-forward' functions which are
unused.
---
emacs/notmuch-show.el |8
1 files changed, 0 insertions(+), 8 deletions(-)
diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
index ad3cc7b..dcaea
Use `previous-single-char-property-change' instead of going
through each character by hand and testing it's visibility. This
fixes `notmuch-show-advance-and-archive' to work for the last
message in thread with hidden signature.
---
emacs/notmuch-show.el | 17 +
1 files changed,
Add Emacs test to check that `notmuch-show-advance-and-archive'
works for the last message in thread with invisible signature.
---
test/emacs | 14 ++
1 files changed, 14 insertions(+), 0 deletions(-)
diff --git a/test/emacs b/test/emacs
index e59de47..bad1122 100755
--- a/test/emac
+20,6 @@
;;
;; Authors: Dmitry Kurochkin
-;; avoid crazy 10-column default of --batch
-(set-frame-width (window-frame (get-buffer-window)) 80)
-
;; `read-file-name' by default uses `completing-read' function to read
;; user input. It does not respect `standard-input' variable
Before the change, emacs run in daemon mode without any visible
buffers. Turns out that this affects emacs behavior in some
cases. In particular, `window-end' function returns `point-max'
instead of the last visible position. That makes it hard or
impossible to implement some tests. The patch r
On Wed, 29 Jun 2011 16:16:40 -0400, Jim Paris wrote:
> Dmitry Kurochkin wrote:
> > Before the change, emacs run in daemon mode without any visible
> > buffers. Turns out that this affects emacs behavior in some
> > cases. In particular, `window-end' function returns
Set SCREENRC and SYSSCREENRC environment variables to "/dev/null"
as suggested by Jim Paris to avoid potential problems with
screen(1) configuration files.
---
test/test-lib.sh |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/test/test-lib.sh b/test/test-lib.sh
index 8d7c9
On Wed, 29 Jun 2011 09:10:19 +0400, Dmitry Kurochkin
wrote:
> On Wed, 29 Jun 2011 05:48:50 +0400, Dmitry Kurochkin
> wrote:
> > Add Emacs test to check that `notmuch-show-advance-and-archive'
> > works for the last message in thread with invisible signature.
> > -
`point-invisible-p' does not work correctly when `invisible'
property is a list. There are standard `invisible-p' and related
functions that should be used instead.
---
emacs/notmuch-lib.el | 15 ---
1 files changed, 0 insertions(+), 15 deletions(-)
diff --git a/emacs/notmuch-lib.e
Remove `notmuch-show-move-past-invisible-backward' and
`notmuch-show-move-past-invisible-forward' functions which are
unused.
---
emacs/notmuch-show.el |8
1 files changed, 0 insertions(+), 8 deletions(-)
diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
index ad3cc7b..dcaea
Use `previous-single-char-property-change' instead of going
through each character by hand and testing it's visibility. This
fixes `notmuch-show-advance-and-archive' to work for the last
message in thread with hidden signature.
---
emacs/notmuch-show.el | 17 +
1 files changed,
Add Emacs test to check that `notmuch-show-advance-and-archive'
works for the last message in thread with invisible signature.
---
test/emacs | 14 ++
1 files changed, 14 insertions(+), 0 deletions(-)
diff --git a/test/emacs b/test/emacs
index e59de47..bad1122 100755
--- a/test/emac
+20,6 @@
;;
;; Authors: Dmitry Kurochkin
-;; avoid crazy 10-column default of --batch
-(set-frame-width (window-frame (get-buffer-window)) 80)
-
;; `read-file-name' by default uses `completing-read' function to read
;; user input. It does not respect `standard-input' variable
Before the change, emacs run in daemon mode without any visible
buffers. Turns out that this affects emacs behavior in some
cases. In particular, `window-end' function returns `point-max'
instead of the last visible position. That makes it hard or
impossible to implement some tests. The patch r
On Wed, 29 Jun 2011 05:48:50 +0400, Dmitry Kurochkin wrote:
> Add Emacs test to check that `notmuch-show-advance-and-archive'
> works for the last message in thread with invisible signature.
> ---
>
> This patch series fixes the bug reported by Sebastien in [1]. I
> was a
`point-invisible-p' does not work correctly when `invisible'
property is a list. There are standard `invisible-p' and related
functions that should be used instead.
---
emacs/notmuch-lib.el | 15 ---
1 files changed, 0 insertions(+), 15 deletions(-)
diff --git a/emacs/notmuch-lib.e
On Tue, 28 Jun 2011 21:38:17 +0400, Dmitry Kurochkin wrote:
> Hi Jani.
>
> On Tue, 28 Jun 2011 10:35:48 + (UTC), Jani Nikula
> wrote:
> > Carl Worth writes:
> >
> > >
> > > On Wed, 22 Jun 2011 08:50:23 +0200, Sebastien Binet
> > > wrot
Remove `notmuch-show-move-past-invisible-backward' and
`notmuch-show-move-past-invisible-forward' functions which are
unused.
---
emacs/notmuch-show.el |8
1 files changed, 0 insertions(+), 8 deletions(-)
diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
index ad3cc7b..dcaea
Use `previous-single-char-property-change' instead of going
through each character by hand and testing it's visibility. This
fixes `notmuch-show-advance-and-archive' to work for the last
message in thread with hidden signature.
---
emacs/notmuch-show.el | 17 +
1 files changed,
Add Emacs test to check that `notmuch-show-advance-and-archive'
works for the last message in thread with invisible signature.
---
This patch series fixes the bug reported by Sebastien in [1]. I
was able to reproduce it and confirm that the second patch from
this series fixes the problem. Unfort
On Tue, 28 Jun 2011 15:14:04 -0700, Carl Worth wrote:
> On Tue, 28 Jun 2011 08:45:11 +0400, Dmitry Kurochkin gmail.com> wrote:
> > Before the change, every Emacs test ran in a separate Emacs
> > instance. Starting Emacs many times wastes considerable time and
> > it gets
On Tue, 28 Jun 2011 13:10:58 -0700, Carl Worth wrote:
Non-text part: multipart/signed
> On Tue, 28 Jun 2011 20:42:42 +0400, Dmitry Kurochkin gmail.com> wrote:
> > I would like to hear what other (Carl in particular) think about this.
> > If the consensus is for your approach, I
On Tue, 28 Jun 2011 13:10:58 -0700, Carl Worth wrote:
> On Tue, 28 Jun 2011 20:42:42 +0400, Dmitry Kurochkin gmail.com> wrote:
> > I would like to hear what other (Carl in particular) think about this.
> > If the consensus is for your approach, I would be happy to impleme
On Wed, 29 Jun 2011 05:48:50 +0400, Dmitry Kurochkin
wrote:
> Add Emacs test to check that `notmuch-show-advance-and-archive'
> works for the last message in thread with invisible signature.
> ---
>
> This patch series fixes the bug reported by Sebastien in [1]. I
> w
`point-invisible-p' does not work correctly when `invisible'
property is a list. There are standard `invisible-p' and related
functions that should be used instead.
---
emacs/notmuch-lib.el | 15 ---
1 files changed, 0 insertions(+), 15 deletions(-)
diff --git a/emacs/notmuch-lib.e
Hi Jani.
On Tue, 28 Jun 2011 10:35:48 + (UTC), Jani Nikula
wrote:
> Carl Worth writes:
>
> >
> > On Wed, 22 Jun 2011 08:50:23 +0200, Sebastien Binet
> > wrote:
> > > On Tue, 21 Jun 2011 15:09:20 -0700, Carl Worth wrote:
> > > > Perhaps this is an emacs bug?
> > > could be, but,
> > >
>
On Tue, 28 Jun 2011 12:22:57 -0400, Austin Clements wrote:
> Quoth myself on Jun 27 at 11:49 pm:
> > Quoth Dmitry Kurochkin on Jun 28 at 5:03 am:
> > EMACSDONE=$TEST_DIRECTORY/emacsdone
> > mkfifo $EMACSDONE
> > coproc emacs --batch --eval '(while t (eva
On Tue, 28 Jun 2011 21:38:17 +0400, Dmitry Kurochkin
wrote:
> Hi Jani.
>
> On Tue, 28 Jun 2011 10:35:48 + (UTC), Jani Nikula wrote:
> > Carl Worth writes:
> >
> > >
> > > On Wed, 22 Jun 2011 08:50:23 +0200, Sebastien Binet
> > > wrote:
Remove `notmuch-show-move-past-invisible-backward' and
`notmuch-show-move-past-invisible-forward' functions which are
unused.
---
emacs/notmuch-show.el |8
1 files changed, 0 insertions(+), 8 deletions(-)
diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
index ad3cc7b..dcaea
Use `previous-single-char-property-change' instead of going
through each character by hand and testing it's visibility. This
fixes `notmuch-show-advance-and-archive' to work for the last
message in thread with hidden signature.
---
emacs/notmuch-show.el | 17 +
1 files changed,
Add Emacs test to check that `notmuch-show-advance-and-archive'
works for the last message in thread with invisible signature.
---
This patch series fixes the bug reported by Sebastien in [1]. I
was able to reproduce it and confirm that the second patch from
this series fixes the problem. Unfort
On Tue, 28 Jun 2011 15:14:04 -0700, Carl Worth wrote:
> On Tue, 28 Jun 2011 08:45:11 +0400, Dmitry Kurochkin
> wrote:
> > Before the change, every Emacs test ran in a separate Emacs
> > instance. Starting Emacs many times wastes considerable time and
> > it gets worse
On Tue, 28 Jun 2011 13:10:58 -0700, Carl Worth wrote:
Non-text part: multipart/signed
> On Tue, 28 Jun 2011 20:42:42 +0400, Dmitry Kurochkin
> wrote:
> > I would like to hear what other (Carl in particular) think about this.
> > If the consensus is for your approach, I
On Tue, 28 Jun 2011 13:10:58 -0700, Carl Worth wrote:
> On Tue, 28 Jun 2011 20:42:42 +0400, Dmitry Kurochkin
> wrote:
> > I would like to hear what other (Carl in particular) think about this.
> > If the consensus is for your approach, I would be happy to implement
> >
Hi Jani.
On Tue, 28 Jun 2011 10:35:48 + (UTC), Jani Nikula wrote:
> Carl Worth writes:
>
> >
> > On Wed, 22 Jun 2011 08:50:23 +0200, Sebastien Binet
> > wrote:
> > > On Tue, 21 Jun 2011 15:09:20 -0700, Carl Worth wrote:
> > > > Perhaps this is an emacs bug?
> > > could be, but,
> > >
>
On Tue, 28 Jun 2011 12:22:57 -0400, Austin Clements wrote:
> Quoth myself on Jun 27 at 11:49 pm:
> > Quoth Dmitry Kurochkin on Jun 28 at 5:03 am:
> > EMACSDONE=$TEST_DIRECTORY/emacsdone
> > mkfifo $EMACSDONE
> > coproc emacs --batch --eval '(while t (eva
Before the change, every Emacs test ran in a separate Emacs
instance. Starting Emacs many times wastes considerable time and
it gets worse as the test suite grows. The patch solves this by
using a single Emacs server and emacsclient(1) to run multiple
tests. Emacs server is started on the first
Before the change, every Emacs test ran in a separate Emacs
instance. Starting Emacs many times wastes considerable time and
it gets worse as the test suite grows. The patch solves this by
using a single Emacs server and emacsclient(1) to run multiple
tests. Emacs server is started on the first
Instead of generating auxiliary run_emacs script every time
test_emacs is run, do it once in the beginning of the test.
Also, use absolute paths in the script to make it more robust.
---
test/test-lib.sh | 17 +++--
1 files changed, 11 insertions(+), 6 deletions(-)
diff --git a/tes
Using `setq' for setting variables in Emacs tests affect other
tests that may run in the same Emacs environment. Currently it
works because each test is run in a separate Emacs instance. But
in the future multiple tests will run in a single Emacs instance.
The patch changes all variables to use `
Minor changes to expected results of other Emacs tests were
needed because the message Date header changed.
---
test/emacs | 34 +-
1 files changed, 9 insertions(+), 25 deletions(-)
diff --git a/test/emacs b/test/emacs
index 4592005..409e033 100755
--- a/test/ema
Few Emacs tests used sed(1) to remove unexpected output in the
beginning to avoid getting confused by messages such as "Parsing
/home/cworth/.mailrc... done". This is no longer needed since
tests are run in a temporary home directory instead of the user's
one. So remove these sed(1) calls.
---
t
Before the change, the common Emacs test scheme was to print
buffer content to stdout and redirect it to a file or capture it
in a shell variable. This does not work if we switch to using
emacsclient(1) for running the tests, because you can not print
to the stdout in this case. (Actually, you can
Most test_emacs calls have long arguments that consist of many
expressions. Putting them on a single line makes it hard to read
and produces poor diff when they are changed. The patch puts
every expression in test_emacs calls on a separate line.
---
test/emacs | 124 ++
/test/test-lib.el
+++ b/test/test-lib.el
@@ -20,6 +20,14 @@
;;
;; Authors: Dmitry Kurochkin
+;; avoid crazy 10-column default of --batch
+(set-frame-width (window-frame (get-buffer-window)) 80)
+
+(defun notmuch-test-wait ()
+ "Wait for process completion."
+ (while (get-buffer-proces
It is no longer needed since tests are run in a temporary home
directory instead of the user's one.
---
test/test-lib.sh |3 ---
1 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/test/test-lib.sh b/test/test-lib.sh
index cc20f41..3ec388c 100755
--- a/test/test-lib.sh
+++ b/test/te
Few Emacs tests had test_expect_equal_file arguments in the wrong
order: the first argument should be the test output and the
second one should be the expected.
---
test/emacs |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/test/emacs b/test/emacs
index 6f82b08..f4ff3f1
On Tue, 28 Jun 2011 00:17:42 -0400, Austin Clements wrote:
> Quoth Dmitry Kurochkin on Jun 28 at 7:59 am:
> > I am sure that would work, but I do not like the complexity. How about
> > getting back to standard emacsclient and running a watchdog in the
> > emacs? Like:
&
On Mon, 27 Jun 2011 23:49:37 -0400, Austin Clements wrote:
> Quoth Dmitry Kurochkin on Jun 28 at 5:03 am:
> > > > The only way I know to
> > > > reliably kill a child process is to open a pipe to it and have it exit
> > > > on its own when it reads EOF.
Austin,
On Tue, 28 Jun 2011 00:22:41 +0400, Dmitry Kurochkin wrote:
> On Mon, 27 Jun 2011 16:02:12 -0400, Austin Clements
> wrote:
> > This looks like a great idea! The test suite has been getting irritating
> > slow.
> >
> > A few minor comments: This pa
;))' >&$EMACSFD
> echo 'Test' >&$EMACSFD
>
> Thoughts?
>
I like it and I will implement it. Thanks for the idea.
Regards,
Dmitry
> [1] If you don't do this, emacs complains that it can't read from
> stdin before it exits. It wo
Before the change, every Emacs test ran in a separate Emacs
instance. Starting Emacs many times wastes considerable time and
it gets worse as the test suite grows. The patch solves this by
using a single Emacs server and emacsclient(1) to run multiple
tests. Emacs server is started on the first
Most test_emacs calls have long arguments that consist of many
expressions. Putting them on a single line makes it hard to read
and produces poor diff when they are changed. The patch puts
every expression in test_emacs calls on a separate line.
---
test/emacs | 124 ++
Before the change, every Emacs test ran in a separate Emacs
instance. Starting Emacs many times wastes considerable time and
it gets worse as the test suite grows. The patch solves this by
using a single Emacs server and emacsclient(1) to run multiple
tests. Emacs server is started on the first
Using `setq' for setting variables in Emacs tests affect other
tests that may run in the same Emacs environment. Currently it
works because each test is run in a separate Emacs instance. But
in the future multiple tests will run in a single Emacs instance.
The patch changes all variables to use `
Instead of generating auxiliary run_emacs script every time
test_emacs is run, do it once in the beginning of the test.
Also, use absolute paths in the script to make it more robust.
---
test/test-lib.sh | 17 +++--
1 files changed, 11 insertions(+), 6 deletions(-)
diff --git a/tes
Minor changes to expected results of other Emacs tests were
needed because the message Date header changed.
---
test/emacs | 34 +-
1 files changed, 9 insertions(+), 25 deletions(-)
diff --git a/test/emacs b/test/emacs
index 4592005..409e033 100755
--- a/test/ema
Before the change, the common Emacs test scheme was to print
buffer content to stdout and redirect it to a file or capture it
in a shell variable. This does not work if we switch to using
emacsclient(1) for running the tests, because you can not print
to the stdout in this case. (Actually, you can
Few Emacs tests used sed(1) to remove unexpected output in the
beginning to avoid getting confused by messages such as "Parsing
/home/cworth/.mailrc... done". This is no longer needed since
tests are run in a temporary home directory instead of the user's
one. So remove these sed(1) calls.
---
t
/test/test-lib.el
+++ b/test/test-lib.el
@@ -20,6 +20,14 @@
;;
;; Authors: Dmitry Kurochkin
+;; avoid crazy 10-column default of --batch
+(set-frame-width (window-frame (get-buffer-window)) 80)
+
+(defun notmuch-test-wait ()
+ "Wait for process completion."
+ (while (get-buffer-proces
It is no longer needed since tests are run in a temporary home
directory instead of the user's one.
---
test/test-lib.sh |3 ---
1 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/test/test-lib.sh b/test/test-lib.sh
index cc20f41..3ec388c 100755
--- a/test/test-lib.sh
+++ b/test/te
Few Emacs tests had test_expect_equal_file arguments in the wrong
order: the first argument should be the test output and the
second one should be the expected.
---
test/emacs |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/test/emacs b/test/emacs
index 6f82b08..f4ff3f1
1001 - 1100 of 1248 matches
Mail list logo
