Re: [PATCH v2 08/10] ruby: move towards more modern RTypedData

Struct, and the information is stored in a struct rb_data_type_t, rather than passed as arguments. Check_Type is replaced with Check_TypedStruct, which is a wrapper for rb_check_typeddata (with casts). -- Felipe Contreras ___ notmuch mailing list -- notmuch@notmuchma

Re: [PATCH v2 04/10] ruby: simplify data get helper

On Wed, May 12, 2021 at 4:59 PM David Bremner wrote: > > Felipe Contreras writes: > > > The type is not actually needed. > > > > Signed-off-by: Felipe Contreras > > --- > > bindings/ruby/defs.h | 22 +++--- > > 1 file changed, 1

Re: Is there a reason why the trashed flag is not synced?

hed flag in IMAP. I'm not actually deleting anything, I just don't want to see those messages in my notmuch client (thanks to excluded_tags). -- Felipe Contreras ___ notmuch mailing list -- notmuch@notmuchmail.org To unsubscribe send an email to notmuch-le...@notmuchmail.org

Re: Is there a reason why the trashed flag is not synced?

On Sun, May 9, 2021 at 4:38 AM David Bremner wrote: > Felipe Contreras writes: > > I understand deleting files is complex, but what's wrong with simply > > tagging the T (trashed) messages as 'deleted'? > > > > I'm using synchronize_flags=true. > > Th

Re: nmbug update

then > let me know and I can provide you with a copy of the current source. Would you consider moving to a different web framework? If so, I could take a bite creating such a site, except probably with a Ruby framework. Cheers. -- Felipe Contreras ___

Re: The future of Ruby bindings

On Fri, Apr 30, 2021 at 5:14 PM Felipe Contreras wrote: > I understand why Ali Polatel did commit c7893408 (ruby: Kill garbage > collection related cruft., 2010-05-26); because the order of the object > destruction cannot be ensured in Ruby, however, there's ways to > workaround that

Re: [PATCH v2 00/10] ruby: object cleanups

On Tue, May 4, 2021 at 3:17 AM Felipe Contreras wrote: > > This superseeds my previous series [1] with much more cleanups. > > An important new change is the move towards RTypedData, which is way superior > to the old RData > objects. > > Everything should work basically

[PATCH v2 10/10] ruby: new notmuch_rb_object_destroy() helper

Using the rb_data_type_t data we can call the correct notmuch destroy function. Signed-off-by: Felipe Contreras --- bindings/ruby/database.c | 6 +- bindings/ruby/defs.h | 14 ++ bindings/ruby/directory.c | 7 +-- bindings/ruby/filenames.c | 7 +-- bindings/ruby

[PATCH v2 09/10] ruby: add all data types

Signed-off-by: Felipe Contreras --- bindings/ruby/database.c | 16 bindings/ruby/defs.h | 37 +++-- bindings/ruby/directory.c | 4 ++-- bindings/ruby/init.c | 16 bindings/ruby/message.c | 6 +++--- bindings/ruby

[PATCH v2 08/10] ruby: move towards more modern RTypedData

Signed-off-by: Felipe Contreras --- bindings/ruby/database.c | 2 +- bindings/ruby/defs.h | 6 -- bindings/ruby/init.c | 4 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/bindings/ruby/database.c b/bindings/ruby/database.c index b9ad3373..bb4273e6 100644

[PATCH v2 07/10] ruby: create Data_Wrap_Notmuch_Object helper

This makes the code more maintainable and will help in further patches. No functional changes. Signed-off-by: Felipe Contreras --- bindings/ruby/database.c | 14 +++--- bindings/ruby/defs.h | 3 +++ bindings/ruby/directory.c | 4 ++-- bindings/ruby/message.c | 6

[PATCH v2 06/10] ruby: add unlikely hint

The error path is very unlikely. Signed-off-by: Felipe Contreras --- bindings/ruby/defs.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bindings/ruby/defs.h b/bindings/ruby/defs.h index ae3ea101..12538a3a 100644 --- a/bindings/ruby/defs.h +++ b/bindings/ruby/defs.h

[PATCH v2 05/10] ruby: fetch class name in case of error

There is not much point in complicating the code for error messages that can be easily constructed. Before: database closed (RuntimeError) After: Notmuch::Database object destroyed (RuntimeError) Signed-off-by: Felipe Contreras --- bindings/ruby/defs.h | 30

[PATCH v2 04/10] ruby: simplify data get helper

The type is not actually needed. Signed-off-by: Felipe Contreras --- bindings/ruby/defs.h | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/bindings/ruby/defs.h b/bindings/ruby/defs.h index 46e2caf8..8fb47b4c 100644 --- a/bindings/ruby/defs.h +++ b

[PATCH v2 03/10] ruby: improve general data get helper

There's no need to do Check_Type, Data_Get_Struct calls rb_data_object_get(), which already does that. Signed-off-by: Felipe Contreras --- bindings/ruby/defs.h | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/bindings/ruby/defs.h b/bindings/ruby/defs.h index e95ea239

[PATCH v2 02/10] ruby: improve all Data_Get_Notmuch_* helpers

There's no need to repeat the same code over and over. Signed-off-by: Felipe Contreras --- bindings/ruby/defs.h | 81 1 file changed, 22 insertions(+), 59 deletions(-) diff --git a/bindings/ruby/defs.h b/bindings/ruby/defs.h index 48544ca2..e95ea239

[PATCH v2 01/10] ruby: add missing Data_Get_Notmuch helpers

Apparently commit 5c9e3855 (ruby: Don't barf if an object is destroyed more than once, 2010-05-26) missed these two. Signed-off-by: Felipe Contreras --- bindings/ruby/directory.c | 2 +- bindings/ruby/threads.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/bindings

[PATCH v2 00/10] ruby: object cleanups

This superseeds my previous series [1] with much more cleanups. An important new change is the move towards RTypedData, which is way superior to the old RData objects. Everything should work basically the same though. [1] id: 20210503075457.649056-1-felipe.contre...@gmail.com Felipe Contreras

[PATCH 3/3] ruby: simplify data get helper

The type is not actually needed. Signed-off-by: Felipe Contreras --- bindings/ruby/defs.h | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/bindings/ruby/defs.h b/bindings/ruby/defs.h index 46e2caf8..edbcc729 100644 --- a/bindings/ruby/defs.h +++ b

[PATCH 1/3] ruby: improve all Data_Get_Notmuch_* helpers

There's no need to repeat the same code over and over. Signed-off-by: Felipe Contreras --- bindings/ruby/defs.h | 81 1 file changed, 22 insertions(+), 59 deletions(-) diff --git a/bindings/ruby/defs.h b/bindings/ruby/defs.h index 48544ca2..e95ea239

[PATCH 0/3] ruby: cleanups

This are simple cleanups that should not have any functional changes. Felipe Contreras (3): ruby: improve all Data_Get_Notmuch_* helpers ruby: improve general data get helper ruby: simplify data get helper bindings/ruby/defs.h | 84 1 file

[PATCH 2/3] ruby: improve general data get helper

There's no need to do Check_Type, Data_Get_Struct calls rb_data_object_get(), which already does that. Signed-off-by: Felipe Contreras --- bindings/ruby/defs.h | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/bindings/ruby/defs.h b/bindings/ruby/defs.h index e95ea239

Re: [PATCH 5/9] test: ruby: simplify test_ruby()

On Sun, May 2, 2021 at 6:02 AM David Bremner wrote: > > Felipe Contreras writes: > > > We always do test_expect_equal_file, so do it in test_ruby() directly. > > > > The only subtest where we don't (get non-existent file) can be easily > > modified. > >

Re: [PATCH] Vim: Fix a deprecated call to the 'mail' gem

eld to Mail::Field.new is deprecated and will > >> be removed in Mail 2.8.0. Use Mail::Field.parse instead. > > I believe this problem was fixed in a different way by Felipe's patch > applied as 8af4cd16 Indeed, but Jules' patch may be a bett

[PATCH 2/3] ruby: add keyword arguments to db.query

That way we don't need pass them to the query object ourselves. Signed-off-by: Felipe Contreras --- bindings/ruby/database.c | 47 +--- bindings/ruby/defs.h | 2 +- bindings/ruby/init.c | 2 +- test/T395-ruby.sh| 18 +++ 4 files

[PATCH 3/3] test: ruby: simplify basic tests

We don't need to check for the order here, that is done in another test. Signed-off-by: Felipe Contreras --- test/T395-ruby.sh | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/test/T395-ruby.sh b/test/T395-ruby.sh index e828efed..9298bc9e 100755 --- a/test/T395

[PATCH 1/3] ruby: use notmuch_exclude_t enum

It exists since 2013, let's allow it to be used in Ruby. Signed-off-by: Felipe Contreras --- bindings/ruby/init.c | 24 bindings/ruby/query.c | 8 +--- test/T395-ruby.sh | 17 + 3 files changed, 46 insertions(+), 3 deletions(-) diff --git

[PATCH 0/3] ruby: improve db.query

test cleanups [1]. [1] id:20210501115923.483816-1-felipe.contre...@gmail.com Felipe Contreras (3): ruby: use notmuch_exclude_t enum ruby: add keyword arguments to db.query test: ruby: simplify basic tests bindings/ruby/database.c | 47 +--- bindings/ruby

[PATCH 9/9] test: ruby: simplify output comparison

Signed-off-by: Felipe Contreras --- test/T395-ruby.sh | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/test/T395-ruby.sh b/test/T395-ruby.sh index 30168109..597330d3 100755 --- a/test/T395-ruby.sh +++ b/test/T395-ruby.sh @@ -20,22 +20,22 @@ test_ruby

[PATCH 8/9] test: ruby: don't use instance variables

Local variables are perfectly fine. Signed-off-by: Felipe Contreras --- test/T395-ruby.sh | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/test/T395-ruby.sh b/test/T395-ruby.sh index f5a8d245..30168109 100755 --- a/test/T395-ruby.sh +++ b/test/T395

[PATCH 7/9] test: ruby: use much more standard Ruby idioms

Signed-off-by: Felipe Contreras --- test/T395-ruby.sh | 20 1 file changed, 8 insertions(+), 12 deletions(-) diff --git a/test/T395-ruby.sh b/test/T395-ruby.sh index f871ddd9..f5a8d245 100755 --- a/test/T395-ruby.sh +++ b/test/T395-ruby.sh @@ -24,7 +24,7 @@ notmuch search

[PATCH 6/9] test: ruby: use much more standard puts

Signed-off-by: Felipe Contreras --- test/T395-ruby.sh | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/test/T395-ruby.sh b/test/T395-ruby.sh index 55bf4c2b..f871ddd9 100755 --- a/test/T395-ruby.sh +++ b/test/T395-ruby.sh @@ -25,7 +25,7 @@ test_ruby <<&qu

[PATCH 5/9] test: ruby: simplify test_ruby()

We always do test_expect_equal_file, so do it in test_ruby() directly. The only subtest where we don't (get non-existent file) can be easily modified. Signed-off-by: Felipe Contreras --- test/T395-ruby.sh | 18 +++--- 1 file changed, 7 insertions(+), 11 deletions(-) diff --git

[PATCH 0/9] test: ruby: several cleanups and simplifications

I found a lot of areas of improvement in the Ruby tests, so I decided to clean them up. With these changes the tests are now much simpler and follow more closely the typical Ruby idioms. Felipe Contreras (9): test: move test_ruby() inside the only client test: ruby: refactor test_ruby

[PATCH 3/9] test: ruby: simplify MAIL_DIR check

Signed-off-by: Felipe Contreras --- test/T395-ruby.sh | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/test/T395-ruby.sh b/test/T395-ruby.sh index 1d27e191..94fab106 100755 --- a/test/T395-ruby.sh +++ b/test/T395-ruby.sh @@ -12,10 +12,7 @@ test_ruby() { ( cat

[PATCH 2/9] test: ruby: refactor test_ruby()

There's no point in repeating the same initialization in all the tests. Signed-off-by: Felipe Contreras --- test/T395-ruby.sh | 48 +++ 1 file changed, 11 insertions(+), 37 deletions(-) diff --git a/test/T395-ruby.sh b/test/T395-ruby.sh index

[PATCH 4/9] test: ruby: simplify MAIL_DIR initialization

There's no need to complicate the script passing the MAIL_DIR environment variable. Signed-off-by: Felipe Contreras --- test/T395-ruby.sh | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/test/T395-ruby.sh b/test/T395-ruby.sh index 94fab106..67d6e205 100755 --- a/test

[PATCH 1/9] test: move test_ruby() inside the only client

Not much point in polluting the main library, and also will be useful to modify it in tandem with the tests. Signed-off-by: Felipe Contreras --- test/T395-ruby.sh | 4 test/test-lib.sh | 4 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/test/T395-ruby.sh b/test/T395

[PATCH 13/13] test: more style fixes

In order to fit the git coding style. Signed-off-by: Felipe Contreras --- test/T140-excludes.sh | 3 +- test/T190-multipart.sh | 3 +- test/T490-parse-time-string.sh | 6 +-- test/export-dirs.sh| 3 +- test/test-lib-common.sh| 6 +-- test/test-lib

[PATCH 12/13] test: trivial style cleanups

Signed-off-by: Felipe Contreras --- test/T000-basic.sh | 2 +- test/T070-insert.sh | 2 +- test/T590-thread-breakage.sh | 10 +- test/export-dirs.sh | 2 +- test/test-lib.sh | 8 5 files changed, 12 insertions(+), 12 deletions(-) diff

[PATCH 11/13] test: emacs: fix a couple of shellcheck complaints

sh line 21: test_require_external_prereq ${TEST_EMACSCLIENT} || ret=1 ^-^ SC2086: Double quote to prevent globbing and word splitting. Did you mean: test_require_external_prereq "${TEST_EMACSCLIENT}" || ret=1 Signed-off-by: Felipe

[PATCH 10/13] test: emacs: check for configured emacs

Commit d59d9c81 (test: Make the emacsclient binary user-configurable, 2012-11-27) modified the prereq check for the configured emacsclient, but we probably want to do the same for emacs itself. Signed-off-by: Felipe Contreras --- test/test-lib-emacs.sh | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH 09/13] test: emacs: simplify missing dependencies check

No functional changes. Signed-off-by: Felipe Contreras --- test/test-lib-emacs.sh | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/test/test-lib-emacs.sh b/test/test-lib-emacs.sh index ecad501a..83f5b10b 100644 --- a/test/test-lib-emacs.sh +++ b/test/test-lib

[PATCH 08/13] test: split emacs functionality to its own file

This way it's easier to identify the tests that do require emacs stuff. Signed-off-by: Felipe Contreras --- test/T160-json.sh | 1 + test/T170-sexp.sh | 1 + test/T310-emacs.sh | 1 + test/T320-emacs-large-search-buffer.sh

[PATCH 07/13] test: add external prereqs to many emacs tests

The tests fail otherwise. Signed-off-by: Felipe Contreras --- test/T310-emacs.sh| 1 + test/T350-crypto.sh | 1 + test/T355-smime.sh| 1 + test/T357-index-decryption.sh | 1 + test/T450-emacs-show.sh | 1 + test/T460-emacs-tree.sh | 1 + test/T730

[PATCH 06/13] test: add prereqs check in test_emacs_expect_t

test_emacs may update the external prereqs, in which case we want to skip the test rather than fail. Signed-off-by: Felipe Contreras --- test/test-lib.sh | 3 +++ 1 file changed, 3 insertions(+) diff --git a/test/test-lib.sh b/test/test-lib.sh index 1067316d..72ac2e89 100644 --- a/test/test

[PATCH 05/13] test: fix wrong SKIP messages

When the external prereqs are updated inside the body of the command (e.g. test_emacs) the message in test_report_skip_ is wrong: it outputs the body of the command instead of the subtest name. We need to pass the same argument we pass to test_skip. Signed-off-by: Felipe Contreras --- test

[PATCH 04/13] test: use correct fqdn in passwd_sanitize()

My fqdn is 'natae.localdomain', however, socket.getfqdn() returns 'localhost'. To fetch the true fqdn we need socket.getaddrinfo(). For more information see: https://stackoverflow.com/a/11580042/10474 Signed-off-by: Felipe Contreras --- test/test-lib.sh | 2 +- 1 file changed, 1 insertion

[PATCH 00/13] test: several fixes and improvements

The current tests fail on my machine due to my configuration, mainly because I didn't have dtach installed, but also other stuff. The following patches fix all the issues I found, and also do plenty of cleanups. Felipe Contreras (13): test: fix passwd_sanitize() test: unset NAME

[PATCH 03/13] test: remove USER_FULL_NAME when not present

If a full name is not configured, the output is empty. This is possibly not portable, but it's a start. Signed-off-by: Felipe Contreras --- test/T590-libconfig.sh | 10 ++ 1 file changed, 10 insertions(+) diff --git a/test/T590-libconfig.sh b/test/T590-libconfig.sh index 51dd29c8

[PATCH 01/13] test: fix passwd_sanitize()

=USER_FULL_NAME=USER_FULL_NAME USER_FULL_NAMEsUSER_FULL_NAMEtUSER_FULL_NAMEdUSER_FULL_NAMEoUSER_FULL_NAMEuUSER_FULL_NAMEtUSER_FULL_NAME USER_FULL_NAME=USER_FULL_NAME=USER_FULL_NAME Let's check for empty strings before doing any replace. Signed-off-by: Felipe Contreras --- test/test-lib.sh | 7 ++- 1 file changed, 6 insertions(+), 1 delet

[PATCH 02/13] test: unset NAME environment variable

Otherwise the output from the tests would be different. Signed-off-by: Felipe Contreras --- test/test-lib.sh | 1 + 1 file changed, 1 insertion(+) diff --git a/test/test-lib.sh b/test/test-lib.sh index e13797a7..ae653363 100644 --- a/test/test-lib.sh +++ b/test/test-lib.sh @@ -112,6 +112,7

Re: notmuch and public-inbox

On Fri, Apr 30, 2021 at 7:05 PM Eric Wong wrote: > > Felipe Contreras wrote: > > My workflow with notmuch is near to perfect, however, the only pain > > point I have is fetching all the mail of a particular mailing list. > > > > To do this efficiently public-in

notmuch and public-inbox

, I can't find an URL of a public-inbox repository of the notmuch mailing list. Am I missing something or has nobody really worked on linking these two tools? Seems like an obvious area of opportunity. Cheers. -- Felipe Contreras ___ notmuch mailing

The future of Ruby bindings

till works), and Ruby's garbage collection would work fine and no memory would be leaked. Thoughts? Cheers. [1] id:20210427085343.2300-1-felipe.contre...@gmail.com -- Felipe Contreras ___ notmuch mailing list -- notmuch@notmuchmail.org To unsubscribe sen

Re: [PATCH 2/2] Vim: Ensure that every queries respect excluded tags

/felipec/notmuch-vim/pull/7 -- Felipe Contreras ___ notmuch mailing list -- notmuch@notmuchmail.org To unsubscribe send an email to notmuch-le...@notmuchmail.org

Re: [PATCH 1/2] Vim: Respect excluded tags when showing a thread

On Tue, Apr 27, 2021 at 3:09 PM David Bremner wrote: > > Felipe Contreras writes: > > > On Mon, Apr 26, 2021 at 6:39 PM David Bremner wrote: > >> > >> Felipe Contreras writes: > >> > > >> > I don't need to test it, the patch is obvio

Re: [PATCH 1/2] Vim: Respect excluded tags when showing a thread

On Mon, Apr 26, 2021 at 6:39 PM David Bremner wrote: > > Felipe Contreras writes: > > > > I don't need to test it, the patch is obviously correct. > > > > Reviewed-by: Felipe Contreras > > Famous last words ;). But OK, applied to master. Er, I acked the firs

[RFC PATCH] Attempt to reactive Ruby gc

, since we still own a reference (from Notmuch::Thread). It's only when both are destroyed that the object is actually freed. Signed-off-by: Felipe Contreras --- bindings/ruby/defs.h | 24 +++- bindings/ruby/extconf.rb | 1 + bindings/ruby/thread.c | 6 +++--- bindings

Re: Release process for 0.32

0-2-felipe.contreras%40gmail.com -- Felipe Contreras ___ notmuch mailing list -- notmuch@notmuchmail.org To unsubscribe send an email to notmuch-le...@notmuchmail.org

Re: [PATCH 1/2] Vim: Respect excluded tags when showing a thread

ed' tag), the entire thread is shown all the > > The two of you are the most recent submitters of patches [1] to the vim > frontend for notmuch. You might want to consider helping test and/or > review each other's patches. I don't need to test it, the patch is obviously correct. Rev

Re: [PATCH 00/13] vim: a bunch of updates from upstream

On Mon, Apr 19, 2021 at 5:14 PM David Bremner wrote: > Felipe Contreras writes: > > > Then I think we could consider removing the vim stuff from notmuch. In > > the meantime I think the three code-bases serve a purpose. > > Thanks for the detailed explanation. Your reaso

Re: [PATCH 00/13] vim: a bunch of updates from upstream

On Mon, Apr 19, 2021 at 5:16 AM David Bremner wrote: > > Felipe Contreras writes: > > > I finally took some time to update notmuch-vim and include some fixes, > > as well as pull requests. > > > > Here are the transplanted patches. > > > > So, big

Re: [PATCH] ruby: fix ruby 3.1 warnings

onfigured: sendemail.assume8bitEncoding = utf-8 I don't know if this is the right thing to do, but in git world everything is utf-8. -- Felipe Contreras ___ notmuch mailing list -- notmuch@notmuchmail.org To unsubscribe send an email to notmuch-le...@notmuchmail.org

Re: [PATCH] ruby: fix ruby 3.1 warnings

y. > - What version of ruby is generating those warnings? I don't see it with > ruby 2.7. I guess that's not necessarily a blocker, as long as the > patched version still builds and runs with older ruby. Yeah, not a blocker. I'm using Ruby 3.0.

[PATCH 13/13] vim: README: sync with upstream

Signed-off-by: Felipe Contreras --- vim/README | 27 +-- 1 file changed, 17 insertions(+), 10 deletions(-) diff --git a/vim/README b/vim/README index c137bacd..d9a635a2 100644 --- a/vim/README +++ b/vim/README @@ -3,7 +3,7 @@ This is a vim plug-in that provides a fully

[PATCH 12/13] vim: remove backwards compatibility wrappers

Seven years is more than enough. Signed-off-by: Felipe Contreras --- vim/notmuch.vim | 50 + 1 file changed, 9 insertions(+), 41 deletions(-) diff --git a/vim/notmuch.vim b/vim/notmuch.vim index e717fb5a..717633c7 100644 --- a/vim/notmuch.vim

[PATCH 11/13] vim: syntax: fix message description highlighting

From: Aaron Borden Signed-off-by: Felipe Contreras --- vim/syntax/notmuch-show.vim | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/vim/syntax/notmuch-show.vim b/vim/syntax/notmuch-show.vim index c3a98b77..de0c43a1 100644 --- a/vim/syntax/notmuch-show.vim +++ b/vim

[PATCH 10/13] vim: option to add reply quote datetime

From: Aaron Borden By default it's empty so the format doesn't change. Cleanup-by: Felipe Contreras Signed-off-by: Felipe Contreras --- vim/notmuch.txt | 7 +++ vim/notmuch.vim | 12 +++- 2 files changed, 18 insertions(+), 1 deletion(-) diff --git a/vim/notmuch.txt b/vim

[PATCH 09/13] vim: option to add email address to reply quote

From: Aaron Borden Cleanup-by: Felipe Contreras Signed-off-by: Felipe Contreras --- vim/notmuch.txt | 6 ++ vim/notmuch.vim | 7 +++ 2 files changed, 13 insertions(+) diff --git a/vim/notmuch.txt b/vim/notmuch.txt index c98f2b53..b658020d 100644 --- a/vim/notmuch.txt +++ b/vim

[PATCH 08/13] vim: trivial cleanup

Signed-off-by: Felipe Contreras --- vim/notmuch.vim | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/vim/notmuch.vim b/vim/notmuch.vim index 8777d412..7a448467 100644 --- a/vim/notmuch.vim +++ b/vim/notmuch.vim @@ -641,9 +641,7 @@ ruby <&l

[PATCH 07/13] vim: use notmuch config command

This simplifies the configuration parsing, is more efficient, and also reverts back to previous logic. Signed-off-by: Felipe Contreras --- vim/notmuch.vim | 26 -- 1 file changed, 12 insertions(+), 14 deletions(-) diff --git a/vim/notmuch.vim b/vim/notmuch.vim index

[PATCH 06/13] vim: trivial cleanup

Signed-off-by: Felipe Contreras --- vim/notmuch.vim | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/vim/notmuch.vim b/vim/notmuch.vim index dd715828..97167461 100644 --- a/vim/notmuch.vim +++ b/vim/notmuch.vim @@ -471,9 +471,8 @@ function! s:NotMuch(...) ruby <&l

[PATCH 05/13] vim: show first part if no text part is detected

Better something than nothing. Signed-off-by: Felipe Contreras --- vim/notmuch.vim | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/vim/notmuch.vim b/vim/notmuch.vim index e2362a2d..dd715828 100644 --- a/vim/notmuch.vim +++ b/vim/notmuch.vim @@ -333,7 +333,7 @@ ruby

[PATCH 04/13] vim: fix for missing parts

Sometimes Mail incorrectly parses multipart messages. See: https://github.com/mikel/mail/issues/1438 Check for empty parts instead of crashing. Signed-off-by: Felipe Contreras --- vim/notmuch.vim | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/vim/notmuch.vim b

[PATCH 01/13] vim: fix Mail 2.8.0 warning

Passing an unparsed header field to Mail::Field.new is deprecated and will be removed in Mail 2.8.0. Use Mail::Field.parse instead. Signed-off-by: Felipe Contreras --- vim/notmuch.vim | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/vim/notmuch.vim b/vim/notmuch.vim index

[PATCH 03/13] vim: doc: minor spelling fix

From: John Gliksberg Signed-off-by: Felipe Contreras --- vim/notmuch.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/vim/notmuch.txt b/vim/notmuch.txt index 4a038102..c98f2b53 100644 --- a/vim/notmuch.txt +++ b/vim/notmuch.txt @@ -144,7 +144,7 @@ If you want to count

[PATCH 02/13] vim: doc: small fixes

Signed-off-by: Felipe Contreras --- vim/notmuch.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/vim/notmuch.txt b/vim/notmuch.txt index 43741022..4a038102 100644 --- a/vim/notmuch.txt +++ b/vim/notmuch.txt @@ -89,7 +89,7 @@ s Send CONFIGURATION

[PATCH 00/13] vim: a bunch of updates from upstream

Felipe Contreras (9): vim: fix Mail 2.8.0 warning vim: doc: small fixes vim: fix for missing parts vim: show first part if no text part is detected vim: trivial cleanup vim: use notmuch config command vim: trivial cleanup vim: remove backwards compatibility wrappers vim: README

[PATCH] ruby: fix ruby 3.1 warnings

init.c:214:5: warning: ‘rb_cData’ is deprecated: by: rb_cObject. Will be removed in 3.1. [-Wdeprecated-declarations] Signed-off-by: Felipe Contreras --- bindings/ruby/init.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/bindings/ruby/init.c b

Re: [PATCH 1/3] build: don't add sub Makefiles to the global deps

Jani Nikula wrote: On Fri, 23 May 2014, Felipe Contreras felipe.contre...@gmail.com wrote: They don't affect the global build. They do. They don't. Cheers. -- Felipe Contreras ___ notmuch mailing list notmuch@notmuchmail.org http

Re: [PATCH 1/3] build: don't add sub Makefiles to the global deps

Jani Nikula wrote: On Sun, 25 May 2014, Felipe Contreras felipe.contre...@gmail.com wrote: Jani Nikula wrote: On Fri, 23 May 2014, Felipe Contreras felipe.contre...@gmail.com wrote: They don't affect the global build. They do. They don't. Your patch, your commit message, please

[PATCH 3/3] test: add tests for Ruby bindings

Signed-off-by: Felipe Contreras --- test/T540-ruby.sh | 98 +++ test/test-lib.sh | 1 + 2 files changed, 99 insertions(+) create mode 100755 test/T540-ruby.sh diff --git a/test/T540-ruby.sh b/test/T540-ruby.sh new file mode 100755 index

[PATCH 2/3] build: add support to build Ruby bindings

So there's no need for the user to manually do that. Signed-off-by: Felipe Contreras --- bindings/ruby/Makefile.local | 21 + bindings/ruby/extconf.rb | 14 ++ configure| 21 + 3 files changed, 44 insertions(+), 12

[PATCH 1/3] build: don't add sub Makefiles to the global deps

They don't affect the global build. Signed-off-by: Felipe Contreras --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 4c0e8c6..2d1aee9 100644 --- a/Makefile +++ b/Makefile @@ -20,7 +20,7 @@ include Makefile.config # We make all targets

[PATCH 0/3] Build and test Ruby bindings

. For now I'm checking only for Ruby 2.1, but more versions can be added later if demanded. Since this support wasn't there before nothing will be broken if we don't build on say, Ruby 2.0. Felipe Contreras (3): build: don't add sub Makefiles to the global deps build: add support to build Ruby

[PATCH 0/3] Build and test Ruby bindings

. For now I'm checking only for Ruby 2.1, but more versions can be added later if demanded. Since this support wasn't there before nothing will be broken if we don't build on say, Ruby 2.0. Felipe Contreras (3): build: don't add sub Makefiles to the global deps build: add support to build Ruby

[PATCH 1/3] build: don't add sub Makefiles to the global deps

They don't affect the global build. Signed-off-by: Felipe Contreras felipe.contre...@gmail.com --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 4c0e8c6..2d1aee9 100644 --- a/Makefile +++ b/Makefile @@ -20,7 +20,7 @@ include

[PATCH 2/3] build: add support to build Ruby bindings

So there's no need for the user to manually do that. Signed-off-by: Felipe Contreras felipe.contre...@gmail.com --- bindings/ruby/Makefile.local | 21 + bindings/ruby/extconf.rb | 14 ++ configure| 21 + 3 files changed

[PATCH 3/3] test: add tests for Ruby bindings

Signed-off-by: Felipe Contreras felipe.contre...@gmail.com --- test/T540-ruby.sh | 98 +++ test/test-lib.sh | 1 + 2 files changed, 99 insertions(+) create mode 100755 test/T540-ruby.sh diff --git a/test/T540-ruby.sh b/test/T540-ruby.sh new

[PATCH 1/2] configure: add a fallback check for zlib

Fraser Tweedale wrote: > On Sat, May 10, 2014 at 05:27:34PM -0500, Felipe Contreras wrote: > > Tomi Ollila wrote: > > > On Sun, May 11 2014, Felipe Contreras > > > wrote: > > > > > > > X?c? wrote: > > > >> Since zlib is part of th

Re: [PATCH 1/2] configure: add a fallback check for zlib

Fraser Tweedale wrote: On Sat, May 10, 2014 at 05:27:34PM -0500, Felipe Contreras wrote: Tomi Ollila wrote: On Sun, May 11 2014, Felipe Contreras felipe.contre...@gmail.com wrote: Xīcò wrote: Since zlib is part of the base system, FreeBSD chose not to register it in pkg

[PATCH] configure: use cc/c++ when GCC not installed

diff --git a/configure b/configure > index 9bde2eb..3f4942b 100755 > --- a/configure > +++ b/configure > @@ -43,8 +43,16 @@ fi > > # Set several defaults (optionally specified by the user in > # environment variables) > -CC=${CC:-gcc} > -CXX=${CXX:-g++} Why not just use cc and c++? -- Felipe Contreras

RE: [PATCH] configure: use cc/c++ when GCC not installed

index 9bde2eb..3f4942b 100755 --- a/configure +++ b/configure @@ -43,8 +43,16 @@ fi # Set several defaults (optionally specified by the user in # environment variables) -CC=${CC:-gcc} -CXX=${CXX:-g++} Why not just use cc and c++? -- Felipe Contreras

github

Jameson Graef Rollins wrote: > On Mon, May 12 2014, Felipe Contreras wrote: > > How would our development cycle be controlled by GitHub? > > > > The whole point of a distributed VCS is that there isn't a single > > central repository you rely on. > > If this is

Re: github

Jameson Graef Rollins wrote: On Mon, May 12 2014, Felipe Contreras felipe.contre...@gmail.com wrote: How would our development cycle be controlled by GitHub? The whole point of a distributed VCS is that there isn't a single central repository you rely on. If this is true then why

github

by github > (or any other proprietary SCM) for many of the same reasons. How would our development cycle be controlled by GitHub? The whole point of a distributed VCS is that there isn't a single central repository you rely on. -- Felipe Contreras

Re: github

would our development cycle be controlled by GitHub? The whole point of a distributed VCS is that there isn't a single central repository you rely on. -- Felipe Contreras ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman

[PATCH] configure: add workaround for systems without zlib.pc

Some systems (e.g. FreeBSD) might not have installed the appropriate pkg-config file as they should. We can workaround the issue by creating the .pc file they should have distributed. Signed-off-by: Felipe Contreras --- compat/.gitignore| 1 + compat/gen_zlib_pc.c | 18

[PATCH] build: fix order of rpath

-by: Felipe Contreras --- Makefile.local | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/Makefile.local b/Makefile.local index fa07d81..af79b5c 100644 --- a/Makefile.local +++ b/Makefile.local @@ -46,15 +46,16 @@ PV_FILE=bindings/python/notmuch/version.py # Smash together

<    1   2   3   4   5   6   7   >