Re: segfault using python bindings

2019-08-23 Thread Rollins, Jameson
On Fri, Aug 23 2019, Daniel Kahn Gillmor wrote: > that matches my understanding too. i'd love to move forward with the > improved bindings, under a different name. > > if someone later figures out the compatibility layer that allows > implementation of the traditional "notmuch" module api atop

Re: segfault using python bindings

2019-08-22 Thread Rollins, Jameson
On Thu, Aug 22 2019, David Bremner wrote: > Daniel Kahn Gillmor writes: > >> (i also find "notmuch2" rather unsatisfying, but python doesn't have a >> meaningful versioning system for backwards-incompatible API changes for >> its modules, so this kind of name augmentation is the only strategy

Re: Apparently, terms with a common prefix are *not* connected by implicit "OR"

2019-08-20 Thread Rollins, Jameson
On Tue, Aug 20 2019, David Bremner wrote: > This will make > > to:a to:b > > and > > from:a from:b > > expand as > > to:a AND to:b > > and > > from:a AND from:b I can't say if the proposed parser prefix change is correct, but I support this behavior. jamie.

Re: Bug#934082: elpa-notmuch: Shows remote images even when requested not to

2019-08-07 Thread Rollins, Jameson
On Wed, Aug 07 2019, David Bremner wrote: > Dear Notmuch people, should we document this issue somehow? Maybe even > try to detect it with customize? I would certainly appreciate some guarantee that my mail viewer was not contacting the internet when I view mail. I'm not sure how that could be

address completion issues in notmuch-emacs

2019-07-17 Thread Rollins, Jameson
Hi. I'm using address completion in notmuch-emacs, but I keep having problems. No matter what "Notmuch Address Internal Completion" customization configuration I use ("sent" or "received") there are tons of missing addresses that I need. It seems, though, that the two configurations might be

Re: Message Id in search summary

2019-06-03 Thread Rollins, Jameson
On Mon, Jun 03 2019, meOme wrote: > I use > notmuch search myWord > for the search and the output seems to be the same as > notmuch search --output=summary myWord > So output=summary is the default, right? > Now (on a user's klick) I would like to show the Message from the saerch > result. > The

Re: notmuch-message-mark-replied

2019-06-03 Thread Rollins, Jameson
On Mon, Jun 03 2019, Örjan Ekeberg wrote: > "Rollins, Jameson" writes: >> I have the following in my emacs config: >> >> '(message-send-hook >>(quote >> (notmuch-message-mark-replied notmuch-fcc-header-setup))) >> >> I'm wonderi

Re: notmuch-message-mark-replied

2019-06-03 Thread Rollins, Jameson
On Mon, Jun 03 2019, David Bremner wrote: > Örjan Ekeberg writes: > >> David Bremner writes: >>> In d9800c8 we deleted the function notmuch-message-mark-replied. >>> >>> Should we make a deprecated-alias for >>> notmuch-message-apply-queued-tag-changes? >> >> The two functions are not

Re: viewing duplicate messages

2019-05-30 Thread Rollins, Jameson
On Thu, May 30 2019, Jorge P. de Morais Neto wrote: > That would be useful to me too. I have a Dell laptop and I subscribed > to email notifications about firmware updates. It turns out that Dell > sends all such notifications (which obviously have different content) > with the same message-id.

Re: v2 of Safe and useful handling of "Mixed Up" mangled messages

2019-05-30 Thread Rollins, Jameson
On Thu, May 30 2019, Daniel Kahn Gillmor wrote: > This is the second revision of the series initially posted at > id:20190528225452.17550-1-...@fifthhorseman.net. > > The changes in this series from v1 are in response to the helpful > review by jrollins. In particular: > > * test to ensure that

Re: [PATCH 4/4] cli/show: show repaired form of "Mixed Up" mangled messages

2019-05-30 Thread Rollins, Jameson
On Thu, May 30 2019, Daniel Kahn Gillmor wrote: > Yes, it does fix notmuch reply as well. Do you think that we should > augment the test suite to include 'notmuch reply' too? I mean, more tests don't hurt, but I don't see it as critical. I think it could be as simple as (please verify):

Re: [PATCH 2/4] util/crypto: identify and repair "Mixed Up" mangled messages

2019-05-30 Thread Rollins, Jameson
On Thu, May 30 2019, Daniel Kahn Gillmor wrote: > I agree that this technically isn't a "crypto function", and as such > might not belong where i've put it. What would you think about > util/repair.{c,h} or util/demangling.{c,h} ? I guess "repair" is maybe clearer? No strong opinion. jamie.

viewing duplicate messages

2019-05-30 Thread Rollins, Jameson
This is essentially a wishlist report... It would be nice to have an easy way in notmuch-emacs-show to know if there are multiple messages with the same message-id in the store, and to cycle through viewing each individually. It's possible (even likely) that one has multiple messages with the

Re: Safe and useful handling of "Mixed Up" mangled messages

2019-05-29 Thread Rollins, Jameson
On Wed, May 29 2019, Daniel Kahn Gillmor wrote: > On Tue 2019-05-28 18:58:22 -0400, Daniel Kahn Gillmor wrote: >> I forgot to mention: this test case makes use of the test_json_nodes >> functionality introduced in 03/17 of the protected header series. >> >> So please only consider this after that

Re: [PATCH 2/4] util/crypto: identify and repair "Mixed Up" mangled messages

2019-05-29 Thread Rollins, Jameson
On Tue, May 28 2019, Daniel Kahn Gillmor wrote: > This patch implements a functional identification and repair process > for "Mixed Up" MIME messages as described in > https://tools.ietf.org/html/draft-dkg-openpgp-pgpmime-message-mangling-00#section-4.1 > > The detection test is not entirely

Re: [PATCH 4/4] cli/show: show repaired form of "Mixed Up" mangled messages

2019-05-29 Thread Rollins, Jameson
On Wed, May 29 2019, Jameson Graef Rollins wrote: > On Tue, May 28 2019, Daniel Kahn Gillmor wrote: >> When showing a message that has been mangled in transit by an MTA in >> the "Mixed up" way, "notmuch show" should instead show the repaired >> form of the message. > > Given that this fix is in

Re: [PATCH 4/4] cli/show: show repaired form of "Mixed Up" mangled messages

2019-05-29 Thread Rollins, Jameson
On Tue, May 28 2019, Daniel Kahn Gillmor wrote: > When showing a message that has been mangled in transit by an MTA in > the "Mixed up" way, "notmuch show" should instead show the repaired > form of the message. Given that this fix is in mime-node.c it will apply to reply as well, not just show,

Re: [PATCH v3 03/17] test: new test framework to compare json parts

2019-05-27 Thread Rollins, Jameson
On Mon, May 27 2019, Daniel Kahn Gillmor wrote: > On Mon 2019-05-27 16:34:27 -0400, Daniel Kahn Gillmor wrote: >> From: Jameson Graef Rollins >> >> This makes it easier to write fairly compact, readable tests of json >> output, without needing to sanitize away parts that we don't care >> about.

Re: Protected Headers (2nd major revision, more testing!)

2019-05-27 Thread Rollins, Jameson
On Sun, May 26 2019, Daniel Kahn Gillmor wrote: > Way back in id:20180511055544.13676-1-...@fifthhorseman.net, i > proposed support for protected headers (in particular, for being able > to read and search for subject lines of encrypted messages which > protect the Subject). Although that series

[PATCH v3] test: new test framework to compare json parts

2019-05-27 Thread Rollins, Jameson
From: Jameson Graef Rollins This makes it easier to write fairly compact, readable tests of json output, without needing to sanitize away parts that we don't care about. Signed-off-by: Daniel Kahn Gillmor --- test/json_check_nodes.py | 114 +++

Re: [PATCH v2 03/17] test: new test framework to compare json parts

2019-05-27 Thread Rollins, Jameson
On Mon, May 27 2019, David Bremner wrote: > Daniel Kahn Gillmor writes: >> + >> +Value test: test that object in json data found at address is equal to >> specified value: >> + >> + label:address|value >> + > > should this maybe be label:address=value ? At least looking that the > regex and

Re: getting all attachments, getting images

2019-05-23 Thread Rollins, Jameson
On Thu, May 23 2019, Danh Doan wrote: > On Thu, May 23, 2019 at 07:06:39AM -0700, meOme wrote: >> Hi! >> How can I get a list of all mails with an attachment in notmuch? > > Notmuch has already tagged all mails with attachment with tag: > attachment, hasn't it? > > Does this command work for you?

[PATCH] tests: environment variable to specify that tests should be serialized

2019-05-05 Thread Rollins, Jameson
From: Jameson Graef Rollins If NOTMUCH_TEST_SERIALIZE is non-null all tests will be run in series, rather than in parallel. --- test/README | 8 ++-- test/notmuch-test | 2 +- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/test/README b/test/README index

Re: parallelize test suite

2019-05-04 Thread Rollins, Jameson
On Sat, May 04 2019, "Rollins, Jameson" wrote: > This is a simple patch series that will run the entire test suite in > parallel if either the moreutils or GNU parallel utility is > available. On my 8-core machine the full test suite will now run in > under 20 seconds,

[PATCH 3/3] tests: run all tests in parallel, if available

2019-05-04 Thread Rollins, Jameson
From: Jameson Graef Rollins If either the moreutils or GNU parallel utility are available, run all tests in parallel. On my eight core machine this makes for a ~x7 speed-up in the full test suite (1m24s -> 12s). The design of the test suite makes this parallelization trivial. ---

[PATCH 1/3] tests: remove some redundant pre-cleanup of the corpus MAIL_DIR

2019-05-04 Thread Rollins, Jameson
From: Jameson Graef Rollins add_email_corpus itself does an rm -rf $MAIL_DIR, so these are not necessary. --- test/T100-search-by-folder.sh | 1 - test/T650-regexp-query.sh | 1 - 2 files changed, 2 deletions(-) diff --git a/test/T100-search-by-folder.sh b/test/T100-search-by-folder.sh

parallelize test suite

2019-05-04 Thread Rollins, Jameson
This is a simple patch series that will run the entire test suite in parallel if either the moreutils or GNU parallel utility is available. On my 8-core machine the full test suite will now run in under 20 seconds, which is a pretty huge improvement. jamie.

[PATCH 2/3] tests: remove entangling corpus index optimization

2019-05-04 Thread Rollins, Jameson
From: Jameson Graef Rollins The add_email_corpus test utility includes logic that tries to re-use an index of the corpus if available. This was seemingly done as an optimization, so that every test that uses the corpus didn't have to create it's own index of the corpus. However, this has the

Re: [PATCH] build: drop support for gmime-2.6

2019-05-02 Thread Rollins, Jameson
On Wed, May 01 2019, David Bremner wrote: > I was thinking of a minimal change now, so it isn't blocking other > things, and then a gradual cleanup. just go for it. ___ notmuch mailing list notmuch@notmuchmail.org

Re: [PATCH] build: drop support for gmime-2.6

2019-05-02 Thread Rollins, Jameson
>>> I was thinking of a minimal change now, so it isn't blocking other >>> things, and then a gradual cleanup. >> >> just go for it. > > You mean this patch, or the other more extensive patch that someone (TM) > has to write? Go for the full cleanup all at once.

disturbing possible bug in notmuch-emacs

2019-03-30 Thread Rollins, Jameson
Hi, all. I encountered a very disturbing bug in my mail configuration yesterday. I'm pretty sure the problem is in notmuch-emacs. I am looking for help in debugging and fixing the issue. Yesterday I sent an email with the following To: header as composed in notmuch-emacs (individual strings