Re: [PATCH] emacs: polish notmuch-hello help text

2012-01-25 Thread Tomi Ollila
+1 ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

[PATCH 2/2] added support for user-specified directories to exclude

2012-01-26 Thread Tomi Ollila
A new configuration key 'database.exclude' is used to determine which directories user wants not to be scanned for new mails. --- Notes (from 2011-09-13): 1) Currently the comments for newly created configuration file are not updated, so for not this is 'undocumented feature'. Should there be an

[PATCH 1/2] moved _notmuch_get_list () and _notmuch_set_list () up in file

2012-01-26 Thread Tomi Ollila
Moved _notmuch_get_list () and _notmuch_set_list () to a location in notmuch-config.c so that new functions that will be located before the old location of those functions can also use these. --- This patch is independent of the next one (just required by it) and can (should) be pushed early. n

Re: [PATCH 1/3] emacs: s/buttonise/buttonize/g

2012-01-26 Thread Tomi Ollila
I personally like -ise (easier to my mind, 'z' is so "hard" in finnish language), but -ize is just prevalent in emacs (customiSe, propertiSe) Tomi ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH] emacs: make `notmuch-show-open-or-close-all' toggle visibility

2012-01-26 Thread Tomi Ollila
+1 Tomi ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH 1/2] emacs: Re-enable line wrapping in `notmuch-show-mode'.

2012-01-26 Thread Tomi Ollila
On Thu, 26 Jan 2012 08:17:50 +, David Edmondson wrote: > Turn on `visual-line-mode' via a hook, so that those who so choose can > avoid it. > --- +1 I think the docstring is good (or it could be nonexistent like in 'turn-on-font-lock). Tomi ___ n

Re: [PATCH 2/2] added support for user-specified directories to exclude

2012-01-27 Thread Tomi Ollila
On Thu, 26 Jan 2012 13:11:36 +, Jani Nikula wrote: > On Thu, 26 Jan 2012 12:11:58 +0200, Tomi Ollila wrote: > > A new configuration key 'database.exclude' is used to determine > > which directories user wants not to be scanned for new mails. > > > >

Re: [PATCH 1/2] moved _notmuch_get_list () and _notmuch_set_list () up in file

2012-01-27 Thread Tomi Ollila
On Thu, 26 Jan 2012 13:03:46 +, Jani Nikula wrote: > On Thu, 26 Jan 2012 12:11:57 +0200, Tomi Ollila wrote: > > Moved _notmuch_get_list () and _notmuch_set_list () to a location > > in notmuch-config.c so that new functions that will be located > > before the old locati

[PATCH] moved _notmuch_(get|set)_list () functions earlyer in the file

2012-01-27 Thread Tomi Ollila
Moved static functions _notmuch_get_list () and _notmuch_set_list () closer to the beginning of file so that their definition is known (without adding forward declarations) in further work. No functional changes. --- notmuch-config.c | 84 +++---

Re: NEWS: add entries for the changes in the python bindings

2012-01-29 Thread Tomi Ollila
On Sun, 29 Jan 2012 18:08:50 +0100, Justus Winter <4win...@informatik.uni-hamburg.de> wrote: > This patch series adds a section for the python binding changes to the > NEWS file. LGTM -- although knowing which python 2.x versions works would be nice to know. At least tests pass using python 2.5 b

Re: [PATCH 3/3] lib: Use talloc to simplify cleanup in notmuch_database_open

2012-01-29 Thread Tomi Ollila
LGTM. all 3. Tomi ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH] lib: update notmuch_tags_get examle to reflect api change

2012-01-29 Thread Tomi Ollila
On Sun, 29 Jan 2012 10:29:01 -0500, Allan Wind wrote: > The function notmuch_database_find_message_by_filename now requires a > notmuch_message_t and returns a notmuch_status_t. This > change was introduced with 02a3076711, LIBNOTMUCH_VERSION_MAJOR = 2, > version 0.9. > --- Good, but [ ... ]

Re: [PATCH] emacs: globally replace non-branching "(if COND (progn ..." with "(when ..."

2012-01-29 Thread Tomi Ollila
On Mon, 30 Jan 2012 08:03:59 +0100, Pieter Praet wrote: > On Sat, 28 Jan 2012 08:41:36 -0400, David Bremner wrote: > > On Sat, 14 Jan 2012 10:17:18 +0100, Pieter Praet wrote: > > > Less code, same results, without sacrificing readability. > > > > > > > This looks OK, although the re-indenting

Re: [PATCH 2/2] emacs: Quote MML tags in replies

2012-01-30 Thread Tomi Ollila
On Sun, 29 Jan 2012 01:07:08 -0500, Aaron Ecay wrote: > Emacs message-mode uses certain text strings to indicate how to attach > files to outgoing mail. If these are present in the text of an email, > and a user is tricked into replying to the message, the user’s files > could be exposed. > ---

[PATCH] moved _config_(get|set)_list () functions earlyer in the file

2012-01-30 Thread Tomi Ollila
Moved static functions _config_get_list () and _config_set_list () closer to the beginning of file so that their definition is known (without adding forward declarations) in upcoming changes. --- This addresses Ethan's comments. Thanks. s/_notmuch_/_config_/ and changed 'in further work' to 'in u

Re: [PATCH] lib: update notmuch_tags_get examle to reflect api change

2012-01-30 Thread Tomi Ollila
On Mon, 30 Jan 2012 09:02:33 -0500, Allan Wind wrote: > The function notmuch_database_find_message_by_filename now requires a > notmuch_message_t and returns a notmuch_status_t. This > change was introduced with 02a3076711, LIBNOTMUCH_VERSION_MAJOR = 2, > version 0.9. > --- > + * status = no

Re: [PATCH 2/2] emacs: fix `notmuch-wash-region-to-button' to work at beginning of buffer

2012-01-30 Thread Tomi Ollila
On Mon, 30 Jan 2012 16:24:46 +0400, Dmitry Kurochkin wrote: > `Notmuch-wash-region-to-button' is the function that creates hidden > regions with buttons for signatures, citations and original messages. > Before the change, it did not work correctly if the to-be-hidden > region started at the begi

Re: [PATCH] STYLE: Initial draft of coding style document

2012-01-30 Thread Tomi Ollila
On Fri, 27 Jan 2012 19:46:58 -0400, David Bremner wrote: > From: David Bremner [ ... ] > + > +* Indent is 4 spaces with mixed tabs/spaces and a tab width of 8. > + Tabs should be only at the beginning of the line. So, after initial indentation (with tabs) there should not be further tabs? We'

Re: [PATCH 2/2] show: Simplify new text formatter code

2012-01-30 Thread Tomi Ollila
On Thu, 26 Jan 2012 01:55:26 -0500, Austin Clements wrote: > This makes the text formatter take advantage of the new code > structure. The previously duplicated header logic is now unified, > several things that we used to compute repeatedly across different > callbacks are now computed once, and

Re: emacs: more flexible and consistent tagging operations

2012-01-30 Thread Tomi Ollila
Works fine. +1 Tomi ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH 0/5 v3] reworked crypto toggle, plus a few other toggles

2012-01-30 Thread Tomi Ollila
On Mon, 30 Jan 2012 16:30:59 +, David Edmondson wrote: > v3: > - Add a toggle for line truncation (>). > - Retain the state of a show buffer across a call to refresh (which >includes the various toggles here). Applied and tested -- patches 2-5 works fine -- I currently don't have any me

Re: [PATCH] lib: update notmuch_tags_get example to reflect api change

2012-01-31 Thread Tomi Ollila
On Mon, 30 Jan 2012 15:35:44 -0500, Allan Wind wrote: > The function notmuch_database_find_message_by_filename now requires a > notmuch_message_t and returns a notmuch_status_t. This > change was introduced with 02a3076711, LIBNOTMUCH_VERSION_MAJOR = 2, > version 0.9. LGTM. Tomi __

Re: [PATCH 2/2] emacs: Don't move to the next thread unless the cursor is at the end of the buffer.

2012-01-31 Thread Tomi Ollila
On Tue, 31 Jan 2012 08:01:54 +, David Edmondson wrote: > When using the spacebar to scroll through a thread, hitting 'space' > when the bottom of the last message is visible should take the cursor > to the end of the buffer rather than immediately archiving the thread > and moving to the next

Re: [PATCH 1/2] emacs: If archiving the last message in a thread, show the next thread.

2012-01-31 Thread Tomi Ollila
On Tue, 31 Jan 2012 08:01:53 +, David Edmondson wrote: > When archiving the last message in a thread (a), rather than just > moving the pointer to the next thread in the parent search buffer, > actually display the next thread. > --- -1. Magic! Rather some customization option which lets user

Re: [PATCH 1/2] emacs: If archiving the last message in a thread, show the next thread.

2012-01-31 Thread Tomi Ollila
On Tue, 31 Jan 2012 12:51:44 +0400, Dmitry Kurochkin wrote: > On Tue, 31 Jan 2012 10:43:10 +0200, Tomi Ollila wrote: > > On Tue, 31 Jan 2012 08:01:53 +, David Edmondson wrote: > > > When archiving the last message in a thread (a), rather than just > > > mov

Re: [PATCH 1/2] emacs: If archiving the last message in a thread, show the next thread.

2012-01-31 Thread Tomi Ollila
On Tue, 31 Jan 2012 10:30:20 +, David Edmondson wrote: > On Tue, 31 Jan 2012 11:25:36 +0200, Tomi Ollila wrote: > > I like David's alternative suggestion (in IRC) where cursor is left at > > the end of buffer in case last message is archived with 'a'. > >

Re: [PATCH] emacs: Move the blank line from the bottom of the headers to the top of the body.

2012-01-31 Thread Tomi Ollila
On Tue, 31 Jan 2012 10:32:12 +, David Edmondson wrote: > On Mon, 30 Jan 2012 21:25:19 -0800, Jameson Graef Rollins > wrote: > > On Mon, 30 Jan 2012 16:52:20 +, David Edmondson wrote: > > > The blank line doesn't really change position, but is now considered > > > to be part of the body

[PATCH] added support for user-specified files & directories to ignore

2012-01-31 Thread Tomi Ollila
A new configuration key 'new.ignore' is used to determine which files and directories user wants not to be scanned as new mails. This work merges my previous attempts and Andreas Amann's work in id:"ylp7hi23mw8@tyndall.ie" See notes in id:"20120131-new-ignore-1-git-send-email-...@iki.fi" ---

Re: [PATCH 3/5] emacs: Allow the indentation of content to be toggled.

2012-02-01 Thread Tomi Ollila
On Tue, 31 Jan 2012 23:50:06 +, Mark Walters wrote: > On Tue, 31 Jan 2012 16:23:32 +, David Edmondson wrote: > > On Tue, 31 Jan 2012 16:15:11 +, Mark Walters > > wrote: > > > Hi I have reviewed the patch series within the limits of my lisp > > > knowledge. Patch 1: is rather beyon

Re: [PATCH] test: make test_expect_equal_file() arguments flexible

2012-02-01 Thread Tomi Ollila
On Wed, 01 Feb 2012 00:47:30 -0800, Jameson Graef Rollins wrote: > On Wed, 1 Feb 2012 11:19:54 +0400, Dmitry Kurochkin > wrote: > > The down side of this approach is that diff argument order depends on > > test_expect_equal_file() argument order. So sometimes we get diff > > from expected to

Re: [PATCH] test: make test_expect_equal_file() arguments flexible

2012-02-01 Thread Tomi Ollila
There are at least these options here 1) go through all ~100 places where test_expect_equal_file is used and fix the call order: quick look tells that the offending uses are in dump-restore, hooks, search-limiting and symbol-hiding. 2) enforce "expected" filename has some format *and* fix

[PATCH 2/2] devel: added newssplit.pl for splitting NEWS for markdown processing.

2012-02-02 Thread Tomi Ollila
ions(+), 0 deletions(-) create mode 100755 devel/newssplit.pl diff --git a/devel/newssplit.pl b/devel/newssplit.pl new file mode 100755 index 000..c1a0b26 --- /dev/null +++ b/devel/newssplit.pl @@ -0,0 +1,56 @@ +#!/usr/bin/perl +# Author: Tomi Ollila +# License: same as notmuch + +# This prog

[PATCH] add support for user-specified files & directories to ignore

2012-02-02 Thread Tomi Ollila
A new configuration key 'new.ignore' is used to determine which files and directories user wants not to be scanned as new mails. Mark the corresponding test as no longer broken (test from id:"1328105573-4626-1-git-send-email-pie...@praet.org" ). This work merges my previous attempts and Andreas A

Re: [PATCH] test: make test_expect_equal_file() arguments flexible

2012-02-02 Thread Tomi Ollila
On Thu, 02 Feb 2012 14:33:56 +, David Edmondson wrote: > On Wed, 01 Feb 2012 09:24:32 -0800, Jameson Graef Rollins > wrote: > > If this is really a problem, I vote for 1. In general, I am not in > > favor of making the test suite more complicated than it needs to be. > > After listening to

Re: [PATCH v2] emacs: add default value to notmuch-search-line-faces

2012-02-02 Thread Tomi Ollila
On Thu, 2 Feb 2012 16:58:41 +0200, Jani Nikula wrote: > Add default value to notmuch-search-line-faces to show "unread" > messages in bold, and "flagged" messages in blue, to have some visual > indication of important messages in search results. This should be > helpful for new users. > > "unrea

Re: ignore folders patch?

2012-02-02 Thread Tomi Ollila
On Sun, 22 Jan 2012 12:32:12 +0100, Fabio Zanini wrote: > Hi! > > This is my first message to the list. In 2010 a patch was developed that > enabled notmuch new to ignore certain subdirectories of the mail folder: > > http://notmuchmail.org/pipermail/notmuch/2010/003170.html > > However, I can

Re: [PATCH] emacs: Fix a notmuch-print.el compiler warning.

2012-02-02 Thread Tomi Ollila
On Wed, 25 Jan 2012 09:24:46 +, David Edmondson wrote: > On Wed, 25 Jan 2012 11:19:30 +0200, Tomi Ollila wrote: > > On Wed, 25 Jan 2012 08:52:15 +, David Edmondson wrote: > > > `notmuch-show-get-prop' should be declared. > > > --- > > > &g

[PATCH v5] add support for user-specified files & directories to ignore

2012-02-02 Thread Tomi Ollila
A new configuration key 'new.ignore' is used to determine which files and directories user wants not to be scanned as new mails. Mark the corresponding test as no longer broken (test from id:"1328105573-4626-1-git-send-email-pie...@praet.org" ). This work merges my previous attempts and Andreas A

Re: Set "From" based on "To" when replying

2012-02-03 Thread Tomi Ollila
On Sat, 21 Jan 2012 16:35:10 +0100, Simon Campese wrote: > Dear Community, > > I've got my own domain and when registering or shopping at some website, > I always use email addresses of the form "websiten...@mydomain.org", so > for example I use "ama...@mydomain.org" when shopping at amazon. The

Re: [PATCH] test: add tests wrt ignoring user-specified files and directories

2012-02-03 Thread Tomi Ollila
On Wed, 1 Feb 2012 15:12:53 +0100, Pieter Praet wrote: > Files and directories which are specified in 'new.ignore' in the > config file shouldn't be indexed nor reported by `notmuch new'. > > --- +1 tested file order with: $ touch ~/mail/mails/a $ touch ~/mail/mails/d $ touch ~/mail/mails/o

Re: [PATCH] configure: update explicit check for glib : >= 2.22

2012-02-03 Thread Tomi Ollila
On Fri, 3 Feb 2012 13:12:25 +0100, Pieter Praet wrote: > As of commit b3caef1f, we're using g_array_unref() in 'lib/query.cc', > which was only introduced in glib 2.22, so update the dependency. > > Thanks to datap...@gmail.com for reporting this [1]. > > Also see commit b88e6abc. > > [1] id:"

Re: [RFC PATCH v2] emacs: make show view a/A/x/X key bindings more consistent

2012-02-03 Thread Tomi Ollila
On Tue, 31 Jan 2012 19:29:06 +0200, Jani Nikula wrote: > Modify the show view key bindings as follows to make them more > consistent: > > 'a' = Archive current message, then move to next message, or show next > thread from search if at the last message in thread. > > 'A' = Archive each message i

Re: olra.theworths.org mail forwarding delay?

2012-02-03 Thread Tomi Ollila
On Fri, 03 Feb 2012 13:15:42 +0100, Pieter Praet wrote: > > It appears some messages really enjoy the hospitality @ olra.theworths.org, > because they stick around and party for quite a while before moving to their > final destinations. > > Here's some examples: > > - id:"m28vkzoo8r@guru.gu

Re: 0.11.1 release in progress

2012-02-03 Thread Tomi Ollila
On Fri, 03 Feb 2012 08:58:46 -0400, David Bremner wrote: > > Hi Folks; > > After some long delays, I am finally getting 0.11.1 out the door. I > have pushed an untagged release candidate to > > git://notmuchmail.org/git/notmuch > branch release > > encourage you to check it out (har har). I w

Re: [PATCH 1/2] test: add check for filename argument for test_expect_equal_file

2012-02-04 Thread Tomi Ollila
On Fri, 03 Feb 2012 18:04:05 +0400, Dmitry Kurochkin wrote: > On Thu, 02 Feb 2012 10:00:59 -0800, Jameson Graef Rollins > wrote: > > Hey, Dmitry. I'm so sorry I sent my last email on your original patch > > before I saw this new series. I do now like your original proposal > > better, since i

Re: Bug: emacs 23.2 doesn't like ido-completing-read

2012-02-04 Thread Tomi Ollila
On Sat, 04 Feb 2012 12:31:57 +, Mark Walters wrote: > > I hadn't realised before but this also goes wrong if you use the prefix > argument to mail (eg ctrl-u m). The current code seems to mess up the > mini-buffer and even closing the buffer does not get out of it. > > Changing ido-completi

Re: NEWS: add entries for the changes in the python bindings

2012-02-05 Thread Tomi Ollila
On Sun, 29 Jan 2012 18:08:50 +0100, Justus Winter <4win...@informatik.uni-hamburg.de> wrote: > This patch series adds a section for the python binding changes to the > NEWS file. I marked patches 2/3 and 3/3 stale as git-am doesn't accept those anymore on top of 2c6710e3ba22f5af6e5813dad8bee732e6

Re: NEWS: add entries for the changes in the python bindings

2012-02-05 Thread Tomi Ollila
On Mon, 06 Feb 2012 00:21:58 -, Justus Winter <4win...@informatik.uni-hamburg.de> wrote: > Quoting Tomi Ollila (2012-02-05 22:19:16) > >On Sun, 29 Jan 2012 18:08:50 +0100, Justus Winter > ><4win...@informatik.uni-hamburg.de> wrote: > >> This patch series a

Re: newbie questions

2012-02-05 Thread Tomi Ollila
On Fri, 3 Feb 2012 12:59:34 +0100, Tamas Papp wrote: > Hi, > > I just started using notmuch. It is fascinating, but I still need to > figure out a few things: > > 1. How can I restrict searches (eg of my inbox) to the last few > messages (eg 50-100) or some date (eg last 2 weeks)? I am using t

[PATCH v6 3/3] NEWS: add news section for new.ignore

2012-02-06 Thread Tomi Ollila
Added NEWS section 'Mail store folder/file ignore'. --- NEWS |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/NEWS b/NEWS index 5c5b645..59da584 100644 --- a/NEWS +++ b/NEWS @@ -29,6 +29,12 @@ Tag exclusion notmuch config set search.exclude_tags deleted spam +

[PATCH v6 2/3] add support for user-specified files & directories to ignore

2012-02-06 Thread Tomi Ollila
A new configuration key 'new.ignore' is used to determine which files and directories user wants not to be scanned as new mails. Mark the corresponding test as no longer broken. This work merges my previous attempts and Andreas Amann's work in id:"ylp7hi23mw8@tyndall.ie" --- notmuch-client.h

[PATCH v6 1/3] test: add tests wrt ignoring user-specified files and directories

2012-02-06 Thread Tomi Ollila
Files and directories which are specified in 'new.ignore' in the config file shouldn't be indexed nor reported by `notmuch new'. This is basically Pieter's work with Austin's comments addressed. --- test/new | 22 ++ 1 files changed, 22 insertions(+), 0 deletions(-) diff --

Re: [PATCH v6 2/3] add support for user-specified files & directories to ignore

2012-02-06 Thread Tomi Ollila
On Mon, 6 Feb 2012 11:28:24 +0200, Tomi Ollila wrote: > A new configuration key 'new.ignore' is used to determine which > files and directories user wants not to be scanned as new mails. > > Mark the corresponding test as no longer broken. > > This work merges my p

Re: [PATCH v7 0/8] reworked crypto toggle, plus a few other toggles

2012-02-06 Thread Tomi Ollila
On Mon, 6 Feb 2012 09:21:14 +, David Edmondson wrote: > v7: > - Simple rebase. The whole patch series applied cleanly (git am) on top of current origin/master + Dmitry's patchset id:"1328426033-21480-2-git-send-email-dmitry.kuroch...@gmail.com" > David Edmondson (8): > emacs: Rework cryp

Re: [PATCH] Free the results of scandir()

2012-02-07 Thread Tomi Ollila
On Tue, 7 Feb 2012 05:05:03 -0500, Ethan Glasser-Camp wrote: > From: Ethan Glasser-Camp > > scandir() returns "strings allocated via malloc(3)" which are then > "collected in array namelist which is allocated via > malloc(3)". Currently we just free the array namelist. Instead, free > all the

[PATCH] uncrustify.cfg: comments and more types

2012-02-07 Thread Tomi Ollila
Changes to devel/uncrustify.cfg: * Updated header comment to state this is config file for *notmuch*. * Added comment about the reason of 'type' keyword used. * Added some more custom types woth 'type' keyword. * Have (every) multiline comment lines start with '*'. --- devel/uncrustify.cfg | 21

Re: [PATCH v3] emacs: Call "notmuch tag" once when applying tag changes to a thread.

2012-02-08 Thread Tomi Ollila
On Wed, 8 Feb 2012 08:36:09 +, David Edmondson wrote: > Optimize thread tagging by combining all the tagging operations to a > single "notmuch tag" call. > > For threads in the order of tens or a hundred inbox tagged messages, > this gives a noticeable speedup. On two different machines, arc

Re: [PATCH 1/2] NEWS: markup changes to make mdwn->html look slightly better

2012-02-08 Thread Tomi Ollila
On Sat, 04 Feb 2012 23:49:38 +, Mark Walters wrote: > > On Wed, 1 Feb 2012 17:22:49 +0200, Tomi Ollila wrote: > > Some formatting in NEWS file has been changed so that it could > > be given to markdown processing almost verbatim. > > More effort has been put in

Re: [PATCH] emacs: cleanup and simplify `notmuch-show-archive-thread' and related functions

2012-02-08 Thread Tomi Ollila
On Wed, 8 Feb 2012 20:48:51 +0400, Dmitry Kurochkin wrote: > Recent changes in notmuch-show tagging introduced some code > duplication. The patch cleanups and simplifies > `notmuch-show-archive-thread' function by using > `notmuch-show-tag-all', no longer used function are removed. After > the

Re: A big thank you for the major tagging speedup

2012-02-08 Thread Tomi Ollila
On Wed, 8 Feb 2012 22:20:54 -0600, Michael Roth wrote: > Anyone know what commit fixed this? Curious whether I'm using or not > already No, you're not. id:"1328719731-13402-1-git-send-email-dmitry.kuroch...@gmail.com" Will do this. Tomi PS: Top-post, yack ;) > On Feb 8, 2012 3:13 PM, "Xavier

Re: [PATCH] Build-Depend on libgmime-2.6-dev | libgmime2.4-dev

2012-02-10 Thread Tomi Ollila
On Fri, 10 Feb 2012 09:15:53 -0400, David Bremner wrote: > On Thu, 9 Feb 2012 18:20:20 -0500, Daniel Kahn Gillmor > wrote: > > libgmime-2.6-dev entered debian unstable today. If 2.6 is available, > > notmuch should build against 2.6 instead of 2.4, as 2.6 is the current > > upstream stable ver

Re: [PATCH v2 1/2] emacs: support defining a list of alternative parts to show

2012-02-12 Thread Tomi Ollila
On Sun, 12 Feb 2012 14:09:57 +0200, Jani Nikula wrote: > On Fri, 10 Feb 2012 10:05:46 +, David Edmondson wrote: > > On Thu, 9 Feb 2012 14:46:02 +, Jani Nikula wrote: [...] > > > + (if (or (equal notmuch-show-all-multipart/alternative-parts t) > > > + (string= chose

Re: [PATCH v6 1/3] test: add tests wrt ignoring user-specified files and directories

2012-02-13 Thread Tomi Ollila
Those interested in this patch set please check lates changes. The test patch (1/3) has been slighty modified from Pieter's version and NEWS patch (3/3) is new. The actual functionality in patch 2/3 is exactly the same as in previous version. This applies cleanly in top of current master ( a5674c

Re: [PATCH] emacs: allow to set RETAIN-STATE for `notmuch-show-refresh-view' interactively

2012-02-13 Thread Tomi Ollila
On Mon, 13 Feb 2012 15:09:07 +0400, Dmitry Kurochkin wrote: > The notmuch-show view refresh function (`notmuch-show-refresh-view', > bound to "=") accepts an optional RETAIN-STATE argument. The patch > allows to set this argument interactively by using "C-u =". > --- +1 Tomi __

Re: [PATCH] emacs: allow to set RETAIN-STATE for `notmuch-show-refresh-view' interactively

2012-02-13 Thread Tomi Ollila
On Mon, 13 Feb 2012 20:02:03 +0100, Daniel Schoepe wrote: > On Mon, 13 Feb 2012 10:29:26 -0500, Austin Clements wrote: > > Quoth Dmitry Kurochkin on Feb 13 at 3:09 pm: > > > The notmuch-show view refresh function (`notmuch-show-refresh-view', > > > bound to "=") accepts an optional RETAIN-STATE

[PATCH v7 0/3] NEWS and test comment adjustments

2012-02-15 Thread Tomi Ollila
This version of 'new.ignore' patch series addresses Austin's last comments in NEWS and test/new documentation parts. No functional changes. ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

[PATCH v7 1/3] test: add tests wrt ignoring user-specified files and directories

2012-02-15 Thread Tomi Ollila
Files and directories which are specified in 'new.ignore' in the config file shouldn't be indexed nor reported by `notmuch new'. This is basically Pieter's work with Austin's comments addressed. --- test/new | 22 ++ 1 files changed, 22 insertions(+), 0 deletions(-) diff --

[PATCH v7 3/3] NEWS: add news section for new.ignore

2012-02-15 Thread Tomi Ollila
Added NEWS section 'Mail store folder/file ignore'. --- NEWS |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/NEWS b/NEWS index f449fba..e9abb86 100644 --- a/NEWS +++ b/NEWS @@ -29,6 +29,12 @@ Tag exclusion notmuch config set search.exclude_tags deleted spam +

[PATCH v7 2/3] add support for user-specified files & directories to ignore

2012-02-15 Thread Tomi Ollila
A new configuration key 'new.ignore' is used to determine which files and directories user wants not to be scanned as new mails. Mark the corresponding test as no longer broken. This work merges my previous attempts and Andreas Amann's work in id:"ylp7hi23mw8@tyndall.ie" --- notmuch-client.h

Re: [PATCH v2] emacs: Fix display of highlighted line in notmuch-search

2012-02-15 Thread Tomi Ollila
On Tue, 14 Feb 2012 18:09:47 +0100, Michal Sojka wrote: > When notmuch-search-line-faces is used to set background color in search > results, the highlight of the current line is not always displayed > correctly. This patch fixes that by increasing the priority property of > the highlight overlay

Re: [PATCH 0/8] Rewrite JSON show format

2012-02-15 Thread Tomi Ollila
On Tue, 14 Feb 2012 12:33:35 -0500, Austin Clements wrote: > The saga continues. As for the text format, this first shifts lots of > code around without changing its semantics, then it dives in and > simplifies a lot of things. Don't be put off by the number of > patches; most of them are straig

Re: [PATCH] emacs: Add the option of counting threads in notmuch-hello

2012-02-15 Thread Tomi Ollila
On Wed, 15 Feb 2012 09:23:31 -0700, Adam Wolfe Gordon wrote: > On Wed, Feb 15, 2012 at 08:52, Dmitry Kurochkin > wrote: > > Can we delay this patch until user-defined sections are pushed?  I know > > I promised to review it long ago.  But I still did not manage to finish > > it yet.  I hope I ca

Re: nomuch_addresses.py

2012-02-17 Thread Tomi Ollila
_addresses so I grabbed a copy from > > git. When I hit tab I get this[1] Was I suppose to do something more? > > Just for completeness: I'm using the nice nottoomuch-addresses.pl script > [1] by Tomi Ollila which doesn't require any bindings and is incredibly > fast

Re: nomuch_addresses.py

2012-02-17 Thread Tomi Ollila
On Fri, 17 Feb 2012 21:33:41 +0100, Sebastian Spaeth wrote: > On Fri, 17 Feb 2012 20:58:50 +0200, Tomi Ollila wrote: > > Thank you for promoting my stuff. > > > > Latest version is 2.0 and name is now nottoomuch-addresses.sh > > It is available at: > > >

Re: nomuch_addresses.py

2012-02-17 Thread Tomi Ollila
On Fri, 17 Feb 2012 22:04:12 -0500, Philippe LeCavalier wrote: > On Fri, 17 Feb 2012 22:46:49 +0200, Tomi Ollila wrote: > > On Fri, 17 Feb 2012 21:33:41 +0100, Sebastian Spaeth > > wrote: > > > On Fri, 17 Feb 2012 20:58:50 +0200, Tomi Ollila > > > wrote: &

Re: [PATCH 0/3] Make notmuch-show-refresh-view retain state by default

2012-02-19 Thread Tomi Ollila
On Sun, 19 Feb 2012 01:22:10 -0500, Austin Clements wrote: > Based on the thread at id:"20120213152858.go27...@mit.edu" it seems > like people want show refresh to retain message state by default (I > certainly do), rather than reset it by default. As a nice bonus, this > fixes a broken test. Hm

Re: [PATCH v2 2/4] test: emacs: new test "notmuch-search: replying to a thread (sending)"

2012-02-19 Thread Tomi Ollila
On Sun, 19 Feb 2012 21:38:26 +0100, Pieter Praet wrote: > As pointed out in the previous commit, the test for replying from > within Emacs didn't actually submit the reply. This one does. > --- > test/emacs | 41 + > 1 files changed, 41 insertions(+), 0 d

Re: [PATCH v2 4/4] test: emacs: new test "notmuch-search: change tags of all matching messages"

2012-02-19 Thread Tomi Ollila
On Sun, 19 Feb 2012 21:38:28 +0100, Pieter Praet wrote: > `notmuch-search-tag-all' (bound to "*") adds and removes tags > to/from all messages which match the query used to populate the > current search buffer. > --- > test/emacs | 32 > 1 files changed, 32 inse

Re: [PATCH v2 0/8] Rewrite JSON show format

2012-02-20 Thread Tomi Ollila
On Sun, 19 Feb 2012 19:26:22 -0500, Austin Clements wrote: > v2 fixes some trivial whitespace issues in devel/schemata [1] and > beefs up one of the explanations in devel/schemata. None of the other > patches have changed, so I'm marking this ready. +1 Tomi _

Re: nomuch_addresses.py

2012-02-21 Thread Tomi Ollila
On Tue, 21 Feb 2012 09:15:09 -, Justus Winter <4win...@informatik.uni-hamburg.de> wrote: > Quoting Daniel Schoepe (2012-02-17 02:28:52) [emphasis mine]: > >Just for completeness: I'm using the nice nottoomuch-addresses.pl script > >[1] by Tomi Ollila *which doesn&#

Re: [PATCH v3 0/3] Fix refreshing with state and make it the default

2012-02-21 Thread Tomi Ollila
On Tue, 21 Feb 2012 10:42:30 -0500, Austin Clements wrote: > Third time's the charm. This fixes show refresh to not mark anything > read when keeping state while refreshing and makes it the default. +1. LGTM. Works well. Tomi ___ notmuch mailing list

Re: [PATCH] Update crypto test for gmime 2.6.5

2012-02-21 Thread Tomi Ollila
On Tue, 21 Feb 2012 17:05:43 +0100, Thomas Jost wrote: > gmime 2.6 had a bug [1] which made it impossible to tell why a signature > verification failed when the signer key was unavailable (empty "sigstatus" > field > in the JSON output). Since 00b5623d the corresponding test is marked as broken >

ANNOUNCE: nottoomuch-addresses.sh 2.1

2012-02-22 Thread Tomi Ollila
nottoomuch-addresses.sh -- email address substring matcher -- completion helper version 2.1 is available. *** ¡¡¡ This is a bugfix release !!! *** (No wonder as this is fixing "point zero" release ;/) Changes: * Fixed a bug where decoding matching but unknown or malformed =?...?=- encoded

[RFC PATCH 2/3] emacs: add selection-menu.el to Makefile.local

2012-02-23 Thread Tomi Ollila
In order for next patch to be easily useable, add selection-menu.el to the build. --- emacs/Makefile.local |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/emacs/Makefile.local b/emacs/Makefile.local index 4fee0e8..ff1e0f9 100644 --- a/emacs/Makefile.local +++ b/emacs/Mak

[RFC PATCH 3/3] emacs: use selection-menu for recipient address completion

2012-02-23 Thread Tomi Ollila
Replace use of completing-read with selection-menu when completing for recipient addresses. --- emacs/notmuch-address.el |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/emacs/notmuch-address.el b/emacs/notmuch-address.el index 2bf762b..1d63fe4 100644 --- a/emacs/notmu

[RFC PATCH 1/3] emacs: selection-menu.el

2012-02-23 Thread Tomi Ollila
menu.el new file mode 100644 index 000..b65cef3 --- /dev/null +++ b/emacs/selection-menu.el @@ -0,0 +1,68 @@ +;;; selection-menu.el --- "generic" menu to choose one string. +;;; +;;; Author: Tomi Ollila -- too ät iki piste fi + +;;; License: GPLv2+ + +(defun selection-menu (ident items &a

Re: [RFC PATCH 1/3] emacs: selection-menu.el

2012-02-25 Thread Tomi Ollila
On Fri, 24 Feb 2012 23:36:23 +, Mark Walters wrote: > On Thu, 23 Feb 2012 17:10:15 +0200, Tomi Ollila wrote: > > RFC/Idea for "improving" some selections made (in notmuch or elsewhere) > > In the hope that this will be useful, and to get some improvement advic

Re: [RFC PATCH 0/2] natural language date range search

2012-02-25 Thread Tomi Ollila
On Mon, 20 Feb 2012 00:55:50 +0200, Jani Nikula wrote: > Hi all, these patches add support for natural language date range search > of the form date:since..until, where since and until can be fairly free > form date/time expressions in English. > > Examples: > > date:two-days..yesterday (all mai

Re: [RFC PATCH 0/2] natural language date range search

2012-02-26 Thread Tomi Ollila
On Sat, 25 Feb 2012 21:53:27 +0200, Jani Nikula wrote: > On Sat, 25 Feb 2012 17:05:44 +0200, Tomi Ollila wrote: [ ... ] > > > > By seeing the thoughts thrown in IRC there seems to be plenty if things > > to resolve until something like this is going to be available in

Re: Regarding notmuch and Fedora 16

2012-02-27 Thread Tomi Ollila
On Mon, 27 Feb 2012 09:42:36 +0100, Karel Zak wrote: > > It seems that we have officially notmuch 0.11 in Fedora 17/rawhide, if > you have the latest stable Fedora 16, then you can use: > > yum --enablerepo=rawhide install notmuch notmuch-devel > > to get: > > $ rpm -q notmuch gmime > notm

Re: [PATCH v5 00/12] emacs: more flexible and consistent tagging operations

2012-02-27 Thread Tomi Ollila
On Sat, 25 Feb 2012 12:20:31 -0400, David Bremner wrote: > On Fri, 24 Feb 2012 00:07:27 +0100, Pieter Praet wrote: > > On Wed, 08 Feb 2012 11:58:32 -0400, David Bremner wrote: > > > On Sun, 5 Feb 2012 11:13:41 +0400, Dmitry Kurochkin > > > wrote: > > > > How about if '*' applies to all messa

Re: [PATCH 0/5] Disable search.exclude_tags for 0.12

2012-03-01 Thread Tomi Ollila
On Wed, 29 Feb 2012 18:13:04 +, Mark Walters wrote: > As requested by David (Bremner) on irc here is a patch series > disabling the search.exclude_tags feature as a temporary measure for > the 0.12 release. > > There are two options: > > The first is to disable the addition of the new searc

[PATCH 1/2] emacs: retain show buffer state after retrieving gpg key

2012-03-01 Thread Tomi Ollila
After retrieving gpg key retain show buffer state like in all other operations (i.e. no other calls to notmuch-show-refresh-view provides optional reset-state argument). Emacs MUA keeps current message under cursor instead of going first open message(possibly marking it read). --- emacs/notmuch-cr

[PATCH 2/2] Spelling fix

2012-03-01 Thread Tomi Ollila
Retreive is spelled as r e t r i e v e . --- emacs/notmuch-crypto.el |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/emacs/notmuch-crypto.el b/emacs/notmuch-crypto.el index e916d66..83e5d37 100644 --- a/emacs/notmuch-crypto.el +++ b/emacs/notmuch-crypto.el @@ -101,7 +101,

Re: [PATCH 0/5] Rewrite mbox and raw show formats

2012-03-03 Thread Tomi Ollila
On Sat, 3 Mar 2012 00:20:20 -0500, Austin Clements wrote: > The show (rewrite) must go on. These are the last two formats in > notmuch show proper; the only remaining format is the reply format. > > One of the ultimate goals of the show rewrite is to make raw actually > work (and probably to sp

Re: [PATCH v2] emacs: Pass a copy to notmuch-saved-search-sort-function

2012-03-05 Thread Tomi Ollila
On Mon, 05 Mar 2012 12:17:43 +0100, Daniel Schoepe wrote: > On Mon, 05 Mar 2012 06:21:52 +0400, Dmitry Kurochkin > wrote: > > On Thu, 1 Mar 2012 21:24:38 +0100, Daniel Schoepe > > wrote: > > > notmuch-saved-search-sort-function might destructively modify its > > > input (`sort' does that, for

Re: [PATCH v2 3/8] show: Allow formatters to return errors

2012-03-07 Thread Tomi Ollila
On Tue, 06 Mar 2012 21:22:55 +, Mark Walters wrote: > On Tue, 6 Mar 2012 18:48:39 +, Austin Clements wrote: > > Formatter errors are propagated to the exit status of notmuch show. > > > > This isn't used by the JSON or text formatters, but it will be useful > > for the raw format, whic

Re: [PATCH] mime_node_open: check if the file is in mbox format, and inform gmime.

2012-03-09 Thread Tomi Ollila
On Thu, 8 Mar 2012 17:48:15 -0400, David Bremner wrote: > From: David Bremner > > It seems that it has always been an error to try to parse an mbox > format file with gmime without calling g_mime_parser_set_scan_from. At least for the time being I think we should apply http://en.wikipedia.org/

Re: [PATCH] mime_node_open: skip envelope from lines at the start of messages

2012-03-10 Thread Tomi Ollila
On Sat, 10 Mar 2012 09:25:31 -0400, David Bremner wrote: > From: David Bremner > > Some MDAs such as procmail (in MH mode), and exim (doing local > delivery in some configurations of the appendfile transport) add a > line to the front of a message with "From " followed by envelope > sender. Sin

Re: [PATCH] emacs: fix MML quoting in replies

2012-03-10 Thread Tomi Ollila
On Sun, 4 Mar 2012 10:25:38 +0200, Jani Nikula wrote: > The reply MML quoting added in commit ae438cc unintentionally MML > quotes also the signature/encryption MML tags added via > message-setup-hook, causing the reply not to be signed/encrypted. > > MML quote just the original message in the t

<    1   2   3   4   5   6   7   8   9   10   >