Re: [PATCH] build: drop support for gmime-2.6

2019-05-02 Thread Rollins, Jameson
On Wed, May 01 2019, David Bremner wrote: > I was thinking of a minimal change now, so it isn't blocking other > things, and then a gradual cleanup. just go for it. ___ notmuch mailing list notmuch@notmuchmail.org

Re: [PATCH] build: drop support for gmime-2.6

2019-05-02 Thread Rollins, Jameson
>>> I was thinking of a minimal change now, so it isn't blocking other >>> things, and then a gradual cleanup. >> >> just go for it. > > You mean this patch, or the other more extensive patch that someone (TM) > has to write? Go for the full cleanup all at once.

Re: [PATCH] build: drop support for gmime-2.6

2019-05-01 Thread David Bremner
"Rollins, Jameson" writes: > On Wed, May 01 2019, David Bremner wrote: >> I was thinking of a minimal change now, so it isn't blocking other >> things, and then a gradual cleanup. > > just go for it. You mean this patch, or the other more extensive patch that someone (TM) has to write? d

Re: [PATCH] build: drop support for gmime-2.6

2019-05-01 Thread David Bremner
Tomi Ollila writes: >> -# we need to have a version >= 2.6.5 to avoid a crypto bug. We need >> -# 2.6.7 for permissive "From " header handling. >> -GMIME_MINVER=2.6.7 >> GMIME3_MINVER=3.0.3 > > This series looks good, but why change GMIME_MINVER to GMIME3_MINVER ? > Both existed before, and I

Re: [PATCH] build: drop support for gmime-2.6

2019-05-01 Thread David Bremner
Daniel Kahn Gillmor writes: > On Wed 2019-05-01 07:46:43 -0300, David Bremner wrote: >> GMime 3.0 is over 2 years old now, and 2.6 has been deprecated in >> notmuch for about 1.5 years. > > I was just looking at this change myself. > > As a gmime maintainer in debian, I'd love to see it happen,

Re: [PATCH] build: drop support for gmime-2.6

2019-05-01 Thread Daniel Kahn Gillmor
On Wed 2019-05-01 07:46:43 -0300, David Bremner wrote: > GMime 3.0 is over 2 years old now, and 2.6 has been deprecated in > notmuch for about 1.5 years. I was just looking at this change myself. As a gmime maintainer in debian, I'd love to see it happen, but i think the right way to do that is

Re: [PATCH] build: drop support for gmime-2.6

2019-05-01 Thread Tomi Ollila
On Wed, May 01 2019, David Bremner wrote: > GMime 3.0 is over 2 years old now, and 2.6 has been deprecated in > notmuch for about 1.5 years. > --- > > Thanks to Rob Browning, I realized that the gzipped-mail-file series I > have recently posted does not compile with GMime 2.6. This made me >

[PATCH] build: drop support for gmime-2.6

2019-05-01 Thread David Bremner
GMime 3.0 is over 2 years old now, and 2.6 has been deprecated in notmuch for about 1.5 years. --- Thanks to Rob Browning, I realized that the gzipped-mail-file series I have recently posted does not compile with GMime 2.6. This made me think that maybe it's the right time to drop support for