[PATCH] emacs: create patch filename from subject for inline patch fake parts

2011-11-19 Thread Jani Nikula
Use the mail subject line for creating a descriptive filename for the wash generated inline patch fake parts. The names are similar to the ones created by 'git format-patch', just without the leading numbers. Signed-off-by: Jani Nikula --- I know notmuch-subject-to-patch-filename is totally un-

[PATCH] emacs: create patch filename from subject for inline patch fake parts

2011-12-20 Thread Jani Nikula
Shameless promotion of own patches... I suppose not many use the notmuch-wash-convert-inline-patch-to-part option, but with this patch I've actually started to like it better. An actual patch name from subject instead of "inline patch". As I said, the lisp is less than perfect here, but this is s

[PATCH] emacs: create patch filename from subject for inline patch fake parts

2011-12-21 Thread Dmitry Kurochkin
Hi Jani. On Tue, 20 Dec 2011 22:05:31 +0200, Jani Nikula wrote: > > Shameless promotion of own patches... I suppose not many use the > notmuch-wash-convert-inline-patch-to-part option, but with this patch > I've actually started to like it better. An actual patch name from > subject instead of "

[PATCH] emacs: create patch filename from subject for inline patch fake parts

2011-12-20 Thread Austin Clements
Seems like a definite improvement, but perhaps a let* instead of all of the setq's? Quoth Jani Nikula on Dec 20 at 10:05 pm: > > Shameless promotion of own patches... I suppose not many use the > notmuch-wash-convert-inline-patch-to-part option, but with this patch > I've actually started to like

[PATCH] emacs: create patch filename from subject for inline patch fake parts

2011-12-21 Thread David Edmondson
On Tue, 20 Dec 2011 16:52:52 -0500, Austin Clements wrote: > Seems like a definite improvement, but perhaps a let* instead of all > of the setq's? What would be a lispy approach? I tried: (defun notmuch-subject-to-patch-filename (subject) "Convert a typical patch mail subject line into a suita

[PATCH] emacs: create patch filename from subject for inline patch fake parts

2011-12-21 Thread Austin Clements
I would definitely go with the latter. It might feel less unwieldy with a shorter variable name than "filename", since that has to be repeated so many times. (It's also not really a filename in the middle of the replace process.) This is splitting hairs, but in my original suggestion, I was thin

[PATCH] emacs: create patch filename from subject for inline patch fake parts

2011-12-21 Thread Jani Nikula
On Wed, 21 Dec 2011 09:40:08 -0500, Austin Clements wrote: > I would definitely go with the latter. > > It might feel less unwieldy with a shorter variable name than > "filename", since that has to be repeated so many times. (It's also > not really a filename in the middle of the replace process

[PATCH] emacs: create patch filename from subject for inline patch fake parts

2011-11-18 Thread Jani Nikula
Use the mail subject line for creating a descriptive filename for the wash generated inline patch fake parts. The names are similar to the ones created by 'git format-patch', just without the leading numbers. Signed-off-by: Jani Nikula --- I know notmuch-subject-to-patch-filename is totally un-

Re: [PATCH] emacs: create patch filename from subject for inline patch fake parts

2011-12-20 Thread Jani Nikula
Shameless promotion of own patches... I suppose not many use the notmuch-wash-convert-inline-patch-to-part option, but with this patch I've actually started to like it better. An actual patch name from subject instead of "inline patch". As I said, the lisp is less than perfect here, but this is s

Re: [PATCH] emacs: create patch filename from subject for inline patch fake parts

2011-12-20 Thread Dmitry Kurochkin
Hi Jani. On Tue, 20 Dec 2011 22:05:31 +0200, Jani Nikula wrote: > > Shameless promotion of own patches... I suppose not many use the > notmuch-wash-convert-inline-patch-to-part option, but with this patch > I've actually started to like it better. An actual patch name from > subject instead of "

Re: [PATCH] emacs: create patch filename from subject for inline patch fake parts

2011-12-20 Thread Austin Clements
Seems like a definite improvement, but perhaps a let* instead of all of the setq's? Quoth Jani Nikula on Dec 20 at 10:05 pm: > > Shameless promotion of own patches... I suppose not many use the > notmuch-wash-convert-inline-patch-to-part option, but with this patch > I've actually started to like

Re: [PATCH] emacs: create patch filename from subject for inline patch fake parts

2011-12-21 Thread David Edmondson
On Tue, 20 Dec 2011 16:52:52 -0500, Austin Clements wrote: > Seems like a definite improvement, but perhaps a let* instead of all > of the setq's? What would be a lispy approach? I tried: (defun notmuch-subject-to-patch-filename (subject) "Convert a typical patch mail subject line into a suita

Re: [PATCH] emacs: create patch filename from subject for inline patch fake parts

2011-12-21 Thread Austin Clements
I would definitely go with the latter. It might feel less unwieldy with a shorter variable name than "filename", since that has to be repeated so many times. (It's also not really a filename in the middle of the replace process.) This is splitting hairs, but in my original suggestion, I was thin

Re: [PATCH] emacs: create patch filename from subject for inline patch fake parts

2011-12-21 Thread Jani Nikula
On Wed, 21 Dec 2011 09:40:08 -0500, Austin Clements wrote: > I would definitely go with the latter. > > It might feel less unwieldy with a shorter variable name than > "filename", since that has to be repeated so many times. (It's also > not really a filename in the middle of the replace process