Re: [PATCH] notmuch-mutt: replace extra command with notmuch-native thread search feature

2023-04-10 Thread David Bremner
Paul Wise writes: > that changes the meaning of the query but I couldn't find any way to > prevent an arbitrary Message-Id from inserting parentheses into the > query. Also notmuch converts Message-Id (test)@hostname to just > @hostname in the Xapian database. I think that right now I am not

Re: [PATCH] notmuch-mutt: replace extra command with notmuch-native thread search feature

2023-04-09 Thread Paul Wise
On Sun, 2023-04-09 at 13:00 -0300, David Bremner wrote: > You might be interested in the s-expression query parser. Part of the > goal is to be less dwim/quirky than the native Xapian query parser, and > to make it easier / safer to construct notmuch queries via programs. That does seem saner to

Re: [PATCH] notmuch-mutt: replace extra command with notmuch-native thread search feature

2023-04-09 Thread David Bremner
Paul Wise writes: > So I think that it would be good if there were a library for notmuch > query construction that would take care of all the different quoting > levels, Message-Id munging etc. This could then get language bindings > so that notmuch based tools and MUAs could use them for

Re: [PATCH] notmuch-mutt: replace extra command with notmuch-native thread search feature

2023-04-08 Thread Paul Wise
On Sat, 2023-04-08 at 08:42 -0300, David Bremner wrote: > did you test this with a message-id with spaces in it? > the quoting is a delicate. You are correct that the quoting for this was wrong, as it was also wrong in the code before my patch and I just copied that, however... I noticed that

Re: [PATCH] notmuch-mutt: replace extra command with notmuch-native thread search feature

2023-04-08 Thread David Bremner
Paul Wise writes: > +search($results_dir, $remove_dups, qq{thread:"{id:$mid}"}); did you test this with a message-id with spaces in it? the quoting is a delicate. d ___ notmuch mailing list -- notmuch@notmuchmail.org To unsubscribe send an email

[PATCH] notmuch-mutt: replace extra command with notmuch-native thread search feature

2023-04-07 Thread Paul Wise
This should be be slightly faster since it avoids forking a shell and is less code in and less dependencies for the script. Since String::ShellQuote isn't used elsewhere, drop mention of it. --- contrib/notmuch-mutt/README | 2 -- contrib/notmuch-mutt/notmuch-mutt | 6 +-