[PATCH 1/1] building from git: use --abbrev=7 for version string

2014-04-24 Thread David Bremner
Tomi Ollila writes: > Users may have set core.abbrev=n, where n != 7 in their git config > file(s) which would give them different than expected version strings > when building notmuch from git. This fixes the commit hash part of > version string to 7 hexadecimal values. pushed to master d

[PATCH 1/1] building from git: use --abbrev=7 for version string

2014-04-23 Thread Jani Nikula
On Tue, 22 Apr 2014, Mark Walters wrote: > LGTM +1 Looks good, and fixes the problem for me. BR, Jani. > > MW > > On Tue, 22 Apr 2014, Tomi Ollila wrote: >> Users may have set core.abbrev=n, where n != 7 in their git config >> file(s) which would give them different than expected version

Re: [PATCH 1/1] building from git: use --abbrev=7 for version string

2014-04-23 Thread David Bremner
Tomi Ollila tomi.oll...@iki.fi writes: Users may have set core.abbrev=n, where n != 7 in their git config file(s) which would give them different than expected version strings when building notmuch from git. This fixes the commit hash part of version string to 7 hexadecimal values. pushed to

[PATCH 1/1] building from git: use --abbrev=7 for version string

2014-04-22 Thread Mark Walters
LGTM +1 MW On Tue, 22 Apr 2014, Tomi Ollila wrote: > Users may have set core.abbrev=n, where n != 7 in their git config > file(s) which would give them different than expected version strings > when building notmuch from git. This fixes the commit hash part of > version string to 7 hexadecimal

[PATCH 1/1] building from git: use --abbrev=7 for version string

2014-04-22 Thread Tomi Ollila
Users may have set core.abbrev=n, where n != 7 in their git config file(s) which would give them different than expected version strings when building notmuch from git. This fixes the commit hash part of version string to 7 hexadecimal values. --- tested with: git config core.abbrev 12 git

[PATCH 1/1] building from git: use --abbrev=7 for version string

2014-04-22 Thread Tomi Ollila
Users may have set core.abbrev=n, where n != 7 in their git config file(s) which would give them different than expected version strings when building notmuch from git. This fixes the commit hash part of version string to 7 hexadecimal values. --- tested with: git config core.abbrev 12 git

Re: [PATCH 1/1] building from git: use --abbrev=7 for version string

2014-04-22 Thread Mark Walters
LGTM +1 MW On Tue, 22 Apr 2014, Tomi Ollila tomi.oll...@iki.fi wrote: Users may have set core.abbrev=n, where n != 7 in their git config file(s) which would give them different than expected version strings when building notmuch from git. This fixes the commit hash part of version string to

Re: [PATCH 1/1] building from git: use --abbrev=7 for version string

2014-04-22 Thread Jani Nikula
On Tue, 22 Apr 2014, Mark Walters markwalters1...@gmail.com wrote: LGTM +1 Looks good, and fixes the problem for me. BR, Jani. MW On Tue, 22 Apr 2014, Tomi Ollila tomi.oll...@iki.fi wrote: Users may have set core.abbrev=n, where n != 7 in their git config file(s) which would give them