Re: [PATCH 1/3] sorting: add the ability to sort by from and subject

2017-09-07 Thread William Casarin
David Bremner writes: > It seems worth mentioning that it's possible to preprocess values into > keys (see Xapian::Enquire::set_sort_by_key). So things like Re: > etc... could be stripped. Hmm looks like I need to create a KeyMaker class which appears to be a glorified

Re: [PATCH 1/3] sorting: add the ability to sort by from and subject

2017-09-04 Thread David Bremner
William Casarin writes: > William Casarin writes: > >> Jani Nikula writes: >> >>> The implementation seems simple enough, but what's the use case, really? >> >> I get all of my rss feeds sent to my inbox, I wanted to be able to group >> similar

Re: [PATCH 1/3] sorting: add the ability to sort by from and subject

2017-09-04 Thread William Casarin
William Casarin writes: > Jani Nikula writes: > >> The implementation seems simple enough, but what's the use case, really? > > I get all of my rss feeds sent to my inbox, I wanted to be able to group > similar feeds (mainly by from, sometimes subject).

Re: [PATCH 1/3] sorting: add the ability to sort by from and subject

2017-09-04 Thread Jani Nikula
On Mon, 04 Sep 2017, William Casarin wrote: > * add {from,subject}-{ascending,descending} sort options The implementation seems simple enough, but what's the use case, really? When thinking about the usefulness of the feature, you have to think about what gets indexed for from:

[PATCH 1/3] sorting: add the ability to sort by from and subject

2017-09-04 Thread William Casarin
* add {from,subject}-{ascending,descending} sort options --- I'm not sure if we want to eventually refactor ascending and descending into a separate option, but I decided to keep it this way for now. lib/notmuch.h| 16 lib/query.cc | 12 notmuch-search.c |