Hello
I do not get the failure with just 1/4 applied but do with all 4
applied. The trivial patch below fixes it, but it might not be the best
solution.
The failure occurs because Jani's patch changes the behavior of a couple
of emacs/notmuch internal functions: the function
notmuch-search-reply
On Jan 7, 2012 5:52 AM, "David Bremner" wrote:
>
> On Thu, 5 Jan 2012 22:25:12 +0200, Jani Nikula wrote:
> > notmuch_show_params_t params is only initialized partially in
> > notmuch_reply_command(). The only field that is used uninitialized is
> > params.decrypt. It is usually non-zero, making
On Sat, 7 Jan 2012 09:31:35 +0200, Jani Nikula wrote:
> On Jan 7, 2012 5:52 AM, "David Bremner" wrote:
> >
> > On Thu, 5 Jan 2012 22:25:12 +0200, Jani Nikula wrote:
> > > notmuch_show_params_t params is only initialized partially in
> > > notmuch_reply_command(). The only field that is used uni
On Sat, 7 Jan 2012 09:31:35 +0200, Jani Nikula wrote:
> On Jan 7, 2012 5:52 AM, "David Bremner" wrote:
> >
> > On Thu, 5 Jan 2012 22:25:12 +0200, Jani Nikula wrote:
> > > notmuch_show_params_t params is only initialized partially in
> > > notmuch_reply_command(). The only field that is used uni
Hello
I do not get the failure with just 1/4 applied but do with all 4
applied. The trivial patch below fixes it, but it might not be the best
solution.
The failure occurs because Jani's patch changes the behavior of a couple
of emacs/notmuch internal functions: the function
notmuch-search-reply
On Thu, 5 Jan 2012 22:25:12 +0200, Jani Nikula wrote:
> notmuch_show_params_t params is only initialized partially in
> notmuch_reply_command(). The only field that is used uninitialized is
> params.decrypt. It is usually non-zero, making "notmuch reply" on encrypted
> messages work by coincidenc
On Jan 7, 2012 5:52 AM, "David Bremner" wrote:
>
> On Thu, 5 Jan 2012 22:25:12 +0200, Jani Nikula wrote:
> > notmuch_show_params_t params is only initialized partially in
> > notmuch_reply_command(). The only field that is used uninitialized is
> > params.decrypt. It is usually non-zero, making
On Thu, 5 Jan 2012 22:25:12 +0200, Jani Nikula wrote:
> notmuch_show_params_t params is only initialized partially in
> notmuch_reply_command(). The only field that is used uninitialized is
> params.decrypt. It is usually non-zero, making "notmuch reply" on encrypted
> messages work by coincidenc
On Thu, 05 Jan 2012 23:22:34 -0400, David Bremner wrote:
> On Thu, 5 Jan 2012 22:25:12 +0200, Jani Nikula wrote:
> > -notmuch_show_params_t params;
> > +notmuch_show_params_t params = { .part = -1 };
> >
> > reply_format_func = notmuch_reply_format_default;
> > -params.part =
On Fri, 06 Jan 2012 10:11:42 +0200, Jani Nikula wrote:
> IMHO the first is cleanest and unaffected by changes in
> notmuch_show_params_t, though might be surprising if you're not (yet)
> used to C99 designated initializers.
Obviously not ;). It would nice to have a consensus about the use of C99
On Fri, 06 Jan 2012 10:11:42 +0200, Jani Nikula wrote:
> IMHO the first is cleanest and unaffected by changes in
> notmuch_show_params_t, though might be surprising if you're not (yet)
> used to C99 designated initializers.
Obviously not ;). It would nice to have a consensus about the use of C99
On Thu, 05 Jan 2012 23:22:34 -0400, David Bremner wrote:
> On Thu, 5 Jan 2012 22:25:12 +0200, Jani Nikula wrote:
> > -notmuch_show_params_t params;
> > +notmuch_show_params_t params = { .part = -1 };
> >
> > reply_format_func = notmuch_reply_format_default;
> > -params.part =
On Thu, 5 Jan 2012 22:25:12 +0200, Jani Nikula wrote:
> -notmuch_show_params_t params;
> +notmuch_show_params_t params = { .part = -1 };
>
> reply_format_func = notmuch_reply_format_default;
> -params.part = -1;
Do I understand correctly that this is just a style change, or do
notmuch_show_params_t params is only initialized partially in
notmuch_reply_command(). The only field that is used uninitialized is
params.decrypt. It is usually non-zero, making "notmuch reply" on encrypted
messages work by coincidence.
Initialize params properly, and set params.decrypt as needed
On Thu, 5 Jan 2012 22:25:12 +0200, Jani Nikula wrote:
> -notmuch_show_params_t params;
> +notmuch_show_params_t params = { .part = -1 };
>
> reply_format_func = notmuch_reply_format_default;
> -params.part = -1;
Do I understand correctly that this is just a style change, or do
notmuch_show_params_t params is only initialized partially in
notmuch_reply_command(). The only field that is used uninitialized is
params.decrypt. It is usually non-zero, making "notmuch reply" on encrypted
messages work by coincidence.
Initialize params properly, and set params.decrypt as needed
16 matches
Mail list logo
