Re: [PATCH 1/7] mime-node: split out _mime_node_set_up_part

2019-06-25 Thread Daniel Kahn Gillmor
On Mon 2019-06-24 19:43:58 -0700, William Casarin wrote: >> +static bool >> +_mime_node_set_up_part (mime_node_t *node, GMimeObject *part, int numchild); >> + > > nit: Instead of a forward declaration, could _mime_node_create be moved after > _mime_node_set_up_part instead? yep, we could

Re: [PATCH 1/7] mime-node: split out _mime_node_set_up_part

2019-06-24 Thread William Casarin
Daniel Kahn Gillmor writes: > This is a code reorganization that should have no functional effect, > but will make future changes simpler, because a future commit will > reuse the _mime_node_set_up_part functionality without touching > _mime_node_create. > > In the course of splitting out this

[PATCH 1/7] mime-node: split out _mime_node_set_up_part

2019-06-24 Thread Daniel Kahn Gillmor
This is a code reorganization that should have no functional effect, but will make future changes simpler, because a future commit will reuse the _mime_node_set_up_part functionality without touching _mime_node_create. In the course of splitting out this function, I noticed a comment in the