[PATCH 3/4] nmbug: Catch stderr in is_unmerged

2014-07-16 Thread David Bremner
"W. Trevor King" writes: > > There should be standard Perl syntax for capturing both streams ;). I > can add a separate parameter instead, but Perl doesn't seem to have > keyword-arguments. At least, nmbug relies on assumptions about > argument values: > > sub git_pipe { > my $envref = (r

Re: [PATCH 3/4] nmbug: Catch stderr in is_unmerged

2014-07-16 Thread David Bremner
"W. Trevor King" writes: > > There should be standard Perl syntax for capturing both streams ;). I > can add a separate parameter instead, but Perl doesn't seem to have > keyword-arguments. At least, nmbug relies on assumptions about > argument values: > > sub git_pipe { > my $envref = (r

[PATCH 3/4] nmbug: Catch stderr in is_unmerged

2014-07-15 Thread David Bremner
"W. Trevor King" writes: > + if ($dir eq '-2|') { > +$dir = '-|'; > + } > + I think I'd prefer an extra flag, rather than making new syntax. The existing syntax is not pretty, but it is standard perl

Re: [PATCH 3/4] nmbug: Catch stderr in is_unmerged

2014-07-15 Thread W. Trevor King
On Tue, Jul 15, 2014 at 08:49:58PM -0300, David Bremner wrote: > "W. Trevor King" writes: > > > + if ($dir eq '-2|') { > > +$dir = '-|'; > > + } > > + > > I think I'd prefer an extra flag, rather than making new syntax. > The existing syntax is not pretty, but it is standard perl There sh

[PATCH 3/4] nmbug: Catch stderr in is_unmerged

2014-07-15 Thread W. Trevor King
On Tue, Jul 15, 2014 at 08:49:58PM -0300, David Bremner wrote: > "W. Trevor King" writes: > > > + if ($dir eq '-2|') { > > +$dir = '-|'; > > + } > > + > > I think I'd prefer an extra flag, rather than making new syntax. > The existing syntax is not pretty, but it is standard perl There sh

Re: [PATCH 3/4] nmbug: Catch stderr in is_unmerged

2014-07-15 Thread David Bremner
"W. Trevor King" writes: > + if ($dir eq '-2|') { > +$dir = '-|'; > + } > + I think I'd prefer an extra flag, rather than making new syntax. The existing syntax is not pretty, but it is standard perl ___ notmuch mailing list notmuch@notmuchmail.

[PATCH 3/4] nmbug: Catch stderr in is_unmerged

2014-07-06 Thread W. Trevor King
Add a '-2|' dir for "execute the command and pipe both stdout and stderr to us". Use this to catch stderr from the rev-parse call in is_unmerged. We already check the status, so we don't want to confuse users with stuff like: error: No upstream configured for branch 'master' on nmbug's stderr

[PATCH 3/4] nmbug: Catch stderr in is_unmerged

2014-07-06 Thread W. Trevor King
Add a '-2|' dir for "execute the command and pipe both stdout and stderr to us". Use this to catch stderr from the rev-parse call in is_unmerged. We already check the status, so we don't want to confuse users with stuff like: error: No upstream configured for branch 'master' on nmbug's stderr